maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Improve search and display in the editor property/method selector

Browse source 
- Use postfix notation for types in the method selector
  (for consistency with the editor help).
- Perform a case-insensitive match and replace spaces with underscores
  in the search string.
- Fix extraneous space after the `void` return type.
This commit is contained in:
Hugo Locurcio 2020-08-19 18:28:05 +02:00
parent 844251596f
commit 4390a9d628
No known key found for this signature in database
GPG key ID: 39E8F8BE30B0A49C
1 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
editor/property_selector.cpp
View file

@ -84,6 +84,9 @@ void PropertySelector::_update_search() {
TreeItem *root = search_options->create_item();
// Allow using spaces in place of underscores in the search string (makes the search more fault-tolerant).
const String search_text = search_box->get_text().replace(" ", "_");
if (properties) {
List<PropertyInfo> props;
@ -167,7 +170,7 @@ void PropertySelector::_update_search() {
continue;
}
if (search_box->get_text() != String() && E->get().name.find(search_box->get_text()) == -1) {
if (search_box->get_text() != String() && E->get().name.findn(search_text) == -1) {
continue;
}
@ -180,7 +183,7 @@ void PropertySelector::_update_search() {
item->set_metadata(0, E->get().name);
item->set_icon(0, type_icons[E->get().type]);
if (!found && search_box->get_text() != String() && E->get().name.find(search_box->get_text()) != -1) {
if (!found && search_box->get_text() != String() && E->get().name.findn(search_text) != -1) {
item->select(0);
found = true;
}
@ -255,7 +258,7 @@ void PropertySelector::_update_search() {
continue;
}
if (search_box->get_text() != String() && name.find(search_box->get_text()) == -1) {
if (search_box->get_text() != String() && name.findn(search_text) == -1) {
continue;
}
@ -270,29 +273,29 @@ void PropertySelector::_update_search() {
} else if (mi.return_val.type != Variant::NIL) {
desc = Variant::get_type_name(mi.return_val.type);
} else {
desc = "void ";
desc = "void";
}
desc += " " + mi.name + " ( ";
desc += vformat(" %s(", mi.name);
for (int i = 0; i < mi.arguments.size(); i++) {
if (i > 0) {
desc += ", ";
}
desc += mi.arguments[i].name;
if (mi.arguments[i].type == Variant::NIL) {
desc += "var ";
desc += ": Variant";
} else if (mi.arguments[i].name.find(":") != -1) {
desc += mi.arguments[i].name.get_slice(":", 1) + " ";
desc += vformat(": %s", mi.arguments[i].name.get_slice(":", 1));
mi.arguments[i].name = mi.arguments[i].name.get_slice(":", 0);
} else {
desc += Variant::get_type_name(mi.arguments[i].type) + " ";
desc += vformat(": %s", Variant::get_type_name(mi.arguments[i].type));
}
desc += mi.arguments[i].name;
}
desc += " )";
desc += ")";
if (E->get().flags & METHOD_FLAG_CONST) {
desc += " const";
@ -306,7 +309,7 @@ void PropertySelector::_update_search() {
item->set_metadata(0, name);
item->set_selectable(0, true);
if (!found && search_box->get_text() != String() && name.find(search_box->get_text()) != -1) {
if (!found && search_box->get_text() != String() && name.findn(search_text) != -1) {
item->select(0);
found = true;
}