maxmustermann/godot
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
31635 commits 10 branches 35 tags 1.1 GiB
Commit graph

1399 commits

Author SHA1 Message Date
George Marques a889084864
GDScript: Don't mark function parameters as constant 
They can be reassigned as if it were a local variable.
 2020-09-01 09:26:28 -03:00
George Marques c8e10aa20b
GDScript: Properly set class inheritance for global classes 2020-09-01 09:26:28 -03:00
George Marques 164cc8705b
GDScript: Check for missing exponent when parsing numbers 
Also forbid multiple underscores in a row as numeric separator.
 2020-09-01 09:26:28 -03:00
George Marques f8fa5e4738
GDScript: Fix analysis of singleton dependencies 
Sometimes a singleton might depend on another before they are fully
compiled so we can't rely on globals in this case.
 2020-09-01 09:26:28 -03:00
George Marques edb4caf24e
GDScript: Allow "extends" to be used inside inner class 2020-09-01 09:26:27 -03:00
George Marques 34dc689ad4
GDScript: Allow "self" to be used in class level 2020-09-01 09:26:27 -03:00
George Marques 1ddb9b1a52
GDScript: Don't try to parse constant scripts that aren't valid 
Since it's likely that they won't parse correctly.
 2020-09-01 09:26:27 -03:00
Hugo Locurcio c4903a603b
Add link titles for all links in the class reference 
This makes them display in a nicer way in the editor help.
(The title will display instead of the full URL.)
 2020-08-31 14:22:07 +02:00
Hugo Locurcio 20d0f5bbd7
Cross-reference GDScript built-in rounding methods to ease discovery 
This closes #19315.
 2020-08-28 17:04:22 +02:00
Rémi Verschelde 46809332dd
Merge pull request #41547 from vnen/gdscript-2-fixes 
Some more GDScript fixes
 2020-08-28 10:36:09 +02:00
George Marques 5033d5c71c
GDScript: Fix crash when parsing properties 2020-08-26 16:08:19 -03:00
George Marques b2b45987d0
GDScript: Show error when there's an inheritance cycle 2020-08-26 16:01:08 -03:00
George Marques 4a3fca47e5
GDScript: Add recursion depth limit for completion 
To avoid crashes when there's a dependency loop.
 2020-08-26 15:38:23 -03:00
George Marques ff16ba1eaa
GDScript: Fix crash when completing code with signals 2020-08-26 15:13:42 -03:00
George Marques 8ccf88a206
GDScript: Fix issues when deriving from other scripts 2020-08-26 14:50:27 -03:00
Rémi Verschelde 9d8f3496e8
Merge pull request #40443 from SkyLucilfer/PluralsSupport 
Added plurals and context support to Translation
 2020-08-25 12:11:56 +02:00
George Marques 722be9aaef
GDScript: Don't fail to load constants if they're not a literal 
It's still okay as long as it's a constant value. This should already
been validated by the analyzer.
 2020-08-24 09:15:33 -03:00
George Marques ca90c9c9a9
GDScript: Properly resolve external inner classes from preload 
This gets the correct parser and class node when resolving from a full
GDScript reference.
 2020-08-23 12:55:27 -03:00
George Marques d36d7e2a1c
GDScript: Use pointer instead of references in cache 
They are not supposed to be kept alive and this is cleaner and less
error-prone than unreferencing the elements.
 2020-08-23 12:55:27 -03:00
George Marques 58f5c2bab6
Merge pull request #41238 from MarianoGnu/gdscript-export-resource 
Fix GdScript Analyzier not detecting Resource subclass correctly
 2020-08-23 11:04:52 -03:00
Paulb23 6cdcdbc242 Fix color region end key seach and start key order 2020-08-22 19:55:44 +01:00
George Marques a880f590e4
GDScript: Make subscript access be properly type checked 2020-08-19 14:35:26 -03:00
George Marques 846856728b
GDScript: Show error when function return type is missing 2020-08-19 14:09:45 -03:00
George Marques 15b16ec0ce
GDScript: Fix signal parameters not respecting commas 2020-08-19 11:32:48 -03:00
George Marques cd3f51c67c
GDScript: Check duplicate keys in dictionaries and enums 2020-08-19 11:14:16 -03:00
George Marques f9ad0b30fa
GDScript: Allow preload() to be used with constant expressions 2020-08-19 10:45:00 -03:00
George Marques a52e457ada
GDScript: Allow keywords to be used in $ notation 2020-08-19 10:19:05 -03:00
SkyJJ ce3461dc88 Update GDScriptTranslationParserPlugin to use GDSriptParser instead of RegEx. 2020-08-19 03:10:51 +02:00
SkyJJ 396f2eee82 Update POT generation to handle context and plurals 2020-08-19 03:01:52 +02:00
George Marques 35176247af
GDScript: Allow enum values to be set to constant expressions 
Also allow them to access previous values wihout referencing the enum.
 2020-08-18 17:44:20 -03:00
George Marques 99d4ea8c79
GDScript: Allow supertype objects to be assigned to a subtype variable 
It allows `get_node()` to be used with typed variables

This is marked as unsafe to warn the user.
 2020-08-18 15:12:51 -03:00
George Marques 8bc9b3a2ae
GDScript: Allow implicit type conversion when constructing variants 
Incidentally fix error message when no valid constructor is found which
was missing an end parenthesis.
 2020-08-18 13:12:18 -03:00
George Marques 8088e9e6ac
GDScript: Add script to cache on reload 
This ensures that scripts created without a resource loader are properly
included in the cache (such as builtin scripts) and are not tried to be
loaded from the disk.
 2020-08-18 11:21:09 -03:00
George Marques 0f9923e67f
GDScript: Allow empty files to be valid scripts 2020-08-17 21:32:49 -03:00
George Marques 3abb3c0d6e
GDScript: Fix crash when superclass file is non-existent 
Incidentally, allow EOF to be an end of statement.
 2020-08-17 21:30:39 -03:00
George Marques fda6f3b600
GDScript: Fix LSP getting wrong union value on unnamed enums 2020-08-17 21:10:30 -03:00
George Marques d06ce2f11e
GDScript: Fix editor crash when writing @tool annotation 2020-08-17 21:02:49 -03:00
George Marques f374021d52
GDSript: Prevent crash when completing unary operators 2020-08-17 20:49:04 -03:00
George Marques 9ecd042e78
GDScript: Allow "match" to be used as an identifier 
This is needed to call the String.match() function.
 2020-08-17 20:14:46 -03:00
George Marques d45e1befe3
GDScript: Fix wrong argument check for formatting operator 2020-08-17 19:49:54 -03:00
Mariano Suligoy a8c01df647 Fix GdScript Analyzier not detecting Resource subclass correctly 2020-08-13 19:46:57 -03:00
George Marques adc1f95d97
Merge pull request #41224 from ThakeeNathees/fix-ctrl+click-not-working 
Fix: ctrl + click not working on script member
 2020-08-13 10:25:46 -03:00
Thakee Nathees c6dc73f9be Fix: ctrl + click not working 2020-08-13 17:35:17 +05:30
George Marques 9413446b2d
Merge pull request #41104 from vnen/gdscript-assignment-tidy 
Tidy up assignment operator check
 2020-08-12 08:54:48 -03:00
Rémi Verschelde cf05486d8e
Merge pull request #41055 from snichols/null-callee-fix 
Fix crash with null callee
 2020-08-11 15:15:43 +02:00
Paulb23 5cf2cf8646 Fix colour region continuation over blank lines, issue 41120 2020-08-08 15:36:46 +01:00
George Marques 69c81309cc
Merge pull request #40673 from ThakeeNathees/gdscript-op-eval-validation 
GDScript operator evaluation validation bug fix
 2020-08-08 10:52:40 -03:00
George Marques 1f14068727
Merge pull request #40951 from bruvzg/gds_cleanup 
[GDScript] Add static HashMap cleanup.
 2020-08-08 10:44:57 -03:00
George Marques 3aef60591b
GDScript: Tidy up assignment operator check 
The operator is already gathered by the parser, no need to do it again
in the analyzer.
 2020-08-08 10:37:51 -03:00
Thakee Nathees 38c7d080e8 GDScript: unsafe arithmetic assignment bug fix 
Fix: #41051
 2020-08-06 11:12:26 +05:30
Stephen Nichols fbd07bf3bf Adding error message for empty grouping expression 2020-08-05 14:42:33 -05:00
Stephen Nichols 8a13be50ab Fixing null callee crash. 2020-08-05 14:41:46 -05:00
George Marques 9adf6d3441
Merge pull request #40690 from ThakeeNathees/arithmetic-assign-type-check-bug-fix 
GDScript arithmetic assignment type check bug fix
 2020-08-03 09:26:09 -03:00
unknown 561af0c17d Fixed tiny grammar issues in error messages 2020-08-03 14:03:28 +05:30
bruvzg ee973f5b90
[GDScript] Add static HashMap cleanup. 2020-08-01 22:08:12 +03:00
Rémi Verschelde ba853f86af
Merge pull request #40903 from Calinou/doc-json 
Improve JSON-related documentation
 2020-07-31 10:39:56 +02:00
Hugo Locurcio 930e10ffff Improve JSON-related documentation 
This closes https://github.com/godotengine/godot-docs/issues/3848.
 2020-07-31 09:56:11 +02:00
Rémi Verschelde 9833f9cc11 doc: Fix typo in BBcode tag 2020-07-30 16:24:37 +02:00
SkyJJ 9cd1ef573c Refix GDScriptTranslationParser leak 2020-07-29 23:17:58 +02:00
Lyuma 68566b7bec GDScript: Fix crash caused by inconsistent get_member 2020-07-29 02:56:03 -07:00
Rémi Verschelde a6916d1f17
Merge pull request #40678 from aaronfranke/string-float64 
Make all String float conversion methods be 64-bit
 2020-07-28 01:27:34 +02:00
Rémi Verschelde 932b75e247 doc: Sync classref with current source 2020-07-28 01:08:44 +02:00
Aaron Franke 56e2c6c704
Make all String float conversion methods be 64-bit 2020-07-27 18:38:53 -04:00
Rémi Verschelde 4e825539e5
Merge pull request #40762 from SkyLucilfer/PackedSceneLeak 
Fix EditorTranslationParser leak
 2020-07-28 00:31:46 +02:00
George Marques 04f46aea8d
GDScript: Fix crash on 'await' completion 2020-07-27 17:17:39 -03:00
SkyJJ 0e54ba0486 Fix EditorTranslationParser leak 2020-07-27 17:02:53 +02:00
Rémi Verschelde 3e99059129
Merge pull request #40714 from ThakeeNathees/Object-type-bug-fix 
GDScript: "Object" datatype changed from BUILTIN to NATIVE
 2020-07-27 08:50:16 +02:00
Rémi Verschelde 33d423e240
Merge pull request #39898 from Meriipu/master_gdscript 
GDScript: Clarified/fixed inaccuracies in the built-in function docs.
 2020-07-26 17:12:13 +02:00
Rémi Verschelde b2096ba53e
Merge pull request #40670 from vnen/remove-multilevel-call 
Remove multilevel calls
 2020-07-26 17:09:41 +02:00
Thakee Nathees 194c2aa7e2 GDScript: "Object" datatype changed from BUILTIN to NATIVE 
Fix: #40656
 2020-07-26 08:00:55 +05:30
Thakee Nathees 5ba46ddf8e GDScript arithmetic assignment type check bug fixed 
Fix: #40686
 2020-07-26 06:46:13 +05:30
Meriipu 7f9bfee0ac GDScript: Clarified/fixed inaccuracies in the built-in function docs. 
The input to smoothstep is not actually a weight, and the decscription
of smoothstep was pretty hard to understand and easy to misinterpret.

Clarified what it means to be approximately equal.

nearest_po2 does not do what the descriptions says it does. For one,
it returns the same power if the input is a power of 2. Second, it
returns 0 if the input is negative or 0, while the smallest possible
integral power of 2 actually is 1 (2^0 = 1). Due to the implementation
and how it is used in a lot of places, it does not seem wise to change
such a core function however, and I decided it is better to alter the
description of the built-in.

Added a few examples/clarifications/edge-cases.
 2020-07-25 20:26:02 +02:00
Thakee Nathees 04dfb78d23 GDScript operator evaluation validation bug fix 
Fix: #40665
 2020-07-24 23:32:29 +05:30
George Marques 2b9d9bc364
Remove multilevel calls 
In general they are more confusing to users because they expect
inheritance to fully override parent methods. This behavior can be
enabled by script writers using a simple super() call.
 2020-07-24 14:13:58 -03:00
George Marques e6b44b93c3
GDScript: Allow "new()" to be called in non-static functions 2020-07-24 13:45:23 -03:00
Rémi Verschelde 3811fb919e
Merge pull request #40598 from vnen/gdscript-2.0 
GDScript 2.0 (again)
 2020-07-24 01:04:57 +02:00
George Marques a0f54cb95e
Wrap up GDScript 2.0 base implementation 2020-07-22 11:07:51 -03:00
Aaron Franke 83e324d670
Update core documentation to match recent C# changes 
Also a few minor API changes like adding AABB.abs()

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
 2020-07-21 14:44:53 -04:00
George Marques aa09b4f85d
Reintroduce code completion 2020-07-20 11:38:40 -03:00
George Marques b6a2628c48
Reenable GDScript LSP server 2020-07-20 11:38:40 -03:00
George Marques dadfcd8aba
Added support for enums to be used as types in GDScript 2020-07-20 11:38:40 -03:00
George Marques 95c0909290
Add warning checks in GDScript analyzer 
Reenable checking those when validating code.
 2020-07-20 11:38:40 -03:00
George Marques 9a76ab8b6a
Add new GDScript type checker 2020-07-20 11:38:40 -03:00
George Marques 17cd6347ba
Add better local variable detection in GDScript parser 
Also store Variant operator to avoid needing to do it repeatedly in
later compiling stages.
 2020-07-20 11:38:39 -03:00
George Marques 7adb0d77cc
Add GDScript cache singleton 2020-07-20 11:38:39 -03:00
George Marques 886732ac2b
Add support for properties 2020-07-20 11:38:39 -03:00
George Marques 34c28eb2b8
Fix comments in beginning of file 
Also improve error for unknown characters.
 2020-07-20 11:38:39 -03:00
George Marques 5d6e853806
New GDScript tokenizer and parser 
Sometimes to fix something you have to break it first.

This get GDScript mostly working with the new tokenizer and parser but
a lot of things isn't working yet. It compiles and it's usable, and that
should be enough for now.

Don't worry: other huge commits will come after this.
 2020-07-20 11:38:39 -03:00
Ryan Roden-Corrent 8dcc39ec91
Include gdscript warning name in LSP message. 
My initial attempt changed this in the gdscript code, which resulted in
a duplicate warning name in the builtin editor. We should just append
the warning name in the LSP instead.

This uses parens to match what is shown in the builtin editor.
 2020-07-14 07:11:16 -04:00
Ryan Roden-Corrent d92fa3b547
Revert "Include gdscript warning name in the warning message." 
This reverts commit de3ad3b30e.
 2020-07-14 06:43:58 -04:00
Paulb23 bc4cee4458 Extract Syntax highlighting from TextEdit and add EditorSyntaxHighlighter 
- Extacted all syntax highlighting code from text edit
- Removed enable syntax highlighting from text edit
- Added line_edited_from signal to text_edit
- Renamed get/set_syntax_highlighting to get/set_syntax_highlighter
- Added EditorSyntaxHighligher
 2020-07-11 17:09:58 +01:00
Paulb23 156daddaaf Expose Syntax highlighter for editor plugins 2020-07-11 15:40:00 +01:00
Paulb23 2f1080be9b Convert syntax highlighters into a resource 2020-07-11 15:26:58 +01:00
Marcel Admiraal 26fcf2b04c Add override keywords. 2020-07-10 13:56:54 +01:00
SkyJJ e9c8bf5e1b Fix GDScriptEditorTranslationParserPlugin instance leak 2020-07-06 22:40:52 +02:00
Rémi Verschelde a535b9160d
Merge pull request #40155 from rcorre/warning-names 
Include gdscript warning name in the warning message.
 2020-07-06 16:49:54 +02:00
Rémi Verschelde 80582d1f82
Merge pull request #40116 from ThakeeNathees/editor-crash-on-super-constructor 
Fix: editor crash on super constructor called
 2020-07-06 16:45:37 +02:00
Ryan Roden-Corrent de3ad3b30e
Include gdscript warning name in the warning message. 
Occasionally you want to ignore a warning with a `warning-ignore`
comment, and you have to go into the settings to look up what the
actual name of the warning is. This patch appends the warning name to
the end of the warning so you know what string to use to ignore it,
similar to other linters like pylint.

For example

```
"The signal 'blah' is declared but never emitted.";
```

is now

```
"The signal 'blah' is declared but never emitted. (UNUSED_SIGNAL)";
```
 2020-07-06 07:22:34 -04:00
SkyJJ cae6f0bda2 Change translation parser plugin API to parse_file() 2020-07-05 12:14:56 +02:00
Thakee Nathees 023b3f2786 Fix: editor crash on super constructor called 
Fix: #39909
 2020-07-04 16:06:07 +05:30
SkyJJ efb4609425 Add translation parser plugin support 2020-07-02 14:47:35 +02:00
Rémi Verschelde a8a2769bb6
Merge pull request #38713 from aaronfranke/string-64bit 
Make all String integer conversion methods be 64-bit
 2020-07-01 16:01:05 +02:00
Tomasz Chabora 13298ed873 Improve the preload and load descriptions 2020-06-28 20:51:46 +02:00
Rémi Verschelde d341181f30
Merge pull request #38067 from ThakeeNathees/elif-error-line-fixed 
GDScript debugger incorrect error line fixed
 2020-06-17 19:17:44 +02:00
Thakee Nathees 9325671faa GDScript debugger incorrect error line fixed 
if the first line of an else or an elif throws a runtime error the
debugger shows incorrect line number.
 2020-06-17 21:24:01 +05:30
Rémi Verschelde 697897cc61
Merge pull request #39275 from ThakeeNathees/shadowed-warning-for-loop-counter 
Added shadowed var warning for `for` loop counter
 2020-06-16 15:51:31 +02:00
Rémi Verschelde 6cefb8d368
Merge pull request #39314 from ThakeeNathees/debugger-incorrect-line-fix 
GDScript debugger stepping to incorrect line fix
 2020-06-16 09:26:49 +02:00
Rémi Verschelde df0779acfd
Merge pull request #39315 from ThakeeNathees/ctrl-click-fix-for-subclasses 
Fix: Ctrl + Click not working for subclasses
 2020-06-16 09:26:15 +02:00
Rémi Verschelde 786f4ada35 GDScript LSP: Fix wrong error checks added in #39385 
Reverts `latest_client_id` back to 0, as I misunderstood how the client
IDs are assigned and, without further testing and debugging, I can't
say if this was a bug or a valid default value.
Similarly, a `latest_client_id` of -1 is no longer raising an error.

Fixes #39548.
 2020-06-15 09:51:56 +02:00
Rémi Verschelde e34f33711b GDScript LSP: Fix crash in notify_client 
`latest_client_id` now defaults to `-1` (invalid ID) instead of `0`.

Also fix typo in notification `gdscrip_client/changeWorkspace`,
and fix argument names in method binds.

Fixes #39375.
 2020-06-08 11:01:45 +02:00
Rémi Verschelde 36f6103026
Merge pull request #39301 from Calinou/fix-argument-parameter-confusion 
Tweak the GDScript error message about passed argument type mismatch
 2020-06-05 11:33:53 +02:00
Rémi Verschelde 150ba031de
Merge pull request #39276 from ThakeeNathees/predefined-check-for-loop-counter 
Added predefined var check for `for` loop counter
 2020-06-05 11:01:55 +02:00
Thakee Nathees 95b0a00d2c Fix: Ctrl + Click not working for subclasses 2020-06-05 12:25:07 +05:30
Thakee Nathees fc89c5c76d Debugger stepping to incorrect line fix 
Fix: #39296
 2020-06-05 12:15:37 +05:30
Hugo Locurcio 30053de182
Tweak the GDScript error message about passed argument type mismatch 
This makes it less confusing.

This closes https://github.com/godotengine/godot-proposals/issues/670.
 2020-06-04 22:31:37 +02:00
Thakee Nathees e153772de2 predefined var check for for loop counter 2020-06-04 10:37:22 +05:30
Thakee Nathees 54835a5302 shodowed var warning for for loop counter 
Fix: #39268
 2020-06-04 10:28:09 +05:30
Aaron Franke 25c978730b
Rename String bin_to_int64 to bin_to_int 
And also change String static to_int(const char *) to return int64_t
 2020-06-03 00:04:15 -04:00
Aaron Franke e5ae89775a
Remove 32-bit String hex_to_int method 2020-06-03 00:03:34 -04:00
Aaron Franke bb8aa107fd
Remove 32-bit String to_int method 2020-06-03 00:03:34 -04:00
George Marques 0f1da72492
Actually set GDScript static reference 2020-05-29 11:01:48 -03:00
Rémi Verschelde ab460e7a6f
Merge pull request #39074 from vnen/gdscript-assert-message 
Fix assert message when no custom message is set
 2020-05-27 08:23:17 +02:00
George Marques f29a2e2606
GDScript: Fix assert message when no custom message is set 2020-05-26 20:40:59 -03:00
Rémi Verschelde bfac9b3538
Merge pull request #39015 from ThakeeNathees/dict-key-autocomplete-regression-fix 
regression: dictionary key no autocomplete fix
 2020-05-25 15:58:08 +02:00
Thakee Nathees 13c372b522 regression: dictionary key no autocomplete fix 
Fix: #38998
 2020-05-24 16:52:44 +05:30
Rémi Verschelde 78e223569b
Merge pull request #33689 from jbuck3/signal-error 
Trigger an error when trying to define a preexisting signal in GDScript
 2020-05-21 11:01:23 +02:00
Rémi Verschelde af366c7adf
Merge pull request #35900 from yamgent/unreachable 
Fix false positive "Unreachable code" warning for loops
 2020-05-21 10:59:59 +02:00
Pedro J. Estébanez 1f0548efd4 Fix too eager GDScriptFunctionState stack cleanup 2020-05-19 16:41:14 +02:00
Tan Wang Leng 7b1423a61e gdscript_parser: Fix "unreachable code" false positive for loops 
Depending on the conditional statements of the 'for' and 'while' loops,
their body may not even execute once. For example:

    func a():
        var arr = []
        for i in arr:
            return i
        # can be reached, but analysis says cannot
        return -1

    func b():
        var should_loop = false
        while should_loop:
           return 1
        # can be reached, but analysis says cannot
        return 0

The parser will complain that the statements after the comment cannot
be reached, but it is clearly possible for our scenario. This is
because the parser falsely assumes that the loop body will always
execute at least once.

Fix the code to remove this assumption for both of those loops.
 2020-05-16 20:02:55 +08:00
Oliver Frank 6815bf42b3 Fix incorrect capabilities notification in LSP 
(cherry picked from commit 2173d041af)
 2020-05-15 23:55:49 +02:00
Thakee Nathees c076a2b7e9 break, continue outside of a loop, match statement handled 2020-05-15 03:16:50 +05:30
Rémi Verschelde 00949f0c5f
Merge pull request #38738 from akien-mga/cause-we-never-go-out-of-style 
Style: Remove new line at block start, enforce line between functions, enforce braces in if and loop blocks
 2020-05-14 23:09:03 +02:00
Rémi Verschelde 0ee0fa42e6 Style: Enforce braces around if blocks and loops 
Using clang-tidy's `readability-braces-around-statements`.
https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
 2020-05-14 21:57:34 +02:00
Rémi Verschelde 5046f666a1
Merge pull request #38610 from ThakeeNathees/infer-type-null-error 
set parser error when infer type is null
 2020-05-14 21:50:48 +02:00
Rémi Verschelde 07bc4e2f96 Style: Enforce separation line between function definitions 
I couldn't find a tool that enforces it, so I went the manual route:
```
find -name "thirdparty" -prune \
  -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \
  -o -name "*.glsl" > files
perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files)
misc/scripts/fix_style.sh -c
```

This adds a newline after all `}` on the first column, unless they
are followed by `#` (typically `#endif`). This leads to having lots
of places with two lines between function/class definitions, but
clang-format then fixes it as we enforce max one line of separation.

This doesn't fix potential occurrences of function definitions which
are indented (e.g. for a helper class defined in a .cpp), but it's
better than nothing. Also can't be made to run easily on CI/hooks so
we'll have to be careful with new code.

Part of #33027.
 2020-05-14 16:54:55 +02:00
Rémi Verschelde 0be6d925dc Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 
Which means that reduz' beloved style which we all became used to
will now be changed automatically to remove the first empty line.

This makes us lean closer to 1TBS (the one true brace style) instead
of hybridating it with some Allman-inspired spacing.

There's still the case of braces around single-statement blocks that
needs to be addressed (but clang-format can't help with that, but
clang-tidy may if we agree about it).

Part of #33027.
 2020-05-14 16:54:55 +02:00
Rémi Verschelde 963a27f8a2
Merge pull request #38611 from ThakeeNathees/shadow-var-warning-bug-fix 
shadowed var warning in nested block bug fix
 2020-05-14 16:48:56 +02:00
Rémi Verschelde 1a8167867b Modernize remaining uses of 0/NULL instead of nullptr (C++11) 
Using clang-tidy's `modernize-use-nullptr`.
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-nullptr.html
 2020-05-14 13:45:01 +02:00
Rémi Verschelde 1f6f364a56 Port member initialization from constructor to declaration (C++11) 
Using `clang-tidy`'s `modernize-use-default-member-init` check and
manual review of the changes, and some extra manual changes that
`clang-tidy` failed to do.

Also went manually through all of `core` to find occurrences that
`clang-tidy` couldn't handle, especially all initializations done
in a constructor without using initializer lists.
 2020-05-14 10:01:56 +02:00
Thakee Nathees 687b1941b4 set parser error when infer type is null 2020-05-13 22:12:23 +05:30
Rémi Verschelde e7c9d81876
Merge pull request #38609 from ThakeeNathees/range-crash-with-non-numeric-const-fix 
range() with non-numeric const argument crash fix
 2020-05-13 15:42:29 +02:00
Rémi Verschelde dc649684be
Merge pull request #38708 from ThakeeNathees/init-assign-type-parser-bug-fix 
regression: var declaration type info parser bug fix
 2020-05-13 15:41:28 +02:00
Thakee Nathees e7f056dfac regression: static func can't access const fix 2020-05-13 06:07:22 +05:30
Thakee Nathees e5d735851d regression: var declaration type info parser bug fix 2020-05-13 05:58:27 +05:30
Rémi Verschelde 69de7ce38c Style: clang-format: Disable AllowShortCaseLabelsOnASingleLine 
Part of #33027.
 2020-05-10 13:13:54 +02:00
Rémi Verschelde e956e80c1f Style: clang-format: Disable AllowShortIfStatementsOnASingleLine 
Part of #33027, also discussed in #29848.

Enforcing the use of brackets even on single line statements would be
preferred, but `clang-format` doesn't have this functionality yet.
 2020-05-10 13:12:16 +02:00
Rémi Verschelde da898c116c
Merge pull request #37160 from ThakeeNathees/saveing-cyclic-inheritance-crash-fix 
Fix: saving gdscript with cyclic inheritance crash the editor
 2020-05-10 13:11:40 +02:00
Rémi Verschelde a128dd97d6
Merge pull request #37020 from aaronfranke/range 
Allow using integer vectors for iteration and make range() use them
 2020-05-10 13:11:07 +02:00
Thakee Nathees 79eee93b9a shadowed var warning in nested block bug fix 
Fix: #38552
 2020-05-10 10:54:23 +05:30
Thakee Nathees 3e10392d48 range() with non-numeric const argument crash fix 2020-05-10 10:07:23 +05:30