Commit graph

24820 commits

Author SHA1 Message Date
Hugo Locurcio 4f14a1f59c
Remove type hint from the @GDScript class documentation
The current consensus in the Godot documentation is to avoid using
type hints unless they're relevant to the behavior explained.
2019-11-26 19:13:55 +01:00
Rémi Verschelde ef1008e53a
Merge pull request #33917 from Faless/enet/memleak
Fix memory leak in NetworkedMultiplayerENet.
2019-11-26 17:29:58 +01:00
Fabio Alessandrelli 391f6ff2c6 Fix memory leak in NetworkedMultiplayerENet.
Dynamically allocated ids of peers where not correctly freed when
calling close_connection and disconnect_peer (with now=true).
2019-11-26 16:00:55 +01:00
Rémi Verschelde 8ea909f5b6
Merge pull request #33915 from touilleMan/issue-33913
Revert faulty stripping of / in ProjectSettings::localize_path
2019-11-26 14:14:01 +01:00
Emmanuel Leblond a1f1a1d798
Revert "Fix localise_path method so that uncached scripts don't sometimes get loaded with two backslashes"
This reverts commit 1342551664.
2019-11-26 13:42:18 +01:00
Rémi Verschelde 966c68badd Range: Remove min/max check added in #33908
This wasn't a very good idea as it puts too strict requirements on how
to set `min` and `max` values. For example, since the default min and
max are 0 and 100, this triggers an error:

```
set_min(256)
set_max(16384)
```

Since `min` will be higher than `max` temporarily. It can be worked
around by setting max first, but it's not really intuitive. I'll relax
the requirement as it's only a problem in `get_as_ratio`, which already
has a check.

Fix another min == max occurrence.
2019-11-26 12:11:21 +01:00
Rémi Verschelde 7e27ac98da
Merge pull request #33899 from Scony/fix-script-check-only-exit-code
godot exit code improvement for --script --check-only, fixes #33895
2019-11-26 11:20:16 +01:00
Pawel Lampe 9feb9aef42 godot exit code improvement for --script --check-only, fixes #33895
this commit causes godot executable to return non-zero exit code
once invalid script is passed via --script during --check-only
2019-11-26 10:53:42 +01:00
Rémi Verschelde ae04d23cce
Merge pull request #33887 from dankan1890/old_search_fix
Fixed missing scrolling in Search Help Dialog.
2019-11-26 10:53:12 +01:00
Rémi Verschelde a698fd1b46
Merge pull request #33908 from akien-mga/range-fix-max-errors
Range: Fix cases where max was set to or below min value
2019-11-26 10:51:20 +01:00
Rémi Verschelde bfd5e09879 Range: Fix cases where max was set to or below min value
It will now raise an error whenever this happens so that we can fix
these situations. `max == min` is not allowed as it could lead to
divisions by zero in ratios, and `max < min` doesn't make much sense.

Fixes #33907.
2019-11-26 10:25:41 +01:00
Rémi Verschelde 55f86e9b7b
Merge pull request #33892 from nekomatata/scirpt-editor-fixes
Fixes around ScriptEditor script list
2019-11-26 08:58:32 +01:00
Rémi Verschelde fa4f525216
Merge pull request #33872 from zaksnet/yield-add-documentation
Add some missing documentation about yield()
2019-11-25 20:56:04 +01:00
Rémi Verschelde 2ca90ba343
Merge pull request #33889 from clayjohn/specular_mode_bug
Fix bug where SpecularMode DISABLED is not cached
2019-11-25 20:55:17 +01:00
Rémi Verschelde da80e3f0f0
Merge pull request #33888 from nekomatata/debug-menu-hide
Debug menu in editor doesn't hide on checkbox toggle
2019-11-25 17:28:57 +01:00
PouleyKetchoupp 3ab5b33a47 Fixes around ScriptEditor script list
- Fixed "Previous Script" shortcut not working (CTRL+SHIFT+<)
- Fixed crash (integer division by zero) when using previous/next script shortcut with no script open
- Fixed error when dropping a script file with no script open
ERROR: ItemList::get_item_metadata: Index p_idx=-1 out of size (items.size()=0)
   At: scene\gui\item_list.cpp:257
2019-11-25 17:16:29 +01:00
Zak Stam 5cfff77ca6 Added missing documentation for yield()
Added some missing documentation about yield() being able to wait for a function also. I cant believe something like that was missing from the docs, it would have saved me so much time (and others i assume).
2019-11-25 18:08:18 +02:00
clayjohn 85dba0c09d Fix bug where specularmode disabled is not cached 2019-11-25 07:36:07 -08:00
PouleyKetchoupp dd552494eb Debug menu in editor doesn't hide on checkbox toggle
Fixes #33850
2019-11-25 16:25:54 +01:00
dankan1890 4de9c51f23 Fixed missing scrolling in Search Help Dialog.
Fix #33675
2019-11-25 16:23:35 +01:00
Rémi Verschelde e297b83b8e
Merge pull request #33883 from bruvzg/mac_locale
[macOS] Fix locale detection.
2019-11-25 16:09:12 +01:00
George Marques 5d7c13dcbb
Fix inverted value check in UWP export packager 2019-11-25 11:22:52 -03:00
bruvzg c8bf0ee062
[macOS] Fix locale detection. 2019-11-25 15:55:17 +02:00
Rémi Verschelde 5ddce7a9df
Merge pull request #33869 from jbuck3/dialog-resize-bug
Fix WindowDialog moving when resized from the left/top edge
2019-11-25 14:38:33 +01:00
Rémi Verschelde 934f6f2529
Merge pull request #33867 from rcorre/get_node_docs
Clarify get_node vs get_node_or_null.
2019-11-25 14:35:45 +01:00
Rémi Verschelde 967cc2c014
Merge pull request #33862 from Faless/net/http_request_chunk_size
Add download_chunk_size property to HTTPRequest.
2019-11-25 14:29:59 +01:00
Rémi Verschelde 5378a8f5b0
Merge pull request #33861 from RobertBColton/patch-1
Update Viewport.xml
2019-11-25 14:26:10 +01:00
Rémi Verschelde f6e5751767
Merge pull request #33860 from nekomatata/stylebox-preview-shadow
StyleBox preview adjusted to fit all drawn content
2019-11-25 14:25:39 +01:00
Rémi Verschelde 397fc4b9a6
Merge pull request #33856 from nekomatata/script-editor-text-edit-error
Fixed index out of size error in TextEdit when opening scripts
2019-11-25 14:14:06 +01:00
Rémi Verschelde d422eff036
Merge pull request #33829 from Calinou/tilemap-editor-use-info-overlay
Use the CanvasItemEditor info overlay to display TileMap coordinates
2019-11-25 13:57:08 +01:00
Rémi Verschelde 899dbf4da0
Merge pull request #33844 from akien-mga/glTexImage2D-format
GLES2: Restructure depth_internalformat code to work on mobile
2019-11-25 13:56:23 +01:00
Rémi Verschelde ba997461ba
Merge pull request #33876 from nekomatata/bookmarks-menu-translation
Removed translation for bookmarks menu item name in TextEditor
2019-11-25 13:52:30 +01:00
PouleyKetchoupp 8f0c1daf1c Removed translation for bookmarks menu item name in TextEditor
Only the label's text needs a translation, and it could cause issues when getting the node by name in a different language.
2019-11-25 13:23:09 +01:00
James Buck 5f451e0fb2 Fix WindowDialog moving when resized from the left/top edge
get_combined_minimum_size() must be used in order to consider the min size
specified by the user when determining how far the left/top edge is allowed
to move. Otherwise the dialog may think it can shrink further than it
should, causing the right/bottom edge to move when the rect size is fixed in
set_size().
2019-11-24 23:39:55 -06:00
Fabio Alessandrelli ed19b4076e Add download_chunk_size property to HTTPRequest.
This allows setting the `read_chunk_size` of the internal HTTPClient.
This is important to reduce the allocation overhead and number of file
writes when downloading large files, allowing for better download speed.
2019-11-24 19:32:20 +01:00
Robert Colton c99f6453b9
Update Viewport.xml
Add description for gui_is_dragging to document drag and drop behavior.
2019-11-24 10:45:04 -05:00
PouleyKetchoupp 1120de862d StyleBox preview adjusted to fit all drawn content
This change allows StyleBox preview to take shadows and content margins into account to display how a whole panel would be rendered.

The preview control clips contents so that in any case it doesn't bleed on controls around.

Fixes #33801
2019-11-24 16:26:30 +01:00
PouleyKetchoupp 8830e53fe1 Fixed index out of size error in TextEdit when opening scripts 2019-11-24 10:48:04 +01:00
clayjohn 5ab3b61520 Restructure depth_internalformat code to work on mobile
This changes the code path so that `glRenderBufferStorage*` always uses
values appropriate for renderbuffers and `glTexImage2D` never uses an
internalformat meant for buffers.

Fixes #33825.
2019-11-23 18:08:19 -08:00
Rémi Verschelde bb1d75f55e glTexImage2D: Fix confusion between format and internal format
The `format` parameter is similar to `internalFormat` but takes different
values, and especially only `GL_DEPTH_COMPONENT` for depth, without size
specifier.

Cf. https://www.khronos.org/registry/OpenGL-Refpages/es3.0/html/glTexImage2D.xhtml

Fixes a regression from #33278 and another occurrence.
2019-11-23 19:38:31 +01:00
Rémi Verschelde 636bc5c32f
Merge pull request #33828 from neikeq/貴様
Mono/C#: Prevent SCons from building API solutions in parallel
2019-11-23 11:24:48 +01:00
Fabio Alessandrelli 9b2073aa97
Merge pull request #33652 from Black-Cat/http-client-fix
Fix HTTPClient::poll crash when connection set to null
2019-11-23 10:15:45 +01:00
Artem Burjachenko b73073ae36 Fix HTTPClient::poll crash when connection set to null 2019-11-23 11:06:14 +04:00
Hugo Locurcio 13f98f80b6
Use the CanvasItemEditor info overlay to display TileMap coordinates
This also removes the editor setting that toggles coordinate display,
as it no longer solves an existing bug.

This closes #28135.
2019-11-22 23:58:36 +01:00
Ignacio Etcheverry ebdd2bc474 Mono/C#: Prevent SCons from building API solutions in parallel 2019-11-22 23:42:24 +01:00
Rémi Verschelde 91b60a74df
Merge pull request #33799 from fire/gltf2-scene
33714 glTF2 scene count change try two.
2019-11-22 20:55:42 +01:00
K. S. Ernest (iFire) Lee 80b1604fa9 33714 glTF2 handle undefined load-time scene. 2019-11-22 08:48:23 -08:00
Rémi Verschelde b7ea22c5d2 i18n: Sync translation template with current source 2019-11-22 09:21:58 +01:00
Rémi Verschelde b395d6bd80 i18n: Sync translations with Weblate 2019-11-22 09:20:29 +01:00
Rémi Verschelde fd6394e217
Merge pull request #33798 from capnm/capnm-fix-33749
Setting the node process priority should not trigger an error
2019-11-22 09:02:40 +01:00