Commit graph

47717 commits

Author SHA1 Message Date
Frank Hassanabad
023d668e13
[Security Solutions] Adds e2e tests for the legacy notification system (#116531)
## Summary

Adds e2e tests for the legacy notification system for:
* Exporting rules
* Reading rules
* Finding rules

Also adds missing e2e tests for the non-legacy actions where they previously did not have e2e tests.

These tests ensure that the legacy notifications system will run for a while.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-10-29 14:02:52 -06:00
Brian Seeders
19f4b6801f
Revert "add the "UI" team label to APM project issues (#116710)"
This reverts commit dc7410edbe.
2021-10-29 15:57:31 -04:00
Gil Raphaelli
dc7410edbe
add the "UI" team label to APM project issues (#116710) 2021-10-29 15:56:32 -04:00
Chris Donaher
478d138c32
Send Endpoint Alert _id field up as insights docs track that on status changes (#116687)
* Send Endpoint Alert _id field up as insights docs track that on status changes

* Added test to make sure top-level underscore-prefixed fields are allowed

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 13:47:31 -06:00
Marshall Main
b59b132ff4
Remove validation requiring action id to be UUID (#116524)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 15:26:06 -04:00
Nathan Reese
ee61368cff
[Maps] fix data-mapping switch enabled for vector tiles (#116366)
* clean up IField API

* disable switch when using MVTs for es docs

* clean up interface comment style

* implement supportsFieldMetaFromEs and supportsFieldMetaFromLocalData in all Field classes

* fix dynamic_color_property test

* fix jest tests

* mock getRangeFieldMeta instead of passing in VectorLayerMock with MockStyle

* review feedback

* clean up supportsFieldMetaFromLocalData test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 12:47:58 -06:00
Paul Tavares
d284d65ad4
[Security Solution][Endpoint] Fix and un-skip Jest UT for Policy Details remove trusted app modal (#116492)
* increase update API response delay
2021-10-29 14:46:30 -04:00
Paul Tavares
ea1c3f2a09
Fix skipped test to be more robust in matching relative dates (#116474)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 14:40:35 -04:00
Kristof C
26ca3ffe05
[105264] Fix error not surfacing bug for Jira (#114800)
* [105264] Fix error not surfacing bug for Jira

* [105264] Fix ServiceNow errors not surfacing to UI

* Fix tests with updated functon

* Fix PR errors

Co-authored-by: Kristof-Pierre Cummings <kristofpierre.cummings@elastic.co>
2021-10-29 13:27:41 -05:00
Aleh Zasypkin
91af33b69f
Upgrade cheerio dependency (1.0.0-rc.91.0.0-rc.10). (#116737) 2021-10-29 20:24:49 +02:00
Sandra G
62f807227b
[Stack Monitoring] Logstash Functional Tests (#116481)
* logstash overview functional test

* logstash nodes listing functional tests

* node detail tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 13:55:32 -04:00
Xavier Mouligneau
3f91556e67
[SECURITY] Copy saved object flyout should not allow copying into the active space (#116657)
* copy saved object flyout should not allow copying into the active space

* stupid me
2021-10-29 13:55:17 -04:00
Shahzad
45476dcbe6
[Uptime] Fix filters in query for fetching monitor attached rules (#115921)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 19:50:47 +02:00
Shahzad
d4d470d938
Fix intermitting series state (#115747)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 19:50:14 +02:00
Shahzad
9714aac93c
[Exp view] Fix apply button equality check (#115744)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 19:49:30 +02:00
Melissa Alvarez
40fd867b65
[ML] Data Frame Analytics Wizard: ensure includes updated correctly on dependent variable change (#116381)
* ensure included fields not overwritten + reduce unnecessary renders.

* ensure editor validation works

* ensure depVar always in includes

* ensure selected runtimeField depVar option is shown
2021-10-29 13:48:42 -04:00
Shahzad
4492a107bd
[Alerting] Remove unnecessary call on every kibana load (#116572) 2021-10-29 19:48:25 +02:00
Spencer
05cfe434f0
[alerting] disable status reporting for now (#116717)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-10-29 12:48:03 -05:00
Frank Hassanabad
29ac5583b7
[Security Solutions] Critical bug fix to make error messages about missing connections clearer for the end user. (#116490)
## Summary

Fixes issue see on this comment:
https://github.com/elastic/kibana/issues/116336#issuecomment-952159636

* Removes legacy toaster component
* Adds newer toaster component
* Removes issue with the deps array within ReactJS
* Adds utility to give a better network error message to the end user.
* This does effect the timeline component since it shares the same import common component.
* Adds a count of how many rules/timeline items have failed imports
* These error toasters mimic Kibana core's error toaster error message and UI/UX
* Adds e2e tests for imports with actions and error messages for them.

## Rules import error messages now

Before for small toaster:
<img width="417" alt="Screen Shot 2021-10-26 at 6 03 25 PM" src="https://user-images.githubusercontent.com/1151048/139132586-3cf77c73-53ac-4066-b01f-2e91ef2da111.png">

After for small toaster for different error conditions:
<img width="358" alt="Screen Shot 2021-10-26 at 6 00 24 PM" src="https://user-images.githubusercontent.com/1151048/139132679-2eeb1ed3-9f6e-4766-a8ed-8804ce3e6963.png">

<img width="396" alt="Screen Shot 2021-10-26 at 6 01 00 PM" src="https://user-images.githubusercontent.com/1151048/139132742-750cd937-f401-44e8-9a10-c21410073b5d.png">

<img width="379" alt="Screen Shot 2021-10-26 at 6 02 29 PM" src="https://user-images.githubusercontent.com/1151048/139132766-21b58bea-7f46-43a6-a0e9-f01632958eab.png">

Before for when you click "See the full error":
<img width="817" alt="Screen Shot 2021-10-26 at 5 58 47 PM" src="https://user-images.githubusercontent.com/1151048/139132980-de1942d6-7b03-4c08-b34a-1fc4a22d5207.png">

After for when you click "See the full error":
<img width="838" alt="Screen Shot 2021-10-27 at 1 48 16 PM" src="https://user-images.githubusercontent.com/1151048/139136581-af1e331e-ed77-4338-8fb0-c2457acd135f.png">

<img width="802" alt="Screen Shot 2021-10-27 at 1 26 31 PM" src="https://user-images.githubusercontent.com/1151048/139135083-9ca56940-30a8-4f83-9355-312307172834.png">

## timeline

Before:
<img width="441" alt="Screen Shot 2021-10-27 at 1 19 00 PM" src="https://user-images.githubusercontent.com/1151048/139136614-8360d6a6-d182-413e-b5d9-b18e3d70dc24.png">

<img width="827" alt="Screen Shot 2021-10-27 at 1 19 08 PM" src="https://user-images.githubusercontent.com/1151048/139136637-f9203ac2-0eea-4a77-9c53-ac2c20ab32e0.png">

After:
<img width="408" alt="Screen Shot 2021-10-27 at 1 49 45 PM" src="https://user-images.githubusercontent.com/1151048/139136758-7532a8ba-6d73-45e2-adbb-6756ee997289.png">

<img width="820" alt="Screen Shot 2021-10-27 at 1 49 50 PM" src="https://user-images.githubusercontent.com/1151048/139136774-26d4a8a2-caf0-4c6f-94d3-a6cd92b79f5f.png">

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-10-29 11:44:38 -06:00
Nicolas Chaulet
d384a2f508
[Fleet] Fix pipeline with id [*] does not exists (#116707) 2021-10-29 13:44:24 -04:00
Frank Hassanabad
83fe1dd90a
Changes log level from info to debug from user complaints about logs filling up (#116518)
## Summary

Changes detections log level from info to debug within the detection engine. Users have been complaining about their log files filling up in excessive size from when they have noisy rules or if they have a large amount of rules enabled.
2021-10-29 11:40:08 -06:00
Nathan Reese
7c73e227eb
[Maps] convert EMS TMS source to typescript (#116508)
* [Maps] convert EMS TMS source to typescript

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 11:33:12 -06:00
Nathan Reese
0a3cd8ebab
[Maps] do not allow label overlap (#116190)
* [Maps] do not allow label overlap

* split symbol labels into seperate layer

* clean up comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 11:31:04 -06:00
Madison Caldwell
6ba984eb03
Add support for actions on kibana.* fields and legacy signal.* fields (#116491)
* Add support for actions on kibana.* fields and legacy signal.* fields

* Improve types and add scheduleNotificationActions test

* Unnecessary cast

* Was accidentally returning all alerts in map, instead of single alert

* Cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 11:29:38 -06:00
Spencer
30872e9063
remove all references to v7 theme (#113570)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 12:28:42 -05:00
Vitalii Dmyterko
b481bff349
[Security Solution][Detections] Fix truncated values in columns for rules table (#115825)
* Fix truncated rule name on rules table

* remove empty line

* remove truncateText for all rules table columns

* rename unit tests

* refactor unit tests

* fix ts error

* fix ts error

* remove config line

* fix types after kbn bootstrap

* CR: remove unnecesary tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 18:28:11 +01:00
Marshall Main
a68f3ffd06
[Security Solution] Only apply field aliases to legacy .siem-signals indices (#115290)
* Only apply field aliases to legacy .siem-signals indices

* Fix unit test mocks

* Add new function for special index existence check

* Actually add new function for special index existence check

* Undo getIndexVersion change

* Add basic integration tests for field alias logic

* Add back create_index to test list

* Add missing markdown to readme

* Revert change to delete_index_route

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 13:19:54 -04:00
Tyler Smalley
efd043e364
[renovate] Renames master to main (#116790)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-10-29 09:55:26 -07:00
Tyler Smalley
c4815d319e
Updates Github link references from master to main (#116789)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-10-29 09:53:08 -07:00
Jen Huang
2194f2b93c
[Fleet] Fix branch conditions to check against main and add skip version check config option (#116530) 2021-10-29 12:47:36 -04:00
Brian Seeders
3036e102ed
Update ES snapshot build branch to build master 2021-10-29 12:42:52 -04:00
Greg Back
535a7b359d
[doc-links] Ensure correct doc links from main branch (#116652)
Until all repos are switched over to using a "main" branch, all the doc
URLs are still published as the "master" version. This also gives us a
single place to change once we start publishing them as "main".
2021-10-29 09:39:59 -07:00
Brian Seeders
ba367bca40
Change all references of master branch to main (#116654) 2021-10-29 12:29:48 -04:00
Zacqary Adam Xeper
6693ef371f
[Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (#115874)
* [Logs UI][Metrics UI] Remove deprecated config fields from APIs

* Fix typecheck

* Fix typecheck

* Fix typecheck

* Fix jest

* Fix functional test

* Remove extraneous timeField args

* Typecheck fix

* Consolidate log file changes to ResolvedLogSourceConfiguration

* Fix merge

* Revert additional logs files

* Revert inventory models

* Revert log_analysis api

* Fix timefield reference in process list

* Restore logs page files, fix typecheck on mock

* Fix functional test

* Restore inventory models index

* Fix typecheck on getFilteredMetrics

* Look CI if you don't tell me all the type errors at once I can't fix them all

* Maybe this is the last typecheck fix who knows
2021-10-29 12:12:26 -04:00
Zacqary Adam Xeper
c0d005db62
[Metrics UI] Fix OR logic on redundant groupBy detection (#116695) 2021-10-29 16:07:04 +00:00
Esteban Beltran
ddf092f38c
[Security Solution] Host isolation exceptions - fixes for QA issues (#116089)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 15:54:17 +00:00
Quynh Nguyen
d4f4e64426
[ML] Re-enable explorer link jest test (#116324)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 15:53:05 +00:00
Tyler Smalley
d295156eb8
Removes master>main sync (#116553)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-10-28 08:45:58 -07:00
Xavier Mouligneau
24e5bd244c
[SECURITY] Remove flaky test on edit user page (#116467)
* no more flaky test

* fix eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 11:21:53 -04:00
Cauê Marcondes
155a16ed2f
[APM] Errors api test: error_groups/main_statistics (#116337)
* use apmApiClient

* refacroting

* fixing errors groups main statistics tests

* refactoring

* fixing error group detailed stats test

* fixing ts issue

* renaming empty archiver
2021-10-28 16:20:51 +01:00
Nicolas Chaulet
a23d5e29a4
[Fleet] Fix edit package policy save button (#116482) 2021-10-28 11:17:47 -04:00
Josh Dover
d5963884b6
Include failure reason when packages cannot be installed during setup (#116612) 2021-10-28 15:47:26 +01:00
Gloria Hornero
b102846c82
adds import Timeline test (#114703) 2021-10-28 15:34:19 +01:00
Marshall Main
d280f12757
[Security Solution] Security RAC migration follow up bug fixes (#116386)
* Add compatibility aliases to alerts as data indices

* Fix dupe mitigation, allow more fields in mapping

* Remove legacy signals fields from new RAC alerts

* Fix cypress test

* Remove outdated comment

* Reduce flakiness in time based test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 10:21:51 -04:00
Paul Tavares
2f3d4fcb48
[Security Solution][Endpoint] Fix bug where users without superuser role are not able to see Endpoint data on Host Details (#116202)
* Add `.catch()` statement to ES calls in order to get better stacktraces
* Improve efficiency of getHostEndpoint() search strategy method
* Refactor `getHostEndpoint()` to use new Metadata service as well as the internal kibana ES client
2021-10-28 15:18:50 +01:00
Paul Tavares
7c12ffffee
[Security Solution][Endpoint] Un-skip Policy Details FTR test suite and fix bug in Policy Details page when saving changes (#115662)
* unskip test suite
* Fix functional tests and some refactoring
* Refactor Policy Details test and centralize getting of Agent Policy combined input for endpoint
* Change approach for checking policy data in fleet pages
* Change Policy Settings displayed in Fleet to a) show a loader while retrieving settings and b) show loading errors if any
* Close any visible toasts before clicking on the save button
2021-10-28 15:10:32 +01:00
Baturalp Gurdin
24c6d6583d
fix: move concurrency parameters to substep (#116461)
Concurrency parameters were not in the correct place which made concurrency settings not in effect.
Moved it to to performance.sh step which also has parallelism in the same level.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 14:59:44 +01:00
Oliver Gupte
2856e19db7
[APM] Adds missing legacy key for apm-server.secret_token (#116385) (#116554) 2021-10-28 09:46:41 -04:00
Frank Hassanabad
b2f4c821f3
[Security Solutions] Adds console logging and relaxes the 200 checks in a 2 areas of the e2e tests (#116548)
## Summary

Adds console logging and relaxes a few 200 checks in the end to end tests in two areas of:
* createExceptionListItem
* importFile

As recently the tests are failing around these parts and possibly we can get information on the next failures if it is from these two areas or if it's from somewhere else we are not expecting.

Also outputs the body message so if it fails in these areas we can see the message with the conflict that might help us see where the issue is arising.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-10-28 15:27:45 +02:00
Shahzad
9e7f1c8e35
[Global search] Prevent unnecessary /internal/global_search/find http call at startup (#112535)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-28 15:26:28 +02:00