Commit graph

16498 commits

Author SHA1 Message Date
Christiane (Tina) Heiligers 557a658545
Converts saved object tagging to new management layout (#102284) 2021-06-17 14:46:30 -04:00
Nicolas Chaulet b8153946c7
[Fleet] Sync hash history with Kibana scoped history (#102523) 2021-06-17 13:57:35 -04:00
Shahzad 4d474bfe4d
[User Experience App] Use filters shared component (#101459)
Co-authored-by: Casper Hübertz <casper@formgeist.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-17 19:19:16 +02:00
Ryland Herrick ac07ebba87
[Security Solution] kbn package for generic hook utils (#101976)
* Adds boilerplate for new hook-utils package

* Move existing, identified utils into our hook-utils package

Updates references, and fixes a few missing config that were preventing
packages from building.

* Extracts a common type and adds a little more JSdoc for clarity

* Adds new useObservable hook

Similar to useAsync (a nearly identical interface), this is meant to
wrap a thunk returning an observable, allowing conditional invocation
and progressive updates as the observable continues to emit.

* Remove orphaned test

This function (and its tests) were moved to the hook-utils package; this
was simply missed.

* Remove optional chaining from kbn package

The build system does not currently support these typescript features.
While a valid fix would also have been to build separate browser and
node targets a la #99390, the use here was very minimal and so changing
to a supported syntax was the most pragmatic fix.

* Update old reference in test file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-17 12:09:17 -05:00
Steph Milovic 06be699862
[Security Solution] [Cases] Various Cases cleanups (#102103) 2021-06-17 10:52:04 -06:00
Constance 0e14cef4cb
[Workplace Search] Convert Settings pages to new page template (#102445)
* Convert Settings > Customize to new page template

* Convert Settings > oAuth application to new page template

+ DRY form wrappers, update test

* Convert Settings > Connectors to new page template

* Convert source config view to new page template

* Convert Settings subnav to EuiSideNav format

+ update main WS nav

* Update routers
2021-06-17 09:36:17 -07:00
Constance 1627240ff8
[Workplace Search] Convert Overview & Security pages to new page template (#102444)
* Convert WS Overview page to new page template

* Misc Overview refactors

- Fix extra spacing caused by hidden onboarding steps

- Default page title to "Organization overview" instead of to onboarding title which flashes during loading

- Prefer shallow over mount (will matter later, when WorkplaceSearchPageTemplate nav includes more kea logic)

* Convert Security page to new page template

+ misc ux enhancement disabling header actions while data is still loading
2021-06-17 09:28:14 -07:00
Constance e8c16e310f
Fix logout link not working on local dev (#102451) 2021-06-17 09:08:51 -07:00
Sandra Gonzales ae411dd1e9
fix node id comparison (#101941)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-17 11:52:51 -04:00
Dan Panzarella 9be0d4d5ad
[Security Solution] Endpoint Pending Action full count (#102502) 2021-06-17 11:47:26 -04:00
Jonathan Budzenski c79519a90f skip flaky suite. #102332 2021-06-17 10:34:00 -05:00
Josh Dover 97feae3d1b
Add xpack.cloud.full_story configuration (#102363) 2021-06-17 10:25:32 -04:00
Josh Dover 02971177cc
Display Kibana overall status in the logs and have FTR wait for green status before running tests (#102108) 2021-06-17 10:19:07 -04:00
Robert Oskamp a9d7431b45
[ML] Functional tests - fix and re-enable module API tests (#102477)
This PR fixes and re-enables the temporarily skipped API test suite for ML modules.
2021-06-17 16:13:10 +02:00
Søren Louv-Jansen ca523479d1
[APM] Remove omitEsFieldValue and update parseEnvironmentUrlParam (#101876) 2021-06-17 15:54:05 +02:00
Marco Liberati 421493c57a
[Lens] More memoization work on the editor_frame (#102186)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-17 15:47:08 +02:00
Jean-Louis Leysens 7a08bd8b69
[Fleet] Add packages to global search results (#102227)
* added public-side implementation for package search

* added a test for the new search results provider and updated behaviour

* added comment about open issue regarding hash router in fleet

* fixed jest tests

* refactor to reduce size of if statement

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-17 15:45:28 +02:00
Aaron Caldwell 246e7be3e5
[Maps] Add layer edit controls (#99812)
Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
2021-06-17 09:21:45 -04:00
Søren Louv-Jansen d57ffce8ec
[APM] Show JVM tab for Java Otel agent (#102346) 2021-06-17 08:56:04 -04:00
Tiago Costa 9569fe0561
skip flaky suite (#101454) 2021-06-17 13:00:22 +01:00
Søren Louv-Jansen 17e264e55e
[APM] Fix SVG rendered agent icon in Service Map, and improve storybook for icons (#102182) 2021-06-17 06:24:39 -04:00
Joe Reuter 84e86763f4
[Lens] Formula time shift (#101718) 2021-06-17 12:17:45 +02:00
Ashokaditya 1445aaa964
Do not show activity log error popups (#102450)
we show an empty state on the actions log tab anyway

refs 2dd22ed92b

fixes elastic/kibana/issues/102335
2021-06-17 12:13:03 +02:00
Marco Liberati 7f625530fb
[Lens] Add some more documentation for dynamic coloring (#101369)
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-17 10:27:25 +02:00
Sergi Massaneda d92ddf4b70
hide not searchable results when no term (#102401) 2021-06-17 10:17:17 +02:00
Marco Liberati 4447ca2a16
[Lens] Fix Formula functional test with multiple suggestions (#102378) 2021-06-17 10:14:29 +02:00
Esteban Beltran a83d0e7f9a
Fix trusted apps modified by field displayed as a date field (#102377)
Fixes https://github.com/elastic/kibana/issues/102308
2021-06-17 09:40:16 +02:00
mgiota fd5883b465
update readme of logs-metrics-ui (#101968) 2021-06-17 08:28:34 +02:00
Nathan L Smith 6113520470
Refactor observability plugin breadcrumbs (#102290)
Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route.

In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases.

The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana".

Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages.

Fixes #102131.
2021-06-17 00:27:23 -05:00
Matthew Kime bfca0c3197
[Index Patterns] Move rollup config to index pattern management v2 (#102285)
* move rollup config to index pattern management
2021-06-16 20:14:28 -05:00
Paul Tavares 2507d37e37
[Security Solution][Endpoint] Isolate Action should only be available to Platinum+ licenses (#102374)
* Isolate action should only be available for platinum license
* Moved `useLicense` hook mock into `__mocks__`
2021-06-16 18:45:40 -04:00
Constance 66c9d801d5
[Enterprise Search] Set up initial KibanaPageTemplate (#102170)
* Set up shared EnterpriseSearchPageTemplate component

* Set up product-specific page templates + setPageChrome

+ misc tech debt - create AS components/layout/index.ts for imports

* Set up navigation helpers for EuiSideNav usage

- Update react_router_helpers to pass back props as a plain JS obj instead of only working with React components (+ update react components to use new simpler helper)

- Convert SideNavLink active logic to a plain JS helper

* Set up top-level product navigations

NYI: sub navigations (future separate PRs)

* Set up test_helpers for inspecting pageHeaders

- primarily useful for rightSideItems, which often contain conditional logic

* Initial example: Convert RoleMappings views to new page template

Minor refactors:
+ remove unnecessary type union
+ fix un-i18n'ed product names
+ add full stop to documentation sentence
+ add semantic HTML tags around various page landmarks (header, section)

* EUI feedback: add empty root parent section

* Revert Role Mappings union type removal

- but shenanigans it a bit to take our i18n'd shared product names (requires as const assertion)

- done to reduce merge conflicts for Scotty / make his life (hopefully) a bit easier between ent-search and Kibana

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 18:23:13 -04:00
Dominique Clarke 1cf82cbc36
[Uptime] refactor Synthetics Integration package UI (#102080)
* refactor contexts

* add http, tcp, and icmp folders

* adjust types

* adjust useUpdatePolicy hook

* adjust synthetics policy create and edit wrappers

* adjust validation

* fix typo and types

* remove typo

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 15:29:28 -04:00
Chris Roberson ab2a80f4b0
[Task Manager] Log at different levels based on the state (#101751)
* Log at different levels based on the state

* Fix types and add tests

* Remove unnecessary code

* Add more descriptive message

* Partially fix failing tests

* Move into separate function

* Get rid of customStatus in favor of moving the logging logic to a separate, mockable function

* Remove debug logging

* Do not log as an error if the stats are empty

* PR feedback

* Add docker whitelist

* alpha order

* English is hard

* Removing extra newline

* PR feedback around ignoring capacity estimation

* Move json utils
2021-06-16 15:20:28 -04:00
Cauê Marcondes adc95c1023
[APM] Fixing time comparison types (#101423)
* fixing time comparison types

* fixing ts issues

* addressing PR comments

* addressing PR comments

* addressing PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 14:32:22 -04:00
Dario Gieselaar 8eea491412
[RAC] Update alert documents in lifecycle rule type helper (#101598)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 14:15:59 -04:00
Robert Oskamp 154150732d
[ML] Functional tests - fix and re-activate alerting flyout test (#102368)
This PR fixes the ML alerting flyout tests and re-activates it.
2021-06-16 13:42:44 -04:00
Tim Sullivan c26d178937
[Reporting] remove unused reference to path.data config (#102267) 2021-06-16 10:32:48 -07:00
Kyle Pollich 4a94156550
[Fleet + Integrations UI] Migrate Fleet UI to new tabbed layout (#101828)
* WIP: Migrate fleet to new page layout system

* Add 'Add Agent' button to agents table

* Fix flyout import in search and filter bar

* Place settings/feedback in header

* Move actions to top nav

* Fix i18n + types + unit test failures

* Remove unused props in DefaultLayout

* Fix background height in Fleet layout

This is fixed through a hack for now, because Kibana's layout doesn't
allow apps to flex the top-level wrapper via `flex: 1`. The same
behavior reported in the original issue (#101781) is present in all
other Kibana apps.

Fixes #101781

* Use euiHeaderHeightCompensation for min-height calc

* Move settings portal to app component

* Fix agent details URL in failing unit test

* Remove unreferenced overview files + update functional tests

* Remove unneeded fragment

* Remove beta badges in Fleet + Integrations

Fixes #100731

* Fix i18n

* Fix page path reference

* Fix failing tests

* Re-fix i18n post merge

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 10:29:38 -07:00
spalger 3e723045a0 remove nested skip (#100296) 2021-06-16 10:14:15 -07:00
spalger f4e0895b17 skip flaky suite (#100296) 2021-06-16 10:10:38 -07:00
spalger c8256d57bd skip flaky suite (#101984) 2021-06-16 10:07:21 -07:00
John Dorlus d2e81ee785
CIT for circle processor (renewed PR) (#102277)
* Added CITs for Circle processor.

* Fixed issue with form function using int instead of string.

* Added changed per nits.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 12:07:50 -04:00
Madison Caldwell c5e74d8241
[RAC][Security Solution] Pull Gap Remediation out of search_after_bulk_create (#102104)
* Modify threshold rules to receive a single date range tuple

* Modify threat match rules to receive a single date range tuple

* Modify custom query rules to receive a single date range tuple

* Fix up tests (partially)

* Change log message to indicate single tuple instead of array

* Bad test?

* Prevent max_signals from being exceeded on threat match rule executions

* Revert "Prevent max_signals from being exceeded on threat match rule executions"

This reverts commit ba3b2f7a382ef7c369f02c7939e1495f72d92bfe.

* Modify EQL rules to use date range tuple

* Modify ML rules to use date range tuple

* Fix ML/EQL tests

* Use dateMath to parse moments in ML/Threshold tests

* Add mocks for threshold test

* Use dateMath for eql tests
2021-06-16 11:35:07 -04:00
Liza Katz 8abb656d7f
[Kuery] Move json utils (#102058)
* Move JSON utils to utils package

* Imports from tests

* delete

* split package

* docs

* test

* test

* imports

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 18:15:47 +03:00
Alison Goryachev 447728ff20
[Watcher] Migrate to use new page layout (#101956) 2021-06-16 11:02:55 -04:00
Wylie Conlon bdc87409ba
[Lens] Create mathColumn function to improve performance (#101908)
* [Lens] Create mathColumn function to improve performance

* Fix empty formula case

* Fix tinymath memoization

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 10:35:55 -04:00
Pete Hampton c4af30845e
Add additional collection item to security allow list filter. (#102192) 2021-06-16 15:33:27 +01:00
Kyle Pollich a84293b743
[Fleet + Integrations UI] Address UI Regressions in Fleet/Integrations (#102250)
* Fix active tabs in integrations UI

Fixes #101771

* Remove duplicate base breadcrumb

Fixes #101785

* Fix i18n
2021-06-16 10:26:19 -04:00
Joe Reuter 036c157f10
[Lens] Unload canvas test properly (#102101) 2021-06-16 16:00:43 +02:00
Paul Tavares 1b7a5a99cb
[Security Solution][Endpoint] Show Endpoint Host Isolation status on endpoint list (#101961)
* Add endpoint isolation status for when multiple actions of different types are pending
* Refactored List to break out Agent status code to separate component
* Generator improvements for how actions are generated for Endpoints
* Add HTTP mock for fleet EPM packages (to silence console errors)
* new `.updateCommonInfo()` method to generator (to regenerate stateful data)
2021-06-16 09:59:51 -04:00
David Sánchez 6b99e662cf
Updates app_id to use integrations one instead of fleet for back button link (#102312) 2021-06-16 15:32:26 +02:00
Tyler Smalley 3236f3fafa skip flaky suite (#102283) 2021-06-16 06:30:31 -07:00
Stacey Gammon a7b0391702
Use export type instead of export to reduce bundle size (#101796)
* Use export type instead of export to reduce bundle size

* Update legacy docs

* update docs again

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 09:28:50 -04:00
Alexey Antonov 78b803be2b
Add telemetry for editor clicks events (#100664)
* Track editor clicks events

Closes: #98949

* add create and open telemetries

* add telemetry for dashboard

* remove hardcoded originatingApp for lens

* DashboardConstants.DASHBOARDS_ID ->  DashboardConstants.DASHBOARD_ID

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 16:16:56 +03:00
David Sánchez 3c1b7e2f66
[Security solutions][Endpoint] Break long names on remove trusted apps/event filters dialog (#102307)
* Break long names on remove trusted apps/event filters dialog.

* Removes wrong class
2021-06-16 15:15:46 +02:00
Casper Hübertz d3c1f7c54d
[Observability] Updating header menu links across Observability apps (#101472)
* [Observability] POC aligning menu links across apps

* [APM] Changed guttersize

* [APM] Replace placeholder button

* [Uptime] Remove icon from Settings header link

* [APM] Reordered anomaly detection and alerts

* [Logs] Remove icon from settings and change guttersize

* [Metrics] Remove icon from settings and change guttersize

* [Logs] Change button style of `isStreaming` state

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 14:38:04 +02:00
Pete Harverson 35e10ba770
[ML] Adds optimizations for Logs UI anomaly detection jobs (#102191)
* [ML] Adds optimizations for Logs UI anomaly detection jobs

* [ML] Increment version for log-entry-categories-count job

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-16 11:31:10 +01:00
Pablo Machado 037d7aeb8f
Enhance cases bulk deletion action dialog message (#101403)
Differentiate the dialog message on the deletion of one item from the deletion of multiple items.
Simplifies CasesTableUtilityBar by handling the selection of multiple and single cases in the same way.
2021-06-16 06:23:10 -04:00
Joe Reuter a946f9bd3d
add description and owner to kibana.json (#102238) 2021-06-16 10:23:31 +02:00
Joe Reuter 4180a026b7
[Lens] Formula overall functions (#99461) 2021-06-16 10:22:26 +02:00
Pablo Machado fbbbcf8b9b
[Security Solution][Timeline] Fix User not able to scroll down and access Alert table on adding long content in Timeline's Description (#101486)
* Add LineClamp component to timeline description

* Truncate timeline description on timeline table

* Fix StyledLineClamp styled component performance issue

Read more: https://styled-components.com/docs/faqs#why-should-i-avoid-declaring-styled-components-in-the-render-method
2021-06-16 10:00:05 +02:00
Casper Hübertz b96914235e
[Observability] Add border to section container panels (#102259) 2021-06-16 09:43:58 +02:00
Casper Hübertz c9678f29e2
[UX] Update panels to use border not shadow (#102262) 2021-06-16 09:43:35 +02:00
Casper Hübertz f39bf9c985
[APM] More styles fixes related to the new page template (#102253)
* [APM] Service map: Add border to panel

* [APM] Metrics: Add border to panel

* [APM] Service overview: Add border to panel

* [APM] Transactions and charts: Add border to panel
2021-06-16 09:35:08 +02:00
István Zoltán Szabó f4d22b36fb
[ML] Adds popover help for ROC curve (#101893)
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2021-06-16 09:13:37 +02:00
Pete Hampton 4cd073f651
Bug: ES query returning no records for d-rule alerts. (#102160) 2021-06-16 08:11:32 +01:00
Tyler Smalley 752609dc47 skip flaky suite (#102282) 2021-06-15 21:34:01 -07:00
Matthew Kime 4cf6bca01e
Revert "[Index Patterns] Move rollup config to index pattern management (#102145)" (#102276)
This reverts commit f1b6fe04ed.
2021-06-15 20:35:19 -05:00
Ryland Herrick 4d921ffb7e
[Security Solution][CTI] Event enrichment search strategy (#101553)
* Adding boilerplate for new CTI search strategy type

This is going to be a subtype of the general SecSol search strategy;
the main functionality is going to be:

* transformation of the incoming parameters into named equivalents
* transformation of responses to include enrichment context fields
  (matched.*)

* More boilerplate, including tests

A few type errors because our functions don't actually do anything yet,
nor are our request/response types fleshed out.

* Starting to flesh out the request parsing

* Defines a basic request, along with a mock
* Defines helper function to generate should clauses from field values
* Adds placeholder tests throughout

* Fleshing out unit tests around our enrichment query

* Fleshing out response parsing of eventEnrichment strategy

* Fix types from elasticsearch

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 16:59:50 -05:00
Bhavya RM 3decc35668
updating the saved objects import file to include by value panels and drilldowns (#102114) 2021-06-15 17:16:55 -04:00
Nathan L Smith c151426ef9
Flyouts for APM alert annotations (#101632) 2021-06-15 13:53:42 -05:00
Shahzad 264339e156
[Lens] Export lens save modal (#100381)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 20:06:06 +02:00
Patryk Kopyciński 35cc59b571
[Osquery] Add support for platform and version fields (#101835) 2021-06-15 19:52:20 +02:00
Vadim Yakhin 7683d9ef17
[Workplace Search] Fix sidebar copy for Account Settings page (#102110)
* Rename PrivateSourcesLayout to PersonalDashboardLayout

The renaming was required because this layout is also used for Account Settings.

* Rename imports

* Rename files

* More personal_dashboard_layout from sources folder to layout folder

* Extract PrivateSourcesSidebar from PersonalDashboardLayout

This is needed to add the ability to pass AccountSettingsSidebar in the
next commit.

* Add and use AccountSettingsSidebar

* Move related styles to personal_dashboard_layout folder

* Move tests from personal_dashboard_layout to private_sources_sidebar

* Add tests for account_settings_sidebar

* Remove redundant import

* Move source-related sidebar text constants to top-level constants file

Now all personal dashboard sidebar copy is in one place
2021-06-15 13:50:43 -03:00
Marius Dragomir ff5ecc3420
[QA]Skip of metricbeat dashboard test (#97174)
* fix flakyness of metricbeat dashboard test

* skip test for now

* Update _metricbeat_dashboard.js

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 18:17:19 +02:00
Tyler Smalley 035f617b58 skip flaky suite (#102012) 2021-06-15 09:00:30 -07:00
Alison Goryachev 6173c04c20
[Snapshot + Restore] Migrate to new page layout structure (#101811) 2021-06-15 11:39:32 -04:00
Scotty Bollinger 42aa7f569a
[Enterprise Search] Refactor Role mappings to use single endpoint (#102096)
* Add tooltip back to table row

This was missed when refactoring the table to an EUI component. Built-in mappings have tooltips and don’t have IDs and need to show tooltips instead of actions.

* Fix roleType display

Also missed in the refactor. Made a mistake when copying/pasting

* Refactor logic files to use single endpoint for UI props

As a part of this feature, we are now passing all props needed for the UI in the list endpoint. Previously, whether creating a new mapping, or updating an existing mapping, an endpoint had to be called to fetch the data needed for display. Now all this data comes from the initial fetching of mappings and the other endpoints are no longer needed.

* Refactor WS test to match AS

There was an issue where 100% test coverage was not achieved in Workplace Search. This had already been fixed in App Search by refactoring. This changes the code and test in Workplace Search to match

* Remove server routes
2021-06-15 10:12:47 -05:00
Anton Dosov c409985090
Convert AppServices management pages to KibanaPageTemplate (#101779) 2021-06-15 16:33:41 +02:00
Byron Hulcher 8ca7b55c15
App Search: Domains Table for Crawler Overview (#101515)
* Add delete route for crawler domains

* Added deleteDomain action to CrawlerOverviewLogic

* New DomainsTable component

* Replace EuiCode with DomainsTable in CrawlerOverview

* Fixing mock imports

* Fix spleling

* Fix i18n tag

* Clean up DomainsTable

* Clean up DomainsTable tests

* Clean up CrawlerOverview tests

* Clean up i18n tag in CrawlerOverviewLogic

* Utilize Kibana i18n and React for timestamp display

* Use elastic.co domain in tests

* Remove unneeded type casting

* Adjusting isDateToday check

* Apply suggestions from code review

* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_overview_logic.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
2021-06-15 10:08:07 -04:00
Joey F. Poon 4b3adfda5f
[Security Solution] restyle endpoint details flyout (#102092) 2021-06-15 08:57:12 -05:00
Ignacio Rivas 2cecca3992
[Remote Clusters] Migrate to new page layout (#102042)
* change page templates

* Small copy tweaks

* Update docs

* small CR changes

* exit function call if fails

* update i18n strings

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 15:28:40 +02:00
Ignacio Rivas a7709b48b5
[Ingest Node Pipelines] Migrate to new page layout (#101894)
* migrate pages to new layout

* fix linter errors

* update translation files

* Nicer try-again cta

* Fix lang and prettier

* small CR changes

* small linter fixes

* fix test copy

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 15:27:48 +02:00
Larry Gregory 68d24080e0
Optimize privilege response validation (#102135) 2021-06-15 09:25:47 -04:00
David Sánchez 341f965452
Fixes empty page when removing last element. Fixes wrong event filters count number. Also adds unit tests (#102173) 2021-06-15 15:12:31 +02:00
James Gowdy ede8432ac7
[ML] Improvements to job saved object sync (#101899)
* [ML] Improvements to job saved object sync

* refactor

* adding testsadding testsadding testsadding testsadding testsadding testsadding testsadding tests

* updating test label

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 14:10:24 +01:00
SoNice! fb138cf165
[Fleet] Remove release messaging (#101450)
Co-authored-by: kobarei <koba.reiji@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 14:50:01 +02:00
Marco Liberati b40732507e
[Lens] Keep filters when transitioning from calculation to regular operation (#101872)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 14:47:25 +02:00
Nathan Reese 35714526c0
[Maps] Handle indices without geoip schema defined in mapping (#100487)
* ensure sourceGeoField and destGeoField for docs included in pew pew source

* tslint
2021-06-15 06:04:07 -06:00
Ashokaditya bcb941acea
[Security Solution][Endpoint] Actions log entries display relative time only up to 1 hr from now (#102162)
* show relative time only upto an hr from now

fixes elastic/security-team/issues/1313

* Update formatted_date_time.tsx

undo changes done in e38e202e81
2021-06-15 13:26:24 +02:00
Shahzad 7390d6a45c
[User Experience App] Update to make sure env filter is being used (#102063) 2021-06-15 12:41:56 +02:00
Alejandro Fernández Gómez 0d6ce5da27
[Uptime] Skip flaky test (#102163) 2021-06-15 06:38:52 -04:00
Matthew Kime f1b6fe04ed
[Index Patterns] Move rollup config to index pattern management (#102145)
* move rollup config to index pattern management
2021-06-15 05:12:43 -05:00
Joe Reuter 2ef66c139a
[Lens] Add reset and hide actions to columns on dashboard (#102025) 2021-06-15 11:48:08 +02:00
Thomas Neirynck 6456c49e2c
[Maps] Remove jitter from bounds-coordinates (#100717) 2021-06-15 11:13:27 +02:00
Casper Hübertz d9905893b9
[Observability] Change sortkey navigation in APM and Uptime (#102134)
* [APM] Change navigation registry sortkey

* [Uptime] Change navigation registry sortkey
2021-06-15 10:40:10 +02:00
Marco Liberati 37728f526d
[Lens] Table headers are aligned the same as cells (#101875)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 10:34:57 +02:00
Marco Liberati 65fec6bd8e
[Lens]Show dynamic coloring only for metrics (#101777)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 10:34:04 +02:00
Casper Hübertz 92b6535df2
[Observability] Fixes border shadow and other enhancements (#102072)
* [Observability] Fixes border shadow and other enhancements

* Update x-pack/plugins/observability/public/components/app/section/index.tsx

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>

* [Observability] Remove unused import and formatting

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 10:12:45 +02:00
Joe Reuter e418a895c3
reduce inner timeout (#102081) 2021-06-15 09:44:43 +02:00
Joe Reuter a8836af1c4
[Lens] do not allow custom bounds on percentage chart (#101743) 2021-06-15 09:33:29 +02:00
Joe Reuter 0bb3b2c666
rename beta badge (#101884) 2021-06-15 09:28:51 +02:00
Jean-Louis Leysens f70542abe2
[Fleet] Adjust add integration flow (#101714)
* Initial commit, very WIP

- added link to the integrations UI instead of add integration
  in fleet
- added a new piece of route state that gets passed to integration
  from fleet when browsing integrations for a policy
- when the integration is being added the page will send the user
  back to the policy overview instead of back to integrations UI

* remove unnecessary agent policy clear function

* added # to path so that navigation is correctly handled

* added logic to read the forward agent policy id

* remove inline select integration package from fleet add integration

* updated toast notification

* using query parameter to pass policy id back to create policy package page

* removed policyId from route path

* fix type issue

* updated the select agent field layout per the designs

* simpified item rendering in combobox and fixed combobox z-index issue

* added comment

* fix types and i18n

* updated icon and removed unused i18n

* refactor to using styled components for cusomt z-index styling

* attempt to fix integration test

* added scroll functionality for dealing with fixed footers that might be obstructing content

* fix scroll direction!

* attempting another scroll algorithm

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-15 09:26:37 +02:00
CJ Cenizal 55a0dbbc09
Discourage use of legacy index templates (#101533)
* Hide legacy index templates table if the user doesn't have any.
* Render deprecation warning above legacy index templates table and in legacy index template wizard.
* Update index template doc link to point to the new docs.
2021-06-14 15:24:24 -07:00
Aaron Caldwell 6e0aed79c3
[Maps] Fix geo alerts handling of multi-fields (#100348) 2021-06-14 17:51:33 -04:00
Apoorva Joshi 35f9625265
[ML] Adds Authentication module with six ML jobs for ECS data (Auditbeat, Winlogbeat, Filebeat and Logs) (#101840)
* Adding Security Authentication jobs in 7.14

* Renamed some jobs

* Changing memory limits and linting change

* Linting fix

* Changed the order

* Adding module to ml_modules.tsx

* Update recognize_module.ts

this test modules uses older Auditbeat data which predates the event.category field so the test has to be skipped per https://elastic.zoom.us/j/93000943632?pwd=TmpvNWhtYUNzMUc0c0N6Tlc2QlVPZz09

* Update recognize_module.ts

needs to be a single line

* Update recognize_module.ts

Some linters want spaces and some linters want no spaces. This linter wants spaces.

* descriptions

added description text

* Update auth_rare_hour_for_a_user.json

removed a wayward newline char

* Minor nitpicking

* memory limits

raised memory limits to 128mb which is larger than the highest observed peak model bytes for the most memory hungry jobs in this event class.

Co-authored-by: Craig <mailredirector36@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-14 12:36:08 -07:00
Domenico Andreoli 8bdc0d7b25
Fix esArchiver path in the Jenkins context (#102095) 2021-06-14 21:31:57 +02:00
Kerry Gallagher 8f5dad98a1
[Logs / Metrics UI] Convert logs and metrics pages to the new Observability page template (#101239)
* Convert Logs and Metrics pages to use the Observability page template
2021-06-14 19:28:08 +01:00
Ece Özalp 4fb0c943a6
[Security Solution] Refactor rules for modularization by updating bulkCreate and wrapHits methods (#101544)
creates bulkCreate and wrapHits factories for the modularization of the detection engine

Co-authored-by: Marshall Main <marshall.main@elastic.co>
2021-06-14 13:31:20 -04:00
Casper Hübertz 767b67d052
[APM] Change View full trace button fill (#102066) 2021-06-14 18:49:58 +02:00
Dario Gieselaar 666bce3923
[APM] Enforce span creation/naming for ES searches (#101856) 2021-06-14 12:44:29 -04:00
Casper Hübertz 571524005e
[APM] Change impact indicator size (#102060) 2021-06-14 18:34:52 +02:00
Nicolas Chaulet 91b804f505
[Fleet] Display NOTICE.txt from package if it exists (#101663) 2021-06-14 12:33:46 -04:00
Larry Gregory adda72edd2
Document platform security plugins in kibana.json (#101965)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-14 12:23:28 -04:00
Søren Louv-Jansen 970e9a037b
[APM] Add AWS and Azure icons for additional services (#101901) 2021-06-14 17:14:15 +02:00
Josh Dover 0e7d4fed93
Fix delayed status API updates in alerting and task_manager (#101778) 2021-06-14 11:14:02 -04:00
Alison Goryachev 8424a92533
[ILM] Migrate to new page layout (#101927) 2021-06-14 10:50:20 -04:00
renovate[bot] b430a985c2
Update dependency @elastic/charts to v30.1.0 (master) (#101683) 2021-06-14 07:43:24 -07:00
Shahzad e0a1a34fbc
[Uptime] Align synthetics report types (#101855) 2021-06-14 15:57:03 +02:00
Ashokaditya 71a81f7cd6
[Security Solution][Endpoint] Actions Log API (#101032)
* WIP

add tabs for endpoint details

* fetch activity log for endpoint

this is work in progress with dummy data

* refactor to hold host details and activity log within endpointDetails

* api for fetching actions log

* add a selector for getting selected agent id

* use the new api to show actions log

* review changes

* move util function to common/utils

in order to use it in endpoint_hosts as well as in trusted _apps

review suggestion

* use util function to get API path

review suggestion

* sync url params with details active tab

review suggestion

* fix types due to merge commit

refs 3722552f73

* use AsyncResourseState type

review suggestions

* sort entries chronologically with recent at the top

* adjust icon sizes within entries to match mocks

* remove endpoint list paging stuff (not for now)

* fix import after sync with master

* make the search bar work (sort of)

this needs to be fleshed out in a later PR

* add tests to middleware for now

* use snake case for naming routes

review changes

* rename and use own relative time function

review change

* use euiTheme tokens

review change

* add a comment

review changes

* log errors to kibana log and unwind stack

review changes

* search on two indices

* fix types

* use modified data

* distinguish between responses and actions and respective states in UI

* use indices explicitly and tune the query

* fix types after sync with master

* fix lint

* do better types

review suggestion

* add paging to API call

* add paging info to redux store for activityLog

* decouple paging action from other API requests

* use a button for now to fetch more data

* add index to fleet indices

else we get a type check error about the constant not being exported correctly
from `x-pack/plugins/fleet/common/constants/agent`

* add tests for audit log API

* do semantic paging from first request

* fix ts error

review changes

* add document id and total to API

review suggestions

* update test

* update frontend to consume the modified api correctly

* update mock

* rename action

review changes

* wrap mock into function to create anew on each test

review changes

* wrap with schema.maybe and increase page size

review changes

* ignore 404

review changes

* use i18n

review changes

* abstract logEntry component logic

review changes

* move handler logic to a service

review changes

* update response object

review changes

* fix paging to use 50 as initial fetch size

* fix translations and move custom hook to component file

review changes

* add return type

review changes

* update default value for page_size

review changes

* remove default values

review changes

https://github.com/elastic/kibana/tree/master/packages/kbn-config-schema#schemamaybe

https://github.com/elastic/kibana/tree/master/packages/kbn-config-schema#default-values

* fix mock data

refs 1f9ae70194

* add selectors for data

review changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-14 15:39:11 +02:00
Dario Gieselaar 0993a1c321
[APM] Display automatic deployment annotations correctly (#102020) 2021-06-14 15:26:13 +02:00
Robert Oskamp 150198404a
[ML] Functional tests - stabilize alerting flyout test (#102030)
This PR stabilizes and re-activates the ML alerting flyout test suite.
2021-06-14 14:55:26 +02:00
Gidi Meir Morris daa3f62cda
[Task Manager] adds capacity estimation to the TM health endpoint (#100475)
Adds Capacity Estimation to the Task Manager Health Endpoint.
Below is a diagram depicting what information we use to estimate the varying capacity variables.

Please use the user facing docs to understand how it fits together. If the docs aren't clear enough - make a review comment and I'll clarify in the docs.
2021-06-14 13:52:30 +01:00
Vadim Dalecky fa855b35b6
Management app locator (#101795)
* feat: 🎸 create management app locator

* refactor: 💡 simplify management locator

* feat: 🎸 export management app locator from plugin contract

* feat: 🎸 improve share plugin exports

* test: 💍 fix test mock

* test: 💍 adjust test mocks

* Update src/plugins/management/public/plugin.ts

Co-authored-by: Tim Roes <mail@timroes.de>

* Update src/plugins/management/public/types.ts

Co-authored-by: Tim Roes <mail@timroes.de>

* Update src/plugins/management/public/types.ts

Co-authored-by: Tim Roes <mail@timroes.de>

* Update src/plugins/management/server/plugin.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Tim Roes <mail@timroes.de>
2021-06-14 14:23:14 +02:00
Tiago Costa b60a438dd3
skip flaky suite (#100438) 2021-06-14 12:51:58 +01:00
James Gowdy f6ce964d9c
[ML] Switching to new datafeed preview (#101780)
* [ML] Switching to new datafeed preview

* fixing wizard test button

* adding schema validator

* fixing tests

* adding check for empty detectors list

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-14 12:31:55 +01:00
Justin Kambic 85710b344f
[Uptime] Add owner and description properties to Uptime's kibana.json (#101963)
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-14 13:29:46 +02:00
David Sánchez ec2ec6ab40
[Security solution][Endpoint] Removes zip compression when creating artifacts (#101379)
* Removes zlib compression when creating artifacts. Also fixes related unit tests and removes old code

* Replaces artifact in new manifest using the ones from fleet client with zlip compression

* Fixes create_policy_artifact_manifest pushArtifacts missing new manifest. Also fixes unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-14 12:25:42 +02:00
Tyler Smalley 344b6310d7 skip flaky suite (#102012) 2021-06-12 06:49:27 -07:00
Shahzad 724ca2d896
[Exploratory View] Use human readable formats (#101520)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-11 12:09:24 +02:00
Michael Dokolin 9bcae4d9cb
[Expressions] Refactor expression functions to use observables underneath (#100409) 2021-06-11 09:53:04 +02:00
Scotty Bollinger f28777f3ba
[Enterprise Search] Add owner and description properties to kibana.json (#101957)
* [Enterprise Search] Add owner and description properties to kibana.json

Adds owner and description properties to kibana.json

* Reorder to match other plugins

Both others have the props at the end of the file:

https://github.com/elastic/kibana/blob/master/src/plugins/bfetch/kibana.json

Also removes redundant prefix from description

* Copy change

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
2021-06-10 20:04:37 -04:00
Steph Milovic de07e98663
[Observability] [Cases] Cases in the observability app (#101487) 2021-06-10 16:39:27 -06:00
ymao1 b242765654
[Alerting][Docs] Combine rule creation and management pages (#101498)
* Combining rule management stuff into single page

* Cleaning up image widths and header sizes

* Adding in placeholder pages

* Adding in placeholder pages

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* PR and test fixes

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* PR fixes

* PR fixes

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-10 17:46:53 -04:00
Nicolas Chaulet 6df58dd7ca
[Fleet] Fix fleet server collector in case settings are not set (#101752) 2021-06-10 16:32:23 -04:00
Yuliia Naumenko e55a93ce58
[Event Log] Populated rule.* ECS fields for alert events. (#101132)
* [Event Log] Populated rule.* ECS fields for alert events.

* added mappings

* changed the params passing

* fixed tests

* fixed type checks

* used kibanaVersion for version event rule

* fixed typos

* fixed tests

* fixed tests

* fixed tests

* fixed tests

* fixed jest tests

* removed references

* removed not populated fields

* fixed tests

* fixed tests

* fixed tests
2021-06-10 12:33:32 -07:00
Oliver Gupte befd30ff6c
[APM] Fleet support for merging input.config values with other nested properties in the policy input (#101690)
* [APM] Improvments in the APM fleet integration (#95501)

* added unit test and line comment

* fixes eslint issues
2021-06-10 15:27:11 -04:00
Stacey Gammon e9a4028005
Add comments to some alerting plugin public API items (#101551)
* Add comments. Remove ruleType as the second param, not needed.

* Add comments. Remove ruleType as the second param, not needed.

* Fix bad type check and update docs

* update docs

* Remove unused import

* change exports to type to avoid increasing bundle size

* Update x-pack/plugins/alerting/public/plugin.ts

Co-authored-by: ymao1 <ying.mao@elastic.co>

* Update x-pack/plugins/alerting/public/plugin.ts

Co-authored-by: ymao1 <ying.mao@elastic.co>

* Update x-pack/plugins/alerting/public/plugin.ts

Co-authored-by: ymao1 <ying.mao@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: ymao1 <ying.mao@elastic.co>
2021-06-10 15:15:53 -04:00
ymao1 5a1f370580
[Alerting][Docs] Moving alerting setup to its own page (#101323)
* Restructuring main alerting page. Adding separate setup page

* Fixing links

* Moving suppressing duplicate notifications section

* Adding redirect

* Reverting redirect. Adding placeholder link

* Adding placeholder text

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Setup page PR fixes

* Alerting page PR fixes

* Update docs/user/alerting/alerting-setup.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2021-06-10 15:14:07 -04:00
Stacey Gammon 9417b699b8
remove uptime public API, it's not used. (#101799) 2021-06-10 14:47:55 -04:00
Scotty Bollinger 797c0c90b0
[Enterprise Search] Refactor RoleMappingsTable to use EuiInMemoryTable (#101918)
* Add shared actions component

Both tables use the same actions

* Refactor RoleMappingsTable to use EuiInMemoryTable

This is way better than the bespoke one I wrote and it comes with pagination for free

- Also fixes a typo in the i18n id
2021-06-10 14:20:54 -04:00
Caroline Horn 61677f7a77
Fix AppContainer layout (#101793)
* Fixing app_container
* Use EUI mixin  `euiHeaderAffordForFixed()` to maintain parity
* Adding `aria-busy` when `showSpinner`
* i18n for the loading aria-label
2021-06-10 14:18:35 -04:00
Shahzad ddccace87e
[Uptime] Unskip alert functional test (#101562) 2021-06-10 20:01:21 +02:00
Scotty Bollinger d7d67df5eb
[Enterprise Search] Create reusable Group and Engine assignment selectors (#101790)
* Create AssignmentSelectors

These components will be used in both the Role Mapping and User flyouts to create and edit role mappings and users, respectively

* Implement AssignmentSelectors in components
2021-06-10 14:36:11 -03:00
Vadim Yakhin a9a834a105
[Workplace Search] Add Account Settings page imported from Security plugin (#99791)
* Copy lazy_wrapper and suspense_error_boundary from Spaces plugin

These components are needed to enable async loading of Security components into Enterprise Search.

The components are copied without any changes except for i18n ids, so it's easier to DRY out in the future if needed.

* Create async versions of personal_info and change_password components

* Create ui_api that allows to load Security components asuncronously

The patterns were mostly copied from Spaces plugin

* Make ui_api available through Security components's lifecycle methods

* Import Security plugin into Enterprise Search

* Add Security plugin and Notifications service to Kibana Logic file

* Export the required components from the Security plugin and
use them in the new AccountSettings component

* Update link to the Account Settings page

* Move getUiApi call to security start and pass core instead of getStartServices

* Simplify import of change_password_async component by providing...
... `notifications` and `userAPIClient` props in the security plugin

* Remove UserAPIClient from ui_api

It's not needed anymore since the components are initiated with this prop already passed

* Export ChangePasswordProps and PersonalInfoProps from account_management/index.ts

This makes it easier to import these props from outside the account_management folder

* Remove notifications service from kibana_logic

It is not needed anymore since we're initializing security components with notifications already provided

* Add UiApi to SecurityPluginStart interface

* Utilize index files for exporting Props types

* Replace Pick<...> with two separate interfaces as it doesn't work well with our docs

* Add a comment explaining why we're not loading async components through index file
2021-06-10 14:20:30 -03:00
Jean-Louis Leysens 92bd5c6424
[Fleet] Adjustments to the "Add agent" flyout (#101576)
* updated add agent flyout buttons

* move close button to left

* added new optional prop for the add agent flyout and factored out a component from the index.tsx file

* quite a big refactor, moved the agent policy authentication to own component and reused in two places

* fixed layout on view where policy was not selected, also fixed a render cycle

* removed unnecessary filter

* move handler to function body instead of in JSX

* remove unused i18n

* added jest test for agent enrollment flyout steps behaviour

* fix issues after master merge

* Fix bad import in type file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-10 18:17:41 +02:00
Alison Goryachev 7dfb086343
[Upgrade Assistant] Migrate to new page layout (#101691) 2021-06-10 11:50:08 -04:00
István Zoltán Szabó 85fa7c8791
[ML] Adds popover help for multiclass confusion matrix (#101732)
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2021-06-10 17:37:57 +02:00
Melissa Alvarez 305f12708d
[ML] Anomaly Detection: Visualize delayed - data Part 1 (#101236)
* wip: add datafeed modal for chart

* Add arrows to navigate through time in the chart

* ensure runtime_mapping and indices_options in search query

* move chart data fetching behind single server endpoint

* remove success check as it is not returned in result

* load necessary modal data in modal

* remove extra legend and add text to action icons

* remove unused endpoint and types

* handle job not found and fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-10 11:03:17 -04:00
Dima Arnautov ef8eb321cf
[ML] Add usage collection for pages in the ML app (#101886)
* [ML] setup usageCollection provider

* [ML] track page usage
2021-06-10 10:36:14 -04:00
Joe Reuter fe3c761b40
stabilize opening of Lens from listing page (#101569) 2021-06-10 16:30:37 +02:00
Wylie Conlon b35cde568b
[Lens] Formula editor (#99297)
* 💄 Hack to fix suggestion box

* 🐛 Fix validation messages

* 🐛 Relax operations check for managedReferences

* Change completion params

* 🏷️ Fix missing arg issue

*  Add more tinymath fns

* 🐛 Improved validation around math operations + multiple named arguments

* 🐛 Use new onError feature in math expression

* ♻️ Refactor namedArguments validation

* 🐛 Fix circular dependency issue in tests + minor fixes

* Move formula into a tab

* 🔥 Leftovers from previous merge

*  Move over namedArgs from previous function

*  Add tests for transferable scenarios

*  Fixed broken test

*  Use custom label for axis

* Allow switching back and forth to formula tab

* Add a section for the function reference

* Add modal editor and markdown docs

* Change the way math nodes are validated

* Use custom portal to fix monaco positioning

* Fix model sharing issues

* Provide signature help

* 🐛 Fix small test issue

* 🐛 Mark pow arguments as required

* 🐛 validate on first render only if a formula is present

* 🔥 Remove log10 fn for now

*  Improved math validation + add tests for math functions

* Fix mount/unmount issues with Monaco

* [Lens] Fully unmount React when flyout closes

* Fix bug with editor frame unmounting

* Fix type

* Add tests for monaco providers, add hover provider

* Add test for last_value

* Usability improvements

* Add KQL and Lucene named parameters

* Add kql, lucene completion and validation

* Fix autocomplete on weird characters and properly connect KQL

* Highlight functions that have additional requirements after validating

* Fix type error and move help text to popover

* Fix escape characters inside KQL

* 🐛 Fix dataType issue when moving over to Formula

* Automatically insert single quotes on every named param

* Only insert single quotes when typing kql= or lucene=

* Reorganize help popover

* Fix merge issues

* Update grammar for formulas

* Fix bad merge

* Rough fullscreen mode

* Type updates

* Pass through fullscreen state

* Remove more chrome from full screen mode

* Fix minor bugs in formula typing

* 🐛 Decouple column order of references and output

* 🔧 Fix tests and types

*  Add first functional test

* Fix copying formulas and empty formula

* Trigger suggestion prompt when hitting enter on function or typing kql=

* 🐛 Prevent flyout from closing while interacting with monaco

* refactoring

* move main column generation into parse module

* fix tests

* refactor small formula styles and markup

* documentation

* adjustments in formula footer

* Formula refactoring (#12)

* refactoring

* move main column generation into parse module

* fix tests

* more style and markup tweak for custom formula

* Fix tests

* [Expressions] Use table column ID instead of name when set

* [Lens] Create managedReference type for formulas

* Fix test failures

* Fix i18n types

* fix fullscreen flex issues

* Delete managedReference when replacing

* refactor css and markup; add button placeholders

* [Lens] Formulas

* Tests for formula

Co-authored-by: Marco Liberati <marco.liberati@elastic.co>

* added error count placeholder

* Add tooltips

* Refactoring from code review

* Fix some editor issues

* Update ID matching to match by name sometimes

* Improve performance of Monaco, fix formulas with 0, update labels

* Improve performance of full screen toggle

* Fix formula tests

* fix stuff

* Add an extra case to prevent insertion of duplicate column

* Simplify logic and add test for output ID

* add telemetry for Lens formula (#15)

* Respond to review comments

*  Improve the signatures with better documentation and examples

* adjust border styles to account for docs collapse

* refactor docs markup; restructure docs obj; styles

* Fix formula auto reordering (#18)

* fix formula auto reordering

* add unit test

* Fix and improve suggestion experience in Formula (#19)

*  Revisit documentation and suggestions

* 👌 Integrated feedback

*  Add query validation for quotes

* Usability updates & type fixes

* add search to formula

* fix form styles to match designs

* fix text styles; revert to Markdown for control

* 👌 Integrated more feedback

* improve search

* improve suggestions

* improve suggestions even more

* 🐛 Fix i18n issues (#22)

* Persist formula on leave, fix fullscreen and popovers

* Fix documentation tests

* 🏷️ fix type issue

* 🐛 Remove hidden operations from valid functions list

* 🐛 Fix empty string query edge case

* 🐛 Enable more suggestions + extends validation

* Fix tests that depended on setState being called without function

* Error state and text wrapping updates

*  Add new module to CodeEditor for brackets matching (#25)

* Fix type

* show warning

* keep current quick function

*  Improve suggestions within kql query

* 📷 Fix snapshot editor test

* 🐛 Improved suggestion for single quote and refactored debounce

* Fix lodash usage

* Fix tests

* Revert "keep current quick function"

This reverts commit ed477054c5.

* Improve performance of dispatch by using timeout

* Improve memoization of datapanel

* Fix escape characters

* fix reduced suggestions

* fix responsiveness

* fix unit test

* Fix autocomplete on nested math

* Show errors and warnings on first render

* fix transposing column crash

* Update comment

* 🐛 Fix field error message

* fix test types

* 📝 Fix i18n name

* 💄 Manage wordwrap via react component

* Fix selector for palettes that interferes with quick functions

* Use word wrapping by default

* Errors for managed references are handled at the top level

* 🐛 Move the cursor just next to new inserted text

* ⚗️ First pass for performance

* 🐛 Fix unwanted change

*  Memoize as many combobox props as possible

*  More memoization

* Show errors in hover

* Use temporary invalid state when moving away from formula

* Remove setActiveDimension and shouldClose, fixed by async setters

* Fix test dependency

* do not show quick functions tab

* increase documentation popover width

* fix functional test

* Call setActiveDimension when updating visualization

* Simplify handling of flyout with incomplete columns

* Fix test issues

* add description to formula telemetry

* fix schema

* Update from design feedback

* More review comments

* Hide callout border from v7 theme

Co-authored-by: dej611 <dej611@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
Co-authored-by: Joe Reuter <email@johannes-reuter.de>
Co-authored-by: Marco Liberati <marco.liberati@elastic.co>
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
2021-06-10 10:09:16 -04:00
Marco Liberati 49ea272240
[Lens] Memoize operationMatrix computation (#101745) 2021-06-10 14:53:25 +02:00
Marco Liberati baef85575d
[Lens] Do not use dynamic coloring for array values (#101750) 2021-06-10 14:52:24 +02:00
David Sánchez e0f817c854
Cleans comment state when submiting and when init the store (#101861) 2021-06-10 14:45:38 +02:00
Stacey Gammon b2903e9f8f
Small clean up with Cases plugin API (#101668)
* Clean up public API of cases plugin

1. Don't use export * on index.ts files that define the public API
2. Add comments to the interface show they show up in the API docs
3. Export types that are part of the public API so they show up in the API docs.
4. Fill in information for the up and coming `description` and `owner` items in kibana.json.

* Update returns comments to be more descriptive

* update api docs

* Remove kibana.json attributes, until PR supporting them is merged.

* Change all exports to export type to avoid increase page bundle size
2021-06-10 08:43:07 -04:00
Stacey Gammon 65d3f49f00
address code review comments (#101764) 2021-06-10 08:36:43 -04:00
Paul Tavares 095f4d0e3b
[Security Solution][Endpoint] Adjust the Pending Actions API types (#101814)
* Adjust Action Status API types
* add lib/service to fetch host pending actions
2021-06-10 08:08:36 -04:00
Christos Nasikas 144e014dbf
[Cases] Improve connectors mapping (#101145) 2021-06-10 11:45:25 +03:00
Pete Harverson 0f5620e5c4
[ML] Fixes display of job group badges in recognizer wizard (#101775) 2021-06-10 09:17:22 +01:00
Domenico Andreoli 7b51debbbb
Fix es_archives path (#101737) 2021-06-10 09:39:07 +02:00
Spencer 7917e3c9d9
[kbnArchiver] convert archive names to root-relative paths (#101839)
* [kbnArchiver] convert archive names to root-relative paths

* ensure that newly multiline hooks are explicitly async

* missed a newly multiline hook

* fix exists check

* avoid extra lines by wrapping arrow body in {}

* one block more

* fix errant `name` variable

Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-06-09 20:13:00 -04:00
Tim Sullivan 3559d375b6
[Reporting] Make "ScreenCapturePanel" shareable for Canvas (#100623)
* use ScreenCapturePanel component in Canvas

* use smaller state object

* add comment about canvas-specific shared component

* fix example

* fix toast error

* fix i18n

* fix data-test-subj

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-09 17:08:33 -07:00
Yuliia Naumenko 274bbdc628
[Alerting UI] Converted Rules and Connectors management pages to new layout. (#101697)
* [Alerting UI] Converted Rules and Connectors management pages to new layout.

* fixed tests

* fixed tests

* fixed tests

* fixed tests
2021-06-09 16:56:30 -07:00
Jen Huang 5a5cdb90a7
[Fleet] Support granular integrations in policy editor (#101531)
* Adjust packageToPackagePolicy to support multiple policy_templates

* Adjust validatePackagePolicy to support multiple policy templates

* Create input for every policy template input instead of grouping

* Related adjustments for previous commit

* Don't key by policy template when package doesn't have integrations

* Adjust limited package check to support multiple policy templates

* First pass at UI support

* Fix imports, add missing schema

* Fix finding input agent templates, adjust tests

* Only enable specific integrations by default in the UI

* Fix import

* Make breadcrumbs and create package policy page title reflect integration, not package

* Only show specific integration inputs when adding integration to a policy

* Change predicate

* Simplify condition
2021-06-09 18:21:23 -04:00
Frank Hassanabad 1cb17d025b
[Security Solution][Detections] Update detection alert mappings to ECS v1.10.0 (#101680)
## Summary

* Grabbed the ECS mappings from [v1.10.0 tag]( https://github.com/elastic/ecs/blob/v1.10.0/generated/elasticsearch/7/template.json)
* Updated the fields that had `constant_keyword` to `keyword` since we do many to 1 of source to signals index
* Wrote a unit tests which tests to ensure we don't have any `constant_keyword` fields
* Updated the `SIGNALS_TEMPLATE_VERSION` version by an increment of 10.

This should mostly fix:
https://github.com/elastic/kibana/issues/101572

Since agents add their data into `_source` even though they have a `constant_keyword`. When agents do not include the values in `_source` we will have to merge `fields` into `_source` before copying which are still planning on doing before release.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-06-09 18:06:10 -04:00
Kyle Pollich 9a412d3da0
[Fleet] Integrations UI: Adjust policies list UI (#101600)
* Add "Add Agent" button to package policy list

- Add button to open enrollment flyout from package policy list screen
- Move necessary components up into `public` in order to open enrollment
  flyout from within Integrations application

* Create initial package policy table actions

* Fix context menu link + add a few tests

* Fix import in list_layout

* Unify package policy actions menu in shared component

* Update x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.test.tsx

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-09 17:07:29 -04:00
Joey F. Poon 8cf6112999
[Security Solution] fix security empty overview links (#101536) 2021-06-09 15:06:44 -05:00
Frank Hassanabad 8c03ccf1f0
Unskips migration tests now that elastic search is fixed (#101682)
## Summary

Unskips signal migration tests now that elastic search is fixed get alias bug

ES ticket about get alias bug:
https://github.com/elastic/elasticsearch/pull/72953

Tickets related that should be fixed now:
https://github.com/elastic/kibana/issues/99915
https://github.com/elastic/kibana/issues/100305

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-06-09 14:02:47 -06:00
Kyle Pollich 845e701487
Fix endpoint -> integrations onboarding link (#101804)
Fixes #101759
2021-06-09 15:58:15 -04:00
ymao1 2fd3c37fdd
[Alerting] Log warning when rules are not rescheduled due to Saved Object not found error (#101591)
* Adding warning to logs when alerting task runner encounters saved object not found and doesn't reschedule rule

* Adding space id to warning message

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-09 15:55:01 -04:00
Craig Chamberlain eb3842b283
Update datafeed_high_count_network_denies.json (#101681)
add a boolean OR between the two possible field values
2021-06-09 15:50:10 -04:00
Paul Tavares 4e0c889b30
[Security Solution][Endpoint] Adds Endpoint Host Isolation Status common component (#101782)
* Common component for displaying Endpoint Host Isolation status
2021-06-09 14:27:47 -04:00
Poff Poffenberger d9c8fef2f8
[Canvas] Update slow query in sample ecommerce workpad (#100714)
* Update slow query in sample ecommerce workpad

* Remove demodata use from sample ecomm workpad

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-09 12:29:34 -05:00
Dmitry Shevchenko ac2e247c5b
Add sh scripts with _bulk_action route usage examples (#101736) 2021-06-09 17:47:52 +02:00
Shahzad 96c684c4ec
[Uptime] Only register route in side nav if uptime show capability is true (#101709) 2021-06-09 17:37:26 +02:00
ymao1 a12ff5d65d
[Alerting][Event log] Persisting duration information for active alerts in event log (#101387)
* WIP

* Storing start, duration and end in alert state

* Writing to event log

* Updating unit tests

* Adding unit tests

* Fixing uuid in tests

* Updating functional test

* Adding functional test

* Removing console logs

* Fixing unit tests

* PR fixes

* Removing uuid from alert information

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-09 11:09:05 -04:00
Tim Roes ee0efabbfc
Address design issues in Discover/Graph (#101584)
* Remove Discover panel shadow

* Fix graph issues
2021-06-09 17:03:28 +02:00
Nathan Reese d415357f73
Change file data visualizer links to point to new location in home application (#101393)
* Link to home file data visualizer

* remove unused import

* i18n cleanup

* remove unused import from EmptyState

* use const

* remove ml functional test cases checking for ml_file_data_visualizer

* more clean-up of ml_file_data_visualizer

* jest snapshot and nav to home page in no_ml_access tests

* revert change to functional test dual_privileges_all at everything_space

* revert another change to security_and_spaces/tests/catalogue.ts

* revert changes to x-pack/test/ui_capabilities/security_only/tests/catalogue.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-09 08:30:40 -06:00
Alejandro Fernández Gómez cd8cf46ad1
[Fleet] Tighten policy permissions, take II (#97366)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-09 16:11:15 +02:00
Dima Arnautov 97b952b0e1
[ML] Add debounce to the severity control update (#101581) 2021-06-09 16:08:08 +02:00
Kyle Pollich 58eb0d40e9
[Fleet] Fix routing issues with getPath and history.push (#101658)
* Fix getPath usage in Fleet app

* Fix pathname in failing test
2021-06-09 10:07:29 -04:00
Dario Gieselaar 520d1e8c04
[APM] Add link-to/transaction route (#101731) 2021-06-09 15:42:05 +02:00
Yulia Čech fb88c99524
[ILM] Refactor types and fix missing aria labels (#101518)
* Refactor phase types (mostly moving imports)

* Refactor phase types (mostly moving imports)

* Renamed a type for consistency and replaced more hard coded strings with types

* Fixed remaining references to the deleted MinAgePhase
2021-06-09 14:42:56 +02:00
Marco Liberati e3c3b6f334
[Lens] New summary row feature for datatable (#101075)
*  New summary row feature for datatable

*  Allow empty strings behind flag + tests

* 🐛 Address the transition problem + refactor

*  Add some unit tests

*  Add first functional tests

* 👌 first feedback addressed

*  Make it handle numeric array values

* 📝 Improved message

*  Fix functional test

* 🔥 Remove warning message for last value

* 🚨 Remove unused import

* 🐛 Fix a bug with last value

* 👌 Integrated feedback

* 💄 Migrated to combobox

*  Fix unit tests + restore right data-test-id

* 🏷️ Fix type issue

* 👌 Address all issues reported

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-09 14:27:49 +02:00
David Sánchez d90285f718
Blocks save event filter with a white space name (#101599) 2021-06-09 14:20:43 +02:00
Stacey Gammon 7604fd7c80
Improve security server types (#101661)
* Remove RecursiveReadonly wrapper on public API items

* Remove Pick and export some types that are part of the public API

* Udpate api docs

* Export API items that are part of the public API

* Add extra comments

* update api docs
2021-06-09 14:01:48 +02:00
Søren Louv-Jansen 8b555c7f12
[APM] Replace side nav with tabs on Settings page (#101460)
Co-authored-by: Casper Hübertz <casper@formgeist.com>
2021-06-09 07:57:42 -04:00
Søren Louv-Jansen d3ce128556
[APM] Only register items in side nav if user has permissions to see app (#101707) 2021-06-09 06:27:53 -04:00
David Sánchez e94a34df30
[Security solution][Endpoint] Add back button when to the event filters list (#101280)
* Add back button when to the event filters list. Isolated back to external app button to be used as generic component

* Adds unit tests for back button

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-09 12:11:56 +02:00
Dmitry Shevchenko 16e66b82b0
Implement "select all" rules feature (#100554) 2021-06-09 11:32:45 +02:00
Dima Arnautov 52d62ceec5
[ML] Remove script fields from the Anomaly detection alerting rule executor (#101607)
* [ML] remove script fields

* [ML] fix initial score
2021-06-09 11:00:05 +02:00
David Sánchez abaac4c6c7
[Security solutions][Endpoint] Update event filtering texts (#101563)
* Changes multilang for add endpoint event filter action on events tab

* Changes more multilangs and display name error only when needed

* Changes variable names and aria labels to be consistent with namings

* Fixes unit test due multilang changes
2021-06-09 10:13:55 +02:00
Constance 12986fb8fc
[Enterprise Search] Mocks/tests tech debt - avoid hungry mocking (#101107)
* Move enzyme & misc test helpers out of __mocks__/ and into new test_helpers/

They're not technically mocks since nothing is being mocked, so we should move them into a test_helpers folder for specificity & organization

* Move React Router mocks into its own separate folder/import

This was part of the initial feedback, that it was unclear why importing something for Kea in __mocks__/index.ts was mocking react router along for the ride. Separating this out makes things clearer and imports more explicit

+ add some handy new mock useX jest.fn()s helpers, so we're not doing `useParams() as jest.Mock` errywhere

* Move Kea & logic mocks/helpers into kea_logic subfolder
- for organization

NOTE: It can't be a plain kea/ folder because then Jest automatically mocks the `kea` module itself kea 🤦

* Fix type failures

- Caused by switch from any to unknown (changed back to any + added a .test_helper suffix exclusion for any)

* Fix Enterprise Search tests/imports

- I checked all application folders but this one, whoops

* PR feedback: comment copy

* Update tests/files added since PR open with new import locations

* Fix misc react router typing

- null not being type-able as a boolean
- forgot to remove various useParam imports after adding mockUseParams
+ misc unused kea import, probably added while debugging kea mocks
2021-06-08 21:36:06 -07:00
Tyler Smalley c225aaaaa5 [FTR] Updates esArchive paths
PR's merged after #101345

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-06-08 21:10:36 -07:00
Tyler Smalley aa8f7f3af2 [FTR] Updates esArchive paths
PR's merged after #101345

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-06-08 21:06:50 -07:00
Frank Hassanabad 4021576436
[Security Solution][Detection Engine] Adds runtime field tests (#101664)
## Summary

Adds runtime field tests with skips around the tests that we do not support just yet.

* Adds tests around corner cases involving ".", "..", ".foo", "foo.", etc...
* Adds tests around overriding values from the runtime fields within the source document
* Adds tests around ambiguity for when we override an array in a runtime field
* Fixes minor wording around previous tests
* Fixes one line string when we do testing in one area

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-06-08 17:31:54 -06:00
Alexander Wert 6c02081ed7
Added APM PHP agent to the list of agent names (#101062)
* Added APM PHP agent to the list of agent names to include it into the agent telemetry collection

* put php label into alphabetical order

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-09 01:13:47 +02:00
Nicolas Chaulet 8c2c83cb7d
[Fleet] Add fleet server telemetry (#101400) 2021-06-08 18:55:48 -04:00