* create xpack plugin skeleton, start to implement management section
* add tag creation modal
* first implementation of the tags table
* use InMemoryTable
* add edit modal and delete action
* update plugin list
* add tag list, fix types
* add capabilities check on client-side
* add tag combo box component
* add missing i18n keys
* fix privilege FTR tests
* add base structure for FTR tests
* fix feature ftr test
* use string literals for i18n
* create savedObjectsTaggingOss plugin, move API types to oss plugin, start to wire to SO management page.
* update plugin list
* fix types
* allow to use `_find` with multiple references
* add FTR test for _find API on references fields
* add _find integration tests
* update generated doc
* start to implement tag filtering on SO management section
* update generated docs
* wire tagging API to dashboard listing page
* fix i18n namespace
* fix type & tests
* update dashboard listing snapshots
* adapt FTR listingTable service to search for parsable queries
* wite tagging API to visualize listing
* update tagging plugin limits
* add server-side and client-side validation for tag create/edit
* rename title field to name
* fix types
* fix types bis
* add removeReferencesTo API to SOR/SOC
* update generated doc
* add server-side unit test for `savedObjectsTagging` plugin
* move tagging API types to its own file
* add savedObjectsTaggingOss mock
* add tags_cache tests
* add tests for client-side tag client
* extract uiApi to distinct files
* various API improvements
* add more tests
* add link between tag and so management sections + add connection counts
* add base functional test suite for tagging
* add more FTR tests
* improve feature control func test
* update codeowners
* update generated doc
* fix access to proxy modal
* adapt SO save modal to allow to add tag field
* add SO decorator registry and tag implementation
* add unit tests for SO tag decorator
* add functional tests for visualize integration
* add tag SO read permission for vis/dash feature
* add RBAC api integ tests
* add API integration tests
* add test for getTagConnectionsUrl
* add SOM test suite
* add dashboard integration suite
* remove test line
* add missing unit tests
* improve API types doc
* fix create modal save button label
* remove console.log
* improve doc
* self review
* add refresh interval for tag cache
* improve page object doc
* minor cleanup
* address review comments
* small layout fixes
* add initial focus
* use lazy accessor for tag request handler context
* adapt SOM export and export route to handle references
* remove icon from feature config due to master changes
* fix SO table tests
* update generated docs
* sort tags by name in filter dropdown and listing component
* wire SO tagging to dashboard save modal
* fix types
* - add 'create tag' action in tag selector
- add notifications on update/create/delete from management
- delete modal wording
* add description max length validation
* remove real-time validation
* fix i18n bundle id
* update expected size of savedObjectsTagging plugin
* use own useIfMounted
* update limit again, contract components cannot be lazy loaded atm.
* math is hard
* remove single usage of lodash for bundle size
* add async imports for create/edit modal
* add FTR test for 'create tag' action from tag selector
* allow 'create new' option to prepopulate name field
* extract savedObjectToTag
* add advancedSettings read user for security api_integ suite
* add audit login for security client wrapper
* use import type when possible
* wire SO tagging to lens visualization
* fix lens jest test
* Fix `create tag` option being selected when closing the selector dropdown
* add sorting to tag column from getTableColumnDef
* address some of restrry comments
* rename tag selector's setSelected option to onTagsSelected
* fix audit logging even type for saved_object_remove_references
* update plugin size limit to current size
* adapt maxlength validation wording
* remove selection column until we have batch action menu
* remove connections link when user lack read privilege to savedObjectManagement
* forbid registering multiple SO decorators with the same priority
* add so decorator test
* extract getTagFindReferences and create API mock
* update audit-logging ascidoc
* doc nit
* throw conflict error if update returns any failure
* use refresh=true as default
* wording nits
* export: rename `references` to `hasReference`
* update generated doc
* set description max length to 100
* do not initialize tag cache on anonymous pages
* split fetchObjectsToExport into two distinct functions
* change tag client `delete` call order
* tsdoc nits
* more nits
* add README for oss plugin
* add oss plugin start tests
* SavedObject.find: rename `references` to `hasReference`
* change section description label
* remove url prefix constants
* last nits and comments
* update generated doc
* [lens] fix unhandled promise rejection when saving Lens with duplicate title
* more clean up
* restore getDisplayName, used by return of checkForDuplicateTitle
* fix jest test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* reduce padding on lens visualizations in dashboard
* tweak padding and axes title colors to match lens
* remove faux padding (border) to match lens padding
* update snapshots
* Revert "update snapshots"
This reverts commit c63cf2bf1c.
* update functional test baseline screenshot
This PR addresses a list of legacy code debt the plugin has incurred over the past year due to extensive changes in its internals and the adoption of the Kibana Platform.
It includes:
1. The `TaskManager` class has been split into several independent components: `TaskTypeDictionary`, `TaskPollingLifecycle`, `TaskScheduling`, `Middleware`. This has made it easier to understand the roles of the different parts and makes it easier to plug them into the observability work.
2. The exposed `mocks` have been corrected to correctly express the Kibana Platform api
3. The lifecycle has been corrected to remove the need for intermediary streames/promises which we're needed when we first introduced the `setup`/`start` lifecycle to support legacy.
4. The Logger mocks have been replaced with the platform's `coreMocks` implementation
5. The integration tests now test the plugin's actual public api (instead of the internals).
6. The Legacy Elasticsearch client has been replaced with the typed client in response to the deprecation notice.
7. Typing has been narrowed to prevent the `type` field from conflicting with the key in the `TaskDictionary`. This could have caused the displayed `type` on a task to differ from the `type` used in the Dictionary itself (this broke a test during refactoring and could have caused a bug in production code if left).
* Create lens action and unregister the visualize one
* remove console
* Implement Discover to Lens, wip, missing tests
* Add unit tests
* fix embed lens to empty dashboard functional tests
* fix suggestions on save
* Fix bug on save button, query and filters should be transferred from discover
* Add functional test for the navigation from Discover to Lens
* PR update after code review
* unregister visualize action only if the action exists
* Change the test to not be flaky
* Move suggestions to editor frame and hide the emptyWorkspace for visualize field
* Update ui actions docs
* Add a retry to remove test flakiness
* Fix bug of infinite loader when removing the y axis dimension
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Making saveMethod mandatory in attribute service
* Making unwrap method mandatory
* Making book embeddable respect new attribute service
* Remove savedObjectsClient from attribute service
* Add checkForDuplicateTitle method to book embeddable
* Make options mandatory on attribute service
* Changing Lens attribute service
* Somw more typescript fixes
* Fixing attribute service typescript and tests
* Fixing typescript errors
* Unsetting feature flag
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Remove wrapping div of DragDrop and pass props to child
* Using EuiHighlight
* Basic styles in for all DnD states
* Fixing dimension button styles
* Fix FieldButton to accept `…rest` props
* A few other minor fixes
* Fixed horizontal scroll of error message
* Quick fix for invalid link
* wip, redsign the xy axis general settings
* pie chart settings. fix tests, initial implementation
* Fix Internationalization
* Cleanup
* remove unused translations
* Add test to check that right axis is enabled
* fix test
* remove unecessary translation
* Added icons and cleaned up some of the visuals for grouped buttons
* Fix types
* Axis Settings Popover Reusable Component
* Legend Popover Reusable Component
* Cleanup unused translations
* Fix right axis behavior
* Revert yLeftTitle to yTitle to avoid migration
* PR fixes
* identify which axis is enabled
* Change the logic on enabling the y axes popovers
* Adjust axis popover on horizontal bars
* fix failing test and change the logic of fetching the y axis titles
* Simpify the axis title logic, make the toolbar repsponsive, add TopAxisIcon
* Ui Changes on legends popover
* Cleanup and more unit tests
* use groupId instead of index to take under consideration all possible scenarios
* fix gridlines
* Remove ts-ignore from icons and move toolbar button to shared components
* Workspace toolbar wraps on smaller devices
* Tooltip on Toolbar appears only if the button is disabled
* clean up
* Add missing translations
* fix eslint
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [Lens] Drag to replace
* Add jest tests for drag and drop
* Fix bug in dragging to empty
* Hide dragged dimension when drag starts
* Make table metrics required
* Update class names
* Implement styles on non-droppable items
* Replace drag and drop image in docs
* Remove extra specificity
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>