Commit graph

417 commits

Author SHA1 Message Date
friol c718972d11 Add ability to replace any panel in edit mode on the fly (#45095)
* First version of change view functionality

* Adds the 'replace view' functionality to dashboard edit mode

* Fixed type_check errors

* Make action part of dashboard_embeddable_container

* Fixed import paths for type check errors

* Fixed i18n errors

* Renamed action to 'Replace panel' and adjusted jest tests to pass type check

* test: add functional tests

Closes #43900
2019-10-23 16:56:50 -05:00
Dmitry Lemeshko b7999157b8
Redesign dashboard tests (#48467) 2019-10-21 23:59:25 +02:00
John Dorlus 7cdd0b2bc9
Hybrid index pattern test (#43498)
* Added 5 second sleep to let thte page load before checking for title.

* Made changes to Rollups page object, added data test subjects to some elements, added function to get Indices to indexmanagement page.

* Removed 5 second wait from old commit,

* Updated home page for a more simplified create rollups method. Simplified data for the rollups to use a simple data structure rather than using makelogs.

* Added stop to the previous rollup job that ran. Added some timeouts to wait for the rollup to run. Added future data to be rolled into hybrid index pattern. Added some custom handling for creating different types of index patterns.

* Added forking condition for if the create index pattern button has the dropdown due to rollup data being present and to handle that case. Changed assertion for rollup job test to ensure that there is one index created with the proper name from the rollup job. Made adjustment to cron expression to run every 10 seconds. Added deletion clauses for all rollup jobs, index patterns and indices to ensure proper teardown.

* Added navigate to the discover page and verify the number of hits.

* Fixed assertion: Not supposed to contain hits.

* Fixing the button that's being searched for.

* Made adjustment to setings page due to test failures.

* Made adjustment to setings page due to test failures.

* Made a change to the order of the parameters for createIndexPattern which was causing non rollup index patterns to break. Also added new conditional and function to click on rollup index pattern button.

* Changed ciGroup and also added logging statements to rollup jobs test.

* Trying an additional wait to see if there is a race condition.

* Changed timing of when rollup job is stopped. It was getting stopped before having triggered.

* Added  waitlogic for condition rather than hardcoded skeep. Used cheerio methods to parse table instead of bluebird's map async. Updated tests assertiuons to ensure the rollup has triggered and produced the right number of documents. Tested many times with Throttling and headless mode enabled.

* Returned the method reloadIndicesButton back to the page object instead of modifying it.

* Changed CI job to run test repeatedly.

* Forgot some script omissions.

* Reverting the script changes. Did not work.

* Readded config to run tests repeatedly per Dima.

* Added additional config for running CI tests.

* Fixed config error.

* Removed extra rollup cration step.

* Made edits per review and added some comments to clarify functions purposes.

* Added explanation of assertion and change that the rollup_info file was renamed.

* Adjusted assertion to compensate for CI's slow network.

* Split the hybrid index pattern test out and rollup job to be in separate files. Mocked out rollups and cleaned up log statements.

* Added load empty kibana to reset kibana to an empty state.

* Removed duplicate file and move method over from it. Updated references.

* Renamed test suite to hybrid index pattern as that's what the test entails

* Fixed missed reference rename.

* Fixed mistaken async keyword causing unhandled rejection error. Also deleted rollup job in hybrid index pattern test in after hook. Renoved log statements.

* Reverted changes to build scripts to normal.

* Fixed jobs file to match upstream due to a missed fix in a merge conflict.

* Added remainder of CI groups to job.

* Removed whitespace error.

* Made fixes per CJs review. Fixed clashing variable names. Reverted rollup job test to assert using rollups table. Changed group back to ciGroup1. Removed duplicate teardown index deletion calls.

* Created more concrete assertion for checking if hybrid index pattern was created. Some refactorings. Changed Math.floor() to Date.now() for avoidance of name collisions.

* Removed the data.json file.

* Addressed nits.
2019-10-17 19:36:54 -07:00
Dmitry Lemeshko 2fb13ce4eb
Improve recently failed tests (#48389)
* [apps/management] improve import objects tests

* [page_objects/dashboard_page] replace link navigation with direct url

* [dashboard/time_zones] reset date format via API

* update jest snapshot

* [management/_kibana_settings] reset date format via API

* revert changees to dashboard tests

* run ciGroup 7 & 8 15x times

* Revert "run ciGroup 7 & 8 15x times"

This reverts commit 8be64d52dc.
2019-10-17 19:37:55 +02:00
Tim Sullivan 1939b8c55c
Reporting: Fix missing time range in the PDF page header (#47916)
* layout selector refactoring

* remove some any types

* Expose the time duration for sharing apps

* switch Reporting to use timeRange.duration

* fix mock

* up the logs for platform bug

* add jest snapshot test

* add functional ui test

* Revert "up the logs for platform bug"

This reverts commit b128c35e15.

* fix snapshot test
2019-10-16 21:39:55 -07:00
Caroline Horn 03f1b1f8b9 [Lens] Help menu GH link and Visualization selection text (#46756)
* Add message in new vis modal

* Add help menu util with link to github

* Fix import

* Oh snap

* Uncomment docs link but make it only visible if page url exists

* Remove Lens-specific code from visualize

* Add Lens help to the chrome help menu

* Replace `calloutText` with `buttonText`

* Dont show docs link yet

* Add beta label to grid and listings

* Fix page object
2019-10-15 16:37:31 -04:00
Greg Thompson 71b1bbd4cb
Upgrade EUI to 14.5.0 (#48119)
* eui 14.5.0

* snapshot updates

* update ChromeBreadcrumb interface

* change bad id selector to data-test-subj selector
2019-10-15 09:59:38 -05:00
Dmitry Lemeshko 4d51ae48e7
Fix several recently failed functional tests (#47976)
* small tweaks to make tests more stable

* fix empty list check, update more tests

* fix
2019-10-14 15:50:36 +02:00
Matthias Wilhelm 83b4b4568c
Fix visualize app chart type test (#47807)
* Add method to detect oss in settings pages

- if it's not OSS, than 'Maps' is added to the expected chart types

Co-authored-by: liza-mae <liza-mae@users.noreply.github.com>
2019-10-14 09:37:05 +02:00
Alexey Antonov 8bf2a4f227
[Automation] TSVB doesn't allow to perform basic functions showing no fields available (#47860) 2019-10-11 11:33:03 +03:00
Matthias Wilhelm 696214c59a
Fix homepage app sample data dashboard test failures in cloud (#47737)
* Improve launchSampleData of HomePageProvider for cloud testing

* Migrate to typescript
2019-10-10 16:34:33 +02:00
Tim Roes a2c984ce6f
Deprecate scale metrics behavior (#47599)
* Deprecate scale metrics behavior

* Fix functional tests

* Fix jest snapshot

* Add back test
2019-10-10 08:28:05 +02:00
Matthias Wilhelm 08de89b588
[discover] fix shared links tests for cloud testing (#47572)
* Add method to open permalinks menu entry if available

* Migrate to TypeScript
2019-10-09 07:34:51 +02:00
Lee Drengenberg 700a7ef576
Add option for Internet Explorer IE11 to FTR (#42967)
* Add option for Internet Explorer IE11

* WIP trying to figure out IE options/capabilities

* more attempts to get IE tests working

* more work, but still can't set font size in Dev Tools Console

* two changes for IE

* revert skip in console test

* this change *appears* to set absolute times but they don't stick

* Shakespeare passing on all 3 browsers

* add config.ie.js, change 'internet explorer' to 'ie'

* increase notifications:lifetime so ew have a chance to see the message

* fix lint error remove unused Options

* updates from PR review, remove console.log

* cleanup + reuse existing code

* make iedriver path work for x-pack tests

* try to avoid changing notification timeout

* resolve path and add correct delimiter

* remove unused code, make timepicker work on IE11

* work-around 45333 for IE11

* [WIP] removing some work-arounds

* revert work-arounds

* cleanup

* remove debugging code

* remove debugging code

* removed unused code

* reverting 2 files that didn't have any material changes
2019-10-04 11:13:58 -05:00
Marco Vettorello 802cd33a2f
Add scroll into view to avoid tooltip overlap (#47106)
The current angular implementation of the tooltip, applied to the Apply button of the visualize editor, suffer from missing the mouseleave event in some cases. This cause the tooltip to remain open in some cases halting the test from clicking the underlying button.
The tooltip implementation will be soon replaced by EUI, so on this PR we are only unskipping the test and scrolling the visualize editor sidebar to avoid this overlap.
2019-10-03 12:17:31 +02:00
Jean-Louis Leysens c33a670def
[Console] Editor component smoke tests (#45872)
* First attempt at editor.tsx integration test

* Fix typo in variable name

* Expanded smoke test integration tests

* Mounting happens in beforeEach
Added i18n context to suppress error messages
Updated name of data-test-subj for the send request button
2019-09-30 16:44:30 +02:00
Matthias Wilhelm f9cc456de0
[discover] De-angularize index pattern selection (#46347)
* Implementation of DiscoverIndexPattern React component

* Implement usage of the DiscoverIndexPattern

* Adapt tests
2019-09-30 11:19:28 +02:00
Dmitry Lemeshko e352f516d7
Fix tsvb chart test (#44657)
* enable switch index patterns test

* run ciGroup6 20x times

* [page_objects/visual_builder_page] retry selecting index pattern

* Revert "run ciGroup6 20x times"

This reverts commit 2151ea9905.

* [services/combo_box] clear input in seperate function

* run ciGroup12 30x times

* update logging message

* Revert "run ciGroup12 30x times"

This reverts commit 08fac11139.
2019-09-27 23:44:24 +03:00
Lee Drengenberg 5a92dec11d
unskip dashboard_screenshot tests by using new setScreenshotSize (#46311)
* use new setScreenshotSize

* change tolerance from 1% to 2% (originally 5%)

* retake baseline without notification dialog

* close add and save notifications

* wait for render complete when going in to FullScreen mode

* add 5 second sleep to see if it ever goes to full screen mode

* add debugging screenshots and sleeps

* try reloading the Kibana index before this test

* 30 iterations with only the first test enabled

* revert multi-run changes

* ran node scripts/build_renovate_config

* fix tslint errors

* fix tslint error

* update xpack dependency to match oss

* update yarn.lock

* revert notifications:lifetime:info change by reducing some other timeouts

* remove commented-out code

* fixed and Unskipped 2nd test

* re-arrange order of dashboard tests to pass :-(

* removed commented-out sleep

Hopefully this won't be an issue

* Add comment about the order of tests

```
      loadTestFile(require.resolve('./view_edit'));
      // Order of test suites *shouldn't* be important but there's a bug for the view_edit test above
      // https://github.com/elastic/kibana/issues/46752
      // The dashboard_snapshot test below requires the timestamped URL which breaks the view_edit test.
      // If we don't use the timestamp in the URL, the colors in the charts will be different.
      loadTestFile(require.resolve('./dashboard_snapshots'));
 ```
2019-09-27 13:49:51 -05:00
Daniil Suleiman b322b6057b
[Vis: Default editor] Euification of heatmap options tab (#45766)
* EUIficate heatmap options

* Move collections

* Split labels in a panel

* Remove angular templates

* Remove unused translations

* Fix functional tests

* Fix validation

* Fix UI details

* Compress color picker

* Improve types

* Replace headings h2 with h3

* Add functional tests

* Create setCustomRangeByIndex
2019-09-27 17:00:09 +03:00
Dmitry Lemeshko 3f83251a20
Fix/markdown functional tests (#46216)
* [page_objects/visual_builder_page] improve text area input clearing and typing value

* run ciGroup6 15x times

* Revert "run ciGroup6 15x times"

This reverts commit d94491769b.
2019-09-20 19:36:05 +02:00
Dmitry Lemeshko 8cd22b7d54
Fix visualize point series tests (#46069)
* change interaction with 'select' element

* run ciGroup5 15x times

* Revert "run ciGroup5 15x times"

This reverts commit 9c19d9a135.
2019-09-19 17:40:09 +02:00
Dmitry Lemeshko b9497feab0
Fix/tsvb functional tests (#45868)
* [page_objects/visual_builder_page] increase timeout & remove FF sleep

* unskip flaky test suites

* run ciGroup6 12x times

* fix tsvb_markdown tests

* skip aggs test

* fix waiting

* run FF tests 8x times

* Revert "run FF tests 8x times"

This reverts commit 75ef2ced46.

* Revert "run ciGroup6 12x times"

This reverts commit 217dbb818c.

* Update test/functional/page_objects/visual_builder_page.ts

review fix

Co-Authored-By: Spencer <email@spalger.com>
2019-09-18 18:53:22 +02:00
Dmitry Lemeshko 9a652ce2a4
Update chromedriver to 77 (#45614)
* bump chromedriver to v77

* fix file import
2019-09-18 17:34:12 +02:00
Lee Drengenberg 5a501ed2e7
use correct id in setting default index pattern in dashboard tests (#45601)
* replace guid with logstash-* in data for default index pattern

* revert change to data archive, instead fix index pattern id
2019-09-18 09:25:53 -05:00
Daniil Suleiman 35e0f9cf5b
Remove extra code from point series functional tests (#45895)
* Remove extra code

* Remove unused ids
2019-09-18 17:22:20 +03:00
Maryia Lapata 71f6150a14
Fix functional test (#45641) 2019-09-16 12:45:16 +03:00
Lee Drengenberg e142442712
correct path with this missing slash (#45666) 2019-09-13 15:43:57 -05:00
Maryia Lapata 1223ab97a6
[Vis: Default Editor] EUIficate 'Metrics & Axis' tab (#43772)
* EUIficate pointe-series and grid

* Apply TS

* Show grid on a panel

* Remove extra space

* Add TS

* Use BasicOptions

* Adjust func test

* Add dataTestSubj prop to SelectOption

* Use id instead of data-sest-subj

* Disable show x-axis lines when there is histogram agg

* Add tooltip for disabled 'Show x-axis lines' config

* Add series_options.tsx

* Migrate series

* Improve changeValueAxis

* Create CategoryAxisPanel

* Create ValueAxesPanel

* Create CustomExtentsOptions

* File renaming

* Use TruncateLabelsOption

* Set min value

* Add validation

* Refactoring

* Move types upper

* Convert series logic

* Convert valueAxes logic

* Rename function

* Add validation and refactoring

* Adjust styles

* Fix rotates

* Apply config for other vis

* Remove old directives

* Fix useHook usage

* Update vislib_vis_type.js

* Fix

* Move Threshold line panel into a separate component

* Remove unused translations

* Apply ui suggestions

* Update functional tests

* Remove angular unit test

* Refactoring

* Fix dependencies

* Refactoring

* Add validation

* Add validation for other vis

* Refactoring of onPositionChanged handler

* Refactoring of addValueAxis

* Get rid of a useEffect

* Refactoring of updateAxisTitle

* Update useCallback

* Refactoring

* Refactoring of collections config

* Refactoring of setChartValueByIndex and setValueAxisByIndex

* Update metrics_axes_options.tsx

* Watch current tab for correct accordion height

* Revert axis title logic

* Fix axis id and name number

* Fix code review comments

* Fix functional tests

* Update visualize_page.js

* Move option tabs in common

* Fix code review comments

* Update index.tsx

* Refactoring

* Fix merge conflict

* Show ThresholdPanel when it's configured

* Fix passing a current tab to vis-options

* Localize 'Count' text

* Pass one axis to CategoryAxisPanel

* Fix y-axis name number when x-axis position changed

* Fix Y-axis name number when position Y-axis changed

* Fix refresh loop

* Re-organize controls

* Apply code review comments

* Refactoring

* Fix extents empty value

* Update y_extents.tsx

* Fix code review comments

* Fix updating several seriesParams when removing axis

* Add thresholdLine config to horizontal bar

* Refactoring

* Reset grid.valueAxis when the axis deleted

* Fix refresh loop

* Set interpolate config for line

* Enable "show dots"
2019-09-13 14:12:43 +03:00
Dmitry Lemeshko a33909a480
Change data-test-subj selector logic to support value with spaces (#43682)
* update test-subj-selector

* update locators

* adjust whitespaces removal

* fix another locator

* fix ML test locators
2019-09-12 09:48:09 +02:00
Marco Vettorello 5cd40b43ff Replace Discover chart with elastic-charts (#43788)
* use elastic-charts for histogram
* add class accessibility
* specify onElementClick type annotation
* set chartElement tooltip type to Follow
* use moment methods for now annotation logic
* move historam inside directive folder
* remove unused timechart directive
* remove dependency from tsvb brush handler
* remove non-required class to fix tooltip overflow
* change the cursor/crosshair
* fix(ie11): add fixed width for header text
* fix: annotation colors on dark theme
* unpdate click and brush ui functional tests
* move functional tests to percy
2019-09-10 12:44:36 -05:00
Matthias Wilhelm 3798674043
De-angularize and EUI-ficate Discover Context control elements (#44474)
* Create ActionBar component, merges loading button and size picker

* Use react component, remove angular code

* Migrate constants + state to typescript

* Remove unused increaseCount functions + tests

* Add jest test
2019-09-10 16:47:28 +02:00
Daniil Suleiman ab24359879 Replace TSVB timeseries charts with elastic-charts (#33558)
* Replace TSVB timeseries charts with elastic-charts

* Add sort index for series

* Update src/legacy/core_plugins/metrics/public/visualizations/views/timeseries/index.js

Co-Authored-By: Nick Partridge <nick.ryan.partridge@gmail.com>

* Fix PR comments

* fix issue with scaling

* fix crosshair styles for bar
2019-09-06 12:45:30 +03:00
Dmitry Lemeshko 3a158b9d7d
FTR: fix WebDriver Actions calls (#44605)
* [services/web_element_wrapper] add actions API methods

* fixes

* [services/browser] fix dragAnDrop to work in both w3c/non-w3c modes

* small review changes

* dragAndDrop: add default values for offset
2019-09-06 07:54:26 +02:00
Dmitry Lemeshko 96cd619380
[visualize/_tsvb_time_series] fix flaky test (#44505) 2019-09-04 08:05:58 +02:00
Josh Dover b352f67bdb
Add ApplicationService Mounting (#41007)
* Add core-only bundle

* Add ApplicationService mounting

* Add LegacyCore{Setup,Start}

* Fix PR comments

* Add functional tests

* Fix PR comments

* Fix PR comments

* Remove other usages of rootRoute

* Use state field notation

* Add support for open in new tab

* Fix PR comments

* Fix pesky await from the dead

* Update docs

* Bump @types/history
2019-09-03 13:03:05 -05:00
Matthias Wilhelm 213ae02162
Remove :type from discover context url (#44008)
* Add url without type to discover context

* Add redirectTo for the legacy URL

* Adapt link to context in discover table

* Remove code duplication by usage of redirectTo

* Remove anchorType from application and tests

* Cleanup mocha tests
2019-08-30 16:33:06 +02:00
Dmitry Lemeshko 9b9801f470
functional tests for input control range (#42483)
* [apps/visualize] functional tests for input control range

* update jest test to have 100% combined coverage with functional
2019-08-21 17:22:54 +02:00
Daniil Suleiman df72f91878
[Vis: Default editor] EUIficate region map options tab (#42944)
* EUIficate region_map_options

* Reuse types

* Remove wms_options directive

* Remove style import

* Fix issue with join field default value
2019-08-15 21:09:28 +03:00
Maryia Lapata a892d58677
[Vis: Default editor] EUIficate Panel Setting tab (#42828)
* EUIficate pointe-series and grid

* Apply TS

* Show grid on a panel

* Remove extra space

* Add TS

* Use BasicOptions

* Adjust func test

* Add dataTestSubj prop to SelectOption

* Use id instead of data-sest-subj

* Disable show x-axis lines when there is histogram agg

* Add tooltip for disabled 'Show x-axis lines' config

* Remove extra space
2019-08-14 17:52:36 +03:00
Peter Pisljar 06706b5748 fixes scaling logic to check agg type instead schema (#42574)
* fixes scaling logic to check agg type instead schema

* adding selenium test

* updating jest snapshot

* fixing test

* Change test order

* Fix test order
2019-08-08 18:09:14 +02:00
Dmitry Lemeshko 7d61cac2d8
FTR: fix testSubjects.missingOrFail (#42290)
* [services/test_subject] fix missingOrFail

* [services/test_subjects] allowHidden option for missingOrFail

* [page_objects/dashboard_page] wait for euiTable loaded, increase timeout for loading page check
2019-07-31 00:19:15 +02:00
Maryia Lapata 85f9ef6433
[Vis Editor] EUIfication of agg and agg-group directives (#40866)
* Create default_editor_agg.tsx

* Create default_editor_agg_group

* Apply drag and drop

* Remove unused dragula dependency

* Remove old mocha tests

* Add ts for state

* Update functional tests

* Update touched condition

* Apply styles for accordion button content

* Apply truncate for agg description

* Remove unused styles

* Separate common props

* Move aggGroupNamesMap to agg_group.js

* Update _sidebar.scss

* Pass schemas prop

* Prevent scroll bar and add space

* Remove unused min from stats

* Add OnAggParamsChange type

* Show error as an icon

* Update background color

* Update title size

* Remove Schema.deprecate since it's not used
2019-07-29 13:58:50 +03:00
Dmitry Lemeshko 044285cb3b
Functional tests: make sure clicked dashboard is opened (#42006)
* [page_objects/dashboard_page] make sure selected dashboard is opened
2019-07-26 15:01:58 +02:00
Meir Meshi db07f13253 Ensure visualizations in percentage mode respect the advanced settings percent format (#39044) 2019-07-23 23:47:27 -06:00
Tim Roes e1bc154478
GoodBye Notifier (#41663)
* Begin notifier removal

* Remove remaining notifier traces

* Remove dead translations

* Remove Angular from config listener

* Import angular-sanitize explicitly in map
2019-07-23 18:26:50 +02:00
Liza Katz 4b8913cb53
hide top nav menu in full screen mode of maps and dashboard (#41672)
* hide top nav menu in full screen mode of maps and dashboard

* Fixed dashboard full screen mode and added full screen mode test to maps
2019-07-23 09:31:44 +03:00
Dmitry Lemeshko 4d884fa448
update dark mode tsvb test (#41618) 2019-07-22 09:41:00 +02:00
Dmitry Lemeshko ade8a2f55d
Fix/re enable skipped functional tests (#41238)
* [home/_sample_data] unskip tests

* [visualize/_tsvb_chart] unskip switch index pattern test

* unskip nodes filter test

* run specific groups 10x times

* Revert "run specific groups 10x times"

This reverts commit ad7302f33f.
2019-07-18 11:58:49 +02:00
Lee Drengenberg 236bc83947
fix deleteAllVisualizations() (#41062) 2019-07-16 14:49:48 -05:00