Commit graph

32117 commits

Author SHA1 Message Date
Kaarina Tungseth
23755f95fa
[DOCS] Collapses content in Kibana and APM APIs (#62201)
* Collapses content in Kibana and APM APIs

* Update docs/api/role-management/put.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/copy_saved_objects.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/copy_saved_objects.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/copy_saved_objects.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/copy_saved_objects.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/copy_saved_objects.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/copy_saved_objects.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/resolve_copy_saved_objects_conflicts.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/resolve_copy_saved_objects_conflicts.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/resolve_copy_saved_objects_conflicts.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/resolve_copy_saved_objects_conflicts.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/resolve_copy_saved_objects_conflicts.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/resolve_copy_saved_objects_conflicts.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/resolve_copy_saved_objects_conflicts.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

* Update docs/api/spaces-management/resolve_copy_saved_objects_conflicts.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2020-04-06 11:15:52 -05:00
Michael Marcialis
e86cb42080
[Core UI] Add missing alt attributes to add data tutorial logos (#62393)
* add empty title prop for data tutorial page icons

* switch alt attribute to title prop

* update snapshots

* enabling skipped a11y tests
2020-04-06 12:15:13 -04:00
Michael Marcialis
70ae8aa6f1
add ownFocus prop to help menu (#62492) 2020-04-06 12:10:20 -04:00
Joe Reuter
1e92dcf1f3
migrate saved object, reset validation counter and fix typo attribute (#62442) 2020-04-06 17:55:27 +02:00
Corey Robertson
6da7c00b5d
Remove the action_value_click action in canvas (#62215)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 11:49:34 -04:00
Shahzad
cde0b73cb1
[Uptime] Removed unnecessary filter from Monitor List Fetch (#61958)
* removed unnecessary filter

* update condition

* added a unit test for mix state

* fix types

* fix type

* updated test

* update

* updates test

* updates test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 17:24:21 +02:00
Justin Kambic
ba446f3900
[Uptime] Default uptime alert type and disable changing type (#62028)
* Default uptime alert type and disable changing type.

* Update functional test to handle new UI flow.

* Fix type error.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 11:11:25 -04:00
Alexey Antonov
fa661c0f9a
match_all query disappears when typed into Lucene query bar (#62194)
* match_all query disappears when typed into Lucene query bar

Closes: #52115

* add migrations for searh savedobject type

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 17:51:27 +03:00
Patrick Mueller
113181b6df
[Alerting] write event log entries for alert execution and it's actions (#61706)
resolves https://github.com/elastic/kibana/issues/55636

Writes eventLog events for alert executions, and the actions executed from
that alert execution.
2020-04-06 10:24:02 -04:00
Larry Gregory
5003179da3
Update cache-control header (#62014)
* update cache-control header

* update tests

* update test run config

* remove custom cache-control header for authentication resources

* address test flakiness

* address PR feedback

* revert changes to endpoint test

* revert changes for real this time

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 10:19:42 -04:00
Nathan Reese
d26372ce9d
[Maps] 7.7 documentation updates (#61332)
* [Maps] 7.7 doc updates

* blended layer

* revert to grid aggregation language

* review feedback
2020-04-06 08:17:50 -06:00
Ahmad Bamieh
450d5fcaa3
[i18n] integrate 7.7 translations (#62597) 2020-04-06 17:06:48 +03:00
Joe Reuter
c2e43109a4
make last stored url space aware (#62264) 2020-04-06 15:57:26 +02:00
Alison Goryachev
f86dac77da
Fix es_ui_shared imports (#62526) 2020-04-06 09:20:29 -04:00
Nathan Reese
102fa1b560
[Maps] clean up IDynamicStyleProperty (#62466)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 07:13:21 -06:00
Joe Reuter
2b32160a65
Vislib: Fix position calculation of ticks in non-horizontal axes (#62309) 2020-04-06 15:03:19 +02:00
James Gowdy
4386d5fa7d
[ML] Register ML and Transforms for the kibana home page (#62499)
* [ML] Register ML for the kibana home page

* adds transforms

* tiny refactor

* updating comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 13:50:20 +01:00
Sébastien Loix
e732196238
[Index management] Fix regression on mappings editor forms (#62437) 2020-04-06 14:40:16 +02:00
Walter Rafelsberger
9e9928f35c
[ML] Fix error messages. (#62575)
Fixes two regressions:
- The migration to NP and its related http service changed the format of error messages, because of this, the output in toast error messages ended up less informational. This PR fixes it by reusing the ML plugin's updated getErrorMessage() function.
- The migration to NP and move to NP's useKibanaContext() introduced a regression where the modal overlays of error toast with long error message would no longer work anymore. This PR fixes it by passing on overlays as a component prop instead of using the context hook within the component.
2020-04-06 14:13:11 +02:00
Jean-Louis Leysens
5ca1c9d627
Clean up code (#62571)
Remove unused import and unnecessary space

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 12:53:24 +02:00
Maja Grubic
4573f8de17
Allow markdown in error embeddable (#62427)
* Allow markdown in error embeddable

* Replace markdown factory with markdown component

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 11:47:30 +01:00
Shahzad
6a32b457f0
[Uptime] Replace usage of date_histogram with aut_date_histogr… (#59577)
* remove usage of manual date_histogram

* update

* update

* remove unused

* update fixtures

* update snaps

* remove duplicate test

* type

* update test

* update fixtures

* update interface

* updated type

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 12:32:36 +02:00
Mikhail Shustov
bdf628d29a
use union of strings instead of enum (#62493)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 12:31:36 +02:00
Mikhail Shustov
5940b72d67
load assets lazily in es-ui plugins (#62487)
* load assets lazily

* addres cj comments
2020-04-06 12:29:11 +02:00
Dario Gieselaar
ca1d77cc14
[APM] Prevent "For the last" expression from jumping (#62414)
Closes #61063.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 11:42:17 +02:00
Dario Gieselaar
3c923d7071
[APM] Set action variables for APM alert types (#62416)
Closes #61941.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 11:39:34 +02:00
Daniil Suleiman
104b49015e
[NP] Dashboard (#61895)
* Remove absoluteToParsedUrl reference in dashboard

* Remove KibanaParsedUrl from visualize

* Fix tests

* Add tests

* Fix saved dashboard

* Fix empty line after resolving conflicts

* Move dashboard to np

* Move migrations back to legacy

* Make it works

* Other fixes

* Move into application folder

* FIx translations

* Make share & home plugins otional

* FIx kbn url tracking, jest tests

* Import from dashboard_constants in FT

* Fix translations order

* Use getStartServices for start plugin deps

* Path fixes

* i18n fix

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 12:11:48 +03:00
Alison Goryachev
4ab89e9145
[DOCS] Update index templates example (#62530) 2020-04-06 05:05:29 -04:00
Jean-Louis Leysens
ae9a7516ce
[Console] Handle the case where saving to history may throw an error (#62424)
* Handle the case where saving to history may throw an error

We should still show the request result even if localStorage is
full (or any other save error occurs)

* Update src/plugins/console/public/application/hooks/use_send_current_request_to_es/use_send_current_request_to_es.ts

Co-Authored-By: Alison Goryachev <alisonmllr20@gmail.com>

Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-06 10:07:56 +02:00
Liza Katz
ddc90247c2
[BUG] Back navigation from surrounding documents doesn't work properly (#62350)
* replace state for load more documents

* simpler solution

* simpler solution + functional test

* fix test

* disable flaky test
2020-04-06 10:41:05 +03:00
Spencer
4962fe9d8a
[jenkins] refer to sizes in most pipeline code (#62082)
* [jenkins] refer to sizes in most pipeline code

* switch back to `linux && immutable` for small instances

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-04 07:11:31 -07:00
spalger
3d154a389e skip flaky suite (#60470) 2020-04-04 07:08:17 -07:00
Daniil Suleiman
5696f6285c
[Discover] Fix flaky FT in field visualize (#62418)
* Unskip

* Set only suite

* Add field search

* Use alternative flaky fix

* Remove extra actions

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-04 17:05:00 +03:00
Walter Rafelsberger
8c06b12212
[ML] Data Frame Analytics: Fix feature importance (#61761)
- Fixes missing num_top_feature_importance_values parameter for analytics job configurations
- Fixes analytics create form to consider feature importance
- Fixes missing feature importance fields from results pages
2020-04-04 09:36:20 +02:00
Tim Sullivan
f1f93d32a4
[Reporting] Use a shim for server config (#62086)
* config shim

* simplify route register calls

* switch to in-sync worker functions

* fix tests

* comment

* fix set up config with defaults

* reduce loc change

* remove test for removed file

* reportingconfigtype

* revert changing executeJobFactory to synchronous

* imports cleanup

* Clean up some awaits

* undo comment

* clean up async

* clean up imports

* add warning logs for config defaults

* Move around some config shim code

* Register routes params take ReportingCore

* usageCollection is an optional dependency
2020-04-03 21:37:54 -07:00
Tim Sullivan
a5c3865594
[Reporting] Fix reporting for non-default spaces (#62226)
* [Reporting] Fix URLs in job params when basePath includes namespace suffix

* canvas fix

* cleanup

* update snapshots in tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 20:18:08 -07:00
CJ Cenizal
ce6a291da1
Fix bug that coerced empty scaled float value to 0 (#62251) 2020-04-03 18:50:26 -07:00
Devin W. Hurley
7e11961869
[SIEM] [Detection Engine] Remove has manage api keys requireme… (#62446)
Alerting no longer requires the manage_api_keys privilege, so we are removing it from the detection engine code. Fixes #62387

* removes hasManageApiKeys since alerting is using the internal user api calls, manage_api_keys privilege is no longer necessary

* linting error

* fixes types and removes a test for manage api keys

* removes manage api key reducer and updates leftover tests

* moves userHasNoPermissions repeated code into a function in helpers, adds a few test cases, updated references to new function

* fix test title

* remove userHasNoPermissions function and remove tests, replace with just not canUserCRUD

* Revert "remove userHasNoPermissions function and remove tests, replace with just not canUserCRUD"

This reverts commit 93912e7e22.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 20:25:12 -04:00
Nathan Reese
a5526c8730
[Maps] Safely handle empty string and invalid strings from EuiColorPicker (#62507)
* [Maps] Safely handle empty string and invalid strings from EuiColorPicker

* move RGBA_0000 to constants
2020-04-03 17:57:53 -06:00
Joel Griffith
9ed69ce9f2
Reporting/bug more blacklisted headers (#62389)
* Adding more blacklisted headers + a starts-with pattern export

* Fixing starts-with pattern export
2020-04-03 15:19:44 -07:00
Ryland Herrick
b9ac2ac223
[SIEM] Prevent undefined behavior in our ML popover (#62498)
* Moves enableDataFeed outside of MLPopover

If we accept our dispatch functions, enableDatafeed can be abstracted as
a pure function. The version bound to popover's dispatch functions is
now named 'handleJobStateChange', as that is the callback it's used for.

* Remove unused component state

We no longer deal with jobs in our local state; that's the
responsibility of the useSiemJobs hook

* Prevent user from initiating multiple job installations

When attempting to run a job from the ML Popover, if the job needs to
first be installed, we set the rest of the jobs to be "loading" while
installation is performed.

Without this change, if users are fast enough they can potentially
trigger multiple rule installations, which is undefined behavior and
leads to failures and bad state in our component.

* Remove unused import
2020-04-03 16:52:12 -05:00
Devin W. Hurley
96ac8def87
[SIEM] [Detection Engine] remove all unknowns from all rules t… (#62327)
* remove all unknowns from all rules table props

* update sorting property type remove optional, also remove unnecessary properties we are not using in sorting, rename paginationMemo prop to pagination, remove null from rulesStatuses type as we are defaulting to empty array now

* fixes type mismatch for sorting and rulesStatuses

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 17:35:06 -04:00
Brent Kimmel
094637672f
base changes for active/current node styling (#62007)
* changes for active/current node styling
* Adjustment to reducer for selected node
*Fix spelling mistake
2020-04-03 17:26:54 -04:00
Spencer
e6c23ea9b2
[kbn/ui-shared-deps] expand and split (#62364)
* [kbn/ui-shared-deps] expand and split

* add two import styles for eui/react-dom that are new

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-03 14:11:36 -07:00
Melissa Alvarez
ebd22842c0
[ML] DF Analytics - ensure destination index pattern created (#62450)
* ensure destinationIndex name is defined

* set array for destIndex as invalid

* update type

* reset destIndex already exists error when updating advanced editor
2020-04-03 16:37:32 -04:00
Ryland Herrick
30afc9d597
Mark rule run as failure if there was an error (#62383)
While we still let the rule execute in the case of gap errors and
stopped ML jobs, we now mark that execution as a failure instead of a
success.
2020-04-03 15:22:38 -05:00
Phillip Burch
cff0e4d456
Add docs for metric explorer alerts (#62314)
* Add docs for metric explorer alerts

* Fix link

* Actually fix the link

* Grammar fix

Co-Authored-By: Brandon Morelli <bmorelli25@gmail.com>

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
2020-04-03 15:21:17 -05:00
spalger
b0523d5eb0 skip flaky suite (#62281) 2020-04-03 13:01:09 -07:00
Frank Hassanabad
85c665acb0
[SIEM][Detection Engine] Fixes export of single rule and the icons
## Summary

Fixes export of single rule and the icons.
* https://github.com/elastic/kibana/issues/62378
* Single export of rules was using the `rule.id` instead of the `rule.rule_id` where now it flips it and works as expected.
* This adds data-test-subj for testing
* This adds jest unit tests to the menu component

Icons Before:
<img width="396" alt="Screen Shot 2020-04-02 at 5 12 43 PM" src="https://user-images.githubusercontent.com/1151048/78315482-5b533280-751a-11ea-8378-d5e106ebd36f.png">

Icons After:
<img width="407" alt="Screen Shot 2020-04-02 at 7 40 28 PM" src="https://user-images.githubusercontent.com/1151048/78315449-3fe82780-751a-11ea-9d16-2f8c2ea22a78.png">

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-03 13:56:54 -06:00
MadameSheema
4cbf6d252b
fixes flakiness (#62406)
* fixes flakiness

* updates 'number of signals' selector

* changes the way we are asserting the text
2020-04-03 21:33:57 +02:00