Commit graph

38992 commits

Author SHA1 Message Date
Ahmad Bamieh
28c8cfbff4
[Telemetry] Application Usage track sub application views (#85765)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 17:25:51 -07:00
Steph Milovic
8f8e933741
[Actions] [Security solution] Jest tests for case_params files (#86028) 2020-12-15 17:20:22 -07:00
Michael Olorunnisola
a9adeee891
[Security Solution][Resolver] Stop tooltip from triggering on popover open (#86010) 2020-12-15 18:46:49 -05:00
Walter Rafelsberger
5bf6eeb8c6
[ML] Data frame analytics: Scatterplot matrix for outlier detection. (#73419)
Scatterplot Matrix for Data Frame Analytics Creation Wizard and Outlier Results pages.
2020-12-16 00:26:47 +01:00
Tyler Smalley
c3770fd709 Revert " [Maps] unify legend for percentiles, interpolate, and custom ordinal color breaks (#85343)"
This reverts commit 85dae266eb.
2020-12-15 14:43:41 -08:00
Lisa Cawley
a9a06ffa74
[ML] Add machine learning documentation links (#85089) 2020-12-15 14:43:27 -08:00
Paul Tavares
69000ffb0d
[SECURITY_SOLUTION][ENDPOINT] Show Trusted Apps summary stats on Custom tab under fleet integrations (#86018)
* show trusted app summary
2020-12-15 17:30:38 -05:00
Georgii Gorbachev
06907b845e
[Security Solution][Detections] Update read-only callouts from warning to info so they persist when dismissed (#84904)
**Addresses:** https://github.com/elastic/kibana/issues/76587

## Summary

In this PR I'm doing basically 2 things:

1. Making readonly callouts we have in Detections `primary` instead of `warning` and thus persistable in local storage (if a callout is dismissed, we remember it there)
2. Creating a reusable implementation for that.

TODO:

- [x] Adjust all callouts used in Detections to be of type `primary`
- [x] Implement the local storage logic (dumb)
- [x] Implement the local storage logic (reusable)
- [x] Add a new user role: "Reader" (read-only user)
- [x] Add Cypress tests

Out of scope:

- Add unit tests. I'll probably address this in a follow-up PR. Do you think it's worth it or better to wait until the rework (see the next point)?
- Rework callouts to standardise them across Detections, Cases and other parts of the Security app? See my comment below in this PR.

## Screen recordings

Quick demo of how this implementation works:

- [primary callouts](https://drive.google.com/file/d/1SYQd_ihKPvzlVUxELI8qNEqLBOkL18Gd/view?usp=sharing)
- [warning, danger](https://drive.google.com/file/d/1lrAFPyXNjOYSiEsUXxY_fjXsvmyDcdWY/view?usp=sharing) (callout types here were manually adjusted)

## Additional notes

Cypress tests are based on the work done in https://github.com/elastic/kibana/pull/81866.

![](https://puu.sh/GXwOd/1c855cb03f.png)
2020-12-15 23:28:00 +01:00
Thomas Neirynck
24f463f84c
[Maps] Track enterprise use of on-prem EMS (#85885) 2020-12-15 16:50:26 -05:00
Nathan Reese
85dae266eb
[Maps] unify legend for percentiles, interpolate, and custom ordinal color breaks (#85343)
* [Maps] unify legend for percentiles, interpolate, and custom ordinal color breaks

* unify mapbox style expression

* snapshot updates

* update jest expects

* use less than and great than symbol for first and last stop

* tslint

* do not show legend if customColorRamp is not provided

* update functional test expects

* update functional test expect

* update mapbox expect expressions in join functional tests

* update mvt expects

* revert mapbox style expression changes for interpole color ramp

* add greater then and equal to symbol for last stop

* disable stop input for first ordinal color stop

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 14:42:02 -07:00
Dima Arnautov
e17cd65196
[Transform] Add support for latest function (#85784)
* [Transform] add latest to the schema definition

* [ML] update interfaces, add guards

* [Transform] WIP support latest function

* [Transform] fix request with missing_bucket after merge

* [Transform] fix error in useDeleteTransforms

* [Transform] fix types and fields sorting for pivot

* [Transform] fix types and jest tests

* [Transform] fix error shape

* [Transform] fixed card width, change description

* [Transform] fixed API integration tests

* [Transform] fix config mapper

* [Transform] improve wizard performance
2020-12-15 22:40:13 +01:00
Constance
2a71d41a60
[App Search] Document Creation Buttons & bare-bones modal/logic (#85902)
* [Setup] Add EuiCardTo helper

* Set up very basic DocumentCreationLogic file modal management

* Create buttons and modal components

* Update EngineOverviewEmpty to use only DocumentCreationButtons

- Remove API section/example/constants for now: per design discussion, we'll be moving this section into the document creation modal
- Move preceding DOCUMENT_CREATION_DESCRIPTION paragraph directly into DocumentCreationButtons, since the Documents view will just use this verbatim

* Update Documents view Index Documents button to show DocumentsCreationModal

- with some extra logic to add a new creationStep view
+ some minor test cleanup / clarification for openDocumentCreation

* Update Crawler button with conditional check

- Forgot to port this over initially

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 13:34:19 -08:00
Patrick Mueller
f693697c18
[actions] expand object context variables as JSON (#85903)
resolves https://github.com/elastic/kibana/issues/75601

Previously, if a context variable that is an object is referenced in a
mustache template used as an action parameter, the resulting variable
expansion will be `[Object object]`.  In this PR, we change this so that
the expansion is a JSON representation of the object.

This is primarily for diagnostic purposes, so that customers can see
all the context variables available, and their values, while testing
testing their alerting actions.
2020-12-15 16:31:36 -05:00
Corey Robertson
6672e26fe5
[Dashboard] Adds dashboard collector for byValue panels (#85867)
* Adds dashboard collector for byValue panels

* Fix telemetry schema

* Remove unused import
2020-12-15 16:26:03 -05:00
Quynh Nguyen
74ae348f2d
[ML] Redesign index-based Data Visualizer (#85726) 2020-12-15 15:19:47 -06:00
Michael Olorunnisola
bfb65434a6
[Security Solution][Resolver] Fix failing test & cleaned up prop drilling (#85994) 2020-12-15 16:00:30 -05:00
Pierre Gayvallet
a4c4fe0504
[SO Tagging] Update tag delete modal confirmation title (#85997)
* Update tag deletion modal confirmation text

* add .
2020-12-15 21:41:47 +01:00
Thomas Neirynck
47e2663473
[Maps] Add percentile (#85367) 2020-12-15 15:40:21 -05:00
Rudolf Meijering
89bd0fbf1e
Resilient saved object migration algorithm (#78413)
* Initial structure of migration state-action machine

* Fix type import

* Retries with exponential back off

* Use discriminated union for state type

* Either type for actions

* Test exponential retries

* TaskEither types for actions

* Fetch indices instead of aliases so we can collect all index state in one request

* Log document id if transform fails

* WIP: Legacy pre-migrations

* UPDATE_TARGET_MAPPINGS

* WIP OUTDATED_DOCUMENTS_TRANSFORM

* Narrow res types depending on control state

* OUTDATED_DOCUMENTS_TRANSFORM

* Use .kibana instead of .kibana_current

* rename control states TARGET_DOCUMENTS* -> OUTDATED_DOCUMENTS*

* WIP MARK_VERSION_INDEX_READY

* Fix and expand INIT -> * transition tests

* Add alias/index name helper functions

* Add feature flag for enabling v2 migrations

* split state_action_machine, reindex legacy indices

* Don't use a scroll search for migrating outdated documents

* model: test control state progressions

* Action integration tests

* Fix existing tests and type errors

* snapshot_in_progress_exception can only happen when closing/deleting an index

* Retry steps up to 10 times

* Update api.md documentation files

* Further actions integration tests

* Action unit tests

* Fix actions integration tests

* Rename actions to be more domain-specific

* Apply suggestions from code review

Co-authored-by: Josh Dover <me@joshdover.com>

* Review feedback: polish and flesh out inline comments

* Fix unhandled rejections in actions unit tests

* model: only delay retryable_es_client_error, reset for other left responses

* Actions unit tests

* More inline comments

* Actions: Group index settings under 'index' key

* bulkIndex -> bulkOverwriteTransformedDocuments to be more domain specific

* state_action_machine tests, fix and add additional tests

* Action integration tests: updateAndPickupMappings, searchForOutdatedDocuments

* oops: uncomment commented out code

* actions integration tests: rejection for createIndex

* update state properties: clearer names, mark all as readonly

* add state properties currentAlias, versionAlias, legacyIndex and test for invalid version scheme in index names

* Use CONSTANTS for constants :D

* Actions: Clarify behaviour and impact of acknowledged: false responses

* Use consistent vocabulary for action responses

* KibanaMigrator test for migrationsV2

* KibanaMigrator test for FATAL state and action exceptions in v2 migrations

* Fix ts error in test

* Refactor: split index file up into a file per model, next, types

* next: use partial application so we don't generate a nextActionMap on every call

* move logic from index.ts to migrations_state_action_machine.ts and test

* add test

* use `Root` to allow specifying oss mode

* Add fix and todo tests for reindexing with preMigrationScript

* Dump execution log of state transitions and responses if we hit FATAL

* add 7.3 xpack tests

* add 100k test data

* Reindex instead of cloning for migrations

* Skip 100k x-pack integration test

* MARK_VERSION_INDEX_READY_CONFLICT for dealing with different versions migrating in parallel

* Track elapsed time

* Fix tests

* Model: make exhaustiveness checks more explicit

* actions integration tests: add additional tests from CR

* migrations_state_action_machine fix flaky test

* Fix flaky integration test

* Reserve FATAL termination only for situations which we never can recover from such as later version already migrated the index

* Handle incompatible_mapping_exception caused by another instance

* Cleanup logging

* Fix/stabilize integration tests

* Add REINDEX_SOURCE_TO_TARGET_VERIFY step

* Strip tests archives of */.DS_Store and __MAC_OSX

* Task manager migrations: remove invalid kibana property when converting legacy indices

* Add disabled mappings for removed field in map saved object type

* verifyReindex action: use count API

* REINDEX_BLOCK_* to prevent lost deletes (needs tests)

* Split out 100k docs integration test so that it has it's own kibana process

* REINDEX_BLOCK_* action tests

* REINDEX_BLOCK_* model tests

* Include original error message when migration_state_machine throws

* Address some CR nits

* Fix TS errors

* Fix bugs

* Reindex then clone to prevent lost deletes

* Fix tests

Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 21:40:02 +01:00
Scotty Bollinger
15876f85b1
[Workplace Search] Split out logic between Source and AddSource (#85658)
* Copy SourceLogic to AddSourceLogic

This commit merely copies SourceLogic and renames it to AddSourceLogic with the name of the component and interfaces changed. This will make reviewing the changes easier later

* Delete duplicated logic data

* Update component paths

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 14:22:11 -06:00
John Schulz
ec4fbf2901
[Fleet][EPM] Revert es-storage-related commits (#85942)
* Revert "[Fleet][EPM] Save installed package assets in ES (#83391)"

This reverts commit 81a340e681.

* Revert 00c2e96

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 15:11:46 -05:00
Nathan Reese
609d60705e
[Maps] provide function to create basemap layer descriptor (#85617)
* [Maps] provide function to create basemap layer descriptor

* update typing

* update APM map to use createBasemapLayerDescriptor

* fix useLayerList jest test

* tslint fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 12:40:44 -07:00
Nathan Reese
fa82f630a0
[Maps] 7.11 documentation updates (#85857)
* [Maps] 7.11 documenation updates

* update search docs with time filter legend indicator

* clean up tracks description

* fix duplicate id

* Update docs/maps/search.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/vector-style.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/vector-style.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* review feedback

* add percentile metric aggregation

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2020-12-15 12:37:16 -07:00
Paul Tavares
23cd2670e1
[SECURITY SOLUTION][ENDPOINT] Trusted Apps API to retrieve item summary by OS (#85870)
* API to return trusted apps summary
2020-12-15 14:21:25 -05:00
Jane Miller
1c1e4981bb
Add malware.threshold field to mac and windows (#85971) 2020-12-15 14:15:23 -05:00
Devon Thomson
e4114dc08f
Dashboard Print Optimize Class Change (#85878)
* Fixed print oversight from deangularize PR & removed grey lines from background of print optimized dashboard PDF
2020-12-15 14:01:11 -05:00
Pierre Gayvallet
f4b7916699
do not throw when query parsing fails (#85970) 2020-12-15 19:54:11 +01:00
Mike Côté
ccfb4b6b1d
Add footer to all emails sent by Kibana email connector with a link to open Kibana or to the alert details page (#84371)
* Initial work

* Change messaging from copy

* Fix jest tests for email connector

* Fix jest tests for alerts plugin

* Update copy

* Use server.publicBaseUrl

* Fix jest tests

* Update tests

* Cleanup jest test

* Code cleanup

* Improve email parameter names for kibana footer url

* Cleanup

* Add test for kibana footer link

* Fix type check

* Fix jest test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 13:51:44 -05:00
Kevin Qualters
47444e77c2
[Security Solution] Pass filters from SIEM to resolver, update resolver when refresh is clicked (#85812)
* Pass filters from SIEM to resolver

* Fix test type errors

* Revert loading state change, update snapshots

* Make correct check in nodeData selector

* Fix inverted logic in nodeData selector

* Revert nodeData invalidation logic

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 13:33:51 -05:00
Devon Thomson
ee37f6dd91
[Time to Visualize] Transition Embeddable State Transfer to Session Storage (#85688)
* Transitioned embeddable state transfer service to use sessionStorage
2020-12-15 13:18:36 -05:00
Melissa Alvarez
11713acc7c
[ML] Data Frame Analytics: ensure map view supports dark theme (#85886)
* use current eui theme in map

* ensure labels do not overlap. add job type legend

* reduce padding in legend popover
2020-12-15 13:17:53 -05:00
Cauê Marcondes
013c1761ee
[APM] Bug: Service overview - change the Traffic and Error rate chart legend labels to the current metric (#85930)
* changing chart legends

* removing (avg) from value
2020-12-15 18:50:26 +01:00
Marco Liberati
56ad415d14
[Lens] Document the "Other" entry in data summaries in Kibana guide (#85575)
* 📝 Address Other entry in data summaries

* 👌 Integrated feedback from review

* 📝 Add not about going beyong 100% with array values

* 👌 Improved documentation for summaries

* 👌 Improved documentation for data summaries covering discussed aspects by type and hardcoded stat values

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/dashboard.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
2020-12-15 18:50:03 +01:00
Scotty Bollinger
7c6f1b8a0a
[Workplace Search] Add i18n to Add Source component tree (#85590)
* Add i18n for AddSourceList

* Add i18n for AvailableSourcesList

* Replace all instances of interal Link

This was missed during the migration. We need to use the components we wrap Eui components with internally.

Also fixes some imports that were unnecessarily going up one level and back down for imports.

* Add i18n for ConfigCompleted

* Add i18n for ConfigDocsLinks

* Add i18n for ConfigurationIntro

* Add i18n for ConfigureCustom

* Add i18n for ConfigureOauth

* Add i18n for ConfiguredSourcesList

* Add i18n for ReAuthenticate

* Add i18n for shared field labels

Also includea shared SourceConfigFields

* Add i18n for SaveConfig

* Add i18n for SaveCustom

* Add i18n for SourceFeatures

* Add i18n for ConnectInstance

* Fix duplicate i18n ID

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 11:44:18 -06:00
Melissa Alvarez
43e20112b1
[ML] Data Frame Analytics: check space permissions before deleting jobs (#85495)
* disable delete until checks complete

* add canDeleteJobs wrapper in saved objects service

* create DeleteJobCheckModal shared component

* wip: add deleteJobModal check in list and map views

* adding remove from current space endpoint

* updating error text

* fixing typo in variable name

* Update button content. Add untagging functionality

* adding anomaly detection delete job modal

* fix modal content bug

* refresh job map after deletion or untagging

* adding job refresh to anomaly detectors

* go straight to delete flow if only action available

* fixing test

* update text

* increase line spacing in check modal

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: James Gowdy <jgowdy@elastic.co>
2020-12-15 12:44:03 -05:00
Marco Liberati
9b71c94ff1
[Lens] Add datasource fields group help text (#85544)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 18:23:41 +01:00
Davis Plumlee
13e5e55901
[Security Solution][Detection Rules] Makes threat techniques optional (#85481) 2020-12-15 12:08:15 -05:00
Constance
07f395f7dd
Misc responsive tweaks to Documents view (#85440)
+ misc cleanup - extra div, true

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 09:02:12 -08:00
Jonathan Budzenski
507ae79ffe skip "without kibana index" suite. #85911 2020-12-15 10:36:35 -06:00
Jonathan Budzenski
e5c675cb61 skip find 'should return 200 with empty response. #85911' 2020-12-15 10:32:00 -06:00
Cauê Marcondes
04d4e71ff5
removing margin for sparkline charts (#85917) 2020-12-15 16:34:11 +01:00
Tiago Costa
47ffefec09
skip flaky suite (#85899) 2020-12-15 15:15:11 +00:00
Tiago Costa
81744dcf6b
skip flaky suite (#85911) 2020-12-15 15:05:39 +00:00
Tiago Costa
5fdace379c
skip flaky suite (#85714) 2020-12-15 15:02:26 +00:00
ymao1
853f30e23d
[Alerts] Remove Add Alerts flyout onClose (#85462)
* Remove add alerts flyout after onClose

* Updating tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Gidi Meir Morris <github@gidi.io>
2020-12-15 09:58:57 -05:00
Alison Goryachev
579ead8eaf
Handle multiple monaco editor instances for Painless lang (#85834) 2020-12-15 09:37:21 -05:00
Casper Hübertz
9ce6331ead
[APM] Increase Logstream height (#85913)
Increasing the component height for more optimal viewing experience.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 15:19:45 +01:00
Nicolas Chaulet
724b90e01b
[Fleet] Fix agent details logs on safari (#85884) 2020-12-15 09:10:17 -05:00
Steph Milovic
335cd1f6fc
[Security Solution] [Cases] Move field mappings from actions to cases (#84587) 2020-12-15 07:06:11 -07:00
Jonathan Buttner
d4a631cf8e
[Security Solution][Resolver] Fixing resolver functional tests (#85647)
* Fixing resolver functional tests

* Import the animation constant

* Only check specific nodes instead of all the ones in view

* Removing check for link text

* updating test description

* Adding comments
2020-12-15 08:31:59 -05:00