maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
37107 commits 329 branches 211 tags 6.1 GiB
Commit graph

11715 commits

Author SHA1 Message Date
John Schulz
302004df47
[Ingest Manager] Configure Elasticsearch output with YAML in global output settings (#79019) 
## Summary
YAML entered on the Settings page will be added to each Elastic Agent policy 

### Settings form
<img width="50%" alt="Screen Shot 2020-10-05 at 9 29 27 AM" src="https://user-images.githubusercontent.com/57655/95085934-daa20880-06ed-11eb-9f52-aab5d69666ad.png"><img width="50%" alt="Screen Shot 2020-10-05 at 9 29 58 AM" src="https://user-images.githubusercontent.com/57655/95085886-c9f19280-06ed-11eb-8c85-a56b330cee37.png">


### Policy screen
<img width="50%" alt="Screen Shot 2020-10-05 at 9 30 38 AM" src="https://user-images.githubusercontent.com/57655/95085889-ca8a2900-06ed-11eb-9cd7-b7590101a15d.png">


### Input Validation
<details><summary>Fails if the value cannot be parsed as YAML, but there are no restricted keys or other guidance</summary>

<img width="50%" alt="Screen Shot 2020-10-05 at 9 32 39 AM" src="https://user-images.githubusercontent.com/57655/95086469-877c8580-06ee-11eb-8189-d70413a0a5c9.png">

</details>

### Open questions
  1. Is "Additional YAML Configuration" ok for the form?
    * Will use "Elasticsearch output configuration"
  1. Alternatives to [`additional_yaml_config`](https://github.com/elastic/kibana/pull/79019/files#diff-d2cc0ddf9161efb6898baca37350c720) for the new saved object key
    * No comments on the name but will move it to the outputs saved object


### Checklist

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
 2020-10-06 18:02:44 -04:00
Nathan L Smith
68130dfd87
Re-enable canvas storyshots (#79750) 
* Only throw the error about building the DLL if we're not running in Jest
* Update existing storyshots
* Add Jest mock for Datasource story

All tests look to be passing and `yarn storybook canvas` works. I clicked through all the stories and it doesn't look like anything is broken.
 2020-10-06 16:59:56 -05:00
Tyler Smalley
92ce8f3040 skips test failing promotion (#79777) 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
 2020-10-06 14:54:30 -07:00
Nathan Reese
ab42ca2c64
[Maps] fix use correct mount-context (#79688) 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2020-10-06 15:48:50 -06:00
Bohdan Tsymbala
383a912f17
[SECURITY_SOLUTION] Reused the naming scheme for field column in conditions table. (#79722) 
* Reused the naming scheme for field column in conditions table.

* Updated snapshot.

* update Operator value to show as `is`

* Update Jest snapshot

Co-authored-by: Paul Tavares <paul.tavares@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2020-10-06 17:31:27 -04:00
Nicolas Chaulet
5853abc1ec
[Ingest Manager] Fix enrollment instructions missing args (#79730) 2020-10-06 17:20:50 -04:00
Thomas Neirynck
fd4eacd29f
[Maps] Enable geo-point for mvt scaling type (#79733) 2020-10-06 17:17:47 -04:00
Bohdan Tsymbala
0a713d3750
Fixed the grid view pagination. (#79717) 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2020-10-06 17:14:09 -04:00
Yuliia Naumenko
4996020087
[Alerting UI] Fixed flaky alerting e2e tests (#79533) 
* Removed skip on alerting e2e tests

* Reduced alerting tests execution time by removing page reload for each test. Added server side cleanup fo each test with createAlert. Removed long waiting toast method for reduce flakiness.

* Added additional cleanup and retry method for delete single alert
 2020-10-06 14:11:05 -07:00
Joe Portner
0a02ac1327
Rename namespaces to initialNamespaces for create operations (#79682) 2020-10-06 17:01:26 -04:00
Brent Kimmel
7068e96007
[Security Solution][Resolver] Pills can overflow to the right of their bounding boxes (#79734) 2020-10-06 16:42:29 -04:00
Ryland Herrick
a4a5393d1f
[Security Solution][Detections] Chore: Fix rule form warnings (#79590) 
* Prevent react warnings for unknown `isVisible` prop

Unknown config options ultimately become attributes on an anchor/button
element, so we need to not overload these config objects.

* Fix react warning about unknown `isDisabled` prop

There is no `isDisabled` prop on the underlying `EuiFieldText`
component, so we should use the native `disabled` attribute instead.

* Fix warning about switching between un-/controlled componenents

On the first few renders, our input refs have not been set while a
default value has, so the length of our values is 1 while our refs is 0.
This causes us to hit the 'else' condition of our ternary, leading to an
input with no value. When the ref is then populated, a value is
generated and so is the error.

The previous logic here was always evaluating to `value: item` and so was
simplified.

* Fix jest warning on unexpected state update

* removes unnecessary use of act()
* renders our component within the test
  * This allows our test to synchronize with react and prevents the
    warning; I suspect it has something to do with the scoping of
    `wrapper` or the `beforeEach` not being async, but I haven't had
    time to investigate.

* Remove unnecessary test guards

These tets no longer throw warnings.
 2020-10-06 15:38:26 -05:00
Constance
c9d2398572
Revert "Temporarily remove Layout from App Search plugin for 7.10 release (#79506)" (#79702) 
This reverts commit d5b8a95694.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2020-10-06 13:24:27 -07:00
John Schulz
76e8d15b86
[Ingest Manger] Agent Policy names are unique (#79201) 
## Summary
closes https://github.com/elastic/kibana/issues/71651

Agent Policy `name` values must be unique

These routes will return a 409 if a name is given which matches an existing agent policy

 * `POST /api/fleet/agent_policies`
 * `POST /api/fleet/agent_policies/{agentPolicyId}/copy`
 * `PUT /api/fleet/agent_policies/{agentPolicyId}`

`AgentPolicyService` members will throw `AgentPolicyNameExistsError` with id(s) of any existing policy/policies

### Checklist
[tests](bfea20049e/x-pack/test/ingest_manager_api_integration/apis/agent_policy/agent_policy.ts)
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
 2020-10-06 16:13:48 -04:00
John Schulz
b8d53fd5aa
[Ingest Manager] Use optional registryProxyUrl setting when contacting Registry (#78648) 
## Summary
If given a `xpack.fleet.registryProxyUrl` setting, Package Manager will use it when contacting the Registry. This only affects the outbound connection Package Manager makes to the Registry to search for available packages, download assets, etc.

### Configuration
<details><summary><strike>Initial PR: common environment variables</strike></summary>

<p>Currently the value must come from a <a href="https://github.com/Rob--W/proxy-from-env#environment-variables">list of popular environment variables</a> which include <code>ALL_PROXY</code>, <code>HTTPS_PROXY</code>, lowercase versions of those, and many more.</p>

<p>Start kibana with a proxy set in an environment variable like: <code>HTTPS_PROXY=https://localhost:8443 yarn start</code></p>

</details>

_update_ based on discussion in the comments, the initial environment variables approach was removed in favor of `xpack.ingestManager.registryProxyUrl`

#### see https://github.com/elastic/kibana/issues/78968 for additional configuration coming later

### Checklist
- [ ] ~~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials.~~ Created https://github.com/elastic/kibana/issues/78961 to track
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Created https://github.com/elastic/kibana/issues/78968 to track the additional configuration work

refs https://github.com/elastic/kibana/issues/70710
 2020-10-06 16:12:32 -04:00
Patryk Kopyciński
6f9f061e8e
[Security Solution] Update TLS fields used in drag-and-drop (#78815) 2020-10-06 22:06:49 +02:00
Tyler Smalley
c2409365de skip flaky suite (#79248) 2020-10-06 12:45:08 -07:00
Quynh Nguyen
478f587b5d
[ML] Fix feature importance decision path not showing up (#79679) 2020-10-06 14:12:41 -05:00
Dima Arnautov
827f0c06fe
[ML] Replace swim lane implementation with elastic-charts Heatmap (#79315) 
* [ML] replace swim lane vis

* [ML] update swimlane_container, add colors constant

* [ML] update swimlane_container, add colors constant

* [ML] update swimlane_container, add colors constant

* [ML] unfiltered label for Overall swim lane

* [ML] tooltip content

* [ML] fix styles, override legend styles

* [ML] hide timeline for overall swimlane on the Anomaly Explorer page

* [ML] remove explorer_swimlane component

* [ML] remove dragselect dependency

* [ML] fix types

* [ML] fix tooltips, change mask fill to white

* [ML] fix highlightedData

* [ML] maxLegendHeight, fix Y-axis tooltip

* [ML] clear selection

* [ML] dataTestSubj

* [ML] remove jest snapshot for explorer_swimlane

* [ML] handle empty string label, fix translation key

* [ML] better positioning for the loading indicator

* [ML] update elastic/charts version

* [ML] fix getFormattedSeverityScore and showSwimlane condition

* [ML] fix selector for functional test

* [ML] change the legend alignment

* [ML] update elastic charts
 2020-10-06 20:51:23 +02:00
Thomas Watson
e31ec7eb54
Give user the option to log out if they encounter a 403 (#75538) 2020-10-06 20:40:28 +02:00
Melissa Alvarez
4c65b6dda4
[ML] DF Analytics results view: ensure boolean values in charts shown without formatting (#78888) 
* add functional test for searchBar filters. remove boolean schema from datagrid

* always use string version of key for charts

* add schema back in for histogram label

* use ?? instead of || for undefined check
 2020-10-06 14:37:47 -04:00
Sandra Gonzales
68c6aa7409
Fixes Fleet API path (#79724) 2020-10-06 10:57:00 -07:00
Angela Chuang
8cab902482
[Security Solution] Update export timeline success message by exported timelines' type (#79469) 
* init tests

* fix export on success message

* add cypress tests

* fix unit tests

* fix unit tests

* Update x-pack/plugins/security_solution/public/timelines/components/timeline/pin/index.tsx

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
 2020-10-06 18:52:44 +01:00
Thomas Watson
8cae9ef25b
Handle errors better in spaces selector (#79471) 2020-10-06 19:43:07 +02:00
Dima Arnautov
3002108c40
[ML] rename inference to trained_models (#79676) 2020-10-06 19:31:59 +02:00
Shahzad
d845922a1a
[UX] Update url filter (#79497) 2020-10-06 19:29:41 +02:00
Melissa Alvarez
06f87bb838
[ML] DF Analytics creation wizard: resolve clone usability issues (#79048) 
* show error when clone fails due to no index pattern

* default results_field unless specified

* results field switch set to on if resultsField for cloned job is default

* ensure cloned job config not overwritten in advanced editor

* show errorToast if unable to clone anomalyDetection job due to no indexPattern

* ensure jobConfig query getting saved in form state

* ensure index patterns with commas handled correctly

* clone should accept comma separated index patterns

* use nullish coalescing operator when checking for undefined analysisFields
 2020-10-06 13:29:16 -04:00
Christos Nasikas
287541891e
[Security Solutions][Case] Settings per case per connector (#77327) 
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2020-10-06 20:03:46 +03:00
Mikhail Shustov
cc7ac29622
more aggressive lazy loading for ingest_manager (#79633) 
* slim ingest_manager

* revert registerPackagePolicyComponent export
 2020-10-06 18:57:30 +02:00
Jen Huang
e8edd5e5c1
#78037 Fix Fleet<=>Endpoint loop when Fleet isn't set up (#79564) 2020-10-06 09:52:01 -07:00
Gidi Meir Morris
25c5daa83a
Renames "Built-In Alerts" feature to "Stack Alerts" and "Actions" feature to "Actions and Connectors" (#79513) 
Renames "Built-In Alerts" feature to "Stack Alerts" and "Actions" feature to "Actions and Connectors" as we've decided these names make more appropriate and better communicate what these features are.
 2020-10-06 17:51:05 +01:00
Shahzad
edbf6b8ce9
[UX] Fixed error rate, made sure all filters are applied (#79222) 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2020-10-06 18:48:35 +02:00
Shahzad
ce2269031a
[UX] Fix long task format (#79509) 2020-10-06 18:46:18 +02:00
Quynh Nguyen
445a7908c1
[ML] Add summary call out to total feature importance if it's empty (#79546) 2020-10-06 11:40:39 -05:00
Melissa Alvarez
5cc8b9bf52
[Transform] Check for source indexPattern before opening clone wizard (#79383) 
* check for source indexPattern before opening clone wizard

* update translations

* update jest test

* move mocks to mock directory
 2020-10-06 12:22:04 -04:00
Tim Sullivan
46e1c5b0f9
[Reporting/Usage] Unskip failing test (#79172) 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2020-10-06 09:18:29 -07:00
Catherine Liu
63b76f2cd5
[Core UI] Kibana Overview Page (#75827) 
* Added kibana landing page

Created kivana_overview plugin

Removed test from home plugin

Added CSS

Fixed page header links

Added news feed

Fixed spacers between news items

[Core UI] Kibana Overview Page Style Tweaks (#76712)

Fixed link to index management

Added solution cards to kibana landing page

Added solution links

Fixed ts errors

Using publishReplay() to support multiple consumers in newsfeed plugin

Added createNewsFeed$ to newsfeed plugin start

Added tests

Removed unnecessary export

Hides overview link when other Kibana apps are not available

Added icon to overview plugin

Removed question mark from news feed title

Updated plugin-list

Fixed i18n errors

Revert snapshot

Updated getting started page copy

Hide news feed when no news feed results

Disables Kibana overview page when kibana apps are unavailable

Updated snapshots

Refactor to use KibanaContextProvider

Fixed security tests

Fixed newsfeed api test

Moved overview_footer and overview_header to kibana-react plugin

[Core UI] Kibana Overview Page Style Fixes (#78677)

* Fixed a11y issues

* Made newsfeed optional dep of kibana overview plugin

* Removed duplicate license copy

* Fixed management security test

* Added toast to change default route button

* Updated snapshots

* Simplified toast notification

* Fixed i18n error

* Assigned kibana_overview plugin to Core UI in CODEOWNERS

* Updated snapshots

* Fix import

* [Core UI] Kibana Overview Page Style Fixes, Part 3 (#78970)

* fix overview cards not stretching height equally

* change var name for better specificity

* [Core UI] Kibana Overview Page Style Fixes, Part 4 (#79136)

* Adds support for all newsfeed plugin config settings in createNewsFeed$

* Fixed type

* Updated kibana overview page route

* Fixed imports in page_footer and page_header

* Update Kibana overview graphics (#79534)

* Updated snapshots

* Updated snapshots

* Changes newsfeed endpoint to kibana analytics in kibana_overview plugin

* Renamed components

* Fixed overview page footer and header component class names

* Removed extraneous files

* Fixed import

* Replaced SVGs with optimized SVGs

* Fixed header and footer in home and kibana overview pages

* Updated snapshots

* Changed url_forwarding plugin appRoute

* Fixed aria-labelledby value

* Updated snapshots

* Added base paths

Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
 2020-10-06 09:13:31 -07:00
Nathan Reese
d9ca4c562e
[ML] avoid full page reload for links following CSV import (#79539) 
* [ML] avoid full page reload for links following CSV import

* cleanup

* review feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
 2020-10-06 10:09:58 -06:00
Nicolas Chaulet
c355dfebab
[Ingest Manager] Move config from xpack.ingestManager to xpack.fleet (#79406) 2020-10-06 11:58:09 -04:00
Wylie Conlon
2de2c70f75
[Lens] Break long titles into multiple lines (#79580) 2020-10-06 11:50:44 -04:00
Brent Kimmel
55af3285dc
Remove backdrop blur: visual regression (#79668) 2020-10-06 11:43:11 -04:00
Patrick Mueller
6b80eb20ab
[Actions] write action executor errors to the Kibana log (#79474) 
resolves https://github.com/elastic/kibana/issues/72058

Finally, we're logging the action executor error responses to the Kibana log.
We have not been doing this previously, out of an abundance of caution.  The
message written may contain data returned from a 3rd party service call, and
we weren't sure this would be "safe" to log, in a PII sense.

After several minor releases, and seeing these service messages in the event
log for almost all the built-in action types, we've decided they are "safe" and
it's time to add them, as they provide some **very** helpful diagnostic
feedback to customers.
 2020-10-06 11:40:35 -04:00
Constance
f530dc8574
[proposal] Groups breadcrumb updates (#79551) 
+ move chrome related settings to router pages
+ pull out i18n constants

Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
 2020-10-06 08:38:48 -07:00
Nathan L Smith
bfa704d6ff
Remove APM stacktrace snapshots (#79543) 
* Remove APM stacktrace snapshots

These are not necessary and have caused problems for other contributors. Replace the snapshots with tests that check for errors or the structure of the results.

Move the test files out of the __test__ directory and rename the directory to __fixtures__.
 2020-10-06 10:22:50 -05:00
Bohdan Tsymbala
f340d71377
[SECURITY_SOLUTION][ENDPOINT] Grid view for trusted apps. (#79485) 
* Refactored store code to group properties related to location so that would be easy to introduce a new view type parameter.

* Added view type to the location and routing.

* Added a simple hook to make navigation easier.

* Improved the navigation hook to get params.

* Some fix for double notification after creating trusted app.

* Added a hook to perform trusted app store actions.

* Fixed trusted app card delete callback.

* Added grid view.

* Fixed the stories structuring.

* Shared more logic between grid and list.

* Finalized the grid view.

* Flattened the props.

* Improved memoization.

* Moved the flex item elements inside conditions.

* Fixed broken stories.

* Updated the snapshot.

* Updated the snapshot.
 2020-10-06 17:18:30 +02:00
Joe Reuter
11886bf51c
[Lens] Add search to chart switcher (#77631) 2020-10-06 17:17:41 +02:00
Sonja Krause-Harder
4d58a0041e
Add license check to direct package upload handler. (#79653) 2020-10-06 16:46:26 +02:00
Nicolas Chaulet
4a160bff80
[Ingest Manager] Rename API /api/ingest_manager => /api/fleet (#79193) 2020-10-06 10:30:21 -04:00
Michael Olorunnisola
aeba4011e2
[Security Solution][Resolver] Simplify CopyableField styling and add comments (#79594) 2020-10-06 10:26:06 -04:00
István Zoltán Szabó
b7057bc274
Fine-tunes ML related text on Metrics UI (#79425) 
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
 2020-10-06 16:25:08 +02:00