Commit graph

29256 commits

Author SHA1 Message Date
Spencer
3c55e55b7a
[failed_tests_cli] update reports with links to github issues (#52048)
* [failed_tests_cli] update reports with links to github issues

* reorder test report hooks so that published Junit includes modified reports

* force failures and enable dry-run mode for debugging

* auto-switch to --dry-run when running in non-tracked branches/prs

* add --skip-junit-update flag to skip mutating the reports

* remove comma after URL to support auto-linking in Jenkins

* Revert "force failures and enable dry-run mode for debugging"

This reverts commit ac0c287a3f.

* fix method call

* extend TestResult to include relevence flag rather than wrapping

* fix createFailureIssue() tests

* make report messages more consistent, append when not dry-run

* rename module

* update snapshots to not contain valid xml

* don't send authorization header if no token defined

* merge with master modified fixtures
2019-12-05 08:46:27 -07:00
Brandon Kobel
d4f604783f
Fix elasticsearch.ssl.alwaysPresentCertificate default (#52242)
* Fixing the default for elasticsearch.ssl.alwaysPresentCertificate

* Updating snapshot
2019-12-05 09:51:16 -05:00
Victor Martinez
9ee67fb6a1
ci(jenkins): enable APM UI e2e tests (#48109) 2019-12-05 13:55:43 +00:00
Søren Louv-Jansen
47dcf87e79
[APM] Quick fix for ACM to ensure more than 10 items are displayed (#52262)
* [APM] Quick fix for ACM to ensure more than 10 items are displayed

* Fix snapshot
2019-12-05 14:46:42 +01:00
Thomas Watson
fb4a6aa21a
Add example apm.dev.js config file to CONTRIBUTING.md (#52206) 2019-12-05 14:45:44 +01:00
Ahmad Bamieh
9fe302cf17
[Cloud] move cloud plugin to np (#51789)
* move cloud dir to plugins from legacy

* first iteration moving to NP

* config as observable

* finish plugin

* migrate xpack.cloud.apm.*

* self code review

* remove unused lodash get

* use lodash get to get configs

* export SerializedDatatable

* eslint fix

* eslint fix

* fix setup type

* fix monitoring tests

* fix test mock function

* resolve ELASTIC_SUPPORT_LINK in core

* running check_core_api_changes script

* review feedback

* mock setHelpSupportUrl

* update snapshots
2019-12-05 08:20:28 -05:00
Shahzad
a096254eb7
[Uptime] Expanded list update most recent error timestamp (#51935)
* update most recent error timestamo

* update snaps

* update snap
2019-12-05 14:14:27 +01:00
Shahzad
c40a3b0e17
[Uptime] Fix/issue 116 fix monitor list pageination arrows (#51912)
* fix pagination arrows for smaller screens

* updated arrow color

* make pagingationa arrow sizing consisten
2019-12-05 14:01:40 +01:00
Anton Dosov
2ffc698a9b
[State Management] Move HashedItemStore to kibana_utils plugin. Make it stateless on memory level. (#52172)
HashedItemStore was also moved to the kibana_utils plugin
2019-12-05 13:32:20 +01:00
Shahzad
abaf0099d0
[Uptime] Added eui spacers around callout in expanded row (#51843)
* added eui spacers around callout

* updated snaps
2019-12-05 12:03:28 +01:00
Alejandro Fernández Haro
bd3857a79b
[NP] Expose global config to the plugins (#51478)
* [NP] Expose global config to the plugins

* globalConfig in Plugin context: expose read-only methods only

* SharedGlobalConfig rework + Moving pkg, fromRoot & path utils from legacy to NP

* Updated API docs

* Fix test references to the moved utils

* Replace zip with combineLatest

* Change tests to describe/it + remove "(deprecated)" from the test description

* Moving path files to a folder + exposing the config path in the contract

* deepFreeze the globalConfig in the pluginContext

* Fix types in tests with new path.config

* Move fromRoot and package_json utils to core/server/utils

* Rename globalConfig to legacy.globalConfig$

* path.config renamed to path.configDir (not renaming path.data because it might be a breaking change)

* Change configDir in mocker as well

* Fix test after config renamed to configDir

* Fix API docs conflicts

* Rename the path properties when exposing them

* path.configDir removed from the path config-schema

* Remove path.configDir. It is already in env.configs

* Add Migration documentation and examples

* Fix 'kibana/server' imports in the MIGRATION docs
2019-12-05 10:25:32 +00:00
Garrett Spong
f21d5ada5a
[SIEM] Adds Signals Table and additional configuration options to StatefulEventsViewer (#52044)
## Summary

This is `Part I` of `II` for adding the `Signals Table` to the main Detection Engine landing page ([meta issue](https://github.com/elastic/kibana/issues/50405)). Breaking into two parts as this contains additional configuration options to the `StatefulEventsViewer` which will be used as part of https://github.com/elastic/kibana/issues/51016.

`Part I` includes:
* `SignalsTable` component that displays signals from the default signals index `.siem-signals`
* Refactors `StatefulEventsViewer` to use `useFetchIndexPatterns` hook instead of `WithSource`
* Adds ability to specify `alias` to `ColumnHeader` when providing column names
* Adds the following new props to `StatefulEventsViewer`
  * `defaultIndices?: string[]` -- for specifying a different index than `siemDefaultIndex`
  * `headerFilterGroup?: React.ReactNode` -- for providing a component to display in the top right of the table (e.g. filter buttons, select, etc.)
  * `timelineTypeContext?: TimelineTypeContextProps` -- config for when creating a new table
    * `documentType?: string` -- user string for type of records displayed (e.g. Signals)
    * `footerText?: string` -- custom footer text for given document type
    * `showCheckboxes: boolean` -- whether or not to show selection checkboxes
    * `showRowRenderers: boolean` -- whether or not to show row renderers
    * `timelineType: TimelineType` -- type of Timeline for setting default columns
    * `title?: string` -- optional custom title
  * `utilityBar?: (totalCount: number) => React.ReactNode` -- optional param for providing your own custom `UtilityBar` instead of using the default `Showing xxx events`.

`Part II` will add support for selection and overflow/batch actions.

<img width="1548" alt="Screen Shot 2019-12-02 at 19 59 34" src="https://user-images.githubusercontent.com/2946766/70016801-89aa0c80-153e-11ea-9dbf-b7b8648fb260.png">

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
  * Note: some placeholders were moved to their own files, and so some raw strings will still exist
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-12-04 23:11:58 -07:00
Michail Yasonik
e8f3fa91d9
Updating accessibility guide and contributing readmes (#52038)
* updating accessibility guide and contributing readmes

* updating dev docs
2019-12-04 19:11:16 -06:00
Phillip Burch
0603ae6ca9
Don't allow duplicate saved views with the same name (#52040)
* Don't allow duplicate saved views with the same name

* Change logic to make it a little easier to reason about

* Change error names
2019-12-04 17:44:51 -06:00
Patrick Mueller
66c7ae6eb4
Whitelist email server in built-in email server action - second try (#52221)
resolves https://github.com/elastic/kibana/issues/50721

note this branch was previously merged into master and then reverted: https://github.com/elastic/kibana/pull/51489 (prior PR made shape changes this one didn't take into account)

Uses the same whitelist config value / utilities that the webhook
action already uses. Was already mentioned in the README doc
that email uses this whitelist config value :-)

Required a change to the functional tests to use a host already
whitelisted in config, made for the the webhook action tests.

Also realized some jest tests on email were bogus, so fixed those
(was passing `user` in config, which is invalid, and masking the
actual thing being tested).
2019-12-04 16:08:29 -05:00
Phillip Burch
a74a129b26
[Metrics-UI] Port graphql query for snapshot and node details to hapijs (#50730)
* Port graphql query for snapshot to hapijs

* fix type

* Remove graphql from node details.

* Use boom for error handling.

* Remove unused imports

* Remove dead code. Merge types

* Fix tests

* Remove unused import

* Rename types

* Go all in on io-ts. Cleanup types

* Fix typecheck
2019-12-04 14:32:38 -06:00
Lisa Cawley
04ec9a231a
Fixes outdated URLs (#52104) 2019-12-04 10:54:14 -08:00
Poff Poffenberger
91df8c0733
Move new Code Editor component to kibana_react so it can be used through Kibana (#45914) 2019-12-04 12:53:42 -06:00
Mike Côté
98060ef790
Remove index pattern requirement when doing a nested query in KQL (#52023) 2019-12-04 13:34:28 -05:00
spalger
bd41b83c18 skip flaky suite (#40670) 2019-12-04 11:25:13 -07:00
spalger
7d14c90f8d Revert "Whitelist email server in built-in email server action (#51489)"
This reverts commit 4ce703e409.
2019-12-04 11:04:10 -07:00
Xavier Mouligneau
b0c5aa9ff0
add validation for nested filter in find API (#51847) 2019-12-04 12:59:22 -05:00
Catherine Liu
6f7dfebcba
[Canvas] Fixes axisConfig position argument UI (#50717) 2019-12-04 10:44:32 -07:00
Devin W. Hurley
3d661c12fb
[SIEM] [Detection Engine] updates shape of mitre attack threats when creating / updating detection engine rules (#52200) 2019-12-04 12:14:18 -05:00
Aaron Caldwell
b001e70e2a
[Maps] Add basic NP shim to Maps app and expose map config (#51683)
* Move plugin init calls to new plugin file, update refs and bind to legacy var. Assume ref for license init

* Bind server calls to __LEGACY var and pass to plugin setup

* Expose map config externally

* Pass in NP features and licensing plugins to replace some xpack_main functionality

* Pass through legacy server config for routes dependency

* Expose map config for legacy plugins

* Remove unused legacy refs

* Update license check to conform with latest NP license practices

* Clean up

* Revert to old license check. Handle NP license checking in separate PR

* Add back the license check file
2019-12-04 10:04:56 -07:00
Mikhail Shustov
b6ba8ca30f
add links to plugin manifest file format. add naming conventions (#51280)
* add links to plugin manifest format

* remove obsolete comment

* address comments. add registry folder to file structure tree

* revert back not confirmed conventions
2019-12-04 17:41:36 +01:00
Robert Oskamp
21edc28ed3
[ML] Add functional tests for analytics UI (#52054)
This PR adds functional UI tests for outlier detection and regression job creation.
2019-12-04 17:20:38 +01:00
Patrick Mueller
4ce703e409
Whitelist email server in built-in email server action (#51489)
resolves https://github.com/elastic/kibana/issues/50721

Uses the same whitelist config value / utilities that the webhook
action already uses. Was already mentioned in the README doc
that email uses this whitelist config value :-)

Required a change to the functional tests to use a host already
whitelisted in config, made for the the webhook action tests.

Also realized some jest tests on email were bogus, so fixed those
(was passing `user` in config, which is invalid, and masking the
actual thing being tested).
2019-12-04 10:30:42 -05:00
Stacey Gammon
4a9d77fd10
Add a section on naming conventions for Start and Setup (#51676) 2019-12-04 10:29:02 -05:00
CJ Cenizal
ffdd392222
Silence Axe's complaints about missing labels for Console's textarea elements, in order to allow our automated a11y tests to pass. (#52150) 2019-12-04 07:19:39 -08:00
Thomas Watson
43b97d8a05
Clean up uses of deprecated API's in node core (#51431)
Ensure no deprecated Node.js core API's are used in Kibana. This is
achieved by throwing an error in either development mode or in CI if one
of the deprecated API's is called, and as such, new PR's should no
longer be able to be merged if they use deprecated API's.

Some of these API's (like the `Buffer` constructor`) is a security risk.
2019-12-04 16:17:19 +01:00
Melissa Alvarez
686afd7ce0
[ML] DF Analytics: create classification jobs via the UI (#51619)
* wip: classification job config in form

* ability to create classification job in form + validation

* ensure classification types are correct for validation

* update reducer test to include jobType validity check

* update analytics jobs help text

* update newJobCapsService to support boolean fields
2019-12-04 08:04:10 -07:00
Dmitry Lemeshko
57865e43ad
Functional tests: elastic chart provider (#52085)
* adding elastic-chart service

* update visual test
2019-12-04 15:24:42 +01:00
Thomas Watson
95e5edd9c4
Instrument Kibana with Elastic APM (#43548)
Instruments Kibana with Elastic APM by adding the Node.js agent to the
source code. The agent is not turned on by default but can be enabled by
setting the environment variable `ELASTIC_APM_ACTIVE=true` or by
creating an apm config file called `config/apm.dev.js` and setting
`active: true` inside of it.

This implementation is not meant to be used by end-users of Kibana as it
lacks integration with the regular Kibana config file. For now, this is
meant as a useful internal tool for Elastic employees when developing
Kibana.

By default, it's pre-configured with a `serverUrl` pointing to an APM
Server hosted on Elastic Cloud. The data is stored in an ES cluster
accessible only by Elastic employees. These defaults can easily be
overwritten using environment variables or via the custom config file.
2019-12-04 15:21:07 +01:00
Vadim Dalecky
73651a1b28
Disabled actions (#51975)
* feat: disable actions from SIEM by using `disabledActions` list

* feat: filter out actions specified in `disabledActions` input prop

* test: 💍 remove legacy test

* chore: 🤖 remove unused import

* test: 💍 add disabledActions prop tests
2019-12-04 05:59:53 -08:00
Søren Louv-Jansen
085a2af8ec
[APM] Fix failing ACM integration test (#52149) 2019-12-04 14:55:41 +01:00
Alison Goryachev
f188c26111
[SR] Support for SLM on Cloud (#51000) 2019-12-04 08:49:10 -05:00
Chris Davies
8cae172f02
[Lens] Make Lens plugin registry signatures consistent (#51839) 2019-12-04 08:36:21 -05:00
Chris Davies
529dcbbe30
[Lens] Remove unused datasource methods (#51840)
* Remove unused datasource methods

* Remove unused function
2019-12-04 08:36:07 -05:00
Dima Arnautov
d421964b13
[ML] Perform cardinality check on enabling the model plot (#51915)
* [ML] add a callout

* [ML] reactive validateCardinality$

* [ML] change check to analysis_config

* [ML] change comment

* [ML] WIP check cardinality in job validator

* [ML] refactor to use jobValidatorUpdated

* [ML] rename vars

* [ML] rename config fields

* [ML] improve stream to cache and compare only analysis_config

* [ML] simplify jobCreator subject

* [ML] remove condition from effect

* [ML] PR remarks
2019-12-04 14:33:22 +01:00
Cauê Marcondes
1240d02c9d
[APM] Make it possible to link directly to a trace with just the trace.id (#51450)
* create new api to fetch root transaction by trace id

* redirecting trace to transaction

* redirecting trace to transaction

* redirecting trace to transaction

* testing external link

* testing external link

* testing external link

* testing external link

* changing route name

* refactoring

* refactoring

* refactoring

* fixing merge conflicts

* adding rangeFrom and to, into the url query param

* removing convertedValue from duration formatter

* refactoring ES query and tracelink component

* pr comments

* refactoring link
2019-12-04 14:08:48 +01:00
Søren Louv-Jansen
ec25343c3c
[APM] Improve formatting in readme 2019-12-04 13:36:00 +01:00
Søren Louv-Jansen
2c669e7c2e
Add Kibana Security setup to readme 2019-12-04 13:32:13 +01:00
Søren Louv-Jansen
b9e2895f22
[APM] Add support for basepath (#52162) 2019-12-04 13:27:26 +01:00
Dima Arnautov
37d1a8e057
[ML] Fix search for Transforms and Analytics tables (#52163)
* [ML] fix TransformTable init

* [ML] fix Analytics table
2019-12-04 13:26:02 +01:00
Rudolf Meijering
7f4bdb2d57
static createRepository factory function (#52056)
* static createRepository factory function

* Fix API docs after master merge
2019-12-04 13:15:37 +01:00
Anton Dosov
c887c42cbf
[Reporting/Visualisation] DOM attributes for reporting integration are missing (#52109) 2019-12-04 13:11:50 +01:00
Anton Dosov
217608d11e
[State Management] Typescripify, jestify, simplify state_hashing and state_storage (#51835)
The hashUrl and unhashUrl functions no longer rely on states being provided as an argument, therefore getUnhashableStates/getUnhashableStatesProvider have been removed.
2019-12-04 12:36:03 +01:00
Søren Louv-Jansen
7ce0a37e3e [APM] await promise in setup script 2019-12-04 09:36:37 +01:00
spalger
a60b557c4d skip flaky test (#43938) 2019-12-04 00:02:41 -07:00