Commit graph

32400 commits

Author SHA1 Message Date
Dmitry Lemeshko 50228df498
Code coverage: run more configs with functional tests (#63680)
* run endpoint tests with coverage

* add more configs

* add plugin_functional config
2020-04-16 20:40:55 +03:00
Larry Gregory d0b4ae7e29
Allow reserved privileges to get their capabilities (#63698) 2020-04-16 12:29:31 -04:00
Alexey Antonov 871f7209f9
[Timeseries] remove unused configuration properties (#62543)
* [Timeseries] remove unused configuration properties

* Fix PR comments

* update id of vis_type_timeseries plugin

* metrics -> vis_type_timeseries

* fix wrong plugin id

* update requiredPliugins for infra/kibana.json

* change id

* update plugin id in infra folder

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 19:28:04 +03:00
Dmitry Lemeshko 464a3c23ba
[FTR]: add chromium-based Edge browser support (#63566) 2020-04-16 19:06:33 +03:00
Daniil Suleiman 6bbcabcf1f
[NP] Visualize (#62294)
* Move visualize plugin to np

* Refactor plugin services

* Clean up

* Remove legacy style usage

* Fix style imports

* Fix timelion_options context provider

* Fix translations

* Change codeowners for visualize

* Import styles in legacy for BWC in Browser tests

* Get rid of embeddable dependency

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 18:32:46 +03:00
Maryia Lapata bae2bda7d4
[NP] Migrate Markdown to NP (#62940)
* Migrate Markdown to NP

* Refactoring

* Add ConfigSchema, server, rename markdown_vis to visTypeMarkdown

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 18:32:07 +03:00
Devin W. Hurley ebcb50227a
[SIEM] [Detection Engine] Changes find_statuses route HTTP met… (#63508)
* changes http method for find_statuses route from GET to POST

* fix test string formatting

* update sample shell script for find statuses route

* adds e2e test for find statuses
2020-04-16 10:52:43 -04:00
Devon Thomson 4b7895a8de
Fixed 0s not being checked for duplicates correctly (#63632)
Fixes duplicate 0 values being allowed in the visualize percentiles input.
2020-04-16 10:41:57 -04:00
Yuliia Naumenko 560e01a38f
[Alerting] Fixed issue when connectors dropdown not showing all available connectors (#63636) 2020-04-16 07:39:35 -07:00
Wylie Conlon 13422b8c91
[Lens] Make average the default suggested metric (#63416)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 10:34:24 -04:00
Wylie Conlon c21cec7abd
[Lens] Fix escaping of field names (#63509)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 10:32:58 -04:00
Mikhail Shustov af09fedaf2
[NP] add http resources sub-service (#61797)
* add HttpResources basic implementation

* expose http resources to plugins

* add mocks

* move http resources to a separate service

* hide rendering service

* adopt internal types

* expose HttpResources service to plugins

* update platform mocks

* plugins start using HttpResources API

* remove RenderingServiceSetup export

* RenderingServiceSetup --> InternalRenderingServiceSetup

* improve types

* remove httpRespources leftovers from http service

* remove rendering types from RequestHanlderContext

* fix security plugin tests

* add unit tests for httpResources service

* add unit tests

* remove outdated cache-control header

* restructure http resources service

* merge getUiPlugins and discover

* static route declaration shouldnt require auth & validate

* update docs

* use HttpResources service instad of rendering

* address comments

* update docs

* roll back unnecessary changes

* use getVars for rendering

* dont pass app. it is not public API

* remove static registers

* update migration guide
2020-04-16 16:09:39 +02:00
Frank Hassanabad 721e4fae1b
[SIEM][Detection Engine] Adds an error aggregator by error reason and a way to filter them
## Summary

Changes the error handling for when responses are returning with errors from the backend. We were aggregating on error status codes, but this will aggregate on the error reason per rule run and report those instead.

* Adds a utility function
* Adds unit tests for the utility function
* Adds TypeScript Types for the utility function
* Adds sample helpers for the mocks for testing 

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-04-16 08:04:23 -06:00
Tim Roes fdc962f348
Remove duplicate refresh button from vis editor menu (#63633)
* Remove the refresh button from vis editor

* Remove unused translations
2020-04-16 15:22:07 +02:00
Ryan Keairns 373d49223a
Style dashboard buttons the same way (#63403)
* Stylize dashboard buttons the same way

* update snapshots

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 07:54:06 -05:00
Aaron Caldwell 11b6f7fc7d
[Maps] Update remaining client dependencies to NP (#63297)
* Routes dependencies updated (except for routes itself)

* Replace all chrome deps except map controller

* Replace npSetup and npStart with normal plugin init logic. Some clean up

* Bind kibana services in map controller

* Use kibana services in map controller

* Convert remaining deps that aren't critical to legacy operation

* Remove last angular bindings to gis map saved object loader

* Consolidate kibana services in NP

* Some fixes. Remove console logs

* Fix type errors

* Fix jest test path refs

* Accomodate legacy 'hacks' and init services for vis type alias

* Review feedback. Remove/update unused declarations

* getFileUpload actually just needed Component tacked on the end

* Handle visibility of toolbars for full screen mode using new core chrome. Should fix test

* Import source types in getInitialLayers to ensure registry
2020-04-16 05:49:53 -06:00
Shahzad a3f4acfc27
[Uptime] Update duration chart query filters (#63620)
* updated duration query

* updated snapshot

* update fixtures

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 13:48:34 +02:00
Matthias Wilhelm 5ffdeb62e0
Migrate vis_type_metric to kibana/new platform (#63096)
* Move vis_type_metric to Kibana Platform

* Adapt i18n

* Cleanup tests

* Modify CODEOWNERS

* Cleanup SCSS
2020-04-16 13:46:23 +02:00
Shahzad d20cbcb903
[Uptime] Update-paths-labeller-with-uptime (#63679)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 12:37:54 +02:00
Ahmad Bamieh 188ebe8e2c
[i18n] Update CODEOWNERS (#63354)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 12:55:22 +03:00
Mikhail Shustov f18aea5dce
add platform team definition of done (#59993)
* add platform team definition of done

* add link to ToC

* add suggestions from Josh

* add tooling

* add testing note
2020-04-16 11:53:51 +02:00
Angela Chuang 7b74aa9d69
[SIEM] move away from Joi for importing/exporting timeline (#62125)
* move away from joi

* update schema for filterQuery

* fix types

* update schemas

* remove boom

* remove redundant params

* reuse utils from case

* update schemas for query params and body

* fix types

* update validation schema

* fix unit test

* update description for test cases

* remove import from case

* lifting common libs

* fix dependency

* lifting validation builder function

* add unit test

* fix for code review

* reve comments

* rename common utils

* fix types
2020-04-16 10:17:15 +01:00
Joe Reuter 02cba10469
Fix discover preserve url (#63580) 2020-04-16 09:51:03 +02:00
Gidi Meir Morris bb9f8845ae
[alerting] Adds an alertServices mock and uses it in siem, monitoring and uptime (#63489)
Work on #61313 has revealed that we don't have amock for AlertServices, which creates coupling between us and any solution depending on us, which makes it harder to make changes in our own code.

This PR adds mocks and uses them in SIEM, Monitoring and Uptime, so that we can make future changes without having to change outside solutions.
2020-04-16 08:45:38 +01:00
Oliver Gupte 3ade2d358d
Closes #63109 for Service Map by resetting edges styles for the selected node (#63655) 2020-04-16 00:42:25 -07:00
Uladzislau Lasitsa ee1cebdbe1
MIgrated index_header to react (#63490) 2020-04-16 10:36:09 +03:00
Uladzislau Lasitsa ce9c6e258a
Index pattern management UI -> TypeScript and New Platform Ready (indexed_fields_table) (#63364)
* MIgrated indexed_fields_table to typescript.

* Updated docs

* Fixed comments

* Fixed types
2020-04-16 10:32:28 +03:00
Steph Milovic 31ed266d73
[SIEM] [Cases] Insert timeline and reporters/tags in table bug fixes (#63642) 2020-04-16 00:53:22 -06:00
Tim Sullivan 3d41ca6d27
[Reporting] Make usable default element positions (#63191)
* [Reporting] Make usable default element posistions

* revert unrelated changes

* fix ts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-15 17:00:56 -07:00
Tim Sullivan f4c81b440d
[Reporting] Switch Serverside Config Wrapper to NP (#62500)
* New config

* fix translations json

* add csv.useByteOrderMarkEncoding to schema

* imports cleanup

* restore "get default chromium sandbox disabled" functionality

* integrate getDefaultChromiumSandboxDisabled

* fix tests

* --wip-- [skip ci]

* add more schema tests

* diff prettiness

* trash legacy files that moved to NP

* create_config tests

* Hoist create_config

* better disableSandbox tests

* fix ts

* fix export

* fix bad code

* make comments better

* fix i18n

* comment

* automatically setting... logs

* replace log_configuration

* fix lint

* This is f2

* improve startup log about sandbox info

* update docs with log reference

* revert log removal

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-15 14:52:32 -07:00
Tim Sullivan 23e3f1aab5
[Reporting] Add "warning" status as an alternate type of completed job (#63498)
* [Reporting] Add "warning" as a status

* test

* fix warning status handling

* Simplify logic

* fix syntax

* more different statuses

* fix warning

* feedbacks
2020-04-15 14:05:19 -07:00
Mike Côté 6c670b77f8
Split action types into own page (#63516)
* Split action types into own page

* Update docs/user/alerting/action-types.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Apply changes based on feedback

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2020-04-15 15:54:36 -04:00
Wylie Conlon ac549ac6f5
[Lens] Only show copy on save for previously saved docs (#63535)
* [Lens] Only show copy on save for previously saved docs

* Update app.test.tsx

import after kibana platform changes

Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
2020-04-15 14:57:44 -04:00
Stacey Gammon 716211f2db
Update README.md (#63622) 2020-04-15 14:12:14 -04:00
Anton Dosov c57297c95b
Bugfix clear saved query crashes kibana on Discover in some cases (#63554)
* actual hotfix

* clean up redundant code

* add functional test
2020-04-15 19:55:43 +02:00
Justin Kambic b670851422
Add uptime CODEOWNER entries. (#63616) 2020-04-15 12:48:16 -04:00
Dima Arnautov 7058070e15
[ML] Extract apiDoc params from the schema definitions (#62933)
* [ML] WIP apiDoc schema extractor

* [ML] extract actual type

* [ML] refactor schema definitions

* [ML] Update README.md

* [ML] extract nested

* [ML] call job validation endpoint with complete payload

* [ML] escape special chars and fix line breaks

* [ML] clean up extractDocEntries

* [ML] serializeWithType

* [ML] add missing annotations

* [ML] fix parent schema assigment

* [ML] support object composition

* [ML] support multiple schemas per block

* [ML] fix for collections

* [ML] fix calendarIdsSchema

* [ML] add ml package.json with apidoc commands

* [ML] use the single output markdown file

* [ML] fix typo

* [ML] change the Calendars order

* [ML] adjust the order in adidoc.json

* [ML] update api version

* [ML] update tsconfig.json include

* [ML] update packages/kbn-pm/dist/index.js

* [ML] update ML overrides in .eslintrc.js

* [ML] yarn.lock symlink

* Revert "[ML] yarn.lock symlink"

This reverts commit 07f06801

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-15 18:40:34 +02:00
Mike Côté e44cf28c98
Fix alerting documentation encryption key requirement (#63512)
* Fix documentation to indicate encryption key config required regardless if security is used or not

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2020-04-15 12:19:15 -04:00
Tim Roes 99332b8a6e
Fix CODEOWNERS and sass lint paths (#63552) 2020-04-15 17:52:21 +02:00
Robert Austin 08aa214190
Endpoint: Redux types (#63413)
## Summary

Changes some types around so modifying redux state or actions will cause type errors

* the state and action types aren't using `Immutable` directly. This means that you can instantiate them and mutate them
* the `state` and `action` params received by all reducers will be automatically cast to `Immutable`
* reducers can return either `Immutable` or regular versions of `state`
* some code may be mutating redux state directly, this is being ignored (at least for now)
2020-04-15 11:19:46 -04:00
Mike Côté bb0d03fe11
Fix alerting UI flaky tests (#62817)
* Use of testSubjects.setValue

* Add waitForEditAlertFlyout

* Fix some extra flakiness

* Test half second sleep to confirm cause of flakiness

* Revert 02417961f9

* Try clearWithKeyboard

* Fix test failures

* Fix uptime tests

* Revert uptime changes
2020-04-15 11:16:14 -04:00
Corey Robertson 3a91e713aa
Fixes Keyboard Shortcuts help extension (#63583) 2020-04-15 11:13:28 -04:00
Stacey Gammon d0404487f6
Add embeddable via saved object example (#61692)
* Add embeddable via saved object example

* give todoRefEmbed a different name from the by value one

* fix types

* fix order of unmounting

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
2020-04-15 11:10:20 -04:00
Rudolf Meijering 00a1144ae2
Refactor Plugins to access elasticsearch from CoreStart (#59915)
* x-pack/watcher: use Elasticsearch from CoreStart

* x-pack/upgrade_assistant: use Elasticsearch from CoreStart

* x-pack/actions: use Elasticsearch from CoreStart

* x-pack/alerting: use Elasticsearch from CoreStart

* x-pack/lens: use Elasticsearch from CoreStart

* expressions: use Elasticsearch from CoreStart

* x-pack/remote_clusters: remove unused Elasticsearch dependency on CoreSetup

* x-pack/oss_telemetry: use Elasticsearch from CoreStart

* Cleanup after #59886

* x-pack/watcher: create custom client only once

* Revert "x-pack/watcher: create custom client only once"

This reverts commit 78fc4d2e93.

* Revert "x-pack/watcher: use Elasticsearch from CoreStart"

This reverts commit b621af9388.

* x-pack/task_manager: use Elasticsearch from CoreStart

* x-pack/event_log: use Elasticsearch from CoreStart

* x-pack/alerting: use Elasticsearch from CoreStart

* x-pack/apm: use Elasticsearch from CoreStart

* x-pack/actions: use Elasticsearch from CoreStart

* PR Feedback

* APM review nits

* Remove unused variable

* Remove unused variable

* x-pack/apm: better typesafety

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-15 17:07:57 +02:00
Daniil Suleiman afb48bceca
[NP] Move visTypeXy plugin (#63449)
* Move vis_type_xy into NP

* Substitute usage in vis_type_vislib

* Disable plugin by default
2020-04-15 18:03:17 +03:00
Brandon Morelli 02bcc8e78b
[APM] docs: restructure APM documentation for 7.7 (#63280) 2020-04-15 07:54:26 -07:00
James Gowdy 6fc4840bae
[ML] Changing file data visualizer max upload setting to string (#63502) 2020-04-15 15:48:04 +01:00
Nicolas Ruflin 3342f9e80e
[Ingest] Add details to indexing strategy around allow chars (#63560)
Add some recommendation around what chars should be used if a dataset or namespace contains a `-`.
2020-04-15 16:44:14 +02:00
Daniil Suleiman 23a5734d07
[NP] TSVB (#63237)
* Move TSVB into new platform

* Get rid of isFunction checks

* Remove extra import of styling constants

* Move styles importing into plugin.ts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-15 17:03:20 +03:00
Oliver Gupte d1d0a44d5d
Closes #63113 by limiting service maps to only draw certain shapes in IE 11 without icons (#63558) 2020-04-15 06:59:47 -07:00