Commit graph

23517 commits

Author SHA1 Message Date
igoristic
50fab1aea3
Swapped kui base class with eui equivalent (#34644)
* Swapped kui base class with eui equivalent

* Added the react component instead
2019-04-08 16:51:44 -04:00
Jason Rhodes
cd532cd8f7
Rework link components to be separated by destination (#34630)
* Creates new LocationContext and useLocation hook

* Re-structures Discover links

* Re-structures ML job link, cleans up discover link changes

* Removes unused components and props

* Adds separated APM and Kibana link components

* Adds InfraLink component

* Adds integration link tests for new link components

* Moves unshared getSearchWithCurrentTimeRange into APMLink component where it is used

* Moves persistent APM params out of the generic url helpers util

* Refactoring rison more

* Clarifies interface names for rison

* Removes risonStringify helper

* Changes link components to inline function exports with manually created component type

* Consolidate APM href generation in one place

* Re-ordered imports for linting

* Updates breadcrumb snapshots now that they include default values
2019-04-08 15:47:16 -04:00
Rudolf Meijering
7a8301e43b
[new-platform] Core API Review process documentation (#34735)
* Core API Review process documentation

* Add links to public/server api docs and migration guide
2019-04-08 21:14:15 +02:00
Jason Rhodes
c9f65adb1b
Add "Show trace logs" action (#34310)
* Adds trace logs link to action menu

* Updates tests

* Fixes time range values for action menu links

* Relaxes type checking on query param object to allow for outgoing links

* Revert unnecessary rison changes after realizing infra links do not accept rison
2019-04-08 14:24:07 -04:00
Ryan Keairns
f7e66eaf6e
[Canvas] Copy edits from docs review (#34666)
* Copy edits from docs review

* couple more edits

* edits
2019-04-08 12:58:06 -05:00
CJ Cenizal
b0542141c0
Update Delete Remote Cluster API to support multiple comma-delimited clusters. (#34595)
* Handle a 500 error. Add error message to toast notifications.
2019-04-08 10:41:08 -07:00
Thomas Neirynck
f611a1fc5e
[Maps] Clear data load error when layer gets correct data (#34484) 2019-04-08 13:37:24 -04:00
Thomas Neirynck
ae977f8636
[Maps] Add filter actions to tooltips (#33635) 2019-04-08 13:03:56 -04:00
Dmitry Lemeshko
f39339d9d3
Functional tests: improve waiting in combobox service (#34707)
* [services/lib/web_element_wrapper] set custom wait for findAll

* [services/remote] print browser name and version on init

* [services/combo_box] fix return statement

* fix lint error
2019-04-08 18:48:55 +02:00
Shaunak Kashyap
3455cf8519
Docs: Simplifying setup by using module configuration variant syntax (#34599)
Now that https://github.com/elastic/beats/pull/9118 is merged, starting 7.1 users will be able configure Metricbeat for monitoring Kibana instances using a simpler syntax.

Previously, users would have to run `metricbeat modules enable kibana` to enable the `kibana` Metricbeat module, then configure the module for Stack Monitoring by manually editing `modules.d/kibana.yml`. Going forward, users will be able to achieve the same effect by running `metricbeat modules enable kibana-xpack`.

This PR updates the docs with this change.

Related: https://github.com/elastic/elasticsearch/pull/40879
2019-04-08 09:04:57 -07:00
James Gowdy
aa78584adc
[ML] Fix file data visualizer index pattern match (#34721)
* [ML] Fix file data visualizer index pattern match

* also global replace . and +
2019-04-08 16:57:06 +01:00
Felix Stürmer
576283cca9
[Infra + Logs UI] Reactively consume the ui settings (#34615)
Previously, the `theme:darkMode` and `dateFormat` settings were only read once, which made them susceptible to race conditions during initialization. This introduces and uses a new `useKibanaUiSetting` hook to reactively consume the settings.
2019-04-08 15:28:27 +02:00
Rudolf Meijering
2e13faf8af
Overlay core service (#34261)
* Move ui/flyout to overlay core service

* Remove onClose in parameter (use FlyoutSession instead)

* Fix tests

* Remove old inspector tests

* Proper TODO message

* Convert flyout service to class

* Use correct i18n

* Resolving weird merge conflicts

* Fix panel plugin test

* Change new platform access

* Add more tests

* Remove commented tests

* Revert test fix (core is actually not fixed yet)

* Fix tests

* Expose onClose as Observable

* Use jest.doMock

* Fix typos

* Core start() -> setup()

* Remove @extends EventEmitter docs

* Refactor and test flyoutservice

* Fix comments: promise -> observable

* Fix tests

* Explicitly define OverlaySetup

* Fix OverlaySetup type signature

* Update Core API review file and docs

* Remove redudant if case

* Change FlyoutRef.onClose into a promise

* Remove redundante cleanup

* Use promise.finally

* Remove targetDomElement from openFlyout()

There's no need to support multiple targetDomElements per FlyoutService
and the current implementation handled this use case incorrectly.

Instead of adding complexity to try to support it, remove this from the
function signature.

* Fix + test to ensure child components are unmounted when a new flyover is displayed

* Wrap flyover in i18n Context component

* TSlint -> ESlint + test improvements
2019-04-08 15:17:59 +02:00
Tiago Costa
e44ad7b358
Generate dockerfiles target to be used for elastic/dockerfiles (#32169)
* feat(NA): generate bundles with dockerfiles as targets.

* chore(NA): change dockerfiles suffix to docker-build-context.
2019-04-08 12:09:51 +01:00
Pete Harverson
659e4712eb
[ML] Limits maximum annotation text length to 1000 characters (#34540)
* [ML] Limits maximum annotation text length to 1000 characters

* [ML] Fix initialization of annotation errors array

* [ML] Fix typo in annotation flyout comment
2019-04-08 11:54:42 +01:00
Alexey Antonov
7514fb804b
[TSVB] Aggregation by 'Static value' is not working properly (#34624)
Fix:  #34620
2019-04-08 13:13:56 +03:00
Daniil Suleiman
d0935ff662
[Vis: Default editor] EUIficate drop partials control (#34358)
* EUIficate drop partials control

* Set right value to a comp before rendering

* Wrap the switch in tooltip

* Exclude legacy styles for eui prefix

* Add a spacer
2019-04-08 12:54:35 +03:00
Peter Pisljar
7693f18f50
updating markdownvis interpreter func arguments (#34534) 2019-04-08 11:15:02 +02:00
Marius Dragomir
bd5e81bafc
Using proper link for Plugin Generator (#34627)
Updated so that we don't link to a generator that was deprecated that links to another generator that was also deprecated.
2019-04-07 21:18:53 +03:00
Liza Katz
4dd7f1788d
New platform move doc table and doc viewer to kibana\discover (#34231)
* Moved doc table to kibana/discover

* moved doc viewer to Kibana app (used by docs and discover)

* Moved
- saved object finder
- paginated selectable list
from partiasls to directives/partials

* Moved paginate controls directive to directives/partials
2019-04-07 14:13:04 +03:00
Peter
7ff4134c6d
fix formatting typo (#34661) 2019-04-05 17:14:23 -04:00
Court Ewing
a08535a7ce
New platform migration guide (#31147)
This initial guide is focused on migrating plugins within the Kibana repo.
Once more of the details are fleshed out in concrete terms, we can
re-purpose it to be published for external developers as well.
2019-04-05 16:26:56 -04:00
CJ Cenizal
48b2478a67
Fix wrapping of Remote Cluster connection status in table. (#34642) 2019-04-05 11:38:42 -07:00
Lisa Cawley
a0f8107b90
[DOCS] Updates data recognizer screenshots for ECS (#34596) 2019-04-05 11:29:48 -07:00
Tiago Costa
3d354a83a2
chore(NA): fix lint rule for canvsas. (#34650) 2019-04-05 18:57:48 +01:00
Oliver Gupte
dda54e4948
[APM] Fixes #33443 by guarding for undefined request types in URL (#33828) 2019-04-05 10:26:12 -07:00
Tiago Costa
ed795d28ee
Migrate from tslint (#33826)
* chore(NA): remove tslint dependencies, configs and enable eslint typescript parser.

* fix(NA): apply recommend eslint typescript rule.s

* chore(NA): upgrade eslint package versions.

* chore(NA): split javascript eslint config in an override section.

* chore(NA): split all eslint configs with overrides.

* chore(NA): remove missing console.log.

* chore(NA): change eslint splits and overrides order.

* chore(NA): replace tslint disable comments with eslint ones.

* chore(NA): solve eslint typescript errors for elastic/kibana-custom/no-default-export

* chore(NA): fixed multiple eslint typescript rule failures.

* chore(NA): add tarfet folder to the eslint ignore.

* chore(NA): apply prettier rule to ts type file.

* chore(NA): remove last mentions to tslint

* chore(NA): add old defined rules

* chore(NA): missing port rules website

* chore(na): ordered rules

* chore(NA): solved eslint typescript problems.

* chore(NA): fix spaced comment problems.

* chore(NA): fix some more eslint typescript rules: import/order no-empty-interface

* chore(NA): fix last rules and comment out what are the ones still failing.

* chore(NA): comment out camelcase rule.

* chore(NA): regenerate kbn pm dist.

* chore(NA): updated snapshots.

* chore(NA): updated snapshots.

* chore(NA): disabled sort-keys rule.

* chore(NA): remove rule prefer-arrow/prefer-arrow-functions.

* chore(NA): fix for @typescript-eslint/no-var-requires rule.

* chore(NA): fixes for @typescript-eslint/camelcase rule.

* chore(NA): fix typo on eslint config kibana typescript.

Co-Authored-By: mistic <tiagoffcc@hotmail.com>

* chore(NA): remove legacy note after the intellij upgrade to 2019.1

* fix(NA): import order plugin.

* chore(NA): fix ts ignore positions after auto fix.

* fix(NA): performance issue with typescript eslint.

* refact(NA): eslint configs organization.

* chore(NA): apply resticted paths to ts files too.

* chore(NA): split comment from eslint ignore.
2019-04-05 17:45:23 +01:00
Pete Harverson
e222fa64e0
[ML] Only update forecasting progress bar if value increases (#34614) 2019-04-05 17:01:16 +01:00
Pete Harverson
bbfe50f39b
[ML] Replace View Forecast button image with Single Metric icon (#34563)
* [ML] Replace View Forecast button image with Single Metric icon

* [ML] Remove table scss overrides and use icon in Explorer view
2019-04-05 16:57:23 +01:00
gchaps
b3f7435ad2
[DOCS] Fixes formatting in plugin and l10 docs (#34594) 2019-04-05 07:01:16 -07:00
Clint Andrew Hall
b55a2063e3
[canvas] Type Renderers; Add DropdownFilter examples (#31299)
## Summary

This PR adds types to Renderers and the DropdownFilter.  It also adds snapshots and stories for DropdownFilter.  This change also includes better `recompose` typings.

<img width="1439" alt="screen shot 2019-01-24 at 5 53 57 am" src="https://user-images.githubusercontent.com/297604/51674396-80efbe00-1f9e-11e9-9ad9-d63b1ec51dbd.png">

## Bugs Found and Resolved

- `AdvancedFilter` renderer never successfully passed a selected `filter` value.
- `DropdownFilter` CSS did not constrain the dropdown arrow.  Without a `relative` positioned parent, the arrow would end up in the top-right of the screen.
- `DropdownFilter` had several [shadowed variables](https://palantir.github.io/tslint/rules/no-shadowed-variable/).
- `DropdownFilter` logic has several improvements, including creation of options and order of inclusion
2019-04-05 08:39:09 -05:00
Aleh Zasypkin
bdb289e3b7
Clear session if it belongs to the authentication provider that is not configured. (#34612) 2019-04-05 15:14:29 +02:00
Matthias Wilhelm
eceeb9fb35
Use enter to submit save modals (#34417)
Now you can use the Enter key to submit the form used e.g. when saving a new dashboard
Good for a11y + a time saver

Adds Form element, migration of Button onClick to Form's onSubmit 
Adds functional test for Enter key submission

Fix #30831
2019-04-05 10:47:30 +02:00
Oliver Gupte
05b842c471
[APM] Addresses #33572 by adding support for new agent 'dotnet' in apm (#34077)
telemetry & documentation links
2019-04-04 22:35:08 -07:00
Nathan Reese
7f7b37aaf9
[Maps] replace jquery_ui_sortable with EUI Drag And Drop (#34553)
* [Maps] replace jquery_ui_sortable with EUI Drag And Drop

* minor clean up

* fix drag and drop skipping

* add jest snapshot test for LayerTOC

* extract EuiDraggable list to js variable

* more unique droppableId

* update jest snapshot
2019-04-04 18:36:05 -06:00
Nathan Reese
23bdee0956
[Maps] automatically disable filter by bounds for indexes with small doc counts (#34456)
* [Maps] automatically disable filter by bounds for indexes with small doc counts

* text updates

* review feedback

* minor text update
2019-04-04 18:34:37 -06:00
Matt Bargar
c4aedfc5ba
Fix stale state in filter field ComboBox (#34494)
The FilterEditor component was not updating derived state when the filter prop changed. This issue was exposed by a race condition in the dashboard app. When there are no panels with an index pattern the dashboard will fetch the default index pattern and pass it into the FilterBar. As a result, if a user managed to click the "Add Filter" button before the default index pattern finished loading the editor would first render with a filter containing no index pattern, which would cause the Field ComboBox to render in a disabled state. The FilterEditor props would update after the default index pattern finished loading, but state variables such as selectedIndexPattern would remain unchanged.

The root issue is that the source of truth about which index pattern should be used is stored in both the filter prop and the selectedIndexPattern state variable. To fix this I added a key prop to the FilterEditor that will be unique to each filter so that the component will be recreated on each filter change, while the draft state can remain fully uncontrolled in the FilterEditor component.
2019-04-04 19:46:31 -04:00
Luke Elmers
8b7f171eb8
Show kbn_top_nav in dashboard only mode. (#34400) 2019-04-04 14:41:18 -06:00
CJ Cenizal
2bf18429cc
Refine UI Metric app README and add guidance on tracking multiple metrics in a single request. (#34572) 2019-04-04 12:07:41 -07:00
CJ Cenizal
e6660de89a
Internationalize Rollup Jobs and Remote Clusters app titles. (#34470) 2019-04-04 11:37:19 -07:00
Sarah Hersh
4bca194d35
resolve merge conflict between master and 6.7 (#34570)
[DOCS] Adds i18n docs to master
2019-04-04 14:15:14 -04:00
dave.snider@gmail.com
f9bdf890ba Design cleanup of Uptime app (#31663)
* uptime design cleanup

* uptime design cleanup

* test

* errorlist now styled

* errorlist now styled

* errorlist now styled

* cleanup

* replace color vars with correct naming

* some titles

* more cleanup

* clean up silly gray graph

* Address problems with UI update.

* Refresh jest snapshots.

* Fix busted types.

* Refresh jest snapshots broken by busted type fix.

* Rename duplicate localization key.

* Use same curve type for both check series on monitors page.

* Remove unused translations.

* Display name instead of ID in ErrorList component.

* Update x-pack/plugins/uptime/public/components/functional/ping_list.tsx

Co-Authored-By: snide <dave.snider@gmail.com>

* Update x-pack/plugins/uptime/public/components/functional/ping_list.tsx

Co-Authored-By: snide <dave.snider@gmail.com>

* Modify updated code to avoid flooding console log with errors.

* Get functional and unit tests passing.

* Fix busted unit test.

* Update jest snapshots.

* Add panel to empty state.

* Avoid rendering monitor list sparkline charts when downSeries has no values.

* Remove crosshair synchronization from monitor charts because of display bug. Provide default 0 value to series for check chart.

* Fix broken snapshot.

* Update monitor list and errors list to handle simple_query_string filters.

* Make FilterBar component incremental to avoid overwriting queries that are in progress of being edited.

* Update histogram query to support simple_text_query.

* Delete hardcoded height prop that was breaking UI in mobile-sized windows.

* Fix bug in check histogram function and add tests.

* Update API tests and functional UI tests.

* Fix type error in test file.

* Last few fixes

- Center empty prompt
- remove crosshairs from sparkline
- reconcile styles of text in table

* Update snaps

* WIP.

* Update snapshot query to avoid Apollo Query class and allow manual fetching.

* Update SnapshotLoading component to better reflect the actual shape of the Snapshot component.

* Introduce HOC to manage GraphQL querying.

* Remove unneeded code.

* Update monitor page query components to use new query paradigm.

* Remove remaining references to apollo query component.

* Update filter bar snapshot.

* Update empty state.

* Fix busted type in test.

* Update schema type to avoid server error.

* Remove obsolete translations.

* Remove more obsolete translations.

* Remove obsolete code from Snapshot component. Rewrite graphql HOC with hooks.

* Change loading state condition for filter bar.

* Simplify app refresh process.

* Update loading state for several components to avoid unnecessary renders.

* Add default sort order for getAll pings function.

* Add translation to bare UI string.

* Update API fixtures to handle new default sort direction.

* Fix type errors.

* Remove unused import.

* Change the way component passes children prop.

* Fix typing error.
2019-04-04 13:26:22 -04:00
Peter
7dbb702b35
fixes #34513 (#34516) 2019-04-04 12:05:42 -04:00
Sébastien Loix
26add272e0
[Remote clusters] Add client integration tests (#34076) 2019-04-04 16:05:22 +02:00
Sébastien Loix
795b72375f
[ILM] Remove "Beta" badge (#34454) 2019-04-04 15:42:27 +02:00
Mike Côté
51e6a009ee
Modify saved object import APIs to handle special use cases from the previous import process (#34161)
* Modify import APIs to handle special use cases from the previous import process

* Cleanup

* Add more examples to the docs

* Make title come from data inside file

* Fix some broken tests

* Fix docs

* Fix docs wording

* Apply PR feedback pt1

* Apply PR feedback pt2
2019-04-04 09:10:54 -04:00
Maryia Lapata
5c2267f2ca
[vis: Default Editor] Remove regex control (#34530)
* Remove usued regex control

* Remove dependency on removed file
2019-04-04 16:10:33 +03:00
Peter Pisljar
954d3e1093
updating tagcloud interpreter func arguments (#33773) 2019-04-04 14:33:38 +02:00
Geoffrey Ammons
2361d5e8b3 Fix migrate significant terms include exclude format (#34392)
* Fix migrate significant terms include/exclude

* update ref to expect, update test initialization

* created function to encapsulate duplicated code

* commented seemingly extraneous code in test

* Removed extraneous initialization code from sig terms test, updated migrate_include_exclude_format.js to use named import from lodash, added localized displayName to sig terms
2019-04-04 12:04:29 +02:00
Tim Roes
cca14121cc
Improve description for translators (#34467)
* Improve description for translators

* Address review feedback
2019-04-04 11:18:16 +02:00