Commit graph

41388 commits

Author SHA1 Message Date
Frank Hassanabad bb265641b4
Updated to allow chunked queries and to increase the timeouts of the REST backend (#94531)
## Summary

Increases the pre-packaged socket timeout and chunks the requests. Existing e2e tests should cover the changes. Interesting enough, when the server sends back a 408, Chrome will re-send the same request again which can cause socket/network saturations. By increasing the timeout, Chrome will not resend the same request again on timeout.

Right now, there is not a way to increase the timeouts for the alerting framework/saved objects as far as I know for connections. That would be an additional safety measure in additional to doing chunked requests. Chunked requests will ensure that the pre-packaged rule does not exhaust ephemeral ports and limit the concurrent requests. 

See this issue talked about below:
https://github.com/sindresorhus/ky/issues/233
https://groups.google.com/a/chromium.org/g/chromium-dev/c/urswDsm6Pe0
https://medium.com/@lighthopper/connection-retry-schedule-in-chrome-browser-a9c814b7dc20

**Manual testing**
You can bump up the rule version numbers manually through a search and replace and then install them. You can add a `console.trace()` to the backend and slow down the requests to ensure they are not happening more than once. 

```
Trace: 
    at updatePrepackagedRules (/Users/frankhassanabad/projects/kibana/x-pack/plugins/security_solution/server/lib/detection_engine/rules/update_prepacked_rules.ts:34:11)
    at createPrepackagedRules (/Users/frankhassanabad/projects/kibana/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/add_prepackaged_rules_route.ts:140:9)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at /Users/frankhassanabad/projects/kibana/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/add_prepackaged_rules_route.ts:66:27
    at Router.handle (/Users/frankhassanabad/projects/kibana/src/core/server/http/router/router.ts:272:30)
    at handler (/Users/frankhassanabad/projects/kibana/src/core/server/http/router/router.ts:227:11)
    at exports.Manager.execute (/Users/frankhassanabad/projects/kibana/node_modules/@hapi/hapi/lib/toolkit.js:60:28)
    at Object.internals.handler (/Users/frankhassanabad/projects/kibana/node_modules/@hapi/hapi/lib/handler.js:46:20)
    at exports.execute (/Users/frankhassanabad/projects/kibana/node_modules/@hapi/hapi/lib/handler.js:31:20)
    at Request._lifecycle (/Users/frankhassanabad/projects/kibana/node_modules/@hapi/hapi/lib/request.js:371:32)
    at Request._execute (/Users/frankhassanabad/projects/kibana/node_modules/@hapi/hapi/lib/request.js:279:9)
```

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-03-15 11:27:31 -04:00
Bryan Clement ce7a0bb8fc
[Asset Management] Osquery autocomplete (#94255)
* added osquery mode to autocomplete

* clean up and formatting

* arm wrestling with the compiler

* more fighting with ace types

* Delete v4.5.0.json

removed unused schema file

* playing the hokey pokey with import statements

* lazy load the schema file

* remove include rule now that we are lazy loading schema json

* update out of date comment

* reduce schema file to what is currently being used, add script for formatting generated api files

* added a readme, and points the compiler at the scripts directory

* swip-swapped the argument order, fixed linting complaints

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-15 08:18:36 -07:00
Thomas Neirynck e1363855bf
[Maps] Isolate maps-setting froms maps_legacy (#92918)
Creates a new plugins, maps_ems, with `map.*` configs and shared EMS-settings. `maps_legacy` now only supports the `region_map` and `coordinate_map` plugins.
2021-03-15 11:15:39 -04:00
Kaarina Tungseth ae1f284118
[DOCS] TSVB updates for 7.12 (#93317)
* [DOCS] TSVB updates for 7.12

* Fixes formatting

* Clean up

* Review comments

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Update docs/user/dashboard/tsvb.asciidoc

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Review comments

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
2021-03-15 09:48:09 -05:00
ymao1 a7c9d3f1e0
[Alerting] Update UI to reflect new terminology (#93597)
* Renaming alerts to rules

* Updating formatted messages

* Updating i18n labels

* Completed renaming in UI

* Updating client routes including redirect

* wip docs update

* Reverting title changes for now

* Fixing types check

* Fixing unit tests

* Fixing functional test

* Fixing functional test

* docs wip

* wip docs update

* Finished first run through docs

* docs docs docs

* Fixing bad merge

* Fixing functional test

* Docs cleanup

* Cleaning up i18n labels

* Fixing functional test

* Updating screenshots

* Updating screenshots

* Updating screenshots

* Updating terminology in alerting examples

* Updating terminology in alerting examples

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-15 10:03:39 -04:00
Anton Dosov bd9170f7dc
[Search Sessions] Search session example app functional test (#92133) 2021-03-15 14:47:14 +01:00
Alejandro Fernández Gómez c062b04691
[Fleet] Ignore inactive agents when removing a policy (#94311)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-15 09:27:56 -04:00
John Schulz a4fa4a62cb
Use consistent-type-imports lint rule to autofix type-only imports (#94464)
## Summary

Use the [`consistent-type-imports` lint rule ](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/consistent-type-imports.md) to use `import type ...` where possible

Code-only changes like this were recently added in https://github.com/elastic/kibana/pull/92979, but it was a more manual process.  This PR adds an autofixable lint rule which will keep the changes up-to-date and Just Work ™️
2021-03-15 13:58:50 +01:00
Anton Dosov df98465982
Fix importing dashboards created before ~6.1.0 (#94332) 2021-03-15 13:57:44 +01:00
Pierre Gayvallet ed5bbdaa95
Move src/apm.js to @kbn/apm-config-loader (#94315)
* Move src/apm.js to @kbn/apm-config-loader

* add unit tests for `initApm`

* return undefined instead of empty config

* use ?.
2021-03-14 22:53:52 +01:00
Mikhail Shustov 0c3514c0f7
Cleanup TS in home plugin (#94516)
* fix problem with home plugin

* home: /mocks/index.ts --> mocks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-12 07:25:22 -05:00
Kerry Gallagher ef042b9e86
[Logs UI] Fixes missing fields in the log entries search strategy (#94443) 2021-03-12 12:57:55 +01:00
kaiyan-sheng 2b372fa8ac
Rename googlecloud to gcp in Add Data UI (#93725) 2021-03-12 10:21:15 +08:00
Kaarina Tungseth 30b03aaca0
[DOCS] Adds the 7.12.0 dashboard features (#93687)
* [DOCS] Adds the features for 7.12

* Feature changes

* Review comments

* Adds Switch to view mode
2021-03-11 16:20:45 -06:00
Nicolas Chaulet 6252e0f035
[Fleet] Catch key parsing error in package install handler (#94484) 2021-03-11 17:15:36 -05:00
Yara Tercero 2c623bd101
[Security Solution][Detections] - Fix threshold preview (#94224)
### Summary

Addresses #92732

7.11+ versions of threshold preview histogram were aggregating by "event.category". This PR updates the preview histogram to take into account threshold field groups and cardinality.

It may need to be called out in documentation or updated to remind users that preview is not an exact guarantee of what signals will be produced as it does not take into account interval and any timestamp_override. Threshold gets a tad bit more confusing because of the multiple aggregations occurring (threshold --> group by field --> histogram).
2021-03-11 13:19:02 -08:00
Nathan Reese 9f5ca1b745
[Maps] convert DrawControl to TS (#94437)
* [Maps] convert DrawControl to TS

* return GeoFilter from createSpatialFilterWithGeometry
2021-03-11 14:05:47 -07:00
Chris Cowan 5517e6cf90
[Metrics UI] Use memory limit for K8S when available (#93686)
* [Metrics UI] Use memory limit for K8S when available

* removing duplicate key

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-11 13:07:04 -07:00
John Schulz 6491ad5112
[Fleet] Fix circular ref by moving code & tests into Fleet (#94171)
## Problem
There's a circular dependency https://github.com/elastic/kibana/issues/91111 between the `fleet` and `security_solution` plugins 

* `security_solution` depends on `fleet`, but 
* `fleet` has (_had_ with this PR) an `import` from  `security_solution` (migrations for the 7.11 and 7.12 package policy objects)

## Proposed solution
### (A) This PR
Move the two imported functions from `security` into `fleet`.

### (B) Follow up issue
Putting integration-specific code into `fleet` doesn't scale (technically or cognitively). Discuss if this use case (specifying saved object migrations, etc) applies to other plugins. e.g. can `apm` do this? `nginx`? If so, should we find a way to move this out of `fleet`?


### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

closes https://github.com/elastic/kibana/issues/91111
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-11 14:41:14 -05:00
Lukas Olson 0298f4f60a
[KQL] Remove Lucene syntax warnings (#93619)
* [KQL] Remove Lucene syntax warnings

* Remove unused translations

* Update docs
2021-03-11 12:29:40 -07:00
Liza Katz 67ecc2051a
7.12 migration test (#94430)
* 7.12 migration test

* improve test
2021-03-11 21:18:51 +02:00
Michael Dokolin a5be04d17b
Add a link to the reporting management dashboard in the started job toast (#81583) (#93961)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-11 21:18:03 +02:00
Thomas Neirynck 9d365a4df8
[Maps] Compare SearchFilters to determine whether mvt layers can skip update (#93531) 2021-03-11 14:07:32 -05:00
Quynh Nguyen fa3b2f0ef6
[ML] Fix Index data visualizer not removing query string with loaded saved search (#94245)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-11 12:59:10 -06:00
Constance 521c336df2
[App Search] Curation: set up server routes, API calls, & bare-bones view (#94341)
* Add server side API routes & update types expected from server

* Create CurationLogic with GET and PUT listeners

- PUT is mostly placeholder for now, we'll actually use it later in future Curation PRs

* Create Curation view component & page load effect

* Update CurationsRouter to use new view + remove add_result route

- Per design discussion w/ Davey, we'll be removing the standalone add result route in favor of an in-page flyout
2021-03-11 09:34:28 -08:00
Paul Tavares 8fc5d8ba30
[FLEET][SECURITY_SOLUTION][ENDPOINT] Fleet Artifact client and refactoring of Endpoint to use it (#93776)
* Fleet: adds new service for Artifact storage management
* Fleet: Expose new `createArtifactsClient()` from Fleet `Plugin#start` interface
* Endpoint: Change Endpoint to use FleetArtifactClient and initial implementation of EndpointArtifactClient
* Endpoint: Add `fleetServerEnabled` feature flag to security solution plugin (will be used in next PR)
* Endpoint: Artifact download api adjusted to get artifact from fleet index
* Endpoint: Added new esArchive for artifacts stored in .fleet-artifacts index for API integration tests
2021-03-11 12:17:18 -05:00
Matthew Kime d089ed9afe
fix median agg with scripted field (#93731)
* fix median agg with scripted field and update test
2021-03-11 11:06:25 -06:00
Spencer 054da62a7a
[ci-stats] ship timings, collect overall bootstrap time (#93557)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-03-11 09:42:22 -07:00
Constance 8be1dd7c54
[App Search] Add custom actions prop to Result component (#94378)
* Add custom actions prop to Result component

- will be used by upcoming Curations work to promote and hide documents

* Add Result custom actions to library

+ [misc] export main Result component from index
2021-03-11 08:40:31 -08:00
Jason Stoltzfus dee1272dd6
Created a stub page for result settings (#94334) 2021-03-11 08:38:34 -08:00
Gidi Meir Morris ba0609f5ba
[Alerting] Ensures ES Query uses the correct sort value to avoid duplicate detections (#94349)
This PR addresses a potential problem that we have *not yet* encountered in the wild, but could in theory happen.
When choosing the sort value to use as the value of the `latestTimestamp` in the ES Query Rule Type, we assumed that the sort value would be parsable as a Date.
In this PR we ensure we only try to use a sort value *if* it can be parsed into a date.
2021-03-11 16:32:32 +00:00
Lukas Olson 813e16f6ae
Fix search telemetry to only update SO periodically (#93130)
* Fix search telemetry to only update SO periodically

* Handle case when searches completed mid flight

* Fix error in resetting counters

* Update docs

* update docs

* Don't track restored searches

* Update docs

* Update docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
2021-03-11 09:17:43 -07:00
Lisa Cawley 633b53ec8d
[ML] Clarifies description of datafeed scroll_size (#94348) 2021-03-11 08:11:37 -08:00
Marco Liberati ed95c08d71
[Lens] Fix area percentage gaps with zero fitting function (#94086)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-11 17:03:58 +01:00
Nathan Reese 91f7711da6
Add pagination control to datavisualizer failures to rendering all errors at a single time (#93839)
* Add pagination control to datavisualizer errors to avoid crashing browser

* conditionally render pagination control

* tslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-11 08:28:15 -07:00
James Rucker 0e1fa8d50a
Small changes to callback params for Atlassian OAuth1 flows (#94395) 2021-03-11 09:26:21 -06:00
Ryan Keairns f61657c5e9
Update text and icons to align with Cloud (#86394)
* Update text and icons to align with Cloud

* Update test to reflect new page title prefix

* Change links conditionally

* Simplify profile link logic

* Add setAsProfile prop for overriding default link

* Address feedback

* remove translations since message has changed

* Tidying up

* Add unit tests.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
2021-03-11 08:53:46 -06:00
Rudolf Meijering 40b648cd06
savedObjects plugin is deprecated and will be removed (#94289)
* savedObjects plugin is deprecated and will be removed

* Update plugin list docs
2021-03-11 07:42:51 -07:00
James Gowdy dfb4eac520
[ML] Adding support for saved object based ml modules (#92855)
* [ML] Adding support for saved object based ml modules

* updating icon mapping

* cleaning up code

* missed private variable

* removing mappings json file

* renaming module id

* updating test

* removing unrelated file

* type clean up

* changing logo type

* changes based on review

* removing fleet changes

* updating type guards

* fixing list module return type

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-11 14:08:48 +00:00
Joe Reuter 33fbe74e4e
[Lens] Transpose columns (#89748) 2021-03-11 13:51:50 +01:00
Gidi Meir Morris 716e2f7816
[Task Manager][Docs] fixes the formatting of an "Important" box (#94276)
Fixes the rendering of the Important callout on: Task Manager Production Considerations
2021-03-11 12:11:24 +00:00
Jean-Louis Leysens 1618e5436b
[Console] Update copy when showing warnings in response headers (#94270)
* remove "deprecated: " from console warning

* refactor "deprecation" to "warning"

* complete name refactor in test files
2021-03-11 10:23:51 +01:00
Daniil 77fe83b1a6
[TSVB] Type public code. Step 1 (#93231)
* Remove request facade and update search strategies

* Use typescript

* Type files

* Update structure

* Update tests

* Type annotations

* Fix type for infra

* Type editor_controller

* Type vis_editor

* Type vis_picker

* Fix types

* Type panel_config

* Fix vis data type

* Enhance types

* Remove generics

* Use constant

* Update docs

* Use empty object as default data

* Fix merge conflict
2021-03-11 12:15:19 +03:00
Robert Oskamp 92307bfe29
[ML] Functional tests - stabilize slider value selection (#94313)
This PR stabilizes the slider value selection during ML functional tests.
2021-03-11 10:11:53 +01:00
spalger ad0517a905 skip another suite blocking es promotion (#94367) 2021-03-10 18:19:54 -07:00
Andrew Goldstein 14c32cbd6c
[Security Solution] Eliminates a redundant external link icon (#94194)
## [Security Solution] Eliminates a redundant external link icon

- Fixes an issue where [a redundant external link icon](https://github.com/elastic/kibana/issues/89084) was rendered next to port numbers

Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link.

- Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions

### Before

<img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png">

### After

<img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png">

### Desk testing

Desk tested in:

- Chrome `89.0.4389.82`
- Firefox `86.0`
- Safari `14.0.3`
2021-03-10 17:17:55 -07:00
spalger 9aeb9f4e4c skip another suite blocking es promotion (#94367) 2021-03-10 15:41:52 -07:00
Scotty Bollinger 26603620a4
[App Search] Role mappings migration part 1 (#94346)
* Fix test suite name

https://github.com/elastic/kibana/pull/94038/files#r590545670

* Move types out of AttributeSelector component to shared types

* Fix random typo

* Add routes and path generator util

* Move constants to shared

* Fix types in mock

* Fix routes

* Fix failing tests
2021-03-10 17:16:46 -05:00
Ryland Herrick 5c352cace7
[Security Solution][Detections] Fix flaky indicator enrichment tests (#94241)
* Make indicator enrichment tests order-independent

Due to the fact that we use named queries to determine matches, and the
fact that the order in which named queries are returned is undefined, we
cannot guarantee a consistent ordering of enrichments if a given event
matches multiple named queries.

Because the ordering is not in itself important to enrichment, in order
to assert the multi-match functionality we must make the assertions
order independent.

* PR feedback

* Since we're only looping for side effects, prefer forEach to map for
  more idiomatic FP.
2021-03-10 16:00:05 -06:00
Vadim Yakhin 5acf15dccd
[Workplace Search] Deduplicate icons (#94359)
* Remove redundant "_" from icon names

* Move all icons from sources_full_bleed to source_icons

Overwrite existing icons in case of conflicts

* Remove fullbleed prop from source_icon

* Minimize the only unminimized icon

* Remove unused icons
2021-03-10 16:46:14 -05:00