Commit graph

41388 commits

Author SHA1 Message Date
Nathan L Smith b6f8d3f8b6
Move anomaly jobs fetching to context (#94135)
* Revert "[APM] Hoist HeaderMenuPortal to prevent unmounts (#92012)"

Revert the change from #92012 to put the `HeaderMenuPortal` back within the routing context so getting data from the path params works.

Use a context to fetch the list of jobs and use it in the callout and the header menu icon. This makes it so the fetch only happens once.

A refetch function is exposed from the context and called when a new job is created.
2021-03-09 15:06:41 -06:00
Oliver Gupte 931b54f636
[APM] Handle correlations view with missing field names (#93443) (#94015)
* [APM] Handle correlations view with missing field names (#93443)

* fixes spelling

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-09 12:37:11 -08:00
Aaron Caldwell 4eff7a0709
[Maps][File upload] Use correctly formatted pipeline with no processors for geojson upload (#94145) 2021-03-09 15:32:11 -05:00
Jen Huang 394593ae94
Use password field for password vars (#94166) 2021-03-09 15:30:26 -05:00
Thomas Neirynck d78222b8e1
[Maps] Improve TMS language (#93863) 2021-03-09 15:03:14 -05:00
Jen Huang 3946c4ad91
[Fleet] Fix package policies created with null var values (empty defaults) (#94040)
* Make package validation be based on types

* Add package info to cache after it is generated from ES storage

* Add logging around package info retrieval and when cache is set

* Add snapshot api integration test for uploaded package info

* Use the apache package for snapshot test instead

* Remove date field from snapshot

* Update docs

* Fix streams getting overridden

* Add back package field to data streams

* PR fixes
2021-03-09 14:53:22 -05:00
Larry Gregory 99566a2248
Document DLS configuration within Kibana role management (#90329)
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-09 13:20:21 -05:00
John Schulz 8ce5cda582
[Fleet] Add links to OpenAPI spec files and online documentation (#94122)
## Summary

Added screenshots of two online viewers and links to the sites. 

<img width="934" alt="Screen Shot 2021-03-09 at 12 35 02 PM" src="https://user-images.githubusercontent.com/57655/110513158-eb5b0e00-80d3-11eb-82c4-de21c494589f.png">


### Checklist

- [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials
2021-03-09 13:07:53 -05:00
Tyler Smalley 0b09e9c4ae
[jest] Removes un-used config files (#94134)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-03-09 18:05:20 +00:00
Tyler Smalley 3cabf8154f
Removes x-pack/.github directory (#94153)
This folder is left-over from when X-Pack was a separate repository

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-03-09 18:04:10 +00:00
Quynh Nguyen be8ea1920f
[ML] Fix Data Visualizer not showing document count for non-time based indices (#93958)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-09 11:26:28 -06:00
Quynh Nguyen fcf397f9c3
[ML] Add functional tests for runtime mappings in Transforms (#92738)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-09 11:25:58 -06:00
Constance ee2ec0aded
[App Search] Add roleHasScopedEngines helper + small roles/ cleanup (#94038)
* Split out roles/ into separate files

- in preparation for new scoped engines helper

* Add new roleHasScopedEngines helper
2021-03-09 08:54:05 -08:00
Thomas Watson b862a6c181
Bump @storybook/* from 6.0.26 to 6.1.20 (#93386) 2021-03-09 08:51:37 -07:00
Joe Reuter 35d01f5a9b
make sure to render once (#93786) 2021-03-09 16:34:40 +01:00
Rudolf Meijering d657118aa0
Saved objects import compatibility across versions (#94072) 2021-03-09 16:07:08 +01:00
Chris Roberson 7d237b8f59
Fix issue with loading logstash node page under standalone cluster (#93617)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-09 10:00:45 -05:00
Byron Hulcher cceed8ddd6
[App Search] Add delete action to EnginesTable component (#92844)
* Add delete engine route to App Search

* Add new deleteEngine listener to EnginesLogic

* Convert EnginesTable Manage into a proper EuiBasicTable action

* Call EnginesLogic.actions.deleteEngine using new action in EnginesTable

* Manage action on EnginesTable should use eye icon

* Confirmation alert for delete action on EnginesTable

* Only display manage/delete actions to users with canManageEngines

* Add success message and reload after successful engine delete

* Jest tests for EngineTable actions

* Copy change for engine delete success message

* Fixing EnginesTable tests

* Adding more tests for DELETE engine route

* engineNameLink -> EngineNameLink

* Remove redundant test

* Convert Engine.type to enum EngineTypes

* Must use mountWithIntl

* Use platinum license instead of role ability check
2021-03-09 09:49:52 -05:00
Marco Liberati 8e6d4ee2f8
[Lens] Fix wrong suggestions from Datatable to other visualizations (#93920)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-09 15:31:17 +01:00
Walter Rafelsberger 326dfa43ca
[ML] Improves error handling for transform wizard when Kibana index pattern or saved search fails to load. (#93915)
Improves error handling for the transform wizard when Kibana index pattern or saved search fails to load.
Previously a non-existing index pattern or saved search or corrupt saved object could cause the page to end up blank. Improved error reporting will catch the problem and display an error callout.
2021-03-09 15:29:45 +01:00
Alison Goryachev 5744f2bc95
update console autocomplete for component templates (#92915) 2021-03-09 09:06:24 -05:00
Stacey Gammon 7d284e2bf4
Add our developer principles to our dev guide. (#93688)
* Create dev_principles.mdx

* add back elasticsearch dev principles link since it is actually public

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-09 08:44:22 -05:00
Daniil c7fc78ea08
[TSVB] Remove request facade and type server code (#92964)
* Remove request facade and update search strategies

* Use typescript

* Type files

* Update structure

* Update tests

* Type annotations

* Fix type for infra

* Enhance types

* Remove generics

* Use constant

* Update docs

* Type capabilities
2021-03-09 16:32:09 +03:00
Xavier Mouligneau af8d5eb4e6
[Security Solution] Add nested field inside of data provider (#93721)
* add nested field inside of dataprovider

* make sure to get nested

* fix elq server side

* add mock for nested attributes

* Add basic tests for nested fields query generation

* Update snapshots and failing tests with nestedFields

* fix nested date

Co-authored-by: Kevin Qualters <kevin.qualters@elastic.co>
2021-03-09 07:49:29 -05:00
ymao1 023d9a028b
[Alerting] Update alerting action variables to follow new terminology (#93836)
* Removing duplicate ActionVariable interface. Updating common action variables in UI

* Passing in alert values as rule variables in transform_action_params

* Fixing unit tests

* Fixing functional test

* Adding functiional test

* Updating paths

* Fixing i18n

* Fixing i18n

* Fixing api docs

* Plugin api build

* Moving spaceId and tags under rule prefix

* Using top level alert prefix

* Fixing i18n

* build api docs

* Fixing functional test

* Fixing functional test
2021-03-09 07:48:38 -05:00
Patryk Kopyciński ed2a1bfb1f
[Asset Management] Add support for Live queries in Osquery (#89889) 2021-03-09 13:25:47 +01:00
Pete Harverson a438810673
[ML] Fixes styling of Single Metric Viewer chart for dark theme (#93581)
* [ML] Fizes styling of Simgle Metric Viewer chart for dark theme

* [ML] Fix lint error in scss

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-09 11:50:31 +00:00
Robert Oskamp 6569e0cfa3
[ML] Functional tests - stabilize transform message assertion (#94056)
This PR stabilizes the transform message assertion during functional tests by only comparing lower cased strings.
2021-03-09 12:40:24 +01:00
Rudolf Meijering 1f4a72e776
Revert "[DOC] Clarify compatibility of Saved Objects across versions (#63090)" (#94070)
This reverts commit 4c58e70a7e.
2021-03-09 12:07:35 +01:00
Christos Nasikas bd354b437b
[Security Solution][Case] Fix SIR labels (#94050) 2021-03-09 05:27:41 -05:00
Christos Nasikas a563f5a72e
[Security Solution][Case] Fix bug where push button is not appearing after switching between connectors (#93986)
* Fix bug

* PR review
2021-03-09 05:22:33 -05:00
Uladzislau Lasitsa d754b0be68
Migration script for 'schema' (#93427)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-09 10:56:11 +03:00
Justin Ibarra 29d0dceb03
[Detection Rules] Add 7.12 rules (#94022) 2021-03-08 20:30:35 -09:00
Cauê Marcondes c2fb2ec936
[APM] Adding comparison to transactions table (#91435)
* adding comparison to transactions table

* fixing api test

* merge

* addressing PR comments

* addressing PR comments

* adding kuery filter

* fixing tests

* addressing PR comments

* fixing concurrency issues

* addressing PR comments

* addressing PR comments

* addressing PR comments

* hiding impact bar when comparison disable

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-08 22:00:29 -05:00
Yara Tercero e603bf5461
[Security Solution][Preview] - Enable preview when only filters used (#94018)
### Summary

Addresses #93245 where the preview button was grayed out when only filters were present - no main query.
2021-03-08 18:59:49 -08:00
Andrew Goldstein bcdfa397ac
[Security Solution] [Timeline] Timeline layout fixes (#93870)
## [Security Solution] [Timeline] Timeline layout fixes

- Fixes Timeline's layout to increase the available height of the table on the Query tab by ~ 40%
- Fixes an issue where the query builder is not displayed in full screen mode

### Query Tab Before

<img width="1790" alt="query-tab-before" src="https://user-images.githubusercontent.com/4459398/110192483-abeaa400-7deb-11eb-8b01-c1753d05ab1c.png">

### Query Tab After

<img width="1792" alt="query-tab-after" src="https://user-images.githubusercontent.com/4459398/110192491-b1e08500-7deb-11eb-9b78-fe8097ca9cd6.png">

### Query Tab: Full Screen Before

<img width="1792" alt="query-tab-full-screen-before" src="https://user-images.githubusercontent.com/4459398/110192497-b73dcf80-7deb-11eb-9553-865b6f7ffa84.png">

### Query Tab: Full Screen After

<img width="1792" alt="query-tab-full-screen-after" src="https://user-images.githubusercontent.com/4459398/110192505-befd7400-7deb-11eb-9e20-6b4a5bd1aaaa.png">

### Correlation Tab Before

<img width="1792" alt="eql-tab-before" src="https://user-images.githubusercontent.com/4459398/110192513-c6bd1880-7deb-11eb-9d20-3bc269498edb.png">

### Correlation Tab After

<img width="1792" alt="eql-tab-after" src="https://user-images.githubusercontent.com/4459398/110192534-db011580-7deb-11eb-8a0b-f92c3d8a64fd.png">

### Correlation Tab: Full Screen Before

<img width="1792" alt="eql-tab-full-screen-before" src="https://user-images.githubusercontent.com/4459398/110192538-e5bbaa80-7deb-11eb-9094-42719e5341f6.png">

### Correlation Tab: Full Screen After

<img width="1792" alt="eql-tab-full-sreen-after" src="https://user-images.githubusercontent.com/4459398/110192620-624e8900-7dec-11eb-9eed-e20a9aafeb90.png">

### Pinned Tab Before

<img width="1792" alt="pinned-tab-before" src="https://user-images.githubusercontent.com/4459398/110192557-07b52d00-7dec-11eb-9d93-2d1ffe0712e7.png">

### Pinned Tab After

<img width="1792" alt="pinned-tab-after" src="https://user-images.githubusercontent.com/4459398/110192559-0c79e100-7dec-11eb-8068-6eb0dd700086.png">

### Pinned Tab: Full Screen Before

<img width="1792" alt="pinned-tab-full-screen-before" src="https://user-images.githubusercontent.com/4459398/110192563-126fc200-7dec-11eb-9024-ffc7b2a887df.png">

### Pinned Tab: Full Screen After

<img width="1792" alt="pinned-tab-full-screen-after" src="https://user-images.githubusercontent.com/4459398/110192569-1865a300-7dec-11eb-9162-84547c929853.png">

### Desk testing

Desk tested in:

- Chrome `89.0.4389.82`
- Firefox `86.0`
- Safari `14.0.3`
2021-03-08 18:41:25 -07:00
gchaps c8a12721ad
[DOCS] Adds entries to glossary (#91962)
* [DOCS] Adds entries for Maps app

* [DOCS] Adds entry for heat map

* [DOCS] Adds geo terms

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update docs/glossary.asciidoc

* Update docs/glossary.asciidoc

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2021-03-08 16:51:36 -08:00
Tim Sullivan 9fef424bba
Switch Reporting to Task Manager (#64853)
* [Reporting] Task Manager

* fix startup

* use synchronous config for task registration

* fix eslint

* pr-90365

* --wip-- [skip ci]

* set maxConcurrency to 0 if pollEnabled is false

* add test for execute_report

* remove unused test file

* more tests

* remove unused test files

* remove priority

* logging cleanups

* fix for queue.pollEnabled: false

* more logging fixes for less duplicated code

* update jest snapshots

* polish

* remove unnecessary

* Update mapping.ts

* polish

* fix bug if instance gets a monitoring task and pollEnabled is false

* simplification

* cosmetic

* fix test

* stop monitoring task sabotage

* update api docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-08 17:33:19 -07:00
James Rucker add02f13e8
[Workplace Search] Persist OAuth token package during OAuth connect flow (#93210)
* Store session data sent from Enterprise Search server

This modifies the EnterpriseSearchRequestHandler to remove any data in a
response under the _sessionData key and instead persist it on the server
side.

Ultimately, this data will be persisted in the login session, but for
now we'll just store it in a cookie. https://github.com/elastic/kibana/issues/92558

Also uses this functionality to persist Workplace Search's OAuth token
package.

* Only return a modified response body if _sessionData was found

The destructuring I'm doing to remove _sessionData from the response is
breaking routes that currently expect an empty response body. This
change just leaves those response bodies alone.

* Refactor from initial feedback & add tests

* Decrease levity

* Changes from PR feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-08 16:17:35 -08:00
Zacqary Adam Xeper 0ce3dc7f10
[Fleet] Prevent duplicate enrollment token names (#92735) 2021-03-08 19:09:42 -05:00
Kevin Qualters 9b99f6d3d1
[Security Solution] Prevent EuiFocusTrap from blocking focus to global search (#93377)
* Prevent EuiFocusTrap from blocking focus to global search

* Only run when flyout is open

* Remove unused import

* Fix broken cypress test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-08 19:03:48 -05:00
Tiago Costa 29a162bee3
chore(NA): ability to call bazel from yarn scripts (#93983)
* chore(NA): ability to call ibazel from yarn scripts

* chore(NA): remove ibazel from package.json

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-08 18:51:32 -05:00
Scotty Bollinger a0e88ece91
[Enterprise Search] Fix bug where special chars breaks UI (#94000)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-08 18:27:17 -05:00
Luca Belluccini 4c58e70a7e
[DOC] Clarify compatibility of Saved Objects across versions (#63090)
* [DOC] Clarify compatibility of Saved Objects across versions

* Update docs/management/managing-saved-objects.asciidoc

* Saved objects compatibility

* clarify that same version export/import is compatible

* Add compatibility to SO import API docs

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
2021-03-08 14:58:11 -08:00
Matthew Kime 2d109df886
Add runtime field functional test (#93710)
Add runtime fields editor functional test
2021-03-08 15:54:59 -06:00
Davis Plumlee 4db502d85c
[Security Solution][Detection Rules] Rules table page size increase (#93993) 2021-03-08 16:53:36 -05:00
Xavier Mouligneau 5d96e5f334
[SECURITY SOLUTION] BUG Manual Alert in case (#93726)
* get the data where it belongs

* Fix layout when alert is deleted

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
2021-03-08 16:28:42 -05:00
spalger 5e634e9931 remove unused xpack.ml.alertContext.kibanaBasePathUrlDescription i18n key 2021-03-08 14:20:16 -07:00
Nathan Reese 7507d6417e
Convert file_upload components to typescript (#93814)
* Convert file_upload components to typescript

* i18n cleanup

* api doc updates

* fix i18n files

* tslint after merge

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-08 14:15:38 -07:00
Ryland Herrick 52787e9379
[Security Solution][Detections]Alerts migrations can be finalized/cleaned up in all spaces (#93809)
* Retrieve SOs by ID in a space-aware manner by using bulkGet

We were previously using a manual invocation of find(), which was a)
tied to the current implementation of how SOs generate their _ids, and
b) didn't respect spaces.

By replacing this with a call to bulkGet, which automatically respects
the space of the current request, and which abstracts away the building
of the actual _id based on the SO ID and type, we address the issues
above.

* Surface SO errors to the finalize/delete APIs

Now that we're using bulkGet, we receive an object with errors if the
object is not found, which by default breaks our subsequent validation.
In order to provider better UX, we re-raise the first of these errors
that we find, if present, and return that to the user.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-08 15:10:16 -06:00