* convert kbn test config into TS
* add test for Kibana embedded in iframe
* run embedded tests in functional suite
* ignore tls errors in functional tests by default
* switch test to https
* remove env vars mutation
* allow to pass ssl config to Kibana
* pass ssl config to axios
* adopt KbnClient interfaces
* adopt KibanaServer
* use KbnRequester in security service
* set sameSiteCookies:None in test
* acceptInsecureCerts in chrome
* remove leftovers
* fix type error
* remove unnecessary field
* address comments
* refactor plugin
* refactor test
* make acceptInsecureCerts configurable
* run firefox tests on ci
* up TS version
* fix firefox.sh script
* fix path
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Replace the Custom Color Picker on TSVB with the EuiColorPicker
* Remove the custom picker sass
* Remove private modules of eui and the custom color swatches
* Clear the color
* changes in test implementation
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [search] Refactor the way search strategies are registered/retrieved on the server
* Fix types and tests and update docs
* Fix failing test
* Fix build of example plugin
* Fix functional test
* Make server strategies sync
Co-authored-by: Liza K <liza.katz@elastic.co>
* update vega version
* a11y skip test
* a11y skip test attempt 2
* adding back all a11y tests
* fix failed karma test
* remove extra 0BSD license
* coalesce yarn.lock versions a little
* update kbn/pm dist
* fix CI
* fix Vega View for ML
Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Added example for using dashboard container by value
1.1 Refactored embeddable explorer e2e test to use new example, removed not needed kbn_tp_embeddable_explorer plugin.
For embeddable explorer examples went away from using getFactoryById() to improve type checks
There is new component a replacement for EmbeddableFactoryRenderer with slightly more flexible api: EmbeddableRenderer.
3.1 We can improve it going forward to support more use case
* implements RedirectCrossAppLinks component
* update doc
* review comments
* use `RedirectCrossAppLinks` in SOM SO table page
* update snapshots due to merge
* do not filter current app
* rename component
* fix snapshots
* add FTR tests
* review comments
* remove the `parseAppUrl` unused core API
* fix snapshots
* fix test plugin ts version
* add newline
* add babel support for export type
* bump ts version to 3.9.3
* rebuild kbn-pm
* bump typescript-eslint
* fix error in security plugin UI
* check export as works
* fix app migration type
* use correct test subj attribute
* fix errors from the old PR
* embeddable is already passed in props
* explicitly define type of fetch
* add some types for viz
* fix fetch type p.2
* add null to allow spreading without type errors due to override
* add type guard to fix type error
* cast to any, since cannot assign unknown
* add timestamp to known types
* fix type error in fetch
* fix type error. id is always defined in attibutes
* declare a type
* move ts-ignore to the lines with errors
* declare tuple type explicitly
* mute type error. cannot assign unknown
* fix errors. id is always defined
* fix error type
* fix override errors. id is always defined
* fix error. extends any doesn't work anymore
* fix type error. type is always defined
* env doesn't always contain values
* fix type error
* cast to string
* add: logs is already declared in getNodeLogsUrl
* state is already passed in props
* fix some errors in timelion
* number of fragments is always defined
* 'absolute' is not just string, but value
* TEMP: option is always defined
* always true if cast to promise manually
* both props are always defined
* explicitly define returned SO type
* workaround type
* bump tslib to be compatible with ts v3.9
* test private property
* rebuild kbn-pm
* Fix ts errors for beats management
* Fix type inference broken by the TS 3.9 upgrade
* Fix ingest manager saved object attributes typings
* Fix TS errors in cross_cluster_replication and index_management.
* Fix TS error in Watcher.
* roll back colorRange wrong type
* fix security plugin types
* TypeScript 3.9 fixes for APM
* Fix ColorRange types.
* fix actions & alerts errors. ByGidi
* fix lists error
* More APM fixes
* Remove paramaterization from `removeEmpty in agent config SettingsPage component (it's only used there and doesn't need to be parameterized.)
* Add option chain for case in registerTransactionDurationAlertType
* Cast `overallValue` in transform_metrics_chart
* Use more specific type for custom link filters
* Add more option chaining for local UI filters buckets response
* Remove unused parameters from routes
* Fix getProjection type parameter
* Use destructuring in serviceNodesLocalFiltersRoute to hide `never` error
* Revert `UnionToIntersection` change in `AggregationResponseMap`
Fixes#67804.
* fix platform type error
* Fix visualizations types.
* Fix data plugin types.
* bump TS version to 3.9.5
* Fix telemetry TS errors
* Fix dashboard code
* Adding Canvas Fixes for TS 3.9
* Fix case and security_solution types
* roll back to the old export syntax. new one might cause problems in api-extractor
* update docs
* Fix timelion code
* Fix meta
* Fix types
* fix type errors om ingest_manager
* bump babel deps
* enable private props & methods syntax
* update kbn-pm dist
* whitelist 0BSD license
* use @babel/plugin-proposal-private-methods in default set as well
* disable new babel plugins
* Revert "disable new babel plugins"
This reverts commit 04d959431d.
* cleanup security_solution types
* Fixes type error for newer TypeScript
* update docs
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>
Co-authored-by: Walter Rafelsberger <walter@elastic.co>
Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Co-authored-by: Tim Roes <tim.roes@elastic.co>
Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
Co-authored-by: FrankHassanabad <frank.hassanabad@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Kibana developer examples
* Batch explorer tests should be run in examples config
* Fix tests
* add codeowner for new developer examples plugin & readme cleanup
* Try to frame embeddable wording based on what a developer's goals are.
* Add noopener noreferer, fix bad merge
* Remove bfetch.png
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Migrated uiSettings items to new platform
* API changes
* Fixed translations
* Fixed comment and i18n
* Fixed tests
* Fixed internalization
* Fix karma tests
* made code more explicit
* Fixed plugin
* Added consts for ui settings ids.
* Added id for another settings
* Fixed tests.
* Improved imports
* Fix imports to public which were happening from the server.
* Fixed paths
* Moved styles to plugin.ts
* Moved styles
* Fixed docs
* Fix ci
* Fix ci
* fix documentation
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
* add skeleton for global_search plugin
* base implementation of the server-side service
* add utils tests
* add server-side mocks
* move take_in_array to common folder
* implements base of client-side plugin
* add tests for server-side service
* fix server plugin tests
* implement `navigateToUrl` core API
* extract processResults for the client-side
* fetch server results from the client side
* factorize process_results
* fix plugin start params
* move things around
* move all server types to single file
* fix types imports
* add basic FTR tests
* add client-side service tests
* add tests for addNavigate
* add getDefaultPreference & tests
* use optional for RequestHandlerContext
* add registerRoutes test
* add base test for context
* resolve TODO
* common nits/doc
* common nits/doc on public
* update CODEOWNERS
* add import for declare statement
* add license check on the server-side
* add license check on the client-side
* eslint
* address some review comments
* use properly typed errors for obs
* add integration tests for the find endpoint
* fix unit tests
* use licensing start contract
* translate the error message
* fix eslint rule for test_utils
* fix test_utils imports
* remove NavigableGlobalSearchResult, use `application.navigateToUrl` instead.
* use coreProvider plugin in FTR tests
* nits
* fix service start params
* fix service start params, bis
* I really need to fix this typecheck oom error
* add README, update missing jsdoc
* nits on doc
* rename siem to security_solution
* rename siem to security solution inside of code
* rename translation keys
* fix snapshot
* replace siem for security solution in tutorial
* missing translation to be renamed
* fix types for api test integration
* updates runner file to match the new path
* change category for kibana settings
* miss renaming in advance settings
* fixes cypress tests
* fix api integration test
* fix new translation
* fix unit test
* update translation i18n
* update translation i18n II
Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
* [New Platform Migration]: Management - Implement NP API
Part of #47432
* partial progress on a number of management sections
* fix passing history
* Fixed types
* Fixed routing for Ingest Node Pipelines
* introduce and use react router wrapped eui components
* react router utils
* work in progress => hashRouter to router
* more partial progress
* remove console.log
* use reactRouterNavigate for management_sidebar
* Breadcrumbs will need to make use of the reactRouterNavigate function
* [triggersActions] app. Hash Router -> Router
* Replace /app/kibana#/management urls to /app/management
* remove ui/public/management
* fix some links to management apps
* fix management url for functional tests
* add data-test-subj for EuiSideNavItem
* partial progress
* fix some of ts issues
* Fixed breadcrumbs for data index management
* [kibana/spaces] section
* fix functional test
* [role_management] fix Breadcrumbs
* [api_keys] fix Breadcrumbs and Navigation
* Fixed routing for remote cluster
* [role_mapping] Partial progress
* [users] partial progress
* [watcher] partial progress
* fix eslint issues
* [snapshot_restore] partial progress
* [rollup_jobs] partial progress
* Fixed routing for cross cluster replications (partial progress). Enhanced reactRouterNavigate
* Perf optimization: fix extra re-rendering
* fix TS errors
* x-pack fix config for functional tests
* Fixed routing for index lifecycle management
* fix some broken CI tests
* fix PR comment
* [snapshot_restore] move onClick into reactRouterNavigate
* fix some jest
* fix some functional tests
* fix functiona test: management scripted fields testing regression for issue
* fix some functional tests
* [licence_management] partial progress
* Fixed x-pack jest tests
* [saved_object_management] partial progress
* Fixed some tests
* fix functional test: should add new role myroleEast
* Reverted part of changes for ml
* [transforms] partial progress
* fix TS errors
* fix functional: redirects to Kibana home
* add support of Backward compatibility
* fix functional: Saved objects management feature controls saved objects management global visualize all privileges listing redirects to Kibana home
* fix PR comment
* fix TS issues
* Fixed x-pack jest tests
* fix oss JEST
* Fixed functional test
* fix functional test
* fix PR comment
* Fixed i18n
* fix typo
* fix Styles
* Fixed paths for cross_cluster_replication
* fix wrong link
* Fixed jest
* Fixed some comments
* fix sorting
* fix type check
* fixed x-pack jest
* fixed x-pack jest
* reverted using of parentHistory
* Add debugging toasts to CCR.
* Comment out non-CCR functional tests.
* Fix typo.
* Uncomment non-CCR functional tests.
* Enable CCR.
* fix CI
* Add comment to explain why CCR is enabled by default and move config variable back to original location in CCR plugin.
* revert some changes in APM
* add space between index pattern name and tags
* fix function test
* Update x-pack/plugins/security/public/management/management_urls.ts
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
* Update x-pack/plugins/security/public/management/api_keys/api_keys_management_app.tsx
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
* Update x-pack/plugins/spaces/public/management/spaces_management_app.tsx
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
* Update x-pack/plugins/security/public/management/roles/roles_management_app.tsx
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
* Update x-pack/plugins/security/public/management/users/users_management_app.tsx
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
* Update x-pack/plugins/security/public/management/management_urls.ts
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
* Update x-pack/plugins/security/public/management/management_urls.ts
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
* [security] getUrlForApp -> navigateToApp
* [mp] fix Uncaught (in promise) undefined
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
* add error if filter index pattern is gone
* docs change - why?
* Fix i18n
* Added a functional test for broken filters (field + index pattern)
* Clarify readme
* Moved readme
* New warning status
* Remove getAll
* git pull upstream master
* Fix translation files
* Fix merge
* added filterbar texts
* disabled correction
* Disable check in maps test until #64861 is resolved
* Fix tests, warning state is not disabled.
* Adjust warning filter - ignore filters from "foreign" index pattern, that are still applicable
* Add an additional unrelaeted filter test
* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
* Fixed test data
* Revert mapping
* Update data with missing test
* Update test to match data
* Code review
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Deangularize timechart header
* Add label attr to options
* Watch the interval prop change
* Tweaking the UI
Mainly moved interval notice to an `append` and copy updates
* Remove outdated i18n tokens
* fix functional test
* Change functional test due to dom changes
* fix functional test
* remove unecessary translation
* remove watcher as it is not necessary anymore
* change interval options copies
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
* create field for references and add comments
* add FTR test
* remove comments
* address comments
* use real reference in dataset and assert against it.
* [CODEOWNERS] set kibana-qa to own test/functional/services
* [functional/services] move low-level services to common folder
* update codeowners
* update imports
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [Reporting/Test] Add Functional test for download CSV
* add todo
* add fs.existsSync check to find download
* debug
* handle timeout
* validate toast
* different way of getting repo_root
* forwardport #64999
* Add additional verifications on dashboard
I hope you don't mind me updating the test directly.
I *thought* the other dashboard tests required a consistent set of exact documents so that the count would always be the same. Since the test uses sample data, I added a new timepicker:quickRanges so that the test can just select it. Test FTR isn't set up to do relative time ranges right now.
But it looks like the dashboard checks aren't that specific to the data. The dashboard seems to have `Last 24 hours` saved in it. And when I don't change it to the whole sample data time range the test still passes.
* fix eslint error
* [page_objects/time_picker] allow any string in setCommonlyUsedTime
Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
* Deserialize bulkCreate response to remove namespace type from id
* Index operations don't return _source in response
* Fix integration tests
* repository: make id generation and seq_no/primary_term spreading more explicit
* API Integration test for bulk create without ids
* Fix copy_to_space snapshot
* Revert "Fix copy_to_space snapshot"
This reverts commit 9c2b7433e3.
* Move test into returns block
* repository.test.js stricter regexp matching
## Summary
Fixes the non-legacy ES test client to work with SSL.
Without this if you try to migrate `siem rules` or `alerting` or `CASE` or anything else that is using SSL based tests you get this error when trying to use the non-legacy:
```ts
// pull in non-legacy service for functional tests
const es = getService('es');
```
```ts
// use it somewhere where your config.ts is utilizing SSL in a functional test
// ...
```
In your console you get this error:
```ts
ConnectionError: self signed certificate in certificate chain
at onResponse (node_modules/@elastic/elasticsearch/lib/Transport.js:205:13)
at ClientRequest.request.on.err (node_modules/@elastic/elasticsearch/lib/Connection.js:98:9)
at TLSSocket.socketErrorListener (_http_client.js:401:9)
at emitErrorNT (internal/streams/destroy.js:91:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
at process._tickCallback (internal/process/next_tick.js:63:19)
```
This fixes that by adding the CA certs from test to the ES test client.
* move core provier to NP. allows to run tests on every page
* remove no-base-path
* pass whole KbnTestServer config
* fix build path
* another id
* np
* build kibana tests plugins. it is used in xpack tests
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This PR migrates the vast majority of Alerting legacy code to the Kibana Platform.
This includes:
1. Removed legacy Task Manager
2. Migrates Fixture plugins in Alerting, Triggers UI and Task Manager Perf
This does not includes:
1. The PagerDuty simulator due to a lack of support for custom responses in the platform. issue opened. https://github.com/elastic/kibana/issues/65045
2. The Webhooks simulator due to a lack of support for custom authorisation. Requires investigation.
* Bind non primary time fields to timepicker
* Fix typescript argument types
* Allow auto interval on all fields
* Remove lens_auto_date function
* Fix existing jest tests and add test todos
* Remove lens_auto_date from esarchives
* Add TimeBuckets jest tests
* Fix typo in esarchiver
* Address review feedback
* Make code a bit better readable
* Fix default time field retrieval
* Fix TS errors
* Add esaggs interpreter tests
* Change public API doc of data plugin
* Add toExpression tests for index pattern datasource
* Add migration stub
* Add full migration
* Fix naming inconsistency in esaggs
* Fix naming issue
* Revert archives to un-migrated version
* Ignore expressions that are already migrated
* test: remove extra spaces and timeField=\\"products.created_on\\"} to timeField=\"products.created_on\"}
* Rename all timeField -> timeFields
* Combine duplicate functions
* Fix boolean error and add test for it
* Commit API changes
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
* Adds telemetry API tests for oss
* Modifies test expectations to match that within oss
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* set files to track for coverage collection
* increase timeout to 4h
* trying to add detectOpenHandles to avoid worker stuck
* update config
* make config paths more common
* update configs
* update jest oss config
* exclude 'tests' folder for coverage
* bring testing on Firefox back
* disable some tests
* skip more tests
* cut more suites for Firefox
* skip more tests for Firefox
* replace smoke tag with includeFirefox
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* snapshot updates
* bump to eui 22.3.0
* snapshots
* Fix css selector in test to match EUI internal DOM change
* Updated snapshots
* Insert react-beautiful-dnd@10 into top-level kibana to force siem's node_modules to hold its correct version
* More snapshot updates, resolved a typescript issue
* Move react-beautiful-dnd dependency around to make things happy again
* Use SearchFilterConfig from the top-level eui export
* Swallow 'ResizeObserver error does not have an err object' error in canvas
* Swallow ResizeObserver error cross-browser
* Attempt at deangularization, nr.2
* Remove padding in fullscreen
* Fixing failing functional test
* Fixing remaining functional test
* Fixing typescript errors
* Fixing filter bar not being visible in fullscreen
* Fixing filter bar not being visible in fullscreen
* Rebasing against master
* Fixing a small leftover
* Fix order of functions
* Fixing linting error
* Changing noPadding to a custom class
* Use filterManagers to handle filters
* Rename class
* Attempt at deangularization, nr.2
* Remove padding in fullscreen
* Fixing failing functional test
* Fixing remaining functional test
* Fixing typescript errors
* Fixing filter bar not being visible in fullscreen
* Fixing filter bar not being visible in fullscreen
* Rebasing against master
* Fixing a small leftover
* Fix order of functions
* Fixing linting error
* [APM] Agent config select box doesn't work on IE (#63236)
* adding value property to select options
* fixing test
* Use globe icon for "ext" span type on service map (#63205)
Both "external" and "ext" can be returned and should have the same icon.
* Move shared vislib components into Charts plugin (#62957)
* Closes#56310
Move shared vislib components into Charts plugin
* Fixed imports in tests
* Changed i18n IDs to match charts namespace
* Renamed ColorSchemaVislibParams to ColorSchemaParams, added enums and got rid of useValidation function
* Renamed ColorSchemaVislibParams to ColorSchemaParams and got rid of useValidation function
* Fixed merge conflict
* Replaced enums with objects again
* Make uptime alert flyout test a little more resilient (#62702)
* [SIEM] [Cases] Unit tests for case UI components (#63005)
* Endpoint: Remove unused `lib` module (#63248)
* [Lens] Fix error in query from generated suggestion (#63018)
* [Lens] Fix error in query from generated suggestion
* Update from review comments
* Fix test
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Resolver/node svg 2 html (#62958)
* Remove some SVG in Resolver nodes and replace with HTML
* [Reporting] convert all server unit tests to TypeScript (#62873)
* [Reporting] convert all server unit tests to TypeScript
* fix ts
* revert unrelated change
* [SIEM] Link ML Rule card CTA to license_management (#63210)
* Link ML Rule card CTA to license_management
Taking the user directly to the license management page within kibana
(where they could immediately start a trial subscription) is much more
actionable than taking them to the subscriptions marketing page.
* Revert translation key change
Neither of these is totally accurate, and there've already been
translations written for the old one.
* Correctly type ILM's optional dependencies as optional (#63255)
And guard against their absence.
* [Telemetry] use prod keys (#63263)
* update chromedriver dependency to 81.0.0 (#63266)
* task/mac-eventing-form (#62999)
adds mac events form for endpoint policy details
Co-authored-by: oatkiller <robert.austin@elastic.co>
* bc6 rule import april 9 (#63152)
* bc6 rule import april 9
Increased the lookback of the ML rules
* re-import
with LF chars
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Added UI for pre-configured connectors. (#63074)
* Added UI for pre-configured connectors.
* fixed due to comments
* Fixed jest tests
* Fixed due to comments and added some functional tests
* test fix
* Fixed failed checks
* Fixed functional tests failing
* TaskManager tasks scheduled without attempting to run (#62078)
* TaskManager tasks scheduled without attempting to run
* Removing unused import
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Changed alerting wrong param name for help xpack.encrypted_saved_objects.encryptionKey to xpack.encryptedSavedObjects.encryptionKey (#63307)
* fix ScopedHistory.createHref to prepend location with scoped history basePath (#62407)
* fix createHref to prepend with scoped history basePath + add option to exclude it.
* fix prependBasePath behavior
* fix test plugins urls
* add pathname to endpoint url builder methods
* Revert "add pathname to endpoint url builder methods"
This reverts commit 7604932b
* adapt createHref instead of prependBasePath
* use object options for createHref
* update generated doc
* fixing custom link popover size and hiding scroll (#63240)
* Changing noPadding to a custom class
* Use filterManagers to handle filters
* Rename class
* Applying some changes
* Reverting search_bar code changes
* Removing some stuff that was causing functional tests to fail
* Removing refresh dashboard container which was causing errors during navigation
* Do not destroy dashboardContainer
* Adding updateSavedQueryId method
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Co-authored-by: DianaDerevyankina <54894989+DianaDerevyankina@users.noreply.github.com>
Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Robert Austin <robert.austin@elastic.co>
Co-authored-by: Wylie Conlon <william.conlon@elastic.co>
Co-authored-by: Brent Kimmel <bkimmel@users.noreply.github.com>
Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
Co-authored-by: Dmitry Lemeshko <dzmitry.lemechko@elastic.co>
Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
Co-authored-by: The SpaceCake Project <randomuserid@users.noreply.github.com>
Co-authored-by: Yuliia Naumenko <jo.naumenko@gmail.com>
Co-authored-by: Brandon Kobel <brandon.kobel@elastic.co>
Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>
The needed change is to rely on history as source of truth for location instead of window.location.
btw, This makes possible to test state syncing utils integration using createMemoryHistory()
One issue was discovered after this change:
When switching from context to discover url was incorrect. history.location inside state syncing utils didn't get the last update. This happened, because history instance created in discover wasn't used in context app and when all listeners unsubscribed from it - it stopped receiving location updates. To fix this I just reused one history instance in discover, context and their kbnUrlTracker
* Move server code into NP folder
* NP config is not yet used
* Relative imports are somewhat broken
* Move common folder into NP
* Move cypress folder into NP
* Move scripts folder into NP
* Move misc. config into NP folder
A few of these were moved into the cypress folder as they're
cypress-specific.
I tried to update all the relative paths but some are likely broken. I'm
not going to know until other stuff is fixed, though.
* Move value for siem index pattern into common/constants
The other default values live in there, this is no different.
* Update paths following file move
If this was referencing the full project, it now references both paths
(legacy for UI, and NP for server).
* Fix typescript errors related to module resolution
These are mostly updating imports to the common/ folder on the UI side
(since things changed relative to those files).
* Replace Legacy Config with NP Config
* Updates plugin to use NP config
* defines new config previously coming from savedObjects config
* cleans up legacy types
Conflicts:
x-pack/plugins/siem/server/lib/detection_engine/routes/rules/export_rules_route.ts
x-pack/plugins/siem/server/lib/detection_engine/routes/rules/import_rules_route.ts
x-pack/plugins/siem/server/lib/detection_engine/rules/types.ts
x-pack/plugins/siem/server/plugin.ts
x-pack/plugins/siem/server/routes/index.ts
x-pack/plugins/siem/server/types.ts
* Remove local SIEM tsconfig
This was originally added to address an issue with tsserver, but that
issue is no longer relevant. The presence of this file confuses
typescript into thinking that siem is a separate TS project.
* Update kibana.json to declare our dependencies
These are not necessarily correct in terms of what's required/optional,
but this is what's declared in our types.
* Remove legacy plugin instantiation
* Removes legacy instantiation of server plugin, which is now handled by
NP
* Loosens legacy config spec so we no longer have to duplicate config
types
* Update tests with NP config
These were written against the old Hapi config function; now, we just
have a POJO.
* Update es_archiver helpers' paths
I'm not quite sure if these are working yet, but they're no longer
throwing errors.
* Ignore restricted path on script
This was cribbed from infra, who has made a similar change.
* Ignore restricted path on temporary savedObject mappings import
This will be changed subsequently when we switch to the NP form of
savedObject type registration.
* Add symlink to lockfile
* Fix paths on circular deps script
* Add separate config for Rule and Timeline saved objects
We had previously used the savedObjects' config, but those are not
currently exposed to us on New Platform. For now, we're going to split
this into two sets of values for the SOs we deal with
importing/exporting within the SIEM app, with the same defaults as
savedObjects.
* Fixing relative paths within cypress
These are strings that wouldn't be caught by typescript.
* add HttpResources basic implementation
* expose http resources to plugins
* add mocks
* move http resources to a separate service
* hide rendering service
* adopt internal types
* expose HttpResources service to plugins
* update platform mocks
* plugins start using HttpResources API
* remove RenderingServiceSetup export
* RenderingServiceSetup --> InternalRenderingServiceSetup
* improve types
* remove httpRespources leftovers from http service
* remove rendering types from RequestHanlderContext
* fix security plugin tests
* add unit tests for httpResources service
* add unit tests
* remove outdated cache-control header
* restructure http resources service
* merge getUiPlugins and discover
* static route declaration shouldnt require auth & validate
* update docs
* use HttpResources service instad of rendering
* address comments
* update docs
* roll back unnecessary changes
* use getVars for rendering
* dont pass app. it is not public API
* remove static registers
* update migration guide
* Add embeddable via saved object example
* give todoRefEmbed a different name from the by value one
* fix types
* fix order of unmounting
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
getHref on Action interfaces in uiActions plugin is now async. getHref is now used only to support right click behaviour. execute() takes control on regular click.
* [Metrics UI] Refactor containers to hooks
* clean up depends; move useInterval out of useWaffleTime;
* converting WithWaffleFilters to useWaffleFilters
* Removing WithWaffleOptions
* Refactor WithWaffleViewState to useWaffleViewState
* Removing obsolete files
* Fixing race condition with complext state
* Adding undefined to RisonValue; unwinding changes trying to work around bad type
* Switching to context
* Change assertion to ignore the length of the current URL
* Fixing test frameork to accept urls longer then 230 characters
* Fixes#59395; Refactor WithMetricsTime to hook; Fixes brushing on metric detail page; fixes refresh button on metric detail page
* Fixing tests with adding timeRange
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Fixes following cases:
Saving dashboard with pinned filter unpins it. Do not save pinned filters with dashboard see #62301 (comment)
When navigating with global filter to dashboard with same saved filter, filter becomes unpinned
When navigating from listing to dashboard with saved filter, back button didn't work
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* bump dependency, add edge support in ftr services
* add config files
* fix browser version for msedge
* use npm ms-chromium-edge-driver
* download edge driver aside from session creation
* move dependency to dev
* update dist/index file
* bump edge-driver version
* change type to msedge to match w3c spec
* fix discover tests for Edge
* Revert "fix discover tests for Edge"
This reverts commit 87e7fdd256.
* bump driver version up
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Move the default_editor to NP
* Fix paths
* Import styles through the visualize
* Other fixes
* Fix ip_ranges exhaustive-deps array
* Fix filters and extend bounds
* Other fixes
* Fix date_ranges tests
* Use useMount on first render
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* enable w3c for chrome
* update maps tests
* update maps tests
* update common_page
* Revert "update maps tests"
This reverts commit 31f43fd678.
* revert changes to maps tests
* undo after removal
* update expect range to pass on Windows, unskip tests for Firefox
* print out value for discover brushing test
* log first timestamp
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* simplify new index pattern button click method
* replace method name to match previous commit
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* update cache-control header
* update tests
* update test run config
* remove custom cache-control header for authentication resources
* address test flakiness
* address PR feedback
* revert changes to endpoint test
* revert changes for real this time
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Remove absoluteToParsedUrl reference in dashboard
* Remove KibanaParsedUrl from visualize
* Fix tests
* Add tests
* Fix saved dashboard
* Fix empty line after resolving conflicts
* Move dashboard to np
* Move migrations back to legacy
* Make it works
* Other fixes
* Move into application folder
* FIx translations
* Make share & home plugins otional
* FIx kbn url tracking, jest tests
* Import from dashboard_constants in FT
* Fix translations order
* Use getStartServices for start plugin deps
* Path fixes
* i18n fix
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Unskip
* Set only suite
* Add field search
* Use alternative flaky fix
* Remove extra actions
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1. Change logic around deciding wether to use time from url or from saved object. Previously code looked only into if _g is present in the url at all. And didn't consider edge case if time or refreshInterval is missing in _g
2. Fix initial syncing of time from savedobject causing redundant history record. _This changed caused order of _a and g params in url change. One test was affected by it because it relied on the order. I don't think it should be considered breaking as order app puts it's query params shouldn't matter.
3. Fix another race condition between state syncing with url and angular controller $destroy. Similar fix was done before in #57795, but this on covers case when we stay within dashboard app, but change dashboard
4. Fix initial panel state migration causing redundant browser history records
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* wip
* typescript map embeddable
* More updates
* Address code review comments and update some usages in SIEM and uptime to the new types
* More clean up - carry over some of the SIEM types to maps for render tool tip
* fixes
* fixes
* Address more review comments
* fixes
* fixes
* fix jest test
* Fix visualize embeddable
* fixes after master merge
* Fixes
* Prefix variable with name "custom" to make it more obvious
* Remove layerList from input state
* fixes
* Update src/plugins/dashboard/public/embeddable/dashboard_container_factory.tsx
Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com>
* review updates
* fixes
* update maps readme
Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>
* accessibility tests for dashboard panel
* added back the skipped test as it is still required to pass through the a11ySnapshot
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Migrated sample_action to NP. Panel action tests returned to the test flow.
* fixed names
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [ci/es] always pull snapshots, break early when they're not available
* move to setup.sh after deps are installed
Co-authored-by: spalger <spalger@users.noreply.github.com>
* Auto interval on date histogram is getting displayed as timestamp per 0 milliseconds when x-axis bucket is collapsed
Closes#57822
* Fixed incorrect interval label displaying while scaling the chart.
* Updated agg.test.tsx snapshot
* Got rid of context and refactored agg hooks
* Fixed agg.type.name check
* Added functional tests to cover the date histogram interval editing
* Fixed some expected values in tests
* Updated some test cases
* Added a new visualization to visualize archive
* Added testSubjects service to replace find where possible
* Updated tests to match updated behavior
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Migrated kbn_tp_custom_visualizations to the new platform
* skip test instead of deleting
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Migrated top nav plugin test to the new platform
* Removed old plugin. Some refactoring.
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Catch invalid calendar exception
* Use isValidEsInterval directly
* Show field error message right away
* Fix for the case 2w
* Update time_interval.tsx
* Restructure validation
* Rename fn to isValidCalendarInterval
* Refactoring
* Update time_interval.tsx
* Add functional tests
* Add functional tests for interval
* Update _area_chart.js
* Don't show error when value is empty
* Use error message from InvalidEsCalendarIntervalError
* Update _area_chart.js
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* unexpose SavedObjectsManagement from legacy server
* migrate saved object management routes to new plugin
* fix endpoint methods
* adapt code due to rebase
* extract types
* improve findAll params
* adapt existing api integration tests and migrate to TS
* update generated doc
* add API integration tests for /scroll/count
* add unit tests for plugin and routes
* add injectMetaAttributes tests
* extract relation type
* add find_relationships tests
* add find_all tests
* do not complete migrator$ to avoid unhandled promise rejection
* fix data for search endpoint integration tests
* remove falsy comment
* rename plugin folder to match plugin id
* address review comments
* update CODEOWNERS
* create coverage folder only if json file being saved
* skip some tests
* unskip test
* do not fail coverage run if some tests fail
* unskip fixed test
Added an emphasize prop to the top nav menu item and used it for a new 'Create new' button which redirects to the 'new visualization' modal.
Co-authored-by: Ryan Keairns <rkeairns@chef.io>
* just a demo of function to return saved object table elements
* fix esArchive data, extend import objects test case for relationships
* improved data-test-subjs
* update snapshot for jest test
* unskip other half of the tests
* removed commented-out code
* use new findByTestSubject methods
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [Telemetry] Migration to NP
* Telemetry management advanced settings section + fix import paths + dropped support for injectVars
* Fix i18nrc paths for telemetry
* Move ui_metric mappings to NP registerType
* Fixed minor test tweaks
* Add README docs (#60443)
* Add missing translation
* Update the telemetryService config only when authenticated
* start method is not a promise anymore
* Fix mocha tests
* No need to JSON.stringify the API responses
* Catch handleOldSettings as we used to do
* Deal with the forbidden use case in the optIn API
* No need to provide the plugin name in the logger.get(). It is automatically scoped + one missing CallCluster vs. APICaller type replacement
* Add empty start method in README.md to show differences with the other approach
* Telemetry collection with X-Pack README
* Docs update
* Allow monitoring collector to send its own ES client
* All collections should provide their own ES client
* PR feedback
* i18n NITs from kibana-platform feedback
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Fix formatter on range aggregation
* Fix test that was using unformatted byte ranges
* Fix test
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* update to eui 21.0.1
* most changes needed for search bar ts changes
* Passing types
* snapshots
* jest tests
* Removed IQuery placeholder types
* Updated functional test to only look at table headers with content
* Moved 'filters' definition around in api docs
* Update types
* update snapshot
* typo
* Move DATA_FRAME_TASK_STATE enum to its own file to fix x-pack functional test config imports
* merge public api 'changes'
Co-authored-by: patrykkopycinski <patryk.kopycinski@elastic.co>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
Adds Navigation APIs to Alerting.
Parts to this PR:
Adds a client side (Public) plugin to Alerting, including two APIs: registerNavigation & registerDefaultNavigation. These allow a plugin to register navigation handlers for any alerts which it is the consumer of- one for specific AlertTypes and one for a default handler for all AlertTypes created by the plugin.
The Alert Details page now uses these navigation handlers for the View In App button. If there's an AlertType specific handler it uses that, otherwise it uses a default one and if the consumer has not registered a handler - it remains disabled.
A generic Alerting Example plugin that demonstrates usage of these APIs including two AlertTypes - one that always fires, and another that checks how many people are in Outer Space and allows you to trigger based on that. 😉 To enable the plugin run yarn start --ssl --run-examples
This PR adds basic functional tests for the file data visualizer, covering a file import and error messages for non-log files. It also moves the file input path handling to a common location in order to avoid code duplication.
* initial implementation of configurable test users
* user superuser by default to match master
* referenced the configs in reporting and api integration
* setting the minimum number of default roles
* looking for x-pack tests with users and roles
* add testUserService in dashboard mode tests
* running only ciGroup7
* uncommenting - addign visualization
* re-enabling all CI groups to run on CI
* reinstating Jenkinsfile
* disable Test user for OIDC config
* improved logging and added Roles for OSS tests to get better info on the runs.
* disable test_user for auth tests
* don't fetch enabledPlugins when testuser disabled
* fix es-lint
* running oss tests with x-pack enabled
* [revertme] build default dist for oss tests
* updating NOTICE.txt file as it complained in the kibana intake tests
* changed to pick OSS builds
* trying a license change to trial
* switch back to xpack builds
* created a new sample data role and used it in homepage tests
* revert test/scripts/jenkins_ci_group.sh
* only refresh browser and wait for chrome if we are already on Kibana page
* fix large_string test to use minimum set of roles and privileges
* fix for date nanos custom timestamp with a configured role
* changes to the files with addition of new roles for the test_user
* reverting to OSS changes and few additions to the time_zone test to run as a test_user
* changes to security
* changes to the x-pack test to use elastic superuser
* fix for chart_types test
* fixes to area chart , input control test
* fix for dashboard filtering test and a new config role
* changes to handle the x-pack tests
* additional role for date nanos mixed
* added the logstash role to the accessibility tests
* removed telemetry setting
* docs+few changes to the tests
* removed Page navigation
* removed pageNavigation which was unused
* test/accessibility/apps/management.ts
* update management.ts
* aria label, and other changes
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* reverted
* unloading of logstash data, fixing aria label
* aria-label
* added the required role
* fix for tsvb chart
* fix for sample data test reverted home_page pageobject file
* changes to sample data test and visualize index file to incorporate OSS changes
* changes to describe() and some more changes to incorporate in settings_page
* re-adding the after()
* removed unwanted roles
* replaced kibana_user with kibana_admin
* added the check of deprecated kibana_user
* testing with kibana_admin role
* fix for discover test
* incorporated the review comments
* incorporated the review comments
* incorporate review comments and added restoreDefaults()
* removed describe.only
* reverted the OSS logic change I had here- pulled into seperate PR
* incorporated the review comments
* incorporated review changes
* adding hidden=true to find hidden kibanaChrome
* change field.test.tsx to be same as that of master branch
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>