Commit graph

8670 commits

Author SHA1 Message Date
Devon Thomson
5c447f6642
one liner fix for lens save modal retaining the originating app connection after it has been severed (#85309) 2020-12-10 10:19:27 -05:00
Gidi Meir Morris
015f3c994b
[Alerting] Introduces a ActionSubGroup which allows for more granular action group scheduling (#84751)
This PR introduces a new concept of an _Action Subgroup_ (naming is open for discussion) which can be used by an Alert Type when scheduling actions.
An Action Subgroup can be dynamically specified, unlike Action Groups which have to be specified on the AlertType definition.
When scheduling actions, and AlertType can specify an _Action Subgroup_ along side the scheduled _Action Group_, which denotes that the alert instance falls into some kind of narrower grouping in the action group.
2020-12-10 15:16:42 +00:00
Angela Chuang
0b929f340e
fix layout on safari (#85442)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-10 15:09:37 +00:00
Luke Elmers
3b5ed46c9d
[data.search] Clean up arguments to esaggs. (#84973) 2020-12-10 07:40:50 -07:00
Aaron Caldwell
ad922d0f59
Geo containment alert sparsity handling: preserve active status for non-updated alerts (#85364)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-10 07:27:01 -07:00
Christos Nasikas
a740a3f8ca
[Security Solution][Case] Alerts comment UI (#84450)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
2020-12-10 16:17:47 +02:00
Tiago Costa
07f90fa626
skip flaky suite (#84020) 2020-12-10 13:50:07 +00:00
Jean-Louis Leysens
f6c149f4f2
[ILM] Moved error and loading notices for data allocation (#85154)
* moved error and loading notices for data allocation field to below description

* removed test code

* expect controls to be showing, only render notice after network request has finished

* added loading spinner for field inputs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-10 14:39:57 +01:00
Anton Dosov
cb29438b0d
[Search] Fix dashboard embeddables don't refetch on searchSessionId change (#84261) 2020-12-10 14:21:35 +01:00
ymao1
488591560b
Fixing recovered instance reference bug (#85412) 2020-12-10 07:20:53 -05:00
Jean-Louis Leysens
dbd14ad39f
[ILM] Add shrink field to hot phase (#84087)
* moved shrink field to shared_fields and added it to the hot phase

* updated test

* update legacy jest test

* removed configuration context for now

* remove unused i18n and remove duplicated isRolloverEnabled check;

* fixed shrink field to use new described field component

* added test for removing shrink field in serialization and re-ordered fields in hot phase advanced
2020-12-10 10:50:31 +01:00
Dario Gieselaar
04428ff93b
[APM] Service overview: Dependencies table (#83416)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-10 10:32:01 +01:00
Shahzad
29235267c9
[Uptime ]Update empty message for certs list (#78575)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-10 10:08:06 +01:00
Joe Reuter
2038582358
[Graph] Fix graph saved object references (#85295) 2020-12-10 09:36:06 +01:00
Cauê Marcondes
af9492b301
[APM] Create new API's to return Latency and Throughput charts (#85242)
* breaking /transactions/charts into /latency and /thoughput

* adding unit tests

* fixing UI

* fixing i18n

* addressing pr comments

* fix api test

* refactoring some stuff

* addressing pr comments

* addressing pr comments

* fixing test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-10 09:14:39 +01:00
Xavier Mouligneau
0f408041b4
[SECURITY SOLUTION] Bundles _source -> Fields + able to sort on multiple fields in Timeline (#83761)
* replace _source with fields

* wip

* unit test

* regroup sorting and number together

* fix bugs from review

* mistake

* Update x-pack/plugins/security_solution/public/timelines/components/timeline/body/column_headers/index.tsx

Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>

* fix snapshot

* review + fix topN and filter from detail view

* fix tests

* fix test

Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
2020-12-09 22:16:38 -05:00
Nicolas Chaulet
c9b5ec7303
[Fleet] Update agent listing for better status reporting (#84798) 2020-12-09 21:07:31 -05:00
Andrew Wilkins
d8a9407a8d
[APM] enable 'sanitize_field_names' for Go (#85373)
https://github.com/elastic/apm-agent-go/pull/856 added
central config support for 'sanitize_field_names' to the
Go agent, so we can now enable it in the UI too.
2020-12-10 09:34:40 +08:00
Larry Gregory
6dfdbe2e83
Introduce external url service (#81234)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-09 18:11:53 -05:00
Larry Gregory
3b9c2e4e9c
Deprecate disabling the security plugin (#85159)
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-09 18:08:49 -05:00
Paul Tavares
6c52ac84c6
[FLEET] New Integration Policy Details page for use in Integrations section (#85355)
* new UI route to show Edit Package Policy page
* Package policy List items point to new Integration Policy details page
* Refactor to use common service to generate pkgKey
* add breadcrumb for edit policy under integrations
2020-12-09 17:50:33 -05:00
Frank Hassanabad
5bb47d48b0
[Security Solutions][Detection Engine] Fixes one liner access control with find_rules REST API
## Summary

Fixes one liner access control where during the project rename, one got named to `access` instead of `access:securitySolution`
2020-12-09 15:07:22 -07:00
Nicolas Chaulet
2355dde1e9
[Fleet] Support editing bool variable in agent policy (#85070) 2020-12-09 14:50:51 -05:00
Aleh Zasypkin
88e61a6651
Migrate API keys functionality to a new Elasticsearch client. (#85029) 2020-12-09 20:43:24 +01:00
Christos Nasikas
8b5c68ab63
[Alerts] Hide case connector (#85398)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-09 21:38:41 +02:00
Trent Mick
e3f150513c
[APM] Add log_level config option to the Node.js Agent (#85346) 2020-12-09 10:25:23 -08:00
Yara Tercero
21ea4f7a6f
[Security Solution][Detection Engine] - Improve DE query build times for large lists (#85051)
## Summary

This PR addresses the following issues:
- https://github.com/elastic/kibana/issues/76979
- https://github.com/elastic/kibana/issues/82267
- removal of unused lucene exceptions logic
2020-12-09 13:18:37 -05:00
Jonathan Buttner
e8a8f20932
[Security Solution] [Resolver] Supporting configurable ID (#84365)
* Trying to flesh out new tree route

* Working on the descendants query

* Almost working descendants

* Possible solution for aggs

* Working aggregations extraction

* Working on the ancestry array for descendants

* Making changes to the unique id for  ancestr

* Implementing ancestry funcitonality

* Deleting the multiple edges

* Fleshing out the descendants loop for levels

* Writing tests for ancestors and descendants

* Fixing type errors and writing more tests

* Renaming validation variable and deprecating old tree routes

* Renaming tree integration test file

* Adding some integration tests

* Fixing ancestry to handle multiple nodes in the request and writing more tests

* Adding more tests

* Renaming new tree to handler file

* Renaming new tree directory

* Adding more unit tests

* Using doc value fields and working on types

* Adding comments and more tests

* Fixing timestamp test issue

* Adding more comments

* Adding timerange and filters

* Updating schema

* Fixing timestamp test issue take 2

* Updating tests to use raw filter

* Adding time to generator

* Adding time filter and tests for retrieving lifecycles

* Removing min array size

* Updating the DAL

* Adding time range iso format

* Working on middleware

* Fleshing out middleware and actions

* Adding id, parent, and name fields to the top level response

* Adding logic for identifying when the view is moved

* WIP: updated data layers and selectors

* Switching to use isAnimating

* WIP: tree is displayed

* WIP: need events data for panel and fix tests

* Removing panning logic, adding comments and renaming things

* WIP: added name to graph

* Writing tests for the models

* Fixing generator start and end time generation

* Updating the mocks with the new interface

* Revert "Fixing generator start and end time generation"

This reverts commit c42ffd75c1.

* WIP: remove unnecessary front end data transformation

* Starting on loading state for nodes and details

* Find the terminated nodes in the middlewaree

* Fixing ingest tests

* Loading states seem to be working

* Removing some todos

* undo graphNodePositions naming

* Node loading state svg and pulse

* Fixing time range

* undo name changes, cleanup

* Creating mock that leverages the generator

* update tree generator

* log nested data in simulator.debugActions()

* change newResolverTree to resolverTree

* fix oneNodeWithPaginatedEvents mock and node events of type test

* Refactoring data reducer test and changing resolverTree DAL

* WIP: updating mocks

* remove deprecation tags

* Fixing the isometric tests

* Fixing process event tests

* updated resolver_tree mocks, update tests

* update additional tests

* fixing eslint

* fixing has more selectors

* update tests

* debugging click test

* Working node loading test

* Adding error cube and another test

* Adding a test for the error case

* use stored indices, update event api call for winlog, cleanup todos

* Adding more comments and restricting the analyze event to only endpoint and winlogbeat

* update to use schema provided by backend

* Fixing some type errors

* Fixing translation issue

* Fixing type errors

* Adding reload functionality

* Fixing translation issue

* Adding more tests for reload

* Cleaning comments up

* adding legend and schema info

* added legend and info popovers

* removed comment

* Adding comments and cleaning up stuff

* add schema and dataSource to mock actions

* Fixing some type errors and starting to address feedback

* Moving mock function

* Handling powershell events

* Adding test for winlogbeat schema

* remove cube loading className in favor of styledComponent

* fix closeAnalyzer jumping from middle of screen when resolver loads

* fix originID casing

* Cleaning up middleware and renaming time range

* Fixing node details test and some of the use selectors

* Fixing tests and types

* fix popover style, cube style, specific timestamp, some translations

* Fixed a test, and continuing to address feedback

* Addressing more feedback

* Refactoring the node data loading tests

* Adding selector for indices

* fix i18n, break apart graph controls, fix process event dot styles

* fix type error, styled description lists, nodeID

* style fix

* Removing unneeded test subjects

* recursion, recursion, recursion

* Calculating ancestors, descendants, generations once in factory and refactoring state

* Removing stringify replacer

* Adding default timerange to be beginning of epoch to max date in future

* refactoring winlog event query to use winlog record_id field

* fix popover toggle

* Fix type issue

* fix popover toggle

* add some tests

* fix types

* Adding link to time range comment

Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-09 12:44:59 -05:00
Zacqary Adam Xeper
a0d69ca209
[Metrics UI] Add process list header, tooltip, and empty prompt (#85202)
* [Metrics UI] Add process list header, tooltip, and empty prompt

* CPU Time -> Time
2020-12-09 11:39:06 -06:00
MadameSheema
6be8f63b52
updates cypress readme (#85434) 2020-12-09 18:26:11 +01:00
Nathan Reese
31b42a3bc7
[Maps] use index-pattern field display name in UX (#84945)
* [Maps] use index-pattern field display name in UX

* use less complex solution for es agg label

* rename

* tslint

* one more tslint fix

* review feedback

* update field_editor snapshots

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-09 10:17:05 -07:00
CJ Cenizal
43a1ae50c0
Remove 'minute' frequency option from SLM policy form because ES won't allow a frequency faster than every 15 minutes. (#84854)
* Add frequencyBlockList prop to CronEditor to allow selectively removing frequency options.
* Add unit test coverage for CronEditor component.
* Convert es_ui_shared cron editor component to TypeScript.
2020-12-09 09:14:57 -08:00
Nathan Reese
b045a95399
[Maps] keep local metrics editor state and only submit metrics to redux store when valid (#84828)
* [Maps] keep invalid metrics editor state local and only submit metrics state when valid

* review feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-09 10:07:22 -07:00
Aaron Caldwell
4a94fa0b78
Add geo-containment to kibana feature config (#85221) 2020-12-09 09:26:31 -07:00
Aaron Caldwell
402641ed9d
Update config usage from geoAlerts -> geoAlerting (#85220) 2020-12-09 09:25:58 -07:00
Thom Heymann
039c8e1894
Add required version number to audit log (#85390)
* Add required version number to audit log

* Added suggestion from code review
2020-12-09 16:07:50 +00:00
Melissa Alvarez
93670ec81f
[ML] Data frame analytics: Adds job deletion and creation to map view (#84299)
* wip: delete job node and update map

* adds ability to delete job and update map

* create job from index node

* can clone job from map

* reset map button

* remove trained model node when deleting job

* remove related model node. remove map tab when root node deleted

* ensure model with no job shows up correctly

* update types and naming

* use urlGenerator

* fix inner scrollbar

* Adjust cytoscapeOptions after EUI update

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
2020-12-09 10:11:08 -05:00
Joe Reuter
33c552feee
[Lens] Use eui component instead of custom color stops (#85239) 2020-12-09 16:06:25 +01:00
ymao1
f3d60c519d
[Actions] Disable 'Resolved' action group for ServiceNow, Jira and IBM Resilient action types (#83829)
* Adding disabled action groups to action type definition

* Adding tests

* Adding tests

* renamed Resolved to Recovered

* fixed missing import

* fixed buggy default message behaviour

* added missing test

* fixed typing

* fixed resolved in tests

* allows alert types to specify their own custom recovery group name

* removed unnecesery field on always fires

* allows alert types to specify their own custom recovery group

* fixed mock alert types throughout unit tests

* fixed typing issues

* reduce repetition of mock data

* fixed alert type list test

* support legacy event log alert recovery syntax

* added doc

* removed unneeded change in jira

* correct callback name in siem

* renamed resolved to  recovered

* fixed mistaken rename

* Moving to alert plugin

* Updating tests

* elvated default params to alert concern instead of actions concern

* made default params optional

* Adding test

* Moving where default action params are retrieved

* Revert "Moving where default action params are retrieved"

This reverts commit 76e7608229.

* Moving where default action params are retrieved

* Cleanup

* Fixing test

* PR fixes

Co-authored-by: Gidi Meir Morris <github@gidi.io>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-09 09:45:38 -05:00
Leaf-Lin
2cdc4ed05e
[Snapshot Restore] Adding max recommended value in retention (#82398) 2020-12-09 09:27:57 -05:00
Alejandro Fernández Gómez
fb6a71189b
[Logs UI][Metrics UI] Tweak navigation bar size for infra apps (#84498)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-09 15:27:11 +01:00
Nicolas Chaulet
a264038b36
[Fleet] Allow to edit package policy with input level template (#85277) 2020-12-09 09:10:07 -05:00
Dmitry
0d682a95bd
[jest] fix errors and warnings (#85291)
* replace deprecated 'wait' with 'waitFor'

* add required 'initialPageSize' field

* fix '.getContext() is not implemented' error

* wrapping code with act

* replace deprecated 'wait' with 'waitFor'

* fix 'state update on an unmounted component' warning
2020-12-09 15:04:21 +01:00
Bohdan Tsymbala
92db24e00c
Trusted Apps Signer UI (#84628)
* Added default value for type parameter in ConditionEntry type.

* Added signer field UI. Flattened a bit component structure and reused some translations.

* Reverted the condition for signer option.

* Fixed the import.

* Removed unused translations.

* Fixed the test.

* Consolidated a bit the deletion and creation flows in redux.
2020-12-09 14:53:53 +01:00
Joe Reuter
e9ad56d1a7
simplify popover open state logic (#85379) 2020-12-09 14:13:38 +01:00
Alejandro Fernández Gómez
f31e7c8591
[Logs UI][Metrics UI] Move actions to the kibana header (#84648)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-09 13:43:17 +01:00
Liza Katz
0a04835ba7
[Search] Session SO polling (#84225)
* Monitor ids

* import fix

* solve circular dep

* eslint

* mock circular dep

* max retries test

* mock circular dep

* test

* jest <(-:C

* jestttttt

* [data.search] Move search method inside session service and add tests

* merge

* Move background session service to data_enhanced plugin

* Better logs
Save IDs only in monitoring loop

* Fix types

* Space aware session service

* ts

* Fix session service saving

* merge fix

* stable stringify

* INMEM_MAX_SESSIONS

* INMEM_MAX_SESSIONS

* Update x-pack/plugins/data_enhanced/server/search/session/session_service.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

* Update x-pack/plugins/data_enhanced/server/search/session/session_service.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

* Use setTimeout to schedule monitoring steps

* settimeout

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
2020-12-09 14:05:01 +02:00
Dima Arnautov
58fc711626
[Transform] Replace legacy elasticsearch client (#84932)
* [Transform] replace legacy elasticsearch client

* [Transform] delete custom legacy client definition, update transforms_audit_messages.ts

* [Transform] fix start and stop transform endpoints

* [Transform] fix privileges and stats endpoints

* [Transform] fix forbidden

* [Transform] revert continue statement, add a comment

* [Transform] update privileges.ts using security namespace

* [Transform] fix error wrappers

* [Transform] add functional test for preview error validation

* [Transform] extract error message from the root cause

* [Transform] remove error translation
2020-12-09 12:55:54 +01:00
Shahzad
2a8c609bf9
[Uptime]Refactor header and action menu (#83779)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-09 12:45:40 +01:00
Jean-Louis Leysens
7fc7fe325c
[ILM] Show forcemerge in hot when rollover is searchable snapshot is enabled (#85292)
* pivot to different rollover validation mechanism

* implement stakeholder feedback to show forcemerge in hot

* replace ternary with if..else statements

* make rollover validation test more comprehensive
2020-12-09 12:29:42 +01:00