* create field for references and add comments
* add FTR test
* remove comments
* address comments
* use real reference in dataset and assert against it.
* [CODEOWNERS] set kibana-qa to own test/functional/services
* [functional/services] move low-level services to common folder
* update codeowners
* update imports
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [Reporting/Test] Add Functional test for download CSV
* add todo
* add fs.existsSync check to find download
* debug
* handle timeout
* validate toast
* different way of getting repo_root
* forwardport #64999
* Add additional verifications on dashboard
I hope you don't mind me updating the test directly.
I *thought* the other dashboard tests required a consistent set of exact documents so that the count would always be the same. Since the test uses sample data, I added a new timepicker:quickRanges so that the test can just select it. Test FTR isn't set up to do relative time ranges right now.
But it looks like the dashboard checks aren't that specific to the data. The dashboard seems to have `Last 24 hours` saved in it. And when I don't change it to the whole sample data time range the test still passes.
* fix eslint error
* [page_objects/time_picker] allow any string in setCommonlyUsedTime
Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
* Deserialize bulkCreate response to remove namespace type from id
* Index operations don't return _source in response
* Fix integration tests
* repository: make id generation and seq_no/primary_term spreading more explicit
* API Integration test for bulk create without ids
* Fix copy_to_space snapshot
* Revert "Fix copy_to_space snapshot"
This reverts commit 9c2b7433e3.
* Move test into returns block
* repository.test.js stricter regexp matching
## Summary
Fixes the non-legacy ES test client to work with SSL.
Without this if you try to migrate `siem rules` or `alerting` or `CASE` or anything else that is using SSL based tests you get this error when trying to use the non-legacy:
```ts
// pull in non-legacy service for functional tests
const es = getService('es');
```
```ts
// use it somewhere where your config.ts is utilizing SSL in a functional test
// ...
```
In your console you get this error:
```ts
ConnectionError: self signed certificate in certificate chain
at onResponse (node_modules/@elastic/elasticsearch/lib/Transport.js:205:13)
at ClientRequest.request.on.err (node_modules/@elastic/elasticsearch/lib/Connection.js:98:9)
at TLSSocket.socketErrorListener (_http_client.js:401:9)
at emitErrorNT (internal/streams/destroy.js:91:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
at process._tickCallback (internal/process/next_tick.js:63:19)
```
This fixes that by adding the CA certs from test to the ES test client.
* move core provier to NP. allows to run tests on every page
* remove no-base-path
* pass whole KbnTestServer config
* fix build path
* another id
* np
* build kibana tests plugins. it is used in xpack tests
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This PR migrates the vast majority of Alerting legacy code to the Kibana Platform.
This includes:
1. Removed legacy Task Manager
2. Migrates Fixture plugins in Alerting, Triggers UI and Task Manager Perf
This does not includes:
1. The PagerDuty simulator due to a lack of support for custom responses in the platform. issue opened. https://github.com/elastic/kibana/issues/65045
2. The Webhooks simulator due to a lack of support for custom authorisation. Requires investigation.
* Bind non primary time fields to timepicker
* Fix typescript argument types
* Allow auto interval on all fields
* Remove lens_auto_date function
* Fix existing jest tests and add test todos
* Remove lens_auto_date from esarchives
* Add TimeBuckets jest tests
* Fix typo in esarchiver
* Address review feedback
* Make code a bit better readable
* Fix default time field retrieval
* Fix TS errors
* Add esaggs interpreter tests
* Change public API doc of data plugin
* Add toExpression tests for index pattern datasource
* Add migration stub
* Add full migration
* Fix naming inconsistency in esaggs
* Fix naming issue
* Revert archives to un-migrated version
* Ignore expressions that are already migrated
* test: remove extra spaces and timeField=\\"products.created_on\\"} to timeField=\"products.created_on\"}
* Rename all timeField -> timeFields
* Combine duplicate functions
* Fix boolean error and add test for it
* Commit API changes
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
* Adds telemetry API tests for oss
* Modifies test expectations to match that within oss
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* set files to track for coverage collection
* increase timeout to 4h
* trying to add detectOpenHandles to avoid worker stuck
* update config
* make config paths more common
* update configs
* update jest oss config
* exclude 'tests' folder for coverage
* bring testing on Firefox back
* disable some tests
* skip more tests
* cut more suites for Firefox
* skip more tests for Firefox
* replace smoke tag with includeFirefox
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* snapshot updates
* bump to eui 22.3.0
* snapshots
* Fix css selector in test to match EUI internal DOM change
* Updated snapshots
* Insert react-beautiful-dnd@10 into top-level kibana to force siem's node_modules to hold its correct version
* More snapshot updates, resolved a typescript issue
* Move react-beautiful-dnd dependency around to make things happy again
* Use SearchFilterConfig from the top-level eui export
* Swallow 'ResizeObserver error does not have an err object' error in canvas
* Swallow ResizeObserver error cross-browser
* Attempt at deangularization, nr.2
* Remove padding in fullscreen
* Fixing failing functional test
* Fixing remaining functional test
* Fixing typescript errors
* Fixing filter bar not being visible in fullscreen
* Fixing filter bar not being visible in fullscreen
* Rebasing against master
* Fixing a small leftover
* Fix order of functions
* Fixing linting error
* Changing noPadding to a custom class
* Use filterManagers to handle filters
* Rename class
* Attempt at deangularization, nr.2
* Remove padding in fullscreen
* Fixing failing functional test
* Fixing remaining functional test
* Fixing typescript errors
* Fixing filter bar not being visible in fullscreen
* Fixing filter bar not being visible in fullscreen
* Rebasing against master
* Fixing a small leftover
* Fix order of functions
* Fixing linting error
* [APM] Agent config select box doesn't work on IE (#63236)
* adding value property to select options
* fixing test
* Use globe icon for "ext" span type on service map (#63205)
Both "external" and "ext" can be returned and should have the same icon.
* Move shared vislib components into Charts plugin (#62957)
* Closes#56310
Move shared vislib components into Charts plugin
* Fixed imports in tests
* Changed i18n IDs to match charts namespace
* Renamed ColorSchemaVislibParams to ColorSchemaParams, added enums and got rid of useValidation function
* Renamed ColorSchemaVislibParams to ColorSchemaParams and got rid of useValidation function
* Fixed merge conflict
* Replaced enums with objects again
* Make uptime alert flyout test a little more resilient (#62702)
* [SIEM] [Cases] Unit tests for case UI components (#63005)
* Endpoint: Remove unused `lib` module (#63248)
* [Lens] Fix error in query from generated suggestion (#63018)
* [Lens] Fix error in query from generated suggestion
* Update from review comments
* Fix test
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Resolver/node svg 2 html (#62958)
* Remove some SVG in Resolver nodes and replace with HTML
* [Reporting] convert all server unit tests to TypeScript (#62873)
* [Reporting] convert all server unit tests to TypeScript
* fix ts
* revert unrelated change
* [SIEM] Link ML Rule card CTA to license_management (#63210)
* Link ML Rule card CTA to license_management
Taking the user directly to the license management page within kibana
(where they could immediately start a trial subscription) is much more
actionable than taking them to the subscriptions marketing page.
* Revert translation key change
Neither of these is totally accurate, and there've already been
translations written for the old one.
* Correctly type ILM's optional dependencies as optional (#63255)
And guard against their absence.
* [Telemetry] use prod keys (#63263)
* update chromedriver dependency to 81.0.0 (#63266)
* task/mac-eventing-form (#62999)
adds mac events form for endpoint policy details
Co-authored-by: oatkiller <robert.austin@elastic.co>
* bc6 rule import april 9 (#63152)
* bc6 rule import april 9
Increased the lookback of the ML rules
* re-import
with LF chars
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Added UI for pre-configured connectors. (#63074)
* Added UI for pre-configured connectors.
* fixed due to comments
* Fixed jest tests
* Fixed due to comments and added some functional tests
* test fix
* Fixed failed checks
* Fixed functional tests failing
* TaskManager tasks scheduled without attempting to run (#62078)
* TaskManager tasks scheduled without attempting to run
* Removing unused import
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Changed alerting wrong param name for help xpack.encrypted_saved_objects.encryptionKey to xpack.encryptedSavedObjects.encryptionKey (#63307)
* fix ScopedHistory.createHref to prepend location with scoped history basePath (#62407)
* fix createHref to prepend with scoped history basePath + add option to exclude it.
* fix prependBasePath behavior
* fix test plugins urls
* add pathname to endpoint url builder methods
* Revert "add pathname to endpoint url builder methods"
This reverts commit 7604932b
* adapt createHref instead of prependBasePath
* use object options for createHref
* update generated doc
* fixing custom link popover size and hiding scroll (#63240)
* Changing noPadding to a custom class
* Use filterManagers to handle filters
* Rename class
* Applying some changes
* Reverting search_bar code changes
* Removing some stuff that was causing functional tests to fail
* Removing refresh dashboard container which was causing errors during navigation
* Do not destroy dashboardContainer
* Adding updateSavedQueryId method
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Co-authored-by: DianaDerevyankina <54894989+DianaDerevyankina@users.noreply.github.com>
Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Co-authored-by: Robert Austin <robert.austin@elastic.co>
Co-authored-by: Wylie Conlon <william.conlon@elastic.co>
Co-authored-by: Brent Kimmel <bkimmel@users.noreply.github.com>
Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
Co-authored-by: Dmitry Lemeshko <dzmitry.lemechko@elastic.co>
Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
Co-authored-by: The SpaceCake Project <randomuserid@users.noreply.github.com>
Co-authored-by: Yuliia Naumenko <jo.naumenko@gmail.com>
Co-authored-by: Brandon Kobel <brandon.kobel@elastic.co>
Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>
The needed change is to rely on history as source of truth for location instead of window.location.
btw, This makes possible to test state syncing utils integration using createMemoryHistory()
One issue was discovered after this change:
When switching from context to discover url was incorrect. history.location inside state syncing utils didn't get the last update. This happened, because history instance created in discover wasn't used in context app and when all listeners unsubscribed from it - it stopped receiving location updates. To fix this I just reused one history instance in discover, context and their kbnUrlTracker
* Move server code into NP folder
* NP config is not yet used
* Relative imports are somewhat broken
* Move common folder into NP
* Move cypress folder into NP
* Move scripts folder into NP
* Move misc. config into NP folder
A few of these were moved into the cypress folder as they're
cypress-specific.
I tried to update all the relative paths but some are likely broken. I'm
not going to know until other stuff is fixed, though.
* Move value for siem index pattern into common/constants
The other default values live in there, this is no different.
* Update paths following file move
If this was referencing the full project, it now references both paths
(legacy for UI, and NP for server).
* Fix typescript errors related to module resolution
These are mostly updating imports to the common/ folder on the UI side
(since things changed relative to those files).
* Replace Legacy Config with NP Config
* Updates plugin to use NP config
* defines new config previously coming from savedObjects config
* cleans up legacy types
Conflicts:
x-pack/plugins/siem/server/lib/detection_engine/routes/rules/export_rules_route.ts
x-pack/plugins/siem/server/lib/detection_engine/routes/rules/import_rules_route.ts
x-pack/plugins/siem/server/lib/detection_engine/rules/types.ts
x-pack/plugins/siem/server/plugin.ts
x-pack/plugins/siem/server/routes/index.ts
x-pack/plugins/siem/server/types.ts
* Remove local SIEM tsconfig
This was originally added to address an issue with tsserver, but that
issue is no longer relevant. The presence of this file confuses
typescript into thinking that siem is a separate TS project.
* Update kibana.json to declare our dependencies
These are not necessarily correct in terms of what's required/optional,
but this is what's declared in our types.
* Remove legacy plugin instantiation
* Removes legacy instantiation of server plugin, which is now handled by
NP
* Loosens legacy config spec so we no longer have to duplicate config
types
* Update tests with NP config
These were written against the old Hapi config function; now, we just
have a POJO.
* Update es_archiver helpers' paths
I'm not quite sure if these are working yet, but they're no longer
throwing errors.
* Ignore restricted path on script
This was cribbed from infra, who has made a similar change.
* Ignore restricted path on temporary savedObject mappings import
This will be changed subsequently when we switch to the NP form of
savedObject type registration.
* Add symlink to lockfile
* Fix paths on circular deps script
* Add separate config for Rule and Timeline saved objects
We had previously used the savedObjects' config, but those are not
currently exposed to us on New Platform. For now, we're going to split
this into two sets of values for the SOs we deal with
importing/exporting within the SIEM app, with the same defaults as
savedObjects.
* Fixing relative paths within cypress
These are strings that wouldn't be caught by typescript.
* add HttpResources basic implementation
* expose http resources to plugins
* add mocks
* move http resources to a separate service
* hide rendering service
* adopt internal types
* expose HttpResources service to plugins
* update platform mocks
* plugins start using HttpResources API
* remove RenderingServiceSetup export
* RenderingServiceSetup --> InternalRenderingServiceSetup
* improve types
* remove httpRespources leftovers from http service
* remove rendering types from RequestHanlderContext
* fix security plugin tests
* add unit tests for httpResources service
* add unit tests
* remove outdated cache-control header
* restructure http resources service
* merge getUiPlugins and discover
* static route declaration shouldnt require auth & validate
* update docs
* use HttpResources service instad of rendering
* address comments
* update docs
* roll back unnecessary changes
* use getVars for rendering
* dont pass app. it is not public API
* remove static registers
* update migration guide
* Add embeddable via saved object example
* give todoRefEmbed a different name from the by value one
* fix types
* fix order of unmounting
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
getHref on Action interfaces in uiActions plugin is now async. getHref is now used only to support right click behaviour. execute() takes control on regular click.
* [Metrics UI] Refactor containers to hooks
* clean up depends; move useInterval out of useWaffleTime;
* converting WithWaffleFilters to useWaffleFilters
* Removing WithWaffleOptions
* Refactor WithWaffleViewState to useWaffleViewState
* Removing obsolete files
* Fixing race condition with complext state
* Adding undefined to RisonValue; unwinding changes trying to work around bad type
* Switching to context
* Change assertion to ignore the length of the current URL
* Fixing test frameork to accept urls longer then 230 characters
* Fixes#59395; Refactor WithMetricsTime to hook; Fixes brushing on metric detail page; fixes refresh button on metric detail page
* Fixing tests with adding timeRange
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Fixes following cases:
Saving dashboard with pinned filter unpins it. Do not save pinned filters with dashboard see #62301 (comment)
When navigating with global filter to dashboard with same saved filter, filter becomes unpinned
When navigating from listing to dashboard with saved filter, back button didn't work
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* bump dependency, add edge support in ftr services
* add config files
* fix browser version for msedge
* use npm ms-chromium-edge-driver
* download edge driver aside from session creation
* move dependency to dev
* update dist/index file
* bump edge-driver version
* change type to msedge to match w3c spec
* fix discover tests for Edge
* Revert "fix discover tests for Edge"
This reverts commit 87e7fdd256.
* bump driver version up
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Move the default_editor to NP
* Fix paths
* Import styles through the visualize
* Other fixes
* Fix ip_ranges exhaustive-deps array
* Fix filters and extend bounds
* Other fixes
* Fix date_ranges tests
* Use useMount on first render
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* enable w3c for chrome
* update maps tests
* update maps tests
* update common_page
* Revert "update maps tests"
This reverts commit 31f43fd678.
* revert changes to maps tests
* undo after removal
* update expect range to pass on Windows, unskip tests for Firefox
* print out value for discover brushing test
* log first timestamp
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* simplify new index pattern button click method
* replace method name to match previous commit
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* update cache-control header
* update tests
* update test run config
* remove custom cache-control header for authentication resources
* address test flakiness
* address PR feedback
* revert changes to endpoint test
* revert changes for real this time
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Remove absoluteToParsedUrl reference in dashboard
* Remove KibanaParsedUrl from visualize
* Fix tests
* Add tests
* Fix saved dashboard
* Fix empty line after resolving conflicts
* Move dashboard to np
* Move migrations back to legacy
* Make it works
* Other fixes
* Move into application folder
* FIx translations
* Make share & home plugins otional
* FIx kbn url tracking, jest tests
* Import from dashboard_constants in FT
* Fix translations order
* Use getStartServices for start plugin deps
* Path fixes
* i18n fix
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Unskip
* Set only suite
* Add field search
* Use alternative flaky fix
* Remove extra actions
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1. Change logic around deciding wether to use time from url or from saved object. Previously code looked only into if _g is present in the url at all. And didn't consider edge case if time or refreshInterval is missing in _g
2. Fix initial syncing of time from savedobject causing redundant history record. _This changed caused order of _a and g params in url change. One test was affected by it because it relied on the order. I don't think it should be considered breaking as order app puts it's query params shouldn't matter.
3. Fix another race condition between state syncing with url and angular controller $destroy. Similar fix was done before in #57795, but this on covers case when we stay within dashboard app, but change dashboard
4. Fix initial panel state migration causing redundant browser history records
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* wip
* typescript map embeddable
* More updates
* Address code review comments and update some usages in SIEM and uptime to the new types
* More clean up - carry over some of the SIEM types to maps for render tool tip
* fixes
* fixes
* Address more review comments
* fixes
* fixes
* fix jest test
* Fix visualize embeddable
* fixes after master merge
* Fixes
* Prefix variable with name "custom" to make it more obvious
* Remove layerList from input state
* fixes
* Update src/plugins/dashboard/public/embeddable/dashboard_container_factory.tsx
Co-Authored-By: Vadim Dalecky <streamich@users.noreply.github.com>
* review updates
* fixes
* update maps readme
Co-authored-by: Vadim Dalecky <streamich@users.noreply.github.com>
* accessibility tests for dashboard panel
* added back the skipped test as it is still required to pass through the a11ySnapshot
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Migrated sample_action to NP. Panel action tests returned to the test flow.
* fixed names
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [ci/es] always pull snapshots, break early when they're not available
* move to setup.sh after deps are installed
Co-authored-by: spalger <spalger@users.noreply.github.com>
* Auto interval on date histogram is getting displayed as timestamp per 0 milliseconds when x-axis bucket is collapsed
Closes#57822
* Fixed incorrect interval label displaying while scaling the chart.
* Updated agg.test.tsx snapshot
* Got rid of context and refactored agg hooks
* Fixed agg.type.name check
* Added functional tests to cover the date histogram interval editing
* Fixed some expected values in tests
* Updated some test cases
* Added a new visualization to visualize archive
* Added testSubjects service to replace find where possible
* Updated tests to match updated behavior
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Migrated kbn_tp_custom_visualizations to the new platform
* skip test instead of deleting
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Migrated top nav plugin test to the new platform
* Removed old plugin. Some refactoring.
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Catch invalid calendar exception
* Use isValidEsInterval directly
* Show field error message right away
* Fix for the case 2w
* Update time_interval.tsx
* Restructure validation
* Rename fn to isValidCalendarInterval
* Refactoring
* Update time_interval.tsx
* Add functional tests
* Add functional tests for interval
* Update _area_chart.js
* Don't show error when value is empty
* Use error message from InvalidEsCalendarIntervalError
* Update _area_chart.js
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* unexpose SavedObjectsManagement from legacy server
* migrate saved object management routes to new plugin
* fix endpoint methods
* adapt code due to rebase
* extract types
* improve findAll params
* adapt existing api integration tests and migrate to TS
* update generated doc
* add API integration tests for /scroll/count
* add unit tests for plugin and routes
* add injectMetaAttributes tests
* extract relation type
* add find_relationships tests
* add find_all tests
* do not complete migrator$ to avoid unhandled promise rejection
* fix data for search endpoint integration tests
* remove falsy comment
* rename plugin folder to match plugin id
* address review comments
* update CODEOWNERS
* create coverage folder only if json file being saved
* skip some tests
* unskip test
* do not fail coverage run if some tests fail
* unskip fixed test
Added an emphasize prop to the top nav menu item and used it for a new 'Create new' button which redirects to the 'new visualization' modal.
Co-authored-by: Ryan Keairns <rkeairns@chef.io>
* just a demo of function to return saved object table elements
* fix esArchive data, extend import objects test case for relationships
* improved data-test-subjs
* update snapshot for jest test
* unskip other half of the tests
* removed commented-out code
* use new findByTestSubject methods
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [Telemetry] Migration to NP
* Telemetry management advanced settings section + fix import paths + dropped support for injectVars
* Fix i18nrc paths for telemetry
* Move ui_metric mappings to NP registerType
* Fixed minor test tweaks
* Add README docs (#60443)
* Add missing translation
* Update the telemetryService config only when authenticated
* start method is not a promise anymore
* Fix mocha tests
* No need to JSON.stringify the API responses
* Catch handleOldSettings as we used to do
* Deal with the forbidden use case in the optIn API
* No need to provide the plugin name in the logger.get(). It is automatically scoped + one missing CallCluster vs. APICaller type replacement
* Add empty start method in README.md to show differences with the other approach
* Telemetry collection with X-Pack README
* Docs update
* Allow monitoring collector to send its own ES client
* All collections should provide their own ES client
* PR feedback
* i18n NITs from kibana-platform feedback
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Fix formatter on range aggregation
* Fix test that was using unformatted byte ranges
* Fix test
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* update to eui 21.0.1
* most changes needed for search bar ts changes
* Passing types
* snapshots
* jest tests
* Removed IQuery placeholder types
* Updated functional test to only look at table headers with content
* Moved 'filters' definition around in api docs
* Update types
* update snapshot
* typo
* Move DATA_FRAME_TASK_STATE enum to its own file to fix x-pack functional test config imports
* merge public api 'changes'
Co-authored-by: patrykkopycinski <patryk.kopycinski@elastic.co>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
Adds Navigation APIs to Alerting.
Parts to this PR:
Adds a client side (Public) plugin to Alerting, including two APIs: registerNavigation & registerDefaultNavigation. These allow a plugin to register navigation handlers for any alerts which it is the consumer of- one for specific AlertTypes and one for a default handler for all AlertTypes created by the plugin.
The Alert Details page now uses these navigation handlers for the View In App button. If there's an AlertType specific handler it uses that, otherwise it uses a default one and if the consumer has not registered a handler - it remains disabled.
A generic Alerting Example plugin that demonstrates usage of these APIs including two AlertTypes - one that always fires, and another that checks how many people are in Outer Space and allows you to trigger based on that. 😉 To enable the plugin run yarn start --ssl --run-examples
This PR adds basic functional tests for the file data visualizer, covering a file import and error messages for non-log files. It also moves the file input path handling to a common location in order to avoid code duplication.
* initial implementation of configurable test users
* user superuser by default to match master
* referenced the configs in reporting and api integration
* setting the minimum number of default roles
* looking for x-pack tests with users and roles
* add testUserService in dashboard mode tests
* running only ciGroup7
* uncommenting - addign visualization
* re-enabling all CI groups to run on CI
* reinstating Jenkinsfile
* disable Test user for OIDC config
* improved logging and added Roles for OSS tests to get better info on the runs.
* disable test_user for auth tests
* don't fetch enabledPlugins when testuser disabled
* fix es-lint
* running oss tests with x-pack enabled
* [revertme] build default dist for oss tests
* updating NOTICE.txt file as it complained in the kibana intake tests
* changed to pick OSS builds
* trying a license change to trial
* switch back to xpack builds
* created a new sample data role and used it in homepage tests
* revert test/scripts/jenkins_ci_group.sh
* only refresh browser and wait for chrome if we are already on Kibana page
* fix large_string test to use minimum set of roles and privileges
* fix for date nanos custom timestamp with a configured role
* changes to the files with addition of new roles for the test_user
* reverting to OSS changes and few additions to the time_zone test to run as a test_user
* changes to security
* changes to the x-pack test to use elastic superuser
* fix for chart_types test
* fixes to area chart , input control test
* fix for dashboard filtering test and a new config role
* changes to handle the x-pack tests
* additional role for date nanos mixed
* added the logstash role to the accessibility tests
* removed telemetry setting
* docs+few changes to the tests
* removed Page navigation
* removed pageNavigation which was unused
* test/accessibility/apps/management.ts
* update management.ts
* aria label, and other changes
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* accidentally checked in a piped file with results.
* reverted
* unloading of logstash data, fixing aria label
* aria-label
* added the required role
* fix for tsvb chart
* fix for sample data test reverted home_page pageobject file
* changes to sample data test and visualize index file to incorporate OSS changes
* changes to describe() and some more changes to incorporate in settings_page
* re-adding the after()
* removed unwanted roles
* replaced kibana_user with kibana_admin
* added the check of deprecated kibana_user
* testing with kibana_admin role
* fix for discover test
* incorporated the review comments
* incorporated the review comments
* incorporate review comments and added restoreDefaults()
* removed describe.only
* reverted the OSS logic change I had here- pulled into seperate PR
* incorporated the review comments
* incorporated review changes
* adding hidden=true to find hidden kibanaChrome
* change field.test.tsx to be same as that of master branch
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* add management section to SavedObjectsType
* adapt import/export routes to get types accessor
* add documentation
* update generated doc
* update migration guide
* use request context to access exportable types
* update generated doc
* adapt SavedObjectsManagement to use the registry
* stop magical tricks about the config type, register it as any other so type.
* fix FTR assertions
* fix so_mixin tests
* register the `config` type from the uiSettings service
* nits and comments
* update generated doc
* remove true from dynamic property definition, use force-cast back for config type
* remove obsolete test comment
* Replace AppState
* Replace GlobalState
* Adapt functional test
* Sync initial app state to URL
* Add jest tests
* Refactoring to use use-default-behaviors="true" in kbn-top-nav
* Cleanup code remove unnecessary imports and variables
* Refactor to use syncQueryStateWithUrl & stopSyncingQueryAppStateWithStateContainer
* Remove discoverPersistedState
* Allow indexPattern switch without $route.reload()
* Remove timeRangeObj because it's not needed
* Create new getDefaultQuery in data plugin
* Simplify check for null in sync_state_with_url.ts
* Remove unused stateMonitorFactory
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
* use inline snapshots instead of snapshots
* hide input value from error messages
* update core snapshots
* update xpack snapshots
* fix ftr assertions
* fix new snapshots
* hide values for byte_size and duration
* update new snapshots
* remove another byte_size value reference
* fix yet another value references in error messages
* update xpack snapshots
* update xpack ftr assertions
* Updated EUI to 20.0.1; updated typescript usage
* snapshots
* Upgrade to eui 20.0.2, fix one more type
* PR feedback
* Update EUI icon usage to the correct types
* Updated with master
* wip
* review follow up
* make ACTION a prefix, not SUFFIX
* fix path
* add warnings about casting to ActionType
* Make context an object in examples, not a string
* require object context, which seems to fix the partial requirement in type and thus the type issue
* mistake
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Move linked_search to react
* Use i18n from start contract
* Move linked search to the editor
* Updating layout and fixing truncation
* Fix functional test, add a tooltip
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
* adding comprehensive dashboard tests
* fixing delete and adding dima changes
* Fixing some of the a11y test failures
* Fixing i18n issue
* Extracting exit fullscreen logic in a separate function
* Fixing typo
* Upgrading axe
* Fixing failing jest tests
* Removing main tag as it was causing a test to fail
* Adding focusable=false to a range control as well
* Update test/accessibility/apps/dashboard.ts
Co-Authored-By: Michail Yasonik <michail.yasonik@elastic.co>
* Fixing linting error
* Update src/legacy/core_plugins/input_control_vis/public/components/vis/list_control.tsx
Co-Authored-By: Michail Yasonik <michail.yasonik@elastic.co>
* Add comments
Co-authored-by: Bhavya RM <bhavya@elastic.co>
Co-authored-by: Michail Yasonik <michail@yasonik.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [Maps] direct Discover visualize to Maps application
* pass initial layers to maps app
* add functional test
* fix parentheses messed up by lint fix
* fix i18n expression
* move logic into lib
* fix typescript errors
* use constant for geo_point and geo_shape, more TS noise
* use encode_array in an attempt to make TS happy
* another round of TS changes
* one more thing
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* change to have --ssl cli option use more recent certs
* also configure 'server.ssl.certificateAuthorities' per PR review
* delete theoretically now-unused ssl creds
* Improve types so emitting the wrong context shape complains, as does using a trigger id that has not been added to the trigger context mapping.
* remove unneccessary code
* run jest with `--detectOpenHandles` on CI to figure out what is happening with pauses
* focus tests on jest integration
* force kill child processes in config reload test
* skip flaky suite
* increase timeout for looking for installed packages
* run all tests again
* Add a way to disable certificate verification for FTR.
* Remove other options
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Revert "Skip flaky test (#57675)"
This reverts commit c965a9efa8.
* Revert "disable firefox smoke tests so we can fix flakiness out of band"
This reverts commit fe3864282a.
* Revert "skip flaky tests (#57643)"
This reverts commit b22045433e.
* Revert "skip flaky suite (#50018)"
This reverts commit b058dc2fe7.
* Revert "skip settings tests (#57608)"
This reverts commit 64625b282c.
* Revert "skip failing suite (#44631)"
This reverts commit 8aa718d11e.
* Revert "skip flaky suite (#44631)"
This reverts commit 6e4efdfa7c.
* Revert "skip flaky test (#57377)"
This reverts commit 59672ab5da.
* Revert "Skip save query tests (#57589)"
This reverts commit 431a1e9c89.
* remove hard coded timeouts
* Revert "Revert "disable firefox smoke tests so we can fix flakiness out of band""
This reverts commit 271f8814d5.
* Revert "remove hard coded timeouts"
This reverts commit 8b843d0aa6.
* wait for managementHome to exist, don't bail early if it's missing
* Revert "skip flaky suite (#45244)"
This reverts commit 0cee1a4adb.
* extend timeouts for common existsOrFail() calls
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Over the last few years we've increased the number of test runners.
Entry points by test type have become too lage of a category for unique
names, so this moves top level test scripts under yarn and replaces test
types with the runner name.
e.g. `yarn test:browser` -> `yarn test:karma`
Closes#41133
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Fully migrates metrics and logs to the NP
Co-authored-by: Jason Rhodes <jason.matthew.rhodes@gmail.com>
Co-authored-by: John Schulz <github.com@jfsiii.org>
Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
* eui to v19.0.0
* typescript updates; idAria removal
* src snapshot updates
* mock euicode and euicodeblock for jest
* x-pack snapshot updates
* mock euicode for jest
* more euicode snapshots
* mock euicode in storyshots
* types/enzyme yarn.lock
* sidenav type update
* build immutable bundles for new platform plugins
* only inspect workers if configured to do so
* [navigation] use an index.scss file
* add yarn.lock symlink
* set pluginScanDirs in test so fixtures stay consistent
* cleanup helpers a little
* fix type error
* support KBN_OPTIMIZER_MAX_WORKERS for limiting workers via env
* test support for KBN_OPTIMIZER_MAX_WORKERS
* expand the available memory for workers when only running one or two
* add docs about KBN_OPTIMIZER_MAX_WORKERS environment variable
* fix README link
* update kbn/pm dist
* implement bundle caching/reuse
* update kbn/pm dist
* don't check for cache if --no-cache is passed
* update renovate config
* standardize on index.scss, move console styles over
* add support for --no-cache to cli
* include worker config vars in optimizer version
* ignore concatenated modules
* update integration test
* add safari to browserslist to avoid user-agent warnings in dev
* update docs, clean up optimizer message/misc naming
* always handle initialized messages, don't ignore states that are attached to specific events
* reword caching docs, add environment var to disable caching
* tweak logging and don't use optimizer.useBundleCache as that's disabled in dev
* handle change notifications
* batch changes for 1 second
* rename CompilerState type to CompilerMsg
* getChanges() no longer needs to assign changes to dirs
* remove unused deps
* split up run_worker.ts and share cacheKey generation logic
* add a couple docs
* update tests and remove unused imports
* specify files when creating bundle cache key
* remove one more unused import
* match existing dev cli output more closely
* update kbn/pm dist
* set KBN_NP_PLUGINS_BUILT to avoid warning in CI
* avoid extending global window type
* add note to keep pluginScanDirs in sync
* pass browserslistEnv in workerConfig so it is used for cache key
* load commons.bundle.js in parallel too
* emit initialized+success states if all bundles are cached
* load bootstraps as quickly as possible
* skip flaky suite
* bump
* update jest snapshots
* remove hashing from cache key generation
* remove unnecessary non-null assertion
* improve docs and break up Optimizer#run()
* remove unused import
* refactor kbn/optimizer to break up observable logic, implement more helpful cache invalidation logic with logging
* fix tests
* add initializing phase
* avoid rxjs observable constructor
* remove unnecessary rxjs helper, add tests for bundle cache
* update consumers of optimizer
* update readme with new call style
* replace "new platform" with "kibana platform"
* fix a couple more renames
* add support for several plain-text file formats
* fix naming of OptimizerMsg => OptimizerUpdate, use "store" naming too
* one more OptimizerMsg update
* ensure bundles are not cached when cache config is false
* test for initializing states and bundle cache events
* remove unnecessary timeout change
* Remove unnecessary helpers
* Add tests for BundleCache class
* Add tests for Bundle class
* test summarizeEvent$
* missing paths are no longer listed in mtimes map
* add tests for optimizer/cache_keys
* Add some extra docs
* Remove labeled loop
* add integration test for kbn-optimizer watcher components
* querystring-browser removed
* tweak logging a smidge, improve info and final message
* remove unused imports
* remove duplication of getModuleCount() method
* move type annotation that validates things
* clear up the build completion message
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Move defaultAppId config param into kibanaLegacy
* Move disableWelcomeScreen config param into Home plugin
* Update api and docs with silent option for renameFromRoot
* adding meta information to KibanaDatatable
* updating filtering functions to use new information
* moving filter creation to APPLY_FILTER_ACTION
* adding SELECT_RANGE_ACTION and TRIGGER
* making _meta optional
* inlining legacy code for inspector
* fixing jest tests
* keeping apply_filter_action and adding value_click_action and trigger
* utilities for serializing/unserializing aggConfigs
* renaming prop to indexPatternId
* cleanup
* updating interpreter functional baselines
* trying to fix tests
* Fix legend tests
* reverting update to multi metric screenshot
* updating based on review
* updating tests
Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* bugfix: 'state:storeInSessionStorage' doesn’t take effect for dashboard without full page reload
* add test “changing 'state:storeInSessionStorage' also takes effect without full page reload”
Default sort is no longer in state. There's now a separate function to provide default sort for ES and UI, in case the user didn't actively select a field to sort by
* [csp] allow blob styles when running from source
* update kbn/pm dist
* add kibanaServer service to saml_api_integration suite
* use common naming
* attempt to use env.packageInfo instead of IS_KIBANA_DISTRIBUTABLE const
* remove mock, clone rules before modifying
* pass env where necessary
* update core api docs
* make env optional in HttpConfig
* add tests for CspConfig changes, base header on this.rules
* fix test snapshot
* make env optional in HttpConfig too
* remove CspConfig.DEFAULT and make env a required constructor arg
* update csp_usage_collector tests
* update core api docs
* fix test name
* rename headerChangedFromDefault back to rulesChangedFromDefault
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* deprecate msearch
* Missing export
* adjust tests, revert loading method of esaggs/boot
* getInjectedMetadata
* Fix jest tests
* update default strategy abort test
* notice update
* Allow running discover errors test independently
* Remove batchSearches
* Detect painless script error
* don't show notifications for aborted requests
* Fix jest tests
* Restore loader indicator
* Decreace loading count on error
* update search test
* Trigger digest after fetching fresh index patterns
* Revert isEqual
* accurate revert
* Return full error details to client from search endpoint
* Re-throw AbortError from http when user aborts request.
* fix typo
* typo
* Adjust routes jest test
* Restore msearch using a separate es connection
* typescript fixes
* set http service mock
* Move es client to dat aplugin, for follow up PR
* Add karma mock
* krma mock
* fix tests
* ts
* Pass in version dynamically
* add headers to esClient host
* Restored fetch soon test
Use tap for loadingCount side effects
* Cleanup search params
* Cleanup search params test
* Revert "Cleanup search params"
This reverts commit ca9dea01d5.
* Revert "Cleanup search params test"
This reverts commit 30b9478612.
* Revert code to use old es client until #44302 is resolved
* Revert changes to getPainlessError
* Fix jest test
* Refactor esClient to trigger loadingIndicator
* fixing tests
* use esClient from searchService
* git remove comment
* fix jest
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* display not found page instead of throwing an error when accessible unavailable app
* move types to public folder
* fix types import
* remove updater from start app
* remove unnecessary await
* Revert "Add label and icon to nested fields in the doc table (#54199)"
This reverts commit f77b3620
* Apply label and icon to nested fields in the doc table
* Add nested type to field_icon
* Improve nested test and add comment
* Fix tests
* Always pass the field type
* EUIficate the sidebar
* Create a state reducer and a state context
* Create an editor context and actions
* Improve types
* Apply aggs reordering
* Fix functionality
* Improve types
* Fix sub_agg changes
* Remove legacy dependencies
* Watch dirty state
* Fix dirty state changes
* Update actions and reducers
* Handle keyboard submit
* Apply editor form validation
* Remove fancy forms
* Update validation
* Use embeddable instead of visualize loader
* Add auto apply behavior
* Remove legacy styles
* Remove the sidebar
* Restrict responsive to the bottom_bar
* Upgrade @elastic/eui to v14.10.0
* Replace EuiBottomBar with EuiControlBar
* Get rid of mutations in control vis
* Revert "Upgrade @elastic/eui to v14.10.0"
This reverts commit 2cd86c51d2.
* Replace bottom bar with a control panel for sidebar
* Replace selectors
* Use editor resizer
* Apply selectors
* Change selectors
* Fix sub agg change values
* Add collapse button
* Fix tests
* Get rid of editor editor_state_context, simplify the code
* Fix jest tests, update snapshots
* Fix types
* Moving collapse button to right of index pattern
* Tweaks bottom buttons
* Moved Vega buttons so they don’t scroll away
* Fix responsiveness
* Resolve UI comments
* Fix console resizer
* Update dev docs
* Bail out of additional render in metrics and axes
* Apply performance optimizations for metrics and axis panel
* Remove unused translations
* Use debounce when autoapply enabled
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Generate legacy vars when rendering all applications
* Move rendering functional tests and add user settings tests
* Make rendering integration tests more robust, get data from page
* Address review nits, fix CI failures
* Remove extraneous file
* Fix type error