Commit graph

30236 commits

Author SHA1 Message Date
Jean-Louis Leysens
6984cf1711
Move SplitPanel to kibana_react (#55529)
* split_panel component -> kibana_react

* Update useEffect for console warning

* `console` -> `kibana-react` i18n namespace

* Update when warning about children is emitted in split panel component

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-24 13:10:59 +01:00
Jean-Louis Leysens
43a7aa7fc0
[Console] Remove z-index from editor panes and move it to the resizer (#55813)
* Remove z-index from editor panes and move it to the resizer

* Update comment
2020-01-24 12:26:25 +01:00
Walter Rafelsberger
fee22e8d94
[ML] Anomaly Explorer: Fix view by selection when filter is active. (#55717)
Fixes the view-by selection when a KQL filter gets active and restores previous behavior:
- If the filter includes AND view-by switches to Job ID.
- Otherwise the view-by selection switches to the first available option present in the KQL filter
- Additionally, the view-by dropdown options get filtered down to the options present in the KQL filter
2020-01-24 11:25:55 +01:00
Walter Rafelsberger
ef4b395873
[ML] Singel Metric Viewer: Fix full refresh check. (#55726)
Fixes the check whether to do a full refresh of the page or not. lastRefresh was mistakenly part of the check. This fixes keeping the flyout open for rules editing.
2020-01-24 11:22:31 +01:00
Alejandro Fernández
d40269c748
Fix the scale of the search markers (#55731)
The search markers where placed on the minimap using a different scale
than the density chart and time ruler. That made the log stream jump to
unexpected time positions when the user clicked on a search marker.

This also fixes an problem where the search markers didn't move
alongside the rest of the minimap when the user dragged and dropped it.
2020-01-24 11:16:11 +01:00
Sébastien Loix
d3151327de
Fix text highlight in search result (#55695) 2020-01-24 14:52:46 +05:30
Shahzad
d25d1bd84e
[Uptime] Clean Url to remove undefined/empty query params (#55386)
* fix usage of useParams

* update code

* update defaults

* update snaps
2020-01-24 09:13:17 +01:00
Maryia Lapata
14a559bfc4
[Discover] DocViews uses local angular (#55389)
* DocViews uses local angular

* Clean up

* Create embeddableInjector only when it's used

* Revert occasional changes

* Update unit test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-24 10:45:46 +03:00
Mikhail Shustov
2f1628784a
[NP] add platform main principles (#53866)
* add platform main principles

* update docs

* unify styles

* remove guidelines. principles should cover this

* Apply suggestions from code review

Co-Authored-By: Josh Dover <me@joshdover.com>

* Apply suggestions from code review

Co-Authored-By: Rudolf Meijering <skaapgif@gmail.com>

* address comments

Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
2020-01-24 07:54:06 +01:00
spalger
e67cc8514a Revert "[csp] allow blob styles when running from source (#54991)"
This reverts commit 375f0b42a7.
2020-01-23 23:32:10 -07:00
Matthias Wilhelm
ac0953e08b
[Discover] Change default sort handling for index patterns without timefield (#54427)
Default sort is no longer in state. There's now a separate function to provide default sort for ES and UI, in case the user didn't actively select a field to sort by
2020-01-24 06:23:53 +01:00
patrykkopycinski
1e91775a7f
[SIEM] Overview Page - Expand Winlogbeat Stats (#55696) 2020-01-24 00:11:13 +01:00
Peter Schretlen
e39ef65c4c
Add developer docs for built-in pagerduty and webhook actions. Add TOC. (#55352) 2020-01-23 17:00:14 -05:00
Brian Seeders
6fcf3f0005
Skip flaky custom appRoute tests 2020-01-23 16:58:13 -05:00
Thomas Neirynck
5a15ad123d
[Maps] use style-prop methods to determine state (#55607) 2020-01-23 15:56:11 -05:00
Anton Dosov
5daed94c30
[Filters] Incorrect result, when calling setFilters() with multiple duplicates between app and global filters (#55591) 2020-01-23 21:45:11 +01:00
Tim Sullivan
e102ae673c
[Reporting/New Platform] Use the logger service from core (#55442)
* More Typescript Fixes

* [Reporting/New Platform] Use the logger service from core

* Add log tag

* fix jest tests

* ts fixes

* fix mocha test

* convert to jest
2020-01-23 13:40:05 -07:00
Wylie Conlon
cda6b13f23
[Lens] Fix regression in field list for beats (thousands of fields) (#55625)
* [Lens] Fix regression in field list for beats

* Add api test
2020-01-23 14:52:43 -05:00
patrykkopycinski
d97526e88c
[SIEM] Attach VisibilitySensor to the TimelineBody instead of window (#55620) 2020-01-23 20:01:10 +01:00
Thomas Watson
bb30bb4fd4
Update .github/CODEOWNERS (#55728) 2020-01-23 19:07:40 +01:00
Joe Reuter
38fd963ed3
Timelion api migration (#53005) 2020-01-23 18:19:33 +01:00
Walter Rafelsberger
a4cf4f4b75
[ML] Single Metric Viewer: Fix zoom on forecast selection. (#55685)
Fixes adjusting the focus chart zoom range when a forecast gets selected. The code is cleaned up so appStateHandler to set the zoom range in the url is only called in one place within contextChartSelected().
2020-01-23 17:16:09 +01:00
Matthew Kime
0c25cb53b2
Advanced Settings management => typescript (#54477)
* advanced settings => typescript
2020-01-23 09:21:46 -06:00
Jimmy Kuang
3d59414038 [ILM] Index Lifecycle Policies show wrong unit in Kibana UI (#55228)
* Added timing and byte size units to hot, cold, warm, and delete phase
2020-01-23 07:14:35 -08:00
Chris Mark
63d3cbc941
Add Kibana tutorial for Statsd Metricbeat module (#55700) 2020-01-23 17:09:36 +02:00
Eli Perelman
fe5e470aae
Explicitly test custom appRoutes (#55405)
* Explicitly test custom appRoutes

* Extract common navigation function
2020-01-23 09:08:13 -06:00
Dima Arnautov
a895977aca
[ML] fix chartTooltip$ observable usage (#55694) 2020-01-23 15:49:54 +01:00
Joe Reuter
841afe32fc
exclude tutorials from code ownership (#55705) 2020-01-23 15:39:43 +01:00
Jean-Louis Leysens
bb37b0f613
[Watcher] Move out of legacy (#54752)
* Moved out of legacy folder

* First iteration of watcher plugin that renders

* Move create Timebuckets to plugin root
Update route registration and fix license checking for NP

* Re-enable Component integration tests

* Minor fix for data deserializer in api.ts

* Slight logic refactor, more defensive plugin startup

* Re-add legacy folder for SCSS pipeline

* Remove duplicate style sheet

* Fix type issue with TimeBuckets export

* Update license management routing logic (issued warning for using basepath on navigating away from license management)
Remove commented out code in watcher

* More defensive plugin registration

* Fix i18n issues and restore registration of feature on home view

* Remove watcher license error check copy

* Restore license error message in watcher

* Fix mock context value

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-23 15:35:36 +01:00
Walter Rafelsberger
2a1dc0af0c
[ML] Anomaly Explorer: Fix persisting time filter refresh to URL. (#55522)
Fixes persisting a custom date picker time range change to the URL in Anomaly Explorer. The code is now in line with Single Metric Viewer.
2020-01-23 15:02:14 +01:00
Dario Gieselaar
0275331514
Add @elastic/apm-ui as code owner of APM NP plugin (#55674) 2020-01-23 13:44:55 +01:00
Sébastien Loix
2cc9ed6dec
[Mappings editor] Accommodate legacy index templates (#55388) 2020-01-23 17:59:26 +05:30
Pierre Gayvallet
071db79a00
ApplicationService: emit from currentAppId$ in legacy mode (#55536)
* emit currentAppId$ in legacy mode

* fix karma tests

* fix karma json structure

* flip if/else

* filter undefined from currentAppId$
2020-01-23 12:37:37 +01:00
Felix Stürmer
4bd329e589
[Logs UI] Fix base path in tutorial URLs (#55459)
This fixes the way the base path is prepended to several tutorial URLs, which broke with #52867.

fixes #55350
2020-01-23 12:27:52 +01:00
Pierre Gayvallet
a75436d93e
Run SO migration after plugins setup phase. (#55012)
* change setClientFactory api to setClientFactoryProvider

* cleanup and add test for service

* change the signatures of SO start/setup

* fix registerCoreContext by accessing stored start contract reference

* move migration inside `start`

* adapt and add service tests

* add doc and export new types

* adapt plugins code

* update generated doc

* better core access

* address some review comments

* remove parametrized type from SavedObjectsClientFactory, use KibanaRequest instead

* add logs when starting and ending so migration

* fix KibanaRequest imports

* NITs and review comments

* fix alerting FTR test

* review comments
2020-01-23 10:41:21 +01:00
Jean-Louis Leysens
9fc0d4ca4b
[Console] Styling for split panel (#55530)
* Update z-index on output panel

* Add z-index setting to console input too
2020-01-23 10:24:29 +01:00
Alexey Antonov
4a8542f859
browser[SEVERE] webpack: A component is changing an uncontrolled input of type %s to be controlled (#55323)
* browser[SEVERE] webpack: A component is changing an uncontrolled input of type %s to be controlled.

Closes: #41017

* fix PR comments

* fix PR comment
2020-01-23 12:21:50 +03:00
Sébastien Loix
111d0db7e3
[Mappings editor] Add missing parameters to object & nested (#55152) 2020-01-23 14:15:28 +05:30
Tiago Costa
2b66759dc7
fix(NA): allow plugins index to be a ts file in kbn-plugin-helpers (#55194)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-23 02:30:32 +00:00
Garrett Spong
90e3bb0a62
[SIEM] [Detection Engine] All Rules fixes (#55641)
## Summary

This PR addresses bugs outlined in https://github.com/elastic/kibana/issues/54935

Including:
* Add Risk Score column
* Remove Method column
* Fixes `Showing Events` on Alerts table
* Fixes Tag overflow
* Shows Tags/Filters

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2020-01-22 18:33:34 -07:00
Frank Hassanabad
da5710dac6
[SIEM][Detection Engine] Reworks actionClient to work with new platform
## Summary

* Changes action client to use new platform from their changes
* Removes unit tests not needed
* Updates unit tests that need updating

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-22 18:17:28 -07:00
Xavier Mouligneau
4348a34da9
[SIEM] Detections bugs (#55626)
* Fix permissions

* Fix selection of event  type on timeline

* add link to rule name

* add filter in data provider

* Add rule status in saved object

* Fix reset field browser

* fix swallow error on creation of prepackaged rules

* fix test
2020-01-22 19:51:54 -05:00
gchaps
31c2a89827
[DOCS] Updates index template example (#55601) 2020-01-22 13:45:39 -08:00
Mike Côté
bc70c99c79
Add legacy support for actions client (#55604) 2020-01-22 16:26:34 -05:00
Nathan Reese
89e90648d6
[Maps] use higher resolution icons with larger fixed sizes (#55596)
* [Maps] use higher resolution icons with larger fixed sizes

* [Maps] use higher resolution icons with larger fixed sizes
2020-01-22 16:09:11 -05:00
Mike Côté
2e6f821d3f
Add xpack_main as a dependency in a few tests (#55602) 2020-01-22 15:36:24 -05:00
Brian Seeders
179dba2deb
Skip flaky test 2020-01-22 14:17:01 -05:00
Spencer
375f0b42a7
[csp] allow blob styles when running from source (#54991)
* [csp] allow blob styles when running from source

* update kbn/pm dist

* add kibanaServer service to saml_api_integration suite

* use common naming

* attempt to use env.packageInfo instead of IS_KIBANA_DISTRIBUTABLE const

* remove mock, clone rules before modifying

* pass env where necessary

* update core api docs

* make env optional in HttpConfig

* add tests for CspConfig changes, base header on this.rules

* fix test snapshot

* make env optional in HttpConfig too

* remove CspConfig.DEFAULT and make env a required constructor arg

* update csp_usage_collector tests

* update core api docs

* fix test name

* rename headerChangedFromDefault back to rulesChangedFromDefault

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-22 11:32:09 -07:00
Thomas Neirynck
003d6e9eed
[Maps] Disable add layer button when flyout is open (#54932) 2020-01-22 13:22:22 -05:00
Gil Raphaelli
773b0ed15d
allow env setting for xpack.apm.serviceMapEnabled (#55476) 2020-01-22 13:11:43 -05:00