Commit graph

44229 commits

Author SHA1 Message Date
Michael Olorunnisola 7d51136523
[Security Solution] - Fix flyout pane z index (#104465) 2021-07-06 17:52:29 -04:00
Pablo Machado 52c7824bff
Fix long data for investigation not truncate on the rule details page (#104428)
Author: Pablo Machado <machadoum@gmail.com>
Co-authored-by: Pablo Machado <machadoum@gmail.com>
2021-07-07 00:04:57 +03:00
Nathan L Smith aae6ae47ea
Remove schema heading from schema settings (#104520)
Also add a story.

Fixes #103753.
2021-07-06 15:58:13 -05:00
Kyle Pollich 4da6c4f93d
[Integrations UI] Fix missing agent flyout on package policy page (#104493)
* Fix missing agent flyout on package policy page

Handle query string changes if user clicks "add agent" link in toast
content while still on the package policy listing page.

Closes #103266

* Unbind history listener in useEffect
2021-07-06 16:47:12 -04:00
Spencer 1d993b6f26
[kbn/optimizer] maintain bundle ref support when using --filter (#104512)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-07-06 13:45:55 -07:00
Jonathan Budzenski 90d6b223a6
[target/windows] Fix KBN_PATH_CONF expansion in bin/*.bat (#104517)
When setting the environment variable KBN_PATH_CONF in Windows, paths
containing special characters will be expanded and interpreted, instead
of being treated as a string.  This wraps `%KBN_PATH_CONF%` in quotes to
prevent this.

Testing:
1) set "KBN_PATH_CONF=C:\With space\special()%$characters\kibana\config"
2) bin\kibana*.bat should run
2021-07-06 14:58:43 -05:00
Sandra Gonzales 08257f1f93
[Monitoring] update SM rule template variables (#104176)
* continue to support shardIndices template variable

* add unit test for large shard size alert

* change template variables in CCR rule

* add CCR rule unit test

* fix internationalization

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-06 15:11:01 -04:00
Tim Sullivan b794e7b7ca
[Reporting] Add warning logs about CSV export type being deprecated (#104025)
* add deprecation logging to csv export type

* fix payload.isDeprecated

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-06 12:01:27 -07:00
Frank Hassanabad dcd84ea81a
Fixes indeterminism with the cy.intercept by moving it upwards above the clicks (#104501)
## Summary

Fixes indeterminism with cypress by moving the `cy.intercept('PATCH', '/api/timeline').as('updateTimeline');` above where the click is happening.

Backport to 7.14.0 to hopefully stabilize it better as well.

You can make the indeterminism deterministic by adding (for testing only), a `cy.wait(5000)` like so:

```ts
// Keep clicking on the disable all button until the first element of all the elements are no longer checked.
// In cases where the click handler is not present on the page just yet, this will cause the button to be clicked
// multiple times until it sees that the click took effect. You could go through the whole list but I just check
// for the first to be unchecked and then assume the click was successful
cy.root()
  .pipe(($el) => {
    $el.find(TIMELINE_ROW_RENDERERS_DISABLE_ALL_BTN).trigger('click');
    return $el.find(TIMELINE_ROW_RENDERERS_MODAL_ITEMS_CHECKBOX).first();
  })
  .should('not.be.checked');
 cy.wait(5000); // <--- Temp addition for testing to ensure our intercept works above this. If the intercept is below this then we see the same indetermism behavior but deterministically.
``` 

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-07-06 14:47:55 -04:00
Brian Seeders 194a8a87a8
[Docs] Add a tutorial for how to open a pull request (#103697) 2021-07-06 14:35:00 -04:00
Melissa Alvarez ebc103f619
[ML] Data Frame Analytics creation: ensure included fields selection table is shown when no docs contain all mapped fields (#104191)
* use indexPatternFields if explain error due to missing values in docs

* fix types
2021-07-06 13:43:55 -04:00
Angela Chuang d5ca242098
fix links for rule monitoring table (#104473) 2021-07-06 18:22:51 +01:00
Angela Chuang 8564b3af0f
[Security Solution] Remove total count for events table on hosts and details page (#104114)
* remove total count for events table on hosts and details page

* hide events count when analyzing an event

* fix unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-06 18:17:27 +01:00
Michael Olorunnisola 71ad073d67
[Security Solution][Analyze Event] Fix resolver range slider (#104475) 2021-07-06 13:17:07 -04:00
Xavier Mouligneau cf9e88c7d7
[RAC] ALerts table in observability (#103270)
Closes #98611

## Summary

Add alerts table in Observability => 

![image](https://user-images.githubusercontent.com/189600/123854490-c68ddf00-d8ec-11eb-897e-2217249d5fba.png)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

| Risk                      | Probability | Severity | Mitigation/Notes        |
|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. |
| Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. |
| [See more potential risk examples](https://github.com/elastic/kibana/blob/master/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2021-07-06 10:28:21 -06:00
Domenico Andreoli 5b49380787
CCS Cypress integration (#103941)
* Add CCS Cypress test runner

* Split flow for CCS Cypress tests

* Make esArchiver load data onto the remote cluster

* Add CCS specific rules with customizable remote name

* Allow overriding @kbn/dev-utils's CA_CERT_PATH

* Add CCS related docs

Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
2021-07-06 09:20:54 -07:00
Dima Arnautov 901ad6391a
[Transform] Fix aggregation name override for the top_metrics aggs (#104446)
* [Transform] Fix aggName for the top_metrics agg

* [Transform] update comment
2021-07-06 11:39:13 -04:00
David Sánchez 763ba305d4
[Security Solution][Endpoint] Event filters text adjustments to be consistent with trusted apps (#104438)
* Text adjustments to be consistent with trusted apps

* Changes flyout submit button text
2021-07-06 17:38:14 +02:00
Lisa Cawley 3d2c2ed1ca
[DOCS] Fixes links to anomaly detection overview (#104350) 2021-07-06 08:27:38 -07:00
Corey Robertson 694f8caeb3
[Canvas] Move away from lib/workpad_service (#104183)
* Move away from lib/workpad_service

* Adds stubs

* Fix types. Swap fetching zip to workpad service

* Fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-06 11:25:34 -04:00
Kyle Pollich eb57dd4a7e
[Fleet] Update "Policies" breadcrumb to "Agent Policies" (#104436)
* Update Policies breadcrumb to Agent Policies

Closes #103447

* Convert tab titles + breadcrumbs to sentence case
2021-07-06 11:05:26 -04:00
Sergi Massaneda 1bc2d9e89a
[Security Solutions] Detect navigation crash fix (#104329)
* detections empty timelines crash patch

* cleaning unnecesary key
2021-07-06 17:01:07 +02:00
Tiago Costa 87971e74e1
skip failing es promotion suite (#104469) 2021-07-06 15:39:08 +01:00
Tiago Costa c72ad3edcb
skip failing es promotion suite (#104467) 2021-07-06 15:34:40 +01:00
Tiago Costa a0b36c75f5
skip failing es promotion suite (#104466) 2021-07-06 15:26:39 +01:00
Cauê Marcondes 434568abe4
[APM] Blank page when navigating to errors metadata (#104322)
* using history.location instead of location

* removing consoles
2021-07-06 10:04:31 -04:00
Joe Portner 57fdadbbec
[Docs] Add auth_provider_hint to authentication docs (#104132) 2021-07-06 10:02:47 -04:00
Wylie Conlon df8f870f38
[Lens] i18n tinymath help text (#104205)
* [Lens] i18n tinymath help text

* Fix i18n ids for remaining strings

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-06 09:49:50 -04:00
Alejandro Fernández Gómez d20de1222c
[Fleet] Tweak agent permissions (#104415) 2021-07-06 09:33:41 -04:00
Pablo Machado 1ae7afd1ca
Fix Kibana page crash on redirect navigation when timeline is open (#104288) 2021-07-06 09:25:14 -04:00
Nicolas Chaulet 75187b6aee
[Fleet] Fix powershell command to add fleet server (#104342) 2021-07-06 09:16:34 -04:00
Aleh Zasypkin 2d48f7fb11
Add userSetup plugin skeleton. (#101610) 2021-07-06 14:41:24 +02:00
Marco Liberati f6fc6c1a3d
Fix new terms enum API when field meta is not passed for autocomplete value suggestions (#104141)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-06 14:36:24 +02:00
Tiago Costa 9773e3f678
skip failing es promotion suite (#104413) 2021-07-06 12:07:54 +01:00
Vadim Dalecky ec5d398865
Redirect endpoint (#103899)
* feat: 🎸 add redirect endpoint app

* feat: 🎸 improve spinner design

* feat: 🎸 implement basic version of redirect endpoint

* feat: 🎸 render errors for user on the screen

* feat: 🎸 improve error message display

* feat: 🎸 improve error display

* feat: 🎸 improve locator errors

* feat: 🎸 improve errors

* feat: 🎸 improve persistable state types

* feat: 🎸 implement migrateToLatest function

* feat: 🎸 migrate locator params to the latest in redirect endp

* Update src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts

* refactor: 💡 make Versioned state be an object

* fix: 🐛 use new VersionedState interface in redirect endpoint

* refactor: 💡 move parseSearchParams into a separate function

* feat: 🎸 implement redirect URL formatter

* feat: 🎸 export redirect URL parsing and formatting functions

* refactor: 💡 use relative import

* test: 💍 add example links through redirect endpoint

* test: 💍 use updated VersionedState type

* test: 💍 add redirect manager tests

* feat: 🎸 add redirect endpoint app to common schema

* chore: 🤖 update telemetry schema

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-06 13:01:51 +02:00
Tiago Costa 79608dcc9e
skip failing es promotion suite (#104409) 2021-07-06 11:58:42 +01:00
Tiago Costa 98942050c9
skip flaky suite (#104372) 2021-07-06 11:41:41 +01:00
Dima Arnautov 253a398db4
[ML] Fix embeddable swim lane container to show a scrollbar on overflow (#104289)
* [ML] fix legend

* [ML] add extra div wrapper for overflow scroll
2021-07-06 12:09:16 +02:00
István Zoltán Szabó 7fefdb1d89
[DOCS] Changes docs link service link for ROC curve. (#104380)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-06 11:47:57 +02:00
Tiago Costa dfc5dbb31b
skip failing es promotion suite (#104366) 2021-07-06 02:29:47 +01:00
Tiago Costa 269577703a
skip failing es promotion suite (#104365) 2021-07-06 02:25:34 +01:00
Tiago Costa 16f69d24b6
skip failing es promotion suite (#104364) 2021-07-06 02:19:47 +01:00
Tiago Costa 2e492c2083
skip failing es promotion suite (#104362) 2021-07-06 02:14:32 +01:00
Cauê Marcondes f5e7b46eb9
[APM] Refactoring menu section (#104338) 2021-07-05 17:15:22 -04:00
Nicolas Chaulet e3c2dfc9b4
[Fleet] Preserve search when syncing hash router and urls (#104310) 2021-07-05 17:14:23 -04:00
Cauê Marcondes b0b0584b55
[APM] When using search bar UI should fall back to transactions (#103987)
* adding kuery bar to search transactions metrics

* addressig PR comments

* fixing api test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-05 16:15:50 -04:00
Lisa Cawley f9c52277fb
[DOCS] Adds ML link to Kibana quickstart (#104018) 2021-07-05 10:10:47 -07:00
James Gowdy 10ea44b24c
[ML] Fixing missing data visualizer links (#103932)
* [ML] Fixing missing data visualizer links

* adding index dataviz links

* fixing permission

* re-enabling tests

* fixing typo

* adding check for non time based index

* catching possible error when getting index pattern

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-05 18:01:41 +01:00
James Gowdy 5301403594
[ML] Fix slow calendar creation UI (#104248)
* [ML] Fix slow calendar creation UI

* updating jest snapshots

* updaing jest tests

* fixing functional tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-07-05 17:53:18 +01:00
Domenico Andreoli a0b96d4fab
Override cy.exec's NODE_TLS_REJECT_UNAUTHORIZED=0 (#104256)
If any of Elasticsearch or Kibana urls uses https, then `node` aborts with:

> Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes
> TLS connections and HTTPS requests insecure by disabling certificate verification.

Investigation proved that cy.exec injects `NODE_TLS_REJECT_UNAUTHORIZED=0` regardless
of how `NODE_TLS_REJECT_UNAUTHORIZED` or `CYPRESS_NODE_TLS_REJECT_UNAUTHORIZED` are
defined in the environment.

1. Use `node --no-warnings`
   Gun too big, could hide other issues worthy of a failure

2. Explicitly pass NODE_TLS_REJECT_UNAUTHORIZED=1

This commit implements option 2.

```
describe('Env checks', () => {
  it('CYPRESS_NODE_TLS_REJECT_UNAUTHORIZED is undefined', () => {
    expect(Cypress.env('NODE_TLS_REJECT_UNAUTHORIZED')).to.equal(undefined);
  });

  it('NODE_TLS_REJECT_UNAUTHORIZED is undefined', () => {
    expect(process.env.NODE_TLS_REJECT_UNAUTHORIZED).to.equal(undefined);
  });

  it('cy.exec environment is sane', () => {
    const NODE_TLS_REJECT_UNAUTHORIZED =
      Cypress.env('NODE_TLS_REJECT_UNAUTHORIZED') === '0' ? '0' : '1';

    cy.exec('set', { env: { NODE_TLS_REJECT_UNAUTHORIZED } })
      .its('stdout')
      .should(($elem) => {
        expect($elem).to.not.contain('NODE_TLS_REJECT_UNAUTHORIZED=0')
      });
  });
});
```
2021-07-05 12:05:01 -04:00