* [TSVB] Importing a dashboard with only TSVB viz on another space, breaks the dashboard
Closes: #103059
* move index-pattern to constant
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* When type endpoint gets os type from os name instead of os family
* Allow users add event filters only for endpoint events
* Fixes error with wrong map function
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Triggers search even if the query hasn't changed
* Add await on async function call
* refactor, use forceSearch store flag instead of new actin type to force search
* fix error when refreshing trusted apps
* Fix ts-error by adding ts-ignore '{ type: "LoadingResourceState"; previousState: ImmutableObject<UninitialisedResourceState> | ImmutableObject<LoadingResourceState<EventFiltersListPageData, ServerApiError>> | ImmutableObject<...> | ImmutableObject<...>; }' is not assignable to type 'ImmutableObject<{ forceRefresh: boolean; }>'.
Object literal may only specify known properties, and 'type' does not exist in type 'ImmutableObject<{ forceRefresh: boolean; }>'
When installation integrations via the browse -> add integration flow in
the integrations UI, we will no longer redirect the user back to the
integration details page.
Closes#100978
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Do not collect code coverage on test_helpers
Note: some test helpers are no longer being used but might be some day - e.g., shallowWithIntl will be used on the beta badge
* Fix uncovered type line
- since we're not iterating over productNames, no need for it to be an array - it can be written more clearly in string union format
* Fix branch coverage on index.tsx
- Since KibanaLogic is setting `|| {}` fallbacks in any case, I've opted to remove them in this file and let fallbacks be handled there
- Fixed typing to make it clear plugins can be undefined (i.e., disabled/optional, etc) in props + reorganize w/ comments
- KibanaValues requires an Omit to override props types
* Crawler DomainsTable test coverage/improvements
- Fix test failing locally due to timezones by increasing the timezone offset
- Cover missing branch line by adding a domain with no `lastCrawl`
- Remove unnecessary extra beforeEach with dupe re-shallow/mounts
- move getTable helper to its most relevant block (it's not being used in the generic column content checks, only in the actions column suite)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Fix toasts rerendering/resetting between page navigations + z-index issues
- note: I opted to delete the `<Callouts>` component in favor of just reverting it to the old `<FlashMessages>`, now that FlashMessages is no longer responsible for toasts
* Update engine creation success messages
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update engine deletion success message
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update source engines add/delete success messages
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update crawler domain delete message
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update API key create/update/delete sucess messages
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update curations delete success message
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update results settings success message
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Update relevance tuning success/reset messages
- to use a toast (+ toast message) instead of a callout
- update copy to match EUI guidelines
* Update document deletion success message
- to use a toast instead of a callout (+ split additional text)
- update copy to match EUI guidelines
* Update role mappings create/update/delete success messages
- to use a toast instead of a callout
- update copy to match EUI guidelines
* Run i18n_check --fix
- per localization team guidelines - strings that have been changed should get deleted/scheduled to be re-translated
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [ML] Converts management app jobs list pages to new layout
* i[ML] Fix translations
* [ML] Set acccessDenied default state back to false
* [ML] Remove headers for error states and text updates following review
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Lens] Document common formulas in product and add formula tutorial
* Make common formulas appear in sidebar and format consistently
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This enables Fleet to accept package field definitions that declare a constant "value"
for `constant_keyword` fields. Fleet will generate an index template for the constant_keyword
field that contains the `value` attribute.
Relates: https://github.com/elastic/package-spec/pull/194
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Port #3904 to Kibana
https://github.com/elastic/ent-search/pull/3904
* DRY out logic interfaces
Should have done this long ago
* Port #3920 to Kibana
https://github.com/elastic/ent-search/pull/3920
* Lint fixes
* Remove error state from form
We already did this for the users flyout. Basically changes the dirty state of the form from an error state to just showing “Required”. i18n had not been translated yet for `ATTRIBUTE_VALUE_ERROR`
* Add loading states
* Remove manual disabling of button
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Remove manual disabling of other button
* Lint fixes
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Automatically install and update the security_detection_engine package
* Remove security_detection_engine from required Fleet packages
* Update fleet package-registry image
* Add sha256: to the distribution package
* Use distribution from https://beats-ci.elastic.co/job/Ingest-manager/job/release-distribution/152
* Change fleet required packag
* Fix bad merge
* Update rules to 0.13.1 package
* Fix NOTICE.txt
- Caused by the wrapping <div> around the child views - removing that div and moving the `data-test-subj` hooks to the individual views fixes the issue
* Remove isFederated from main app and routes
* Expose all overview cards that were hidden for federated auth
* Expose all user features that were hidden for groups
* Remove remaining isFederatedAuth references
* Lint fixes
* Add modified test back for Workplace Search
* Remove extraCell
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Remove brackets
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Update test name
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Refactor NotFound component
- shared NotFound becomes NotFoundPrompt - returns only an EuiEmptyPrompt, and individual products/plugins are in charge of their own layout, rather than NotFound doing a bunch of arduous switch handling (also closer to how errorConnecting is a component set per-plugin)
- This is both due to the recent page template refactor and the fact that WS has extra complex logic of needing to switch between its kibana layout and personal dashboard layout
- logos are still hosted in shared/ since they need extra custom CSS to work correctly sizing wise and in dark mode. I renamed its folder from `assets`->`logos` for extra clarity
* [AS] Update current AS routers using NotFound
+ update EngineRouter to use NotFound
* [WS] Update app router
- Handle errorConnecting at the topmost level, instead of in WorkplaceSearchConfigured (to simplify various logic/expectations & match App Search)
- Simplify isOrganization check to use `useRouteMatch` instead of a regex
- Use new NotFound component
- Add NotFound component for the personal dashboard router
* [WS] Improve Source 404 UX
- Add NotFound to SourceRouter + add breadcrumbs for organization views
- When an actual source ID 404s, fix blanket redirect to a dashboard aware redirect - personal dashboard 404s should send the user back to personal sources, not organization sources
+ add a flash message error (similar to how App Search behaves for engine 404s)
+ harden error status checks (gracefully allow for non-http errors to fall back flashAPIErrors
* [WS] Improve Settings 404 UX
- This was the only remaining WS route I found that either did not have a 404 or a fallback to some overview page, so I tweaked the redirect order for a graceful redirect (vs a blank page)
* Fix settings router test
* Move away from custom product logos to OOTB Enterprise Search logo
Keeping it simple, etc. RIP in peace fancy logos
* [PR feedback] toContain over stringContaining
