This addresses two issues that have come up:
Alerting and Actions have TypeScript types that are needed across server and public plugins, and need to be extracted to a common path (thanks @chrisronline for bringing this to our attention)
Due to the above, types have been duplicated between the alerting and actions when needed in the Alerting UI, which has led to them diverging. This forces the UI to type check against the API, which will help reduce these errors in the future.
* Disallow importing Joi client side
* Move elasticsearch lib into server folder
* Add a comment about the 'joi' eslint rule
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Fixes the view-by selection when a KQL filter gets active and restores previous behavior:
- If the filter includes AND view-by switches to Job ID.
- Otherwise the view-by selection switches to the first available option present in the KQL filter
- Additionally, the view-by dropdown options get filtered down to the options present in the KQL filter
Fixes the check whether to do a full refresh of the page or not. lastRefresh was mistakenly part of the check. This fixes keeping the flyout open for rules editing.
The search markers where placed on the minimap using a different scale
than the density chart and time ruler. That made the log stream jump to
unexpected time positions when the user clicked on a search marker.
This also fixes an problem where the search markers didn't move
alongside the rest of the minimap when the user dragged and dropped it.
* DocViews uses local angular
* Clean up
* Create embeddableInjector only when it's used
* Revert occasional changes
* Update unit test
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Default sort is no longer in state. There's now a separate function to provide default sort for ES and UI, in case the user didn't actively select a field to sort by
* More Typescript Fixes
* [Reporting/New Platform] Use the logger service from core
* Add log tag
* fix jest tests
* ts fixes
* fix mocha test
* convert to jest
Fixes adjusting the focus chart zoom range when a forecast gets selected. The code is cleaned up so appStateHandler to set the zoom range in the url is only called in one place within contextChartSelected().
* Moved out of legacy folder
* First iteration of watcher plugin that renders
* Move create Timebuckets to plugin root
Update route registration and fix license checking for NP
* Re-enable Component integration tests
* Minor fix for data deserializer in api.ts
* Slight logic refactor, more defensive plugin startup
* Re-add legacy folder for SCSS pipeline
* Remove duplicate style sheet
* Fix type issue with TimeBuckets export
* Update license management routing logic (issued warning for using basepath on navigating away from license management)
Remove commented out code in watcher
* More defensive plugin registration
* Fix i18n issues and restore registration of feature on home view
* Remove watcher license error check copy
* Restore license error message in watcher
* Fix mock context value
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* change setClientFactory api to setClientFactoryProvider
* cleanup and add test for service
* change the signatures of SO start/setup
* fix registerCoreContext by accessing stored start contract reference
* move migration inside `start`
* adapt and add service tests
* add doc and export new types
* adapt plugins code
* update generated doc
* better core access
* address some review comments
* remove parametrized type from SavedObjectsClientFactory, use KibanaRequest instead
* add logs when starting and ending so migration
* fix KibanaRequest imports
* NITs and review comments
* fix alerting FTR test
* review comments
* browser[SEVERE] webpack: A component is changing an uncontrolled input of type %s to be controlled.
Closes: #41017
* fix PR comments
* fix PR comment