Commit graph

29432 commits

Author SHA1 Message Date
Spencer 7ba47eebbf
[euiUtils] fix unnecessary useEffect dep (#52782) 2019-12-11 12:49:15 -07:00
Nathan Reese a50d3781af
[Maps] fix tooltips for CCS (#52793) 2019-12-11 12:39:04 -07:00
Christiane (Tina) Heiligers 3bb48e67c0
Fixes the link to advanced settings in the telemetry opt-in notice banner (#52699)
* Prepends base path to the link to advanced settings in the telemetry opt-in notice banner from all apps
2019-12-11 12:18:37 -07:00
Tim Sullivan 711b44b7fb
[Reporting/NP Migration] Remove server.expose of ExportTypeRegistry (#50973)
* [Reporting/NPMigration] typescriptify ExportTypeRegistry, remove from server.expose

* Minor routes registration cleanup

* move the ETR test file

* Re-pack the route registration, reduce LOC changes

* add EnqueueJobFn type

* Fix usage collector test

* remove a throw error used for development/debugging

* fix imports error

* Fix execute job tests

* wip test fixes

* test fixes for real

* fix more tests

* fix diffs

* Add TODOs about the ExportTypesRegistry.register unwrap the factory functions.

* really make headlessbrowserdriver required as an execute job factory option

* fix tests

* Use constants for license type keywords
2019-12-11 12:11:07 -07:00
Frank Hassanabad f53e1a9dbd
[SIEM][Detection Engine] Adds privileges API endpoint
## Summary

Adds a privileges API endpoint for the UI and people to query to check to see if their namespaced index is going to have the correct privileges or not.

Usage:

Testing:

Set up your user name and password to a test space for the CLI. Give whatever permissions
you want for restricted access to the test-space user, test-space role, and the test-space actual 
space to ensure everything works out as expected.

```sh
export ELASTICSEARCH_USERNAME=test-space
export ELASTICSEARCH_PASSWORD=(passwword)
export SPACE_URL=/s/test-space
```

Then use it like so

API:
```sh
GET /api/detection_engine/privileges
```

CLI:
```sh
./get_privileges.sh
```

Return will be something like this:

```sh
{
  "username": "test-space",
  "has_all_requested": false,
  "cluster": {
    "monitor_ml": true,
    "manage_ccr": false,
    "manage_index_templates": true,
    "monitor_watcher": true,
    "monitor_transform": true,
    "read_ilm": true,
    "manage_api_key": false,
    "manage_security": false,
    "manage_own_api_key": false,
    "manage_saml": false,
    "all": false,
    "manage_ilm": true,
    "manage_ingest_pipelines": true,
    "read_ccr": false,
    "manage_rollup": true,
    "monitor": true,
    "manage_watcher": true,
    "manage": true,
    "manage_transform": true,
    "manage_token": false,
    "manage_ml": true,
    "manage_pipeline": true,
    "monitor_rollup": true,
    "transport_client": true,
    "create_snapshot": true
  },
  "index": {
    ".siem-signals-test-space": {
      "all": false,
      "manage_ilm": true,
      "read": false,
      "create_index": true,
      "read_cross_cluster": false,
      "index": false,
      "monitor": true,
      "delete": false,
      "manage": true,
      "delete_index": true,
      "create_doc": false,
      "view_index_metadata": true,
      "create": false,
      "manage_follow_index": true,
      "manage_leader_index": true,
      "write": false
    }
  },
  "application": {}
}
```

Example permissions that work for managing all signal indexes across all spaces so that the user in question can create it for each space:

<img width="1274" alt="Screen Shot 2019-12-10 at 4 48 19 PM" src="https://user-images.githubusercontent.com/1151048/70579132-f63f8f80-1b6c-11ea-86f7-204fd2163cea.png">

Example permissions that work for managing only a specific signal index:
<img width="1234" alt="Screen Shot 2019-12-10 at 3 49 24 PM" src="https://user-images.githubusercontent.com/1151048/70579185-11aa9a80-1b6d-11ea-8a33-311e85ce5dc9.png">
 
Example permissions that work for an end user using signals across all spaces:
<img width="1229" alt="Screen Shot 2019-12-10 at 3 49 41 PM" src="https://user-images.githubusercontent.com/1151048/70579233-31da5980-1b6d-11ea-8b3a-85703ebcc57f.png">

Example permissions that work for an end user using signals for a a specific index:
<img width="1234" alt="Screen Shot 2019-12-10 at 3 49 24 PM" src="https://user-images.githubusercontent.com/1151048/70579259-43bbfc80-1b6d-11ea-94c1-8bbc65e621b2.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2019-12-11 11:52:11 -07:00
Dmitry Lemeshko 7658e9c631
FTR: add 'throttle' option to cli (#33241)
* [ftr/cli] add throttling option

* [ftr/cli] add headless option, fix test
2019-12-11 19:41:25 +01:00
Alexey Antonov f2b48910a0
[ui/public/utils] Move items into agg_types (#52744)
Closes #51855
2019-12-11 21:25:18 +03:00
Poff Poffenberger 19fec54e0b
[Canvas] Add NP routing for custom elements (#52561)
* [Canvas] Add NP routing for custom elements

* Remove unused type

* Cleanup

* Adding await to delete

* Cleanup
2019-12-11 11:59:44 -06:00
Lukas Olson 8395596159
[Search service] Add timeout parameter from config to requests (#52352)
* Add timeout parameter to requests

* export SharedGlobalConfig from `core/server`
2019-12-11 10:57:19 -07:00
Brandon Morelli b91c24c0b3
docs: unknown route (#52703) 2019-12-11 09:53:44 -08:00
Aleh Zasypkin 2ec82d3dd9
Migrate the rest of the API endpoints to the New Platform plugin (#50695) 2019-12-11 18:35:49 +01:00
Josh Dover a91e53f18f
Add asResponse option to HttpService methods (#52434) 2019-12-11 10:53:17 -06:00
Spencer ab1fe3f14e
[kbnClient] Retry uiSettings.replace() calls up to 5 times (#52601)
* [kbn/dev-utils] target ES2019 to transpile ??

* Retry uiSettings.replace() calls up to 5 times

* share logic for selecting junit report name to ensure they are unique

* convert to junit report path helper
2019-12-11 09:50:03 -07:00
Spencer a25bf49eb8
Add failure screenshot links to JUnit failures (#52449) 2019-12-11 09:42:43 -07:00
Mariana Dima 73938f0cf4
add azure data (#52669) 2019-12-11 17:34:46 +01:00
Devin W. Hurley a12d8551a1
[SIEM] [Detection Engine] Search signals index (#52661)
* adds route for querying signals index, also updates signal status type names

* first pass at happy path tests

* fixes stuff after rebase with master

* utilizes removes search_query from payload and replaces it with just query, adds aggs to signals search api, updates route and validation tests

* removes _headers parameter from route handler and updates comment for aggs script
2019-12-11 11:09:36 -05:00
James Gowdy 4f2a6f8362
[ML] Replacing angular routing (#51842)
* [ML] Replacing angular routing

* removing old files

* changing overview

* renaming overview route

* adding df analytics routes

* adding timeseriesexplorer route

* removing old files

* adding route for explorer

* adding access denied page

* adding module view or create redirect

* fixing job cloning

* adding breadcrumb system

* removing old breadcrumbs files

* fix include

* enabling management section

* injecting app dependencies

* fixing missed dependencies

* fixing saved searches

* fixing type errors

* removing included data start

* code clean up

* updating translations

* fixing router test failures

* fixing functional tests

* removing last use of SavedSearch

* removing comment

* fixing bug in line chart query

* improving saved search jobs

* fixing data viz functional test

* adding comment

* dealing with time range error

* removing unnecessary chrome imports

* cleaning up code

* moving resolver to own file

* changes based on review

* fixing index data viz on basic license

* fixing edit calendar

* adding create job breadcrumb

* fixing results appstate

* fixing management links

* updating new job constants file

* fixing rebase conflicts

* removing commented out code

* adding additional text to the resolver error
2019-12-11 15:58:11 +00:00
Victor Martinez 16447626c9 ci(jenkins): simplify the kibana setup for the e2e tests (#52729) 2019-12-11 16:56:41 +01:00
Pete Harverson c962009df6
[ML] Adds Enterprise license to Start trial text on data viz page (#52749) 2019-12-11 15:54:05 +00:00
Ben Skelker 6f79046ff2
[SIEM] Improves map configuration text on Network page (#52469)
* updates SIEM network page maps conf message

* corrects link atts

* updated message

* updated message again

* finally

* updates after feedback
2019-12-11 17:41:24 +02:00
Chris Roberson 8c19b5e017
Skip all logstash pipeline tests (#52743) 2019-12-11 10:35:34 -05:00
Robert Oskamp 3130759c47
[ML] Functional tests - export service types (#52612)
With this PR the types of the ML services that are used in other services are exported from the service file to allow a cleaner re-use.
2019-12-11 16:25:48 +01:00
Joe Reuter b6ea6990c0
Migrate url shortener service (#50896) 2019-12-11 14:19:28 +01:00
Joe Reuter 489b39cfe7
Re-enable datemath in from/to canvas timelion args (#52159) 2019-12-11 14:14:25 +01:00
Felix Stürmer 0cd62cabbb
[Logs + Metrics UI] Remove eslint exceptions (#50979)
This removes the two eslint exceptions specific to the `infra` plugin introduced in #49244.

fixes #49563
2019-12-11 13:48:40 +01:00
Alejandro Fernández 9fcc93457f
[Logs + Metrics UI] Add missing headers in Logs & metrics (#52405)
* Fix broken aria references

`EuiDescribedFormGroup` needs an actual header in its `title` for it to
make a correct `aria-labelledby`.

* Fix `aria-labelledby` references in settings page


Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2019-12-11 13:47:37 +01:00
Robert Oskamp 248904ec87
[ML] API integration tests - initial tests for bucket span estimator (#52636)
This PR adds basic API integration tests for the bucket span estimator.
2019-12-11 11:05:36 +01:00
Jean-Louis Leysens aa31b535d1
[Watcher] New Platform (NP) Migration (#50908)
* First iteration of watch public -> new platform
Still need to switch to np ready version of use_request

* - Switched to using np ready request
- Some updates after API changes

* First attempt at server shim

* Rename file and re-enable react hooks linting

* Fix some public types and react hooks lint rules

* Fix types

* More ES lint react hooks fixes

* Migrated server lib -> ts. Part way done with migrating routes to NP router and TS

* Big subset of routes to TS and NP router - almost there

* Delete legacy error wrappers and moved last set of routes to TS and NP router

* Remove @ts-ignore's and update route registration to use shim with http router

* Added routes validations, fixes for hooks and fixes for types

* Fix more types and finish testing API routes

* Fix usage of feature catalogue and fix time buckets types

* Fix error message shape [skip ci]

* Split legacy from new platform dependencies server-side

* Refactor: Seperate client legacy and NP dependencies

* Add file: added types file

* Fix UISettings client type import

* Update license pre-routing factory spec

* Update variable names, use of I18nContext (use NP) and docs

* Use NP elasticsearchclient

* Simplify is_es_error_factory

* Fix types

* Improve code legibility and remove second use of `useAppContext`

* Use @kbn/config-schema (not validate: false) on routes!

* Fix watch create JSON spec

* Create threshold test working

* Unskip watch_edit.test.ts

* Unskip watch_list.test.ts

* Done re-enabling component integration tests

* TimeBuckets typo + remove unnecessary // @ts-ignore
2019-12-11 09:54:42 +01:00
Aleh Zasypkin 7e27f0d35f
Decouple Authorization subsystem from Legacy API. (#52638) 2019-12-11 08:55:46 +01:00
Dario Gieselaar f0eb4bb675
[APM] Fix some warnings logged in APM tests (#52487)
* [APM] Fix some warnings logged in APM tests

(Seemingly) since the React upgrade in 439708a6f9, our tests have started logging various warnings/errors to the console. The test suite is still passing but it creates a lot of noise.

Changes:

- use `act` or `wait` when appropriate
- mock useFetcher calls
- cleanup in useDelayedVisbility

* Replace tick() with wait()
2019-12-11 08:47:44 +01:00
Alexey Antonov 6a8b2a25c8
[ui/public/utils] Delete unused base_object & find_by_param (#52500)
Closes #51854
2019-12-11 10:30:45 +03:00
Alexey Antonov 1013271c85
[ui/public/utils] Move items into ui/vis (#52615)
* [ui/public/utils] Move items into ui/vis

* fix PR comments
2019-12-11 10:28:54 +03:00
spalger 3e1915d287 fix newlines in kbn-analytics build script 2019-12-10 21:07:57 -07:00
Stacey Gammon 79fc07c0c3
Add top level examples folder and command to run, --run-examples. (#52027)
* Add top level examples folder and command to run, `--run-examples`.

* Add comment explaining reason --run-examples flag turns off base path.
2019-12-10 18:02:03 -05:00
Tiago Costa 0eb4c18fe0
feat(NA): add trap for SIGINT in the git precommit hook (#52662) 2019-12-10 22:05:19 +00:00
gchaps 6e476e845d
[DOCS] Updtes description of elasticsearch.requestHeadersWhitelist (#52675) 2019-12-10 12:30:11 -08:00
Christiane (Tina) Heiligers 2dcb44850a
[Telemetry/Pulse] Updates advanced settings text for usage data (#52657)
* [Telemetry/Pulse] Updates advanced settings text for usage data
2019-12-10 12:55:41 -07:00
Frank Hassanabad 48d897e6e7
[SIEM][Detection Engine] Adds the default name space to the end of the signals index
## Summary

One liner to add the `default` to the end of the siem signals index for people to play with it.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-12-10 12:01:48 -07:00
Felix Stürmer cf28280496
[Logs UI] Generalize ML module management (#50662)
This abstracts the specific job details out of the ML module management hooks to enable re-use with the upcoming categorization module.

closes #50322
2019-12-10 19:21:10 +01:00
Joe Reuter 3c57f71c3a
Removing stateful saved object finder (#52166) 2019-12-10 17:50:00 +01:00
Joe Reuter 618e70433b
Shim oss telemetry (#51168) 2019-12-10 17:32:56 +01:00
Tim Sullivan e71deb2683
[Reporting/Screenshots] Do not fail the report if request is aborted (#52344)
* [Reporting/Screenshots] Do not fail the report if request is aborted

* take pageRequestFailed out of pageExit observable
2019-12-10 09:24:13 -07:00
Xavier Mouligneau 8115e500ff
[SIEM] [DETECTION ENG] Add MITRE ATT&CK (#52398)
* add mitre attack enterprise

* Add Mitre Att&ck on the about rule

* review

* fix internatiolazition

* bugs review

* fix ux with add reference
2019-12-10 10:46:56 -05:00
Frank Hassanabad 6ea07cbb9c
[SIEM][Detection Engine] Renaming and moving of folders and files (#52587)
## Summary

* Creates several folders
* Moves schema into smaller files
* Moves `utils.ts` in smaller files
* Splits apart the types to not be in one giant file but rather cascade bottom up

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2019-12-10 08:43:04 -07:00
Juan Álvarez 5217dfd731
update apm index pattern (#52629) 2019-12-10 16:11:58 +01:00
Maja Grubic 717e40c444
Move DashboardEmptyScreen inside DashboardViewport (#51939)
* Prototyping adding Visualization to Dashboard

* i18n fixes

* Remvoing dashboard empty screen directive

* Updating test for empty dashboard screen

* Removing unused state variable

* Adding a test for DashboardViewPort

* i18n & minor fixes

* Fixing fullscreen mode view

* Fixing failing functional test (hopefully)

* Minor style fix

* Fixing EUI text, rendering empty screen OR the panels

* Fixing empty screen in fullscreen mode

* Update snapshot

* Trying to render empty screen from Angular controller

* refactor: 💡 don't pass renderEmpty through inputs

And make sure isEmptyState is not stale.

* Fixing tests after Vadim's commit

* Removing unnecessary isEmptyStateProps

* Skipping failing test

* Removing unnecessary en.json file

* Re-adding emptyState, reintroducing functional test

* Fixing ja-JP file

* Undoing my thing to the functional test
2019-12-10 15:05:05 +00:00
Jean-Louis Leysens b4a27519b7
[Console] Move out of quarantined (#52270)
* WiP, lotta broken things, working through new editor.ts

* RowParser -> TS

* Utils to TS and regular module

* Finished first version of core & sense editor wrappers. Tokenizer provider test working. Still need to delete some files

* WiP - moved A LOT of code around and busy fixing sense-editor tests

* Fix sense editor test

* Clean up mocks

* Moved A LOT of code out of quarantined.
Still working on sense editor's integration test
Not running yet.

* WiP still finishing up manual testing

* Fix use of Ace Range and fix open documentation

* Move out of quarantined!

* Remove load remote editor state for now

* - fix use of token iterator
- remove ace ranges from sense editor spec and fix spec 🤦

* Address getSelectionRange document TODO
Clean up use of jquery
Remove use of `done` inside async tests (input_tokenization.test.js)
Capitalize elasticsearch
Introduce helper for converting to AceRange inside legacy core editor
Update typings
Clean up imports
Cleaner variable assignment

* Update src/legacy/core_plugins/console/public/np_ready/application/models/sense_editor/curl.ts

Co-Authored-By: Rory Hunter <pugnascotia@users.noreply.github.com>

* Remove commented-out code
lib/utils.js -> lib/utils.ts
Rename engulfling range (sense_editor)

* Rename format request function

* utils.ts default export usage cleanup

* Update replace regex and add another utils test

* Remove legacy replace behaviour

* Fix typo in comment
2019-12-10 13:16:23 +01:00
Shahzad f6c44df066
[Uptime] Feature/expandable row in details ping list (#51890)
* update columns

* update expand row in ping list
2019-12-10 12:37:57 +01:00
Matthias Wilhelm c4e4da377d
[Discover] Move State to inner angular (#52369) 2019-12-10 12:21:57 +01:00
Pierre Gayvallet 1cdbd600a9
moves eui mapping to own file (#52518) 2019-12-10 12:19:50 +01:00