Commit graph

30158 commits

Author SHA1 Message Date
Lisa Cawley ccbb2863e7
[DOCS] Add tip for using elasticsearch-certutil http command (#55357) 2020-01-21 18:54:54 -08:00
Frank Hassanabad 8f0c413ef5
[SIEM][Detection Engine] Critical blocker, fixes schema accepting values it should not (#55488)
## Summary

* This fixes the schema accepting values the UI cannot handle at this point with severity. It's best to just set it to a small fixed enumeration of values.
* From feedback from people the values should have more defaults and be more consistent in the schema so gave defaults for `from`, `to`, and `interval`.
* Removed dead query examples that cannot happen because immutable cannot be set by end users anymore
* Changes the version and other sections to be integer only and not allow floats
* Added unit tests

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-21 19:02:28 -07:00
Xavier Mouligneau 5344702246
[SIEM] Detections create prepackage rules (#55403)
* update extra action on rule detail to match design

* remove experimental label

* allow pre-package to be deleted + do not allow wrong user to create pre-packages rules

* Additional look back minimum value to 1

* fix flow with edit rule

* add success toaster when rule is created or updated

* Fix Timeline selector loading

* review ben doc + change detectin engine to detection even in url

* Succeeded text size consistency in rule details page

* fix description of threats

* fix test

* fix type

* fix internatinalization

* adding pre-packaged rules

* fix bug + enhance ux

* unified icon

* fix i18n

* fix bugs

* review I

* review II

* add border back
2020-01-21 20:31:11 -05:00
Tim Sullivan c531eb477b
[Reporting] Convert CSV Export libs to Typescript (#55117)
* [Reporting] Convert CSV Export libs to Typescript

* fix jest tests

* more ts conversion

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 17:39:03 -07:00
Nathan Reese 04374e665c
[Maps] show field type icons in data driven styling field select (#55166)
* [Maps] show field icons in data driven styling field select

* only show origin group label when there is more then one origin

* review feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 18:52:13 -05:00
Patrick Mueller b78c1b1042
Adds event log for actions and alerting (#45081)
initial code for event log

see issue https://github.com/elastic/kibana/issues/45083
2020-01-21 18:00:08 -05:00
Frank Hassanabad db1a64da76
[SIEM][Detection Engine] Fixes critical blocker where signals on signals are not operating
## Summary

This fixes halting, infinite creation of signals, and cyclic issues with signals when they are reflected on their own index. Without this fix, you could get a user who looks back at a signals index as both their input and output index and forever generates new signals forever and ever and ever until the heath death of the universe. 

* Changes the data structure to support parent and ancestors
* Adds a check for the parent and ancestors
* Adds README.md and in-depth testing of cyclic concepts
* Adds README.md and in-depth testing of depth levels of signal concepts
* Added unit tests for both use cases
* Removed extra console.log statement found in the code base

Follow the two README.md's included for testing and explanation of how it works.

See `test_cases/signals_on_signals/depth_test`
See `test_cases/signals_on_signals/halting_test`

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-21 15:29:43 -07:00
Frank Hassanabad 31d3821598
[SIEM][Detection Engine] Critical blocker, adds need REST prefix for cloud
## Summary

* Adds needed `/` to the beginning of cloud requests from Kibana -> ES

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-21 15:28:49 -07:00
Thomas Neirynck 391c348a97
remove incorrect config (#55427) 2020-01-21 16:45:40 -05:00
Matt Bargar 884560806c
Retain pinned filters when loading and clearing saved queries (#54307)
When we originally implemented Saved Queries we had them overwrite pinned filters on load and on clear. This caused the issue in #53258. If you have a saved query loaded in Discover for example and you navigate to a different app and then back to Discover, that saved query will get get reloaded since app state is retained when navigating back and forth between apps. If you created a pinned filter in between visits to Discover, it will get removed when the saved query is reloaded.

This issue made me reconsider our previous decision. I think pinned filters should not be affected by loading or clearing a saved query, since they are pinned they should only be removed if the user explicitly asks for it. This solves the reported issue and I also think it makes the UI more intuitive.
2020-01-21 16:33:53 -05:00
Pedro Jaramillo 7eb934e80c
Resolver zoom, pan, and center controls (#55221)
* Resolver zoom, pan, and center controls

* add tests, fix north panning

* fix type issue

* update west and east panning to behave like google maps
2020-01-21 16:00:52 -05:00
Brian Seeders 0cd1733c8a
Skip failing endpoint saga tests 2020-01-21 15:54:05 -05:00
Eli Perelman 2aa87738a7
[skip-ci] Update migration guide to add rendering service example (#54744)
* Update migration guide to add rendering service example

* Address review nits

* Address nits

* Add chromeless apps to TOC
2020-01-21 14:48:16 -06:00
Kaarina Tungseth 0ac60494d6
[DOCS] Updates to heat map page (#55097) 2020-01-21 14:01:28 -06:00
Paul Tavares 5a5bade8be
[Endpoint] Fix saga to start only after store is created and stopped on app unmount (#55245)
- added `stop()`/`start()` methods to the Saga Middleware creator factory
- adjust tests based on changes
- changed application `renderApp` to stop sagas when react app is unmounted
2020-01-21 14:21:33 -05:00
Felix Stürmer 85edc66125
[Logs UI] Use the correct icons and labels in the feature cont… (#55292)
This fixes logs and metrics icons as well as the metrics label in the feature control lists which were missed during the renaming.

fixes #55283
2020-01-21 19:42:22 +01:00
Justin Kambic 16b5fd7e04
[Uptime] Handle locations with names but no geo data (#55234)
* Handle locations with names but no geo data.

* Fix broken types, add a comment explaining some weird ts-related code.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 13:41:36 -05:00
Thomas Neirynck 740d4d1afa
[File upload] Enforce file-type check in file dialog (#55063) 2020-01-21 13:23:49 -05:00
patrykkopycinski fc21c49c35
[SIEM] Fix Detections page breadcrumbs (#55173) 2020-01-21 19:20:53 +01:00
Michail Yasonik da54657b91
Grouped Kibana nav (#53545)
Adds concept of `category` to nav links, grouping them by this in the side nav
2020-01-21 12:48:07 -05:00
James Gowdy 01fe8afb98
[ML] Fixing categorization wizard example results (#54924)
* [ML] Fixing categorization wizard example results

* moving validation results to class

* cleaning up category analyzer types

* small tweaks

* removing commented out code

* fixing string ids

* small refactor

* improving validation messages

* fixing types

* updating message text

* fixing typo

* adding privileges error

* updating privilege message

* changes based on review

* removing old warning message

* fixing translations

* renaming enum
2020-01-21 17:35:47 +00:00
Joe Portner 5aa85dc751
Update Monitoring plugin's Elasticsearch configuration (#55119)
* Fix Monitoring plugin Elasticsearch SSL config

Plugin now allows "keystore" and "truststore" values in its
config schema as the documentation currently states.
Plugin also now reads PEM and PKCS12 files off of the filesystem
before attempting to create an Elasticsearch client.

* Add missing Elasticsearch config deprecations

Several Elasticsearch config deprecations were overlooked for
monitoring-specific Elasticsearch settings.
2020-01-21 12:35:02 -05:00
Liza Katz f26596145e
Clean up search service (#53766)
* deprecate msearch

* Missing export

* adjust tests, revert loading method of esaggs/boot

* getInjectedMetadata

* Fix jest tests

* update default strategy abort test

* notice update

* Allow running discover errors test independently

* Remove batchSearches

* Detect painless script error

* don't show notifications for aborted requests

* Fix jest tests

* Restore loader indicator

* Decreace loading count on error

* update search test

* Trigger digest after fetching fresh index patterns

* Revert isEqual

* accurate revert

* Return full error details to client from search endpoint

* Re-throw AbortError from http when user aborts request.

* fix typo

* typo

* Adjust routes jest test

* Restore msearch using a separate es connection

* typescript fixes

* set http service mock

* Move es client to dat aplugin, for follow up PR

* Add karma mock

* krma mock

* fix tests

* ts

* Pass in version dynamically

* add headers to esClient host

* Restored fetch soon test
Use tap for loadingCount side effects

* Cleanup search params

* Cleanup search params test

* Revert "Cleanup search params"

This reverts commit ca9dea01d5.

* Revert "Cleanup search params test"

This reverts commit 30b9478612.

* Revert code to use old es client until  #44302 is resolved

* Revert changes to getPainlessError

* Fix jest test

* Refactor esClient to trigger loadingIndicator

* fixing tests

* use esClient from searchService

* git remove comment

* fix jest

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 18:49:57 +02:00
Nick Partridge ce2930ec51
De-angularize vis tooltips (#54954)
* Remove angular dependencey from vis/tooltip
* Move tooltip logic into vislib
* Remove and fix all ngMock refs in vislib tests
* Add numeral to renovate config
* Add vis_type_vislib to codeowners
* Move vis_legend into vislib and fix errors
* vis_type_vislib/public imports to be only top-level
2020-01-21 10:46:56 -06:00
Josh Dover b0af1bf95c
Clear core loading indicator just before UI is rendered (#55242)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 09:19:08 -07:00
Justin Kambic 2bf111c50f
[Uptime] Fix flaky uptime overview page test (#54767)
* Fix flaky uptime overview page test.

* Increase timeout for url checks.

* Prefer standard `retry.try` to custom retry implementation.

* Remove unneeded symbol.

* Remove unnecessary type annotation.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 10:58:57 -05:00
James Gowdy ce286f543e
[ML] Adding missing job groups to recognizer wizard (#55392) 2020-01-21 15:25:58 +00:00
Aleh Zasypkin be31198d21
Re-enable Kerberos + anonymous access test. (#55377) 2020-01-21 15:55:54 +01:00
Daniil Suleiman 6feabcd533
Generate a static parser, move tests to vis_type_timelion (#55299)
* Use generated parser, move tests to vis_type_timelion

* Remove legacy tests

* Create a grunt task for generating a parser
2020-01-21 17:38:28 +03:00
Nathan Reese d3cef4791e
[Maps] fix warning about missing key in react element (#55372) 2020-01-21 08:54:42 -05:00
Joe Reuter 6b02ed804f
Migrate session storage short url handling (#55021) 2020-01-21 14:52:32 +01:00
Joe Reuter c88aa5a505
Migration: Separate legacy and index entrypoint (#54124) 2020-01-21 14:49:30 +01:00
patrykkopycinski c196058350
[SIEM] Update ml_conditional_links cypress tests (#55373) 2020-01-21 14:04:52 +01:00
Dima Arnautov a131f1dbcf
[ML] Formatting for additional timing and model size stats (#55062)
* [ML] formatting for additional timing and model size stats

* [ML] roundToDecimalPlace only average search time

* [ML] adjust functional tests

* [ML] remove debug tag, fix assert value

* [ML] check for no decimal place

* [ML] fix functional tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 13:50:18 +01:00
Aleh Zasypkin 9d3d3cdc67
Migrate Management views to Kibana Platform plugin (#53880) 2020-01-21 13:40:39 +01:00
Anton Dosov 27c8a4bc25
[State Management] remove AppState from Dashboard app (#54105)
Removes AppState from dashboard app and replaces it with state containers and state syncing utilities.
2020-01-21 13:04:49 +01:00
Mikhail Shustov 4971a2c772
Expose fatalErrors API from the Start contract (#55300)
* Expose FatalErrors from the Start contract.

This API is intended to be used for runtime as well.

* update docs

* update data plugin snapshot to fix tests

* address comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 12:58:40 +01:00
Liza Katz 4ca2fbdb11
[BUG] Data fetching twice on discover timefilter change (#55279)
* Fix bug #54887
 - Filters are not only fetch once on timefilter change
 - Make sure that discover doesn't fetch data when a disabled filter is changed
 - Support compareFilters on an array of filters.
 - Added tests to compare filters
 - Exctracted sortFilters and added tests to it.

* code review + FilterCompareOptions

* Remove sort by

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-21 11:03:55 +02:00
Sébastien Loix a20ac0d710
[Mappings editor] Add missing max_shingle_size parameter to search_as_you_type (#55161) 2020-01-21 14:27:51 +05:30
Alejandro Fernández cdb0021ac6
[Logs UI] Fix z-index of logs page toolbar (#54469)
* Fix z-index of logs page toolbar

* Extract `FixedDatePicker` from log setup page, and use it in the stream page

* Clean unused import

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-20 18:28:55 +01:00
Gidi Meir Morris 638792a557
removes CTA from Task Manager info message (#55334)
removes CTA from Task Manager info message
2020-01-20 17:24:17 +00:00
James Gowdy bf0bcfe703
[ML] Fixing missing job_type in job messages search (#55330) 2020-01-20 16:12:25 +00:00
Walter Rafelsberger 3e567b5cf2
[ML] Correctly pass on severity value to anomaly explorer charts. (#55207)
- Fixes passing on the severity value correctly to anomaly explorer charts. The wrong value of undefined being passed down caused anomaly markers not showing up.
- This bug surfaced that the severity value was never applied to filter multi-bucket anomalies which is now also fixed by this PR.
- Adds a check if topInfluencers is an array.
2020-01-20 15:43:22 +01:00
Walter Rafelsberger bd7f7ab48a
[ML] Single Metric Viewer: Fix job check. (#55191)
Fixes switching via navigation to Single Metric Viewer from Anomaly Explorer for a job which isn't supported in the Single Metric Viewer.
2020-01-20 15:37:41 +01:00
Pierre Gayvallet de7a22d523
Show error page when accessing unavailable app (#54656)
* display not found page instead of throwing an error when accessible unavailable app

* move types to public folder

* fix types import

* remove updater from start app

* remove unnecessary await
2020-01-20 15:00:11 +01:00
James Gowdy 82ab1a604f
[ML] Improving job wizards with datafeed aggregations (#55180)
* [ML] Improving job wizards with datafeed aggregations

* picking all agg keys for fields

* function move and rename
2020-01-20 13:24:48 +00:00
Mikhail Shustov a9824f476b
remove flaly assetion. a license presence tested anyway (#55289) 2020-01-20 13:37:07 +01:00
Shahzad 6c420b7d86
fix commonly used ranges uptime (#54930) 2020-01-20 12:19:30 +01:00
patrykkopycinski 4328265c5d
[SIEM] Use proper icons on Detections view (#55215) 2020-01-20 12:06:17 +01:00
Marcin Tojek 641fe3da44
Fix: invalid translation referenced (#54901) 2020-01-20 12:04:02 +01:00