Commit graph

47741 commits

Author SHA1 Message Date
Christos Nasikas e35999134b
[Actions][Docs] Rename isLegacy to usesTableApi (#116922) 2021-11-01 14:49:35 +02:00
Joe Reuter b8ebccf67a
retry specific metric suggestion check (#116909)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 13:48:12 +01:00
Giorgos Bamparopoulos ab092300f6
Add API tests for dependencies metadata (#116648)
* Add API tests for dependencies metadata

* Rename metadata tests to event metadata

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
2021-11-01 12:40:09 +00:00
Ashokaditya 8fd02151e9
[Security Solution][Endpoint] Add tests for pending status API changes (#115998)
* add tests for pending status api changes

related to elastic/kibana/pull/115441

refs elastic/security-team/issues/1705

* update mock

refs elastic/kibana/pull/116214

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 11:56:07 +01:00
Christos Nasikas 2f55e68d02
[Cases] Do not show deprecated callout on deleted connectors (#116615)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-11-01 10:36:53 +02:00
Thomas Watson 8a39a113a0
Finalize removal of legacy audit logger (#116282) 2021-10-30 22:33:37 +01:00
Vadim Yakhin a7fd3deb73
[Workplace Search] Fix early sources logic unmounting (#113023)
* Fix error appearing if user leaves Sources page very quickly

The issue was that the response from /sources endpoint could came after the user has left the page.
Since the user has already left the page, the Sources logic is unmounted,
and any code that was using the response couldn't update the value in that logic file and caused an error.

Fortunately Kea provides a `breakpoint` API exactly for such cases:
https://kea.js.org/docs/guide/additional#breakpoints

This commit uses that API to fix the issue.

* Fix error appearing after leaving Sources page less quickly

This commit solves the same problem, but for the /status endpoint:
1) for the first status call that saves server values to the sources_logic
2) for the subsequent status calls that poll the server for the status updates

* Increase test coverage

The new test duplicates the test below it, but it doesn't set up
initial source statuses. For some reason this case was considered to be covered before,
but after seemingly unrelated changes in this PR, the coverage started to show that this
code branch was missed.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-30 20:48:18 +01:00
Walter Rafelsberger 2cfcb8caf9
[ML] Fix y axis ticks. (#116670)
Fixes the y axis ticks for chart variants where the maximum transaction count for overall buckets is only 1.
2021-10-30 14:51:55 +00:00
Caroline Horn 151968be4f
[Dev Tools] Design fixes for theme v8 (#116236)
* Fixed icon buttons in Console
* Quick cleanup of tabs and panels
2021-10-30 09:34:22 +00:00
Frank Hassanabad eaedb7863d
Follow up (#116860)
## Summary

One line follow up from #116490 from @dhurley14 here: https://github.com/elastic/kibana/pull/116490#discussion_r739314768


### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-10-29 23:39:36 -06:00
Tyler Smalley ea62dd04af
[ci] Temporarily stop writing to Bazel remote cache (#116866)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-10-29 21:06:26 -07:00
Devin W. Hurley 6817a02e0d
[Security Solution] [Platform] Fix critical bug when migrating action within update route (#116512)
* WIP - need to figure out how to delete old siem-detection action SO's after each test

* WIP - adds some fixes for the update rules utility that differ from patch rules utility

* fix type checks

* cleanup

* remove commented out code

* rename const to use capital snake case

* naming integration tests, adds expect for disabled rules that get migrated, adds expect for pre-migrated rules
2021-10-29 22:05:55 -04:00
Frank Hassanabad 57899a2f68
Removes isUuid and tests as they're not used anymore (#116848)
## Summary

Removes isUuid and tests as they're not used anymore

### Checklist

Delete any items that are not applicable to this PR.
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-10-29 19:33:59 -06:00
Spencer 2797fab000
[kbn/optimizer] dll @babel/runtime modules used by entry bundles (#113453)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-10-29 18:08:20 -05:00
Esteban Beltran 107661129d
[Security Solution] Use useEndpointPrivileges instead of checking the license directly (#116142)
* Use useEndpointPrivileges instead of checking the license directly

* Use the correct privilege key

* rename variable

* Skips flaky test

* Remove skip

* Remove extra dependency

* Add back entries check

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-30 00:01:48 +01:00
Frank Hassanabad 347c138bc0
Fixes flake seen on CI by sorting the results (#116846)
## Summary

Sorting fix for flake test. Fixes: https://github.com/elastic/kibana/issues/116691

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-10-29 23:08:13 +01:00
Luke Elmers 1d6b60954b
[saved objects] Strip version qualifier in SO service to fix unknown type deprecations. (#116480) 2021-10-29 22:23:48 +01:00
Esteban Beltran 5afa164ab9
[Security Solution] Fix edit not working due to state management overwrite in Host isolation exceptions (#116676)
* Fix edit not working due to state management overwrite

* clear the form after a succesfull update

* Preserve order after editing and adding
2021-10-29 23:01:14 +02:00
Cauê Marcondes 7130d6eb45
[APM] Api tests for Error distribution api (#116674)
* adding tests for error distribution

* addressing pr changes

* addressing pr comments

* fixing ts issues
2021-10-29 21:57:08 +01:00
Andrea Del Rio f32c334ad2
[Controls] Post integration design cleanup (#116511) 2021-10-29 13:52:39 -07:00
Zacqary Adam Xeper 285cd009a5
Revert "[Metrics UI] Fix OR logic on redundant groupBy detection (#116695)" (#116820)
This reverts commit c0d005db62.
2021-10-29 16:48:15 -04:00
Zacqary Adam Xeper 4712c10f84
Revert "[Logs UI][Metrics UI] Remove deprecated config fields from APIs and SavedObjects (#115874)" (#116819)
This reverts commit 6693ef371f.
2021-10-29 16:47:54 -04:00
Gil Raphaelli a0aee5b714
add the "UI" team label to APM project issues (#116844) 2021-10-29 16:32:36 -04:00
Ece Özalp f65485f997
[SecuritySolution][CTI] Fix preview matrix histogram query (#116328)
* [SecuritySolution][CTI] Fix preview matrix histogram query

* fixes mock

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 16:21:14 -04:00
Frank Hassanabad 023d668e13
[Security Solutions] Adds e2e tests for the legacy notification system (#116531)
## Summary

Adds e2e tests for the legacy notification system for:
* Exporting rules
* Reading rules
* Finding rules

Also adds missing e2e tests for the non-legacy actions where they previously did not have e2e tests.

These tests ensure that the legacy notifications system will run for a while.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-10-29 14:02:52 -06:00
Brian Seeders 19f4b6801f
Revert "add the "UI" team label to APM project issues (#116710)"
This reverts commit dc7410edbe.
2021-10-29 15:57:31 -04:00
Gil Raphaelli dc7410edbe
add the "UI" team label to APM project issues (#116710) 2021-10-29 15:56:32 -04:00
Chris Donaher 478d138c32
Send Endpoint Alert _id field up as insights docs track that on status changes (#116687)
* Send Endpoint Alert _id field up as insights docs track that on status changes

* Added test to make sure top-level underscore-prefixed fields are allowed

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 13:47:31 -06:00
Marshall Main b59b132ff4
Remove validation requiring action id to be UUID (#116524)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 15:26:06 -04:00
Nathan Reese ee61368cff
[Maps] fix data-mapping switch enabled for vector tiles (#116366)
* clean up IField API

* disable switch when using MVTs for es docs

* clean up interface comment style

* implement supportsFieldMetaFromEs and supportsFieldMetaFromLocalData in all Field classes

* fix dynamic_color_property test

* fix jest tests

* mock getRangeFieldMeta instead of passing in VectorLayerMock with MockStyle

* review feedback

* clean up supportsFieldMetaFromLocalData test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 12:47:58 -06:00
Paul Tavares d284d65ad4
[Security Solution][Endpoint] Fix and un-skip Jest UT for Policy Details remove trusted app modal (#116492)
* increase update API response delay
2021-10-29 14:46:30 -04:00
Paul Tavares ea1c3f2a09
Fix skipped test to be more robust in matching relative dates (#116474)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 14:40:35 -04:00
Kristof C 26ca3ffe05
[105264] Fix error not surfacing bug for Jira (#114800)
* [105264] Fix error not surfacing bug for Jira

* [105264] Fix ServiceNow errors not surfacing to UI

* Fix tests with updated functon

* Fix PR errors

Co-authored-by: Kristof-Pierre Cummings <kristofpierre.cummings@elastic.co>
2021-10-29 13:27:41 -05:00
Aleh Zasypkin 91af33b69f
Upgrade cheerio dependency (1.0.0-rc.91.0.0-rc.10). (#116737) 2021-10-29 20:24:49 +02:00
Sandra G 62f807227b
[Stack Monitoring] Logstash Functional Tests (#116481)
* logstash overview functional test

* logstash nodes listing functional tests

* node detail tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 13:55:32 -04:00
Xavier Mouligneau 3f91556e67
[SECURITY] Copy saved object flyout should not allow copying into the active space (#116657)
* copy saved object flyout should not allow copying into the active space

* stupid me
2021-10-29 13:55:17 -04:00
Shahzad 45476dcbe6
[Uptime] Fix filters in query for fetching monitor attached rules (#115921)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 19:50:47 +02:00
Shahzad d4d470d938
Fix intermitting series state (#115747)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 19:50:14 +02:00
Shahzad 9714aac93c
[Exp view] Fix apply button equality check (#115744)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 19:49:30 +02:00
Melissa Alvarez 40fd867b65
[ML] Data Frame Analytics Wizard: ensure includes updated correctly on dependent variable change (#116381)
* ensure included fields not overwritten + reduce unnecessary renders.

* ensure editor validation works

* ensure depVar always in includes

* ensure selected runtimeField depVar option is shown
2021-10-29 13:48:42 -04:00
Shahzad 4492a107bd
[Alerting] Remove unnecessary call on every kibana load (#116572) 2021-10-29 19:48:25 +02:00
Spencer 05cfe434f0
[alerting] disable status reporting for now (#116717)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-10-29 12:48:03 -05:00
Frank Hassanabad 29ac5583b7
[Security Solutions] Critical bug fix to make error messages about missing connections clearer for the end user. (#116490)
## Summary

Fixes issue see on this comment:
https://github.com/elastic/kibana/issues/116336#issuecomment-952159636

* Removes legacy toaster component
* Adds newer toaster component
* Removes issue with the deps array within ReactJS
* Adds utility to give a better network error message to the end user.
* This does effect the timeline component since it shares the same import common component.
* Adds a count of how many rules/timeline items have failed imports
* These error toasters mimic Kibana core's error toaster error message and UI/UX
* Adds e2e tests for imports with actions and error messages for them.

## Rules import error messages now

Before for small toaster:
<img width="417" alt="Screen Shot 2021-10-26 at 6 03 25 PM" src="https://user-images.githubusercontent.com/1151048/139132586-3cf77c73-53ac-4066-b01f-2e91ef2da111.png">

After for small toaster for different error conditions:
<img width="358" alt="Screen Shot 2021-10-26 at 6 00 24 PM" src="https://user-images.githubusercontent.com/1151048/139132679-2eeb1ed3-9f6e-4766-a8ed-8804ce3e6963.png">

<img width="396" alt="Screen Shot 2021-10-26 at 6 01 00 PM" src="https://user-images.githubusercontent.com/1151048/139132742-750cd937-f401-44e8-9a10-c21410073b5d.png">

<img width="379" alt="Screen Shot 2021-10-26 at 6 02 29 PM" src="https://user-images.githubusercontent.com/1151048/139132766-21b58bea-7f46-43a6-a0e9-f01632958eab.png">

Before for when you click "See the full error":
<img width="817" alt="Screen Shot 2021-10-26 at 5 58 47 PM" src="https://user-images.githubusercontent.com/1151048/139132980-de1942d6-7b03-4c08-b34a-1fc4a22d5207.png">

After for when you click "See the full error":
<img width="838" alt="Screen Shot 2021-10-27 at 1 48 16 PM" src="https://user-images.githubusercontent.com/1151048/139136581-af1e331e-ed77-4338-8fb0-c2457acd135f.png">

<img width="802" alt="Screen Shot 2021-10-27 at 1 26 31 PM" src="https://user-images.githubusercontent.com/1151048/139135083-9ca56940-30a8-4f83-9355-312307172834.png">

## timeline

Before:
<img width="441" alt="Screen Shot 2021-10-27 at 1 19 00 PM" src="https://user-images.githubusercontent.com/1151048/139136614-8360d6a6-d182-413e-b5d9-b18e3d70dc24.png">

<img width="827" alt="Screen Shot 2021-10-27 at 1 19 08 PM" src="https://user-images.githubusercontent.com/1151048/139136637-f9203ac2-0eea-4a77-9c53-ac2c20ab32e0.png">

After:
<img width="408" alt="Screen Shot 2021-10-27 at 1 49 45 PM" src="https://user-images.githubusercontent.com/1151048/139136758-7532a8ba-6d73-45e2-adbb-6756ee997289.png">

<img width="820" alt="Screen Shot 2021-10-27 at 1 49 50 PM" src="https://user-images.githubusercontent.com/1151048/139136774-26d4a8a2-caf0-4c6f-94d3-a6cd92b79f5f.png">

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-10-29 11:44:38 -06:00
Nicolas Chaulet d384a2f508
[Fleet] Fix pipeline with id [*] does not exists (#116707) 2021-10-29 13:44:24 -04:00
Frank Hassanabad 83fe1dd90a
Changes log level from info to debug from user complaints about logs filling up (#116518)
## Summary

Changes detections log level from info to debug within the detection engine. Users have been complaining about their log files filling up in excessive size from when they have noisy rules or if they have a large amount of rules enabled.
2021-10-29 11:40:08 -06:00
Nathan Reese 7c73e227eb
[Maps] convert EMS TMS source to typescript (#116508)
* [Maps] convert EMS TMS source to typescript

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 11:33:12 -06:00
Nathan Reese 0a3cd8ebab
[Maps] do not allow label overlap (#116190)
* [Maps] do not allow label overlap

* split symbol labels into seperate layer

* clean up comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 11:31:04 -06:00
Madison Caldwell 6ba984eb03
Add support for actions on kibana.* fields and legacy signal.* fields (#116491)
* Add support for actions on kibana.* fields and legacy signal.* fields

* Improve types and add scheduleNotificationActions test

* Unnecessary cast

* Was accidentally returning all alerts in map, instead of single alert

* Cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 11:29:38 -06:00
Spencer 30872e9063
remove all references to v7 theme (#113570)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 12:28:42 -05:00
Vitalii Dmyterko b481bff349
[Security Solution][Detections] Fix truncated values in columns for rules table (#115825)
* Fix truncated rule name on rules table

* remove empty line

* remove truncateText for all rules table columns

* rename unit tests

* refactor unit tests

* fix ts error

* fix ts error

* remove config line

* fix types after kbn bootstrap

* CR: remove unnecesary tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-10-29 18:28:11 +01:00