Commit graph

32380 commits

Author SHA1 Message Date
Mikhail Shustov f18aea5dce
add platform team definition of done (#59993)
* add platform team definition of done

* add link to ToC

* add suggestions from Josh

* add tooling

* add testing note
2020-04-16 11:53:51 +02:00
Angela Chuang 7b74aa9d69
[SIEM] move away from Joi for importing/exporting timeline (#62125)
* move away from joi

* update schema for filterQuery

* fix types

* update schemas

* remove boom

* remove redundant params

* reuse utils from case

* update schemas for query params and body

* fix types

* update validation schema

* fix unit test

* update description for test cases

* remove import from case

* lifting common libs

* fix dependency

* lifting validation builder function

* add unit test

* fix for code review

* reve comments

* rename common utils

* fix types
2020-04-16 10:17:15 +01:00
Joe Reuter 02cba10469
Fix discover preserve url (#63580) 2020-04-16 09:51:03 +02:00
Gidi Meir Morris bb9f8845ae
[alerting] Adds an alertServices mock and uses it in siem, monitoring and uptime (#63489)
Work on #61313 has revealed that we don't have amock for AlertServices, which creates coupling between us and any solution depending on us, which makes it harder to make changes in our own code.

This PR adds mocks and uses them in SIEM, Monitoring and Uptime, so that we can make future changes without having to change outside solutions.
2020-04-16 08:45:38 +01:00
Oliver Gupte 3ade2d358d
Closes #63109 for Service Map by resetting edges styles for the selected node (#63655) 2020-04-16 00:42:25 -07:00
Uladzislau Lasitsa ee1cebdbe1
MIgrated index_header to react (#63490) 2020-04-16 10:36:09 +03:00
Uladzislau Lasitsa ce9c6e258a
Index pattern management UI -> TypeScript and New Platform Ready (indexed_fields_table) (#63364)
* MIgrated indexed_fields_table to typescript.

* Updated docs

* Fixed comments

* Fixed types
2020-04-16 10:32:28 +03:00
Steph Milovic 31ed266d73
[SIEM] [Cases] Insert timeline and reporters/tags in table bug fixes (#63642) 2020-04-16 00:53:22 -06:00
Tim Sullivan 3d41ca6d27
[Reporting] Make usable default element positions (#63191)
* [Reporting] Make usable default element posistions

* revert unrelated changes

* fix ts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-15 17:00:56 -07:00
Tim Sullivan f4c81b440d
[Reporting] Switch Serverside Config Wrapper to NP (#62500)
* New config

* fix translations json

* add csv.useByteOrderMarkEncoding to schema

* imports cleanup

* restore "get default chromium sandbox disabled" functionality

* integrate getDefaultChromiumSandboxDisabled

* fix tests

* --wip-- [skip ci]

* add more schema tests

* diff prettiness

* trash legacy files that moved to NP

* create_config tests

* Hoist create_config

* better disableSandbox tests

* fix ts

* fix export

* fix bad code

* make comments better

* fix i18n

* comment

* automatically setting... logs

* replace log_configuration

* fix lint

* This is f2

* improve startup log about sandbox info

* update docs with log reference

* revert log removal

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-15 14:52:32 -07:00
Tim Sullivan 23e3f1aab5
[Reporting] Add "warning" status as an alternate type of completed job (#63498)
* [Reporting] Add "warning" as a status

* test

* fix warning status handling

* Simplify logic

* fix syntax

* more different statuses

* fix warning

* feedbacks
2020-04-15 14:05:19 -07:00
Mike Côté 6c670b77f8
Split action types into own page (#63516)
* Split action types into own page

* Update docs/user/alerting/action-types.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Apply changes based on feedback

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2020-04-15 15:54:36 -04:00
Wylie Conlon ac549ac6f5
[Lens] Only show copy on save for previously saved docs (#63535)
* [Lens] Only show copy on save for previously saved docs

* Update app.test.tsx

import after kibana platform changes

Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
2020-04-15 14:57:44 -04:00
Stacey Gammon 716211f2db
Update README.md (#63622) 2020-04-15 14:12:14 -04:00
Anton Dosov c57297c95b
Bugfix clear saved query crashes kibana on Discover in some cases (#63554)
* actual hotfix

* clean up redundant code

* add functional test
2020-04-15 19:55:43 +02:00
Justin Kambic b670851422
Add uptime CODEOWNER entries. (#63616) 2020-04-15 12:48:16 -04:00
Dima Arnautov 7058070e15
[ML] Extract apiDoc params from the schema definitions (#62933)
* [ML] WIP apiDoc schema extractor

* [ML] extract actual type

* [ML] refactor schema definitions

* [ML] Update README.md

* [ML] extract nested

* [ML] call job validation endpoint with complete payload

* [ML] escape special chars and fix line breaks

* [ML] clean up extractDocEntries

* [ML] serializeWithType

* [ML] add missing annotations

* [ML] fix parent schema assigment

* [ML] support object composition

* [ML] support multiple schemas per block

* [ML] fix for collections

* [ML] fix calendarIdsSchema

* [ML] add ml package.json with apidoc commands

* [ML] use the single output markdown file

* [ML] fix typo

* [ML] change the Calendars order

* [ML] adjust the order in adidoc.json

* [ML] update api version

* [ML] update tsconfig.json include

* [ML] update packages/kbn-pm/dist/index.js

* [ML] update ML overrides in .eslintrc.js

* [ML] yarn.lock symlink

* Revert "[ML] yarn.lock symlink"

This reverts commit 07f06801

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-15 18:40:34 +02:00
Mike Côté e44cf28c98
Fix alerting documentation encryption key requirement (#63512)
* Fix documentation to indicate encryption key config required regardless if security is used or not

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2020-04-15 12:19:15 -04:00
Tim Roes 99332b8a6e
Fix CODEOWNERS and sass lint paths (#63552) 2020-04-15 17:52:21 +02:00
Robert Austin 08aa214190
Endpoint: Redux types (#63413)
## Summary

Changes some types around so modifying redux state or actions will cause type errors

* the state and action types aren't using `Immutable` directly. This means that you can instantiate them and mutate them
* the `state` and `action` params received by all reducers will be automatically cast to `Immutable`
* reducers can return either `Immutable` or regular versions of `state`
* some code may be mutating redux state directly, this is being ignored (at least for now)
2020-04-15 11:19:46 -04:00
Mike Côté bb0d03fe11
Fix alerting UI flaky tests (#62817)
* Use of testSubjects.setValue

* Add waitForEditAlertFlyout

* Fix some extra flakiness

* Test half second sleep to confirm cause of flakiness

* Revert 02417961f9

* Try clearWithKeyboard

* Fix test failures

* Fix uptime tests

* Revert uptime changes
2020-04-15 11:16:14 -04:00
Corey Robertson 3a91e713aa
Fixes Keyboard Shortcuts help extension (#63583) 2020-04-15 11:13:28 -04:00
Stacey Gammon d0404487f6
Add embeddable via saved object example (#61692)
* Add embeddable via saved object example

* give todoRefEmbed a different name from the by value one

* fix types

* fix order of unmounting

Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
2020-04-15 11:10:20 -04:00
Rudolf Meijering 00a1144ae2
Refactor Plugins to access elasticsearch from CoreStart (#59915)
* x-pack/watcher: use Elasticsearch from CoreStart

* x-pack/upgrade_assistant: use Elasticsearch from CoreStart

* x-pack/actions: use Elasticsearch from CoreStart

* x-pack/alerting: use Elasticsearch from CoreStart

* x-pack/lens: use Elasticsearch from CoreStart

* expressions: use Elasticsearch from CoreStart

* x-pack/remote_clusters: remove unused Elasticsearch dependency on CoreSetup

* x-pack/oss_telemetry: use Elasticsearch from CoreStart

* Cleanup after #59886

* x-pack/watcher: create custom client only once

* Revert "x-pack/watcher: create custom client only once"

This reverts commit 78fc4d2e93.

* Revert "x-pack/watcher: use Elasticsearch from CoreStart"

This reverts commit b621af9388.

* x-pack/task_manager: use Elasticsearch from CoreStart

* x-pack/event_log: use Elasticsearch from CoreStart

* x-pack/alerting: use Elasticsearch from CoreStart

* x-pack/apm: use Elasticsearch from CoreStart

* x-pack/actions: use Elasticsearch from CoreStart

* PR Feedback

* APM review nits

* Remove unused variable

* Remove unused variable

* x-pack/apm: better typesafety

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-15 17:07:57 +02:00
Daniil Suleiman afb48bceca
[NP] Move visTypeXy plugin (#63449)
* Move vis_type_xy into NP

* Substitute usage in vis_type_vislib

* Disable plugin by default
2020-04-15 18:03:17 +03:00
Brandon Morelli 02bcc8e78b
[APM] docs: restructure APM documentation for 7.7 (#63280) 2020-04-15 07:54:26 -07:00
James Gowdy 6fc4840bae
[ML] Changing file data visualizer max upload setting to string (#63502) 2020-04-15 15:48:04 +01:00
Nicolas Ruflin 3342f9e80e
[Ingest] Add details to indexing strategy around allow chars (#63560)
Add some recommendation around what chars should be used if a dataset or namespace contains a `-`.
2020-04-15 16:44:14 +02:00
Daniil Suleiman 23a5734d07
[NP] TSVB (#63237)
* Move TSVB into new platform

* Get rid of isFunction checks

* Remove extra import of styling constants

* Move styles importing into plugin.ts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-15 17:03:20 +03:00
Oliver Gupte d1d0a44d5d
Closes #63113 by limiting service maps to only draw certain shapes in IE 11 without icons (#63558) 2020-04-15 06:59:47 -07:00
Yuliia Naumenko 6f1fe676f2
Fixed inability to clear numeric field in a "Group over top docs" condition (#63543) 2020-04-15 06:43:17 -07:00
Anton Dosov 3b64a65ed6
[Drilldowns] improve action.getHref() for drilldowns (#63228)
getHref on Action interfaces in uiActions plugin is now async. getHref is now used only to support right click behaviour. execute() takes control on regular click.
2020-04-15 15:41:42 +02:00
Alexander Reelsen 88d3523925
Add processors to devtools console autocomplete (#60553)
This add completion support for the csv, circle, geoip, html strip,
inference, set security user, urldecode and user agent processors to the
dev tools console.
2020-04-15 06:30:26 -07:00
Nicolas Chaulet 423a297f75
[Ingest] Use agent.yml template when creating a datasource stream from a package (#62631) 2020-04-15 09:23:57 -04:00
patrykkopycinski 5deb74e6c4
[SIEM][Detection Engine] Increase UI unit tests coverage (#62230) 2020-04-15 14:34:29 +02:00
Phillip Burch c885ea5379
Because onThreshold is changed even when it hasn't changed add a check (#63555)
* Because onThreshold is changed even when it hasn't changed add a check

* Fix join
2020-04-15 06:43:03 -05:00
Gidi Meir Morris d1134c551e
[Alerting] Handle when an Alerting Task fails due to its Alert object being deleted mid flight (#63093)
Detects if a task run failed due to the task SO being deleted mid flight and if so writes debug logs instead of warnings.

Detects if an Alerting task run failed due to the alert SO being deleted mid flight of the task and if so ensures the task doesn't reschedule itself (as it usually would with other types of tasks).

Ensures that the operation of deleting or disabling an Alert won't fail if it fails to delete an already deleted task (a task might preemptively self delete if its underlying alert object was deleted, even if the overall delete operation wasn't deleted).
2020-04-15 12:34:16 +01:00
Tim Roes ebbc062689
Move Lens frontend to Kibana Platform (#62965)
* Move Lens frontend to Kibana platform

* Fix line breaks

* Fix jest tests

* Fix remaining test

* Remove old Lens plugin entry

* Fix i18n prefix

* Add config schema

* Address review
2020-04-15 12:22:37 +02:00
Thomas Watson cf87efb9d0
Add test:jest_integration npm script (#62938) 2020-04-15 10:20:01 +02:00
Uladzislau Lasitsa 18687a3531
[data.search.aggs] Remove service getters from agg types (AggConfig part) (#62548)
* removed getFieldFormats from aggConfig

* made new properties is private

* Fixed ci

* Fixed tests

* Fixes clone method

* move filedFotmats inside opt fro AggConfigs

* Added readonly

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-15 11:16:36 +03:00
Matthias Wilhelm 8264352bbe
[Discover] Fix broken setting of bucketInterval (#62939)
* Fix broken setting of bucketInterval, remove $watch

* Fix and adapt functional tests
2020-04-15 08:33:10 +02:00
Phillip Burch bf63b56f83
Disable adding conditions when in alert management context. (#63514)
* Disable adding conditions when in alert manament context.

* Fix typo

* Change id for i18n string
2020-04-14 18:32:05 -05:00
Patrick Mueller 7677764c65
[Alerting] fixes to allow pre-configured actions to be executed (#63432)
resolves https://github.com/elastic/kibana/issues/63162

Most of the support for pre-configured actions has already been added
to Kibana, except for one small piece.  The ability for them to be
executed.  This PR adds that support.
2020-04-14 18:20:50 -04:00
Candace Park 0abbb1d9c4
adding useMemo (#63504) 2020-04-14 18:19:31 -04:00
Nathan Reese 5aa93be77d
[Maps] fix double fetch when filter pill is added (#63024)
* [Maps] fix double fetch when filter pill is added

* remove isDataSyncActive

* set dataMetaAtStart to null instead of deleting

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-14 15:41:50 -06:00
Wylie Conlon 7cd746bc2f
[Lens] Fix missing formatting bug in "break down by" (#63288)
* [Lens] Fix missing formatting bug in "break down by"

* Stop showing UUIDs, make logic more explicit

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-14 17:20:18 -04:00
Steph Milovic f9e8c1bfff
[SIEM] [Cases] Removed double pasted line (#63507) 2020-04-14 14:11:50 -06:00
Tim Sullivan 29aba88a00
[Reporting] Improve functional test steps (#63259)
* Start of refactoring

* remove unused fixtuers

* fix the refactoring bugs

* update archive with better dashboard

* important comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-14 12:55:49 -07:00
Christos Nasikas 287d477f21
[SIEM][CASE] Tests for server's configuration API (#63099)
* Test utils

* Test get_configure

* Test post_configure

* Test get_connectors

* Test patch_configure

* Improve test

* Fixes

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-14 22:09:03 +03:00
Steph Milovic d275d7f4df
[SIEM] [Cases] Case container unit tests (#63376) 2020-04-14 12:25:54 -06:00