Commit graph

23530 commits

Author SHA1 Message Date
Mike Côté
fcd60ca0d9
Ensure migrations run on saved object import (#34793)
* Ensure migrations run on saved object import

* Fix broken tests

* Fix ESLint errors
2019-04-09 15:18:49 -04:00
Pete Harverson
d259e1f258
[ML] Fixes Single Metric Viewer anomaly markers for long chart aggregation (#34791) 2019-04-09 17:04:42 +01:00
Mike Côté
962722ae8a
Convert saved objects UI to use new import / export API (#33513)
* Initial work converting UI to use new server side APIs

* Remove missed file

* Fix jest tests

* Code cleanup pt1

* Fix file casing

* Fix jest tests

* Modify UI to support including nested references

* Fix button layout

* Connect includeReferencesDeep, remove references_missing_references logic

* Fix broken tests

* Cleanup

* Display success notifications and auto close modals on export

* More code cleanup

* Log to server when user imports using legacy .json file

* Final cleanup

* Update test snapshots to match updated text

* Apply PR feedback pt1

* Remove isLoading and wasImportSuccessful state variables, use single status variable instead

* Move business logic out of flyout component

* Apply PR feedback

* Update wordings
2019-04-09 12:02:54 -04:00
Josh Dover
5e32992a54
[UA] Show different interstital text when cluster is upgraded (#34762) 2019-04-09 09:54:17 -05:00
Artyom Gospodarsky
6a72bcb1d9
Update a snaphot (#34787) 2019-04-09 16:41:51 +03:00
Kerry Gallagher
a5fb494d84
[InfraUI] Use EuiSuperDatePicker on the Metrics page (#34427)
* Remove custom date picker for Metrics page, replace with EuiSuperDatePicker. Remove redux-observable for metrics-time state, replace with hooks.

Pass through refreshInterval and set it as part of the startMetricsAutoReload action

Refactor metric time controls to use EuiSuperDatePicker

Remove redux / redux-observable usage for MetricsTime, replace with hooks

Add useInterval hook and hook up to auto reloading

Add refresh interval support to the URL

Use more concise syntax

Add small styling

Add tests for metric_time

Add extra test

Add correct typings

Update time range immediately when auto reload is turned on (so we don't wait for the first interval to elapse)

Use stricter typing

Remove custom date range picker

Amend translations after removing custom date range picker

* Amend test for CI sensitivity

* Amend test assertions

* DRY up with useCallback
2019-04-09 12:49:04 +01:00
Sébastien Loix
3bc39bdf77
[CCR] Client tests auto-follow pattern & follower index forms (#34449) 2019-04-09 11:43:04 +02:00
Alexey Antonov
be8ea4a722
[TSVB] [Performance]request for api/metrics/fields triggered after all UI changes (#34436)
* [TSVB] [Performance]request for api/metrics/fields triggered after all UI changes

Fix: #34433

* [TSVB] [Performance]request for api/metrics/fields triggered after all UI changes - prevent reRender in case of no changes

Fix: #34433

* should update data on switching tabs

* fix PR comments
2019-04-09 12:34:35 +03:00
Alexey Antonov
9bde4e4830
Timeseries Visual Builder - DST shift in historic data (#34283)
* Timeseries Visual Builder - DST shift in historic data

* Timeseries Visual Builder - DST shift in historic data - performance optimization
2019-04-09 12:30:50 +03:00
Artyom Gospodarsky
11e9d88ba9
[TSVB] Add Include and Exclude fields to the Terms group (#34153)
* Add Include and Exclude fields to the Terms group

* Change *clude to *cludeLabel

* Add the include and exclude parametrs to the server side

* Remove an unnecessary prop

* Use destructring

* Change back a variable

* Destruct lodash

* Fix input filling

* Add type checking to inputs

* Add constants to field types

* Make a snapshot of the SplitByTermsUI component

* Move constants to common
2019-04-09 12:12:05 +03:00
Søren Louv-Jansen
0eff2e15f5
[APM] Set minimum bucket size to connect dots in metric chart (#34473) 2019-04-09 09:33:58 +02:00
Robert Monfera
47e97532ed
[Canvas] Fix: wait for DOM element to exist (#34475)
* Fix: wait for DOM element to exist

* Fix: add the missing retry in the other branch too

* Fix: clear timeout

* Perf: avoid an extra async step

* Chore: remove unused static props and explicitly initialize them via the constructor
2019-04-09 00:35:38 +02:00
Christiane (Tina) Heiligers
95f93e5f81
Enables optional use of the timezone set in Advanced Settings in queries (#34602)
* Adds time_zone to query

* Adds dateFormatTZ to kuery query

Removes comments

* Adds defaults for the dateFormatTZ to the function signatures

* Adds tests for date match in kuery

Modifies test

* Adds a test for get_es_query_config

* Adds test for get timezone from settings utility method

* Adds tests for modified range method

Adds config param test to node_types/functions

code clean up

* resolves initial PR comments

* Refactors build_es_query test

* Refactors get_time_zone_from_settings test

* Uses spys to test that the config is passed down to children in ast toElasticsearchQuery

* removes default config nulls

* Deletes sinon.spy tests in kuery

* removes moment.setDefault from __tests__/get_timezone_from_settings.js
2019-04-08 14:18:09 -07:00
igoristic
50fab1aea3
Swapped kui base class with eui equivalent (#34644)
* Swapped kui base class with eui equivalent

* Added the react component instead
2019-04-08 16:51:44 -04:00
Jason Rhodes
cd532cd8f7
Rework link components to be separated by destination (#34630)
* Creates new LocationContext and useLocation hook

* Re-structures Discover links

* Re-structures ML job link, cleans up discover link changes

* Removes unused components and props

* Adds separated APM and Kibana link components

* Adds InfraLink component

* Adds integration link tests for new link components

* Moves unshared getSearchWithCurrentTimeRange into APMLink component where it is used

* Moves persistent APM params out of the generic url helpers util

* Refactoring rison more

* Clarifies interface names for rison

* Removes risonStringify helper

* Changes link components to inline function exports with manually created component type

* Consolidate APM href generation in one place

* Re-ordered imports for linting

* Updates breadcrumb snapshots now that they include default values
2019-04-08 15:47:16 -04:00
Rudolf Meijering
7a8301e43b
[new-platform] Core API Review process documentation (#34735)
* Core API Review process documentation

* Add links to public/server api docs and migration guide
2019-04-08 21:14:15 +02:00
Jason Rhodes
c9f65adb1b
Add "Show trace logs" action (#34310)
* Adds trace logs link to action menu

* Updates tests

* Fixes time range values for action menu links

* Relaxes type checking on query param object to allow for outgoing links

* Revert unnecessary rison changes after realizing infra links do not accept rison
2019-04-08 14:24:07 -04:00
Ryan Keairns
f7e66eaf6e
[Canvas] Copy edits from docs review (#34666)
* Copy edits from docs review

* couple more edits

* edits
2019-04-08 12:58:06 -05:00
CJ Cenizal
b0542141c0
Update Delete Remote Cluster API to support multiple comma-delimited clusters. (#34595)
* Handle a 500 error. Add error message to toast notifications.
2019-04-08 10:41:08 -07:00
Thomas Neirynck
f611a1fc5e
[Maps] Clear data load error when layer gets correct data (#34484) 2019-04-08 13:37:24 -04:00
Thomas Neirynck
ae977f8636
[Maps] Add filter actions to tooltips (#33635) 2019-04-08 13:03:56 -04:00
Dmitry Lemeshko
f39339d9d3
Functional tests: improve waiting in combobox service (#34707)
* [services/lib/web_element_wrapper] set custom wait for findAll

* [services/remote] print browser name and version on init

* [services/combo_box] fix return statement

* fix lint error
2019-04-08 18:48:55 +02:00
Shaunak Kashyap
3455cf8519
Docs: Simplifying setup by using module configuration variant syntax (#34599)
Now that https://github.com/elastic/beats/pull/9118 is merged, starting 7.1 users will be able configure Metricbeat for monitoring Kibana instances using a simpler syntax.

Previously, users would have to run `metricbeat modules enable kibana` to enable the `kibana` Metricbeat module, then configure the module for Stack Monitoring by manually editing `modules.d/kibana.yml`. Going forward, users will be able to achieve the same effect by running `metricbeat modules enable kibana-xpack`.

This PR updates the docs with this change.

Related: https://github.com/elastic/elasticsearch/pull/40879
2019-04-08 09:04:57 -07:00
James Gowdy
aa78584adc
[ML] Fix file data visualizer index pattern match (#34721)
* [ML] Fix file data visualizer index pattern match

* also global replace . and +
2019-04-08 16:57:06 +01:00
Felix Stürmer
576283cca9
[Infra + Logs UI] Reactively consume the ui settings (#34615)
Previously, the `theme:darkMode` and `dateFormat` settings were only read once, which made them susceptible to race conditions during initialization. This introduces and uses a new `useKibanaUiSetting` hook to reactively consume the settings.
2019-04-08 15:28:27 +02:00
Rudolf Meijering
2e13faf8af
Overlay core service (#34261)
* Move ui/flyout to overlay core service

* Remove onClose in parameter (use FlyoutSession instead)

* Fix tests

* Remove old inspector tests

* Proper TODO message

* Convert flyout service to class

* Use correct i18n

* Resolving weird merge conflicts

* Fix panel plugin test

* Change new platform access

* Add more tests

* Remove commented tests

* Revert test fix (core is actually not fixed yet)

* Fix tests

* Expose onClose as Observable

* Use jest.doMock

* Fix typos

* Core start() -> setup()

* Remove @extends EventEmitter docs

* Refactor and test flyoutservice

* Fix comments: promise -> observable

* Fix tests

* Explicitly define OverlaySetup

* Fix OverlaySetup type signature

* Update Core API review file and docs

* Remove redudant if case

* Change FlyoutRef.onClose into a promise

* Remove redundante cleanup

* Use promise.finally

* Remove targetDomElement from openFlyout()

There's no need to support multiple targetDomElements per FlyoutService
and the current implementation handled this use case incorrectly.

Instead of adding complexity to try to support it, remove this from the
function signature.

* Fix + test to ensure child components are unmounted when a new flyover is displayed

* Wrap flyover in i18n Context component

* TSlint -> ESlint + test improvements
2019-04-08 15:17:59 +02:00
Tiago Costa
e44ad7b358
Generate dockerfiles target to be used for elastic/dockerfiles (#32169)
* feat(NA): generate bundles with dockerfiles as targets.

* chore(NA): change dockerfiles suffix to docker-build-context.
2019-04-08 12:09:51 +01:00
Pete Harverson
659e4712eb
[ML] Limits maximum annotation text length to 1000 characters (#34540)
* [ML] Limits maximum annotation text length to 1000 characters

* [ML] Fix initialization of annotation errors array

* [ML] Fix typo in annotation flyout comment
2019-04-08 11:54:42 +01:00
Alexey Antonov
7514fb804b
[TSVB] Aggregation by 'Static value' is not working properly (#34624)
Fix:  #34620
2019-04-08 13:13:56 +03:00
Daniil Suleiman
d0935ff662
[Vis: Default editor] EUIficate drop partials control (#34358)
* EUIficate drop partials control

* Set right value to a comp before rendering

* Wrap the switch in tooltip

* Exclude legacy styles for eui prefix

* Add a spacer
2019-04-08 12:54:35 +03:00
Peter Pisljar
7693f18f50
updating markdownvis interpreter func arguments (#34534) 2019-04-08 11:15:02 +02:00
Marius Dragomir
bd5e81bafc
Using proper link for Plugin Generator (#34627)
Updated so that we don't link to a generator that was deprecated that links to another generator that was also deprecated.
2019-04-07 21:18:53 +03:00
Liza Katz
4dd7f1788d
New platform move doc table and doc viewer to kibana\discover (#34231)
* Moved doc table to kibana/discover

* moved doc viewer to Kibana app (used by docs and discover)

* Moved
- saved object finder
- paginated selectable list
from partiasls to directives/partials

* Moved paginate controls directive to directives/partials
2019-04-07 14:13:04 +03:00
Peter
7ff4134c6d
fix formatting typo (#34661) 2019-04-05 17:14:23 -04:00
Court Ewing
a08535a7ce
New platform migration guide (#31147)
This initial guide is focused on migrating plugins within the Kibana repo.
Once more of the details are fleshed out in concrete terms, we can
re-purpose it to be published for external developers as well.
2019-04-05 16:26:56 -04:00
CJ Cenizal
48b2478a67
Fix wrapping of Remote Cluster connection status in table. (#34642) 2019-04-05 11:38:42 -07:00
Lisa Cawley
a0f8107b90
[DOCS] Updates data recognizer screenshots for ECS (#34596) 2019-04-05 11:29:48 -07:00
Tiago Costa
3d354a83a2
chore(NA): fix lint rule for canvsas. (#34650) 2019-04-05 18:57:48 +01:00
Oliver Gupte
dda54e4948
[APM] Fixes #33443 by guarding for undefined request types in URL (#33828) 2019-04-05 10:26:12 -07:00
Tiago Costa
ed795d28ee
Migrate from tslint (#33826)
* chore(NA): remove tslint dependencies, configs and enable eslint typescript parser.

* fix(NA): apply recommend eslint typescript rule.s

* chore(NA): upgrade eslint package versions.

* chore(NA): split javascript eslint config in an override section.

* chore(NA): split all eslint configs with overrides.

* chore(NA): remove missing console.log.

* chore(NA): change eslint splits and overrides order.

* chore(NA): replace tslint disable comments with eslint ones.

* chore(NA): solve eslint typescript errors for elastic/kibana-custom/no-default-export

* chore(NA): fixed multiple eslint typescript rule failures.

* chore(NA): add tarfet folder to the eslint ignore.

* chore(NA): apply prettier rule to ts type file.

* chore(NA): remove last mentions to tslint

* chore(NA): add old defined rules

* chore(NA): missing port rules website

* chore(na): ordered rules

* chore(NA): solved eslint typescript problems.

* chore(NA): fix spaced comment problems.

* chore(NA): fix some more eslint typescript rules: import/order no-empty-interface

* chore(NA): fix last rules and comment out what are the ones still failing.

* chore(NA): comment out camelcase rule.

* chore(NA): regenerate kbn pm dist.

* chore(NA): updated snapshots.

* chore(NA): updated snapshots.

* chore(NA): disabled sort-keys rule.

* chore(NA): remove rule prefer-arrow/prefer-arrow-functions.

* chore(NA): fix for @typescript-eslint/no-var-requires rule.

* chore(NA): fixes for @typescript-eslint/camelcase rule.

* chore(NA): fix typo on eslint config kibana typescript.

Co-Authored-By: mistic <tiagoffcc@hotmail.com>

* chore(NA): remove legacy note after the intellij upgrade to 2019.1

* fix(NA): import order plugin.

* chore(NA): fix ts ignore positions after auto fix.

* fix(NA): performance issue with typescript eslint.

* refact(NA): eslint configs organization.

* chore(NA): apply resticted paths to ts files too.

* chore(NA): split comment from eslint ignore.
2019-04-05 17:45:23 +01:00
Pete Harverson
e222fa64e0
[ML] Only update forecasting progress bar if value increases (#34614) 2019-04-05 17:01:16 +01:00
Pete Harverson
bbfe50f39b
[ML] Replace View Forecast button image with Single Metric icon (#34563)
* [ML] Replace View Forecast button image with Single Metric icon

* [ML] Remove table scss overrides and use icon in Explorer view
2019-04-05 16:57:23 +01:00
gchaps
b3f7435ad2
[DOCS] Fixes formatting in plugin and l10 docs (#34594) 2019-04-05 07:01:16 -07:00
Clint Andrew Hall
b55a2063e3
[canvas] Type Renderers; Add DropdownFilter examples (#31299)
## Summary

This PR adds types to Renderers and the DropdownFilter.  It also adds snapshots and stories for DropdownFilter.  This change also includes better `recompose` typings.

<img width="1439" alt="screen shot 2019-01-24 at 5 53 57 am" src="https://user-images.githubusercontent.com/297604/51674396-80efbe00-1f9e-11e9-9ad9-d63b1ec51dbd.png">

## Bugs Found and Resolved

- `AdvancedFilter` renderer never successfully passed a selected `filter` value.
- `DropdownFilter` CSS did not constrain the dropdown arrow.  Without a `relative` positioned parent, the arrow would end up in the top-right of the screen.
- `DropdownFilter` had several [shadowed variables](https://palantir.github.io/tslint/rules/no-shadowed-variable/).
- `DropdownFilter` logic has several improvements, including creation of options and order of inclusion
2019-04-05 08:39:09 -05:00
Aleh Zasypkin
bdb289e3b7
Clear session if it belongs to the authentication provider that is not configured. (#34612) 2019-04-05 15:14:29 +02:00
Matthias Wilhelm
eceeb9fb35
Use enter to submit save modals (#34417)
Now you can use the Enter key to submit the form used e.g. when saving a new dashboard
Good for a11y + a time saver

Adds Form element, migration of Button onClick to Form's onSubmit 
Adds functional test for Enter key submission

Fix #30831
2019-04-05 10:47:30 +02:00
Oliver Gupte
05b842c471
[APM] Addresses #33572 by adding support for new agent 'dotnet' in apm (#34077)
telemetry & documentation links
2019-04-04 22:35:08 -07:00
Nathan Reese
7f7b37aaf9
[Maps] replace jquery_ui_sortable with EUI Drag And Drop (#34553)
* [Maps] replace jquery_ui_sortable with EUI Drag And Drop

* minor clean up

* fix drag and drop skipping

* add jest snapshot test for LayerTOC

* extract EuiDraggable list to js variable

* more unique droppableId

* update jest snapshot
2019-04-04 18:36:05 -06:00
Nathan Reese
23bdee0956
[Maps] automatically disable filter by bounds for indexes with small doc counts (#34456)
* [Maps] automatically disable filter by bounds for indexes with small doc counts

* text updates

* review feedback

* minor text update
2019-04-04 18:34:37 -06:00
Matt Bargar
c4aedfc5ba
Fix stale state in filter field ComboBox (#34494)
The FilterEditor component was not updating derived state when the filter prop changed. This issue was exposed by a race condition in the dashboard app. When there are no panels with an index pattern the dashboard will fetch the default index pattern and pass it into the FilterBar. As a result, if a user managed to click the "Add Filter" button before the default index pattern finished loading the editor would first render with a filter containing no index pattern, which would cause the Field ComboBox to render in a disabled state. The FilterEditor props would update after the default index pattern finished loading, but state variables such as selectedIndexPattern would remain unchanged.

The root issue is that the source of truth about which index pattern should be used is stored in both the filter prop and the selectedIndexPattern state variable. To fix this I added a key prop to the FilterEditor that will be unique to each filter so that the component will be recreated on each filter change, while the draft state can remain fully uncontrolled in the FilterEditor component.
2019-04-04 19:46:31 -04:00