maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix type of id in focusPane action in setttings schema (#11395)

Browse source 
## Summary of the Pull Request

The type of the `"id"` argument of the `focusPane` action under `"actions"` in the `settings.json` schema was incorrectly set to a string.
It's actually expecting a non-negative number, and defaults to 0.
So I fixed the schema.

## PR Checklist
* [x] Closes #11393
* [x] CLA signed
* [ ] Tests added/passed
* [ ] Documentation updated
* [x] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

## Detailed Description of the Pull Request / Additional comments



## Validation Steps Performed

I've validated that a string makes Windows Terminal complain it's a string and not a number, and that a number works as expected, and that the default is indeed zero.
This commit is contained in:
NotWearingPants 2021-10-04 15:38:33 +03:00 committed by GitHub
parent e5293b7814
commit 99b1190734
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
doc/cascadia/profiles.schema.json
View file

@ -1184,8 +1184,9 @@
"pattern": "focusPane" "pattern": "focusPane"
}, },
"id": { "id": {
"type": "string", "type": "integer",
"default": "", "minimum": 0,
"default": 0,
"description": "The ID of the pane to focus" "description": "The ID of the pane to focus"
} }
} }
@ -1229,7 +1230,7 @@
"description": "When provided, summon the window whose name or ID matches the given name value. If no such window exists, then create a new window with that name." "description": "When provided, summon the window whose name or ID matches the given name value. If no such window exists, then create a new window with that name."
}, },
"dropdownDuration": { "dropdownDuration": {
"type": "number", "type": "integer",
"minimum": 0, "minimum": 0,
"default": 0, "default": 0,
"description": "When provided with a positive number, \"slide\" the window in from the top of the screen using an animation that lasts dropdownDuration milliseconds." "description": "When provided with a positive number, \"slide\" the window in from the top of the screen using an animation that lasts dropdownDuration milliseconds."