maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

figure this out

Browse source
This commit is contained in:
Mike Griese 2021-11-16 06:35:31 -06:00
parent b421ee6ca0
commit d675fd824a
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/cascadia/TerminalControl/ControlCore.cpp
View file

@ -1715,14 +1715,14 @@ namespace winrt::Microsoft::Terminal::Control::implementation
bool ControlCore::_isBackgroundTransparent() bool ControlCore::_isBackgroundTransparent()
{ {
// TODO! I had: // If we're:
return Opacity() < 1.0f || UseAcrylic(); // * Not fully opaque
// * On an acrylic background (of any opacity)
// But the Atlas Renderer PR changed this to: // * rendering on top of an image
// //
// const auto backgroundIsOpaque = _settings.Opacity() == 1.0 && _settings.BackgroundImage().empty();\ // then the renderer should not render "default background" text with a
// // fully opaque background. Doing that would cover up our nice
// Only one of these is right, right? // transparency, or our acrylic, or our image.
// The background image thing might be a return Opacity() < 1.0f || UseAcrylic() || !_settings->BackgroundImage().empty();
} }
} }