maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
terminal/src
History
Mike Griese c58033cda2
Don't crash when restore-down'ing the alt buffer (#2666) 
## Summary of the Pull Request

When a user had "Disable Scroll Forward" enabled and switched to the alt buffer and maximized the console, then restored down, we'd crash. Now we don't.

## References

## PR Checklist
* [x] Closes #1206 
* [x] I work here
* [x] Tests added/passed

## Detailed Description of the Pull Request / Additional comments

The problem is that we'd previously try to "anchor" the viewport to the virtual bottom when resizing like this. This would also cause us to move the top of the viewport down, into the buffer. However, if the alt buffer is getting smaller, we don't want to do this - if we anchor to the old _virtualBottom, the bottom of the viewport will actually be outside the current buffer.

This could theoretically happen with the main buffer too, but it's much easier to repro with the alt buffer.
2019-09-05 15:37:27 -05:00
..
buffer Add support for HTML copy (#1224) 2019-08-19 22:59:01 +00:00
cascadia warnings as errors for cppwinrt projects, then fix the warnings (#2660) 2019-09-04 16:43:45 -07:00
host Don't crash when restore-down'ing the alt buffer (#2666) 2019-09-05 15:37:27 -05:00
inc Changed default padding to 8,8,8,8 and default font size to 11 (#2378) 2019-08-29 09:47:01 -07:00
interactivity Accessibility: Refactor Providers (#2414) 2019-08-20 16:32:44 -07:00
internal add clang-format conf to the project, format the c++ code (#1141) 2019-06-11 13:27:09 -07:00
propsheet inbox: reflect incoming changes from Windows (#1359) 2019-06-20 17:51:04 -07:00
propslib inbox: reflect changes from 20h1 branch (#2310) 2019-08-07 10:58:53 -07:00
renderer dx: Render all gridlines (and, bonus: the box cursor) properly (#2491) 2019-08-20 16:14:26 -07:00
server A better fix for #tab-titles-are-too-long (#2373) 2019-08-14 16:16:38 -07:00
terminal Make the RIS command clear the display and scrollback correctly (#2367) 2019-08-27 18:45:38 -07:00
testlist inbox: Merge accumulated build fixes from RS_ONECORE_DEP_ACIOSS (#1002) 2019-05-24 12:28:30 -07:00
tools Fix typo (#2538) 2019-08-29 09:41:10 -07:00
tsf Reflect inbox changes in 8c63dff 2019-09-03 13:32:31 -07:00
types Add support for short hex color codes like #CCC (#2658) 2019-09-04 11:45:35 -07:00
winconpty Open-source the PseudoConsole family of functions in a new DLL (#2611) 2019-09-04 12:03:44 -07:00
common.build.dll.props Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
common.build.exe.or.dll.props Switch to v5 UUIDs as profile GUIDs for the default profiles (#913) 2019-05-21 13:29:16 -07:00
common.build.exe.props Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
common.build.lib.props Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
common.build.post.props Attempt to clean up PCHs as we build to leave more Hosted Agent disk space (#2271) 2019-08-06 06:51:50 -05:00
common.build.pre.props Set utf-8 for the entire project (#1929) 2019-07-11 13:13:10 -07:00
common.build.tests.props Refactor TerminalApp and Add Tests for Xaml Content (#1164) 2019-07-15 14:27:56 -05:00
ConsolePerf.regions.xml Tab to spaces (#578) 2019-05-13 18:06:36 -07:00
ConsolePerf.wprp Tab to spaces (#578) 2019-05-13 18:06:36 -07:00
cppwinrt.build.post.props Update a number of our dependencies (#2301) 2019-08-07 16:43:49 -07:00
cppwinrt.build.pre.props warnings as errors for cppwinrt projects, then fix the warnings (#2660) 2019-09-04 16:43:45 -07:00
dirs Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
project.inc inbox: merge refactoring payload from FI 2019-06-11 17:01:26 -07:00
project.unittest.inc inbox: merge refactoring payload from FI 2019-06-11 17:01:26 -07:00
StaticAnalysis.ruleset add audit mode to ci (#948) 2019-05-24 14:48:10 -07:00
unit.tests.x64.runsettings Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
unit.tests.x86.runsettings Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
wap-common.build.post.props Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00
wap-common.build.pre.props Initial release of the Windows Terminal source code 2019-05-02 15:29:04 -07:00