Johannes Rieken
6117524374
make NotebookCellData and NotebookData classes, rename NotebookCellData#cellKind to NotebookCellData#kind
2021-03-05 15:17:55 +01:00
Johannes Rieken
86df444212
remove todos
2021-03-05 15:17:55 +01:00
Sandeep Somavarapu
3a21f7815c
Merge pull request #118125 from microsoft/sandy081/keybindingsEditor/adoptTable
...
Adopt to use new table widget
2021-03-05 15:09:55 +01:00
Sandeep Somavarapu
57aaafc72f
Do not check for settings sync enablement while initializing in web
2021-03-05 15:09:39 +01:00
Sandeep Somavarapu
d4b5298cd6
-add bg color to even child
...
- clean up
2021-03-05 14:53:04 +01:00
Johannes Rieken
997c9f2930
add showNotebookDocument overload or uri
2021-03-05 14:50:47 +01:00
Benjamin Pasero
ae2f3e07e1
streams - add test for using error as data
2021-03-05 14:47:20 +01:00
Benjamin Pasero
be70750f86
comment 💄
2021-03-05 14:38:37 +01:00
Benjamin Pasero
b65719bfa2
streams - require explicit end() after error() and remove error support from end()
2021-03-05 14:32:08 +01:00
Johannes Rieken
188e6aac85
stop the code bunny, reuse the createAndFillInContextMenuActions-util, fyi @sandy081 @rebornix
2021-03-05 14:28:43 +01:00
Johannes Rieken
7386525c68
remove one more occurence of '1_run'
2021-03-05 14:04:51 +01:00
Sandeep Somavarapu
bc62648b05
Revert "Remove authentication provider package.json declaration"
...
This reverts commit 811dc8d45a
.
2021-03-05 14:02:57 +01:00
Martin Aeschlimann
fead22bae4
bump distro
2021-03-05 13:48:28 +01:00
Christof Marti
eed8a79e81
Extract proxy agent support ( #117054 )
2021-03-05 13:35:44 +01:00
João Moreno
79096af475
use CSS for odd styling
2021-03-05 13:30:35 +01:00
isidor
223f4f820f
multi cursor: announce cursor changes
...
fixes #109918
2021-03-05 13:18:05 +01:00
Johannes Rieken
3b05017bb8
more 💄 , more strict typings
2021-03-05 13:09:18 +01:00
Johannes Rieken
1d8493b203
💄 in mainThreadNotebooks, return types, more private, dispoable store, duplication removal, etc
2021-03-05 12:52:35 +01:00
Sandeep Somavarapu
81edf8b91a
Merge pull request #118071 from mtaran-google/main
...
Fix typo in IWorkbenchExtensioManagementService
2021-03-05 12:24:14 +01:00
Johannes Rieken
85c1a17b60
Merge IEditor and INotebookEditor, move editor things into notebook editor service
2021-03-05 12:17:21 +01:00
isidor
fc78583696
fixes #118006
2021-03-05 12:15:23 +01:00
Sandeep Somavarapu
39c1d68086
#62531 clean up
2021-03-05 11:25:19 +01:00
Johannes Rieken
2dfc39c694
Remove arrays#mergeSort because by now browsers support the refined sort spec which mandates sort
to be stable.
...
See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
@sandy081 @mjbvz @joaomoreno @aeschli I have made the adoption in your areas. Note that `mergeSort` did NOT operate "in place" whereas `sort` does so please do a quick double check for this (tho my confidence is high)
2021-03-05 11:08:46 +01:00
Johannes Rieken
587274078c
remove NotebookDocumentMetadata#displayOrder, https://github.com/microsoft/vscode/issues/117684
2021-03-05 10:33:58 +01:00
Johannes Rieken
3e8b0eb2d4
remove displayOrder from NotebookDocumentMetadata API, https://github.com/microsoft/vscode/issues/117684
2021-03-05 09:44:04 +01:00
Sandeep Somavarapu
afae25919a
Merge pull request #115351 from gjsjohnmurray/fix-62531
...
fix #62531 add negative text filtering to Problems
2021-03-05 09:42:12 +01:00
Benjamin Pasero
fa37b721d1
💄
2021-03-05 07:51:46 +01:00
Benjamin Pasero
ddb17dc128
💄
2021-03-05 07:50:30 +01:00
Benjamin Pasero
dbbf2b1688
shell env - introduce a service to resolve shell env as promise ( #108804 )
2021-03-05 07:47:53 +01:00
Connor Peet
bd2b229870
debug: update js-debug
2021-03-04 22:03:35 -08:00
Matt Bierner
567b82a0f9
Reduce padding of new markdown cells in notebook
...
#117493
2021-03-04 20:07:15 -08:00
Matt Bierner
38ac13bc83
Slightly reposition the folding indicator for cells
...
For #117493
2021-03-04 20:07:15 -08:00
Matt Bierner
99f2b830a1
Improve drag and drop indicators for custom markdown cells in notebooks
...
Fixes #118002
2021-03-04 20:07:15 -08:00
Matt Bierner
354a0a2620
Disallow dragging the outer markdown cell for rendered markdown cells
...
It seems like we want all drag events to get channeled through the webview in this case
2021-03-04 20:07:15 -08:00
Matt Bierner
a34ed4b0d7
Make markdown cells span full width of editor
...
Previously we left a large gap on the right side
2021-03-04 20:07:15 -08:00
Rob Lourens
60d600b366
Fix showing wrong name for files in search after rename
...
Fix #117778
2021-03-04 19:36:34 -08:00
Matt Bierner
1c7ced625a
Update dimensions of webview element when it is shown again
...
Fixes #117735
2021-03-04 18:54:40 -08:00
Matt Bierner
72995bcb80
Mark property as readonly array
...
Caller should never modify this array directly
2021-03-04 18:42:55 -08:00
Matt Bierner
28b7345808
Improve documentation for WebviewService
2021-03-04 18:42:55 -08:00
Matt Bierner
9fa1800b97
Make the webview icons manager disposable
2021-03-04 18:42:55 -08:00
Matt Bierner
5bff5459d1
Move webview icons from generic webview service to the webview workbench service
...
WebviewIcons are only used for webview panels
2021-03-04 18:42:55 -08:00
Matt Bierner
acdcb64a6c
Throw error if a webview is double registered
2021-03-04 18:42:55 -08:00
Matt Bierner
487296741f
Don't require lazy webview to be passed to WebviewInput
...
The WebviewOverlay is already lazy, so we dont need an extra level of laziness when creating webviews
2021-03-04 18:42:55 -08:00
Matt Bierner
344f329dd4
Make reviveWebview take an options bag instead of parameters
...
It is easy to mess up the order of arguments. Use an options bag to prevent this
2021-03-04 18:42:55 -08:00
SteVen Batten
79ff1ec91b
gate on feature flag
2021-03-04 17:53:46 -08:00
SteVen Batten
aca4cb1298
workspace trust telem
2021-03-04 17:49:44 -08:00
Matt Bierner
0f97504942
Fix output padding/margin for diff notebook editors
...
Fixes #118096
2021-03-04 17:11:05 -08:00
Miguel Solorio
9f395ddb93
Update Codicons 7e0f377891
2021-03-04 14:16:53 -08:00
Matt Bierner
0eca51a2da
Mark selected markdown previews in notebooks ( #117947 )
...
* Mark selected markdown previews in notebooks
Fixes #117706
Our current approach to marking selected cells will not work for webview backed markdown preview cells. This PR makes the webview track the selection state of each markdown cell so that we can properly style the selected cells inside the webview
* Adding supprot for decorations for markdown cells
2021-03-04 14:09:50 -08:00
Miguel Solorio
191d332413
Add offset to button focus ( fixes #117909 )
2021-03-04 14:01:51 -08:00