Commit graph

1210 commits

Author SHA1 Message Date
Christian
55660989e4 Fix dupe bug on TileAssemblyAdvancedWorkbench
Closes #634
2013-02-26 14:24:15 -05:00
kouteiheika
1ec990d0c8 Bulletproof the Box class against accidental world corruption and bugs.
In some rare cases the Box's initialize() may be supplied with
coordinates equal to INT_MAX while theoretically being initialized.
Normally this would be harmless, as with every coordinate being
INT_MAX the resulting box's dimensions are zero, however anywhere
where one of the coordinates is actually used in a loop with a
"i <= coord" condition the loop counter will overflow and bad things
will happen, e.g. in FillerFlattener.iteratePattern, where
I encountered this bug, an array will overflow and take down the
whole game with it resulting in a corrupted world. (As broken INT_MAX
coordinates will get saved in NBT tags.)
2013-02-23 17:07:44 +01:00
SirSengir
c15f011a02 Merge pull request #652 from AartBluestoke/patch-6
Update common/buildcraft/transport/PipeTransportItems.java
2013-02-22 00:19:47 -08:00
Player
86897df6ec (hopefully) fix quarry target search 2013-02-21 22:20:37 +01:00
Andrew Hill
8354db8e21 Update common/buildcraft/transport/PipeTransportItems.java
LogisticsPipes would like to be able to handle reversed items ourselves. (in some cases we want to buffer, and try to eject once the associated machine/inventory has space)
2013-02-21 20:57:13 +10:00
Player
d609f9662f .. for real 2013-02-21 03:55:13 +01:00
Player
d10cd4bc4a fix previous commit 2013-02-21 03:53:01 +01:00
Player
f1a7ebf484 Merge branch 'master' of github.com:BuildCraft/BuildCraft 2013-02-21 00:28:49 +01:00
Player
99c8402df1 use a better algorithm when grouping items in transport pipes 2013-02-21 00:26:59 +01:00
SirSengir
6431318a8d Merge pull request #649 from AartBluestoke/upstreamMaster
another null check needed
2013-02-20 08:11:05 -08:00
Player
7146463b21 Merge branch 'master' of github.com:BuildCraft/BuildCraft 2013-02-20 16:54:30 +01:00
Player
81db6ee4c5 fix transport pipe explosions not destroying the pipe 2013-02-20 16:53:37 +01:00
Andrew Hill
131f2459ed another null check needed
the crafting helper is not used anywhere other than the 3 places that
have null checks. (this was the third location)
2013-02-21 01:50:51 +10:00
SirSengir
36fa2068bf Merge pull request #647 from AartBluestoke/upstreamMaster
correction to the previous commit
2013-02-20 07:27:41 -08:00
Andrew Hill
a48e184ddb correction to the previous commit
please --squash this or the previous ones.
(and i'll try not to write up commits using the web interface, even for
simple things in the future)
2013-02-21 01:04:11 +10:00
SirSengir
041e4afcf6 Merge pull request #646 from AartBluestoke/upstreamMaster
check for null recipe
2013-02-19 23:22:29 -08:00
Andrew Hill
d16e44fb81 check for null recipe 2013-02-20 11:04:35 +10:00
SirSengir
c211af80ee Merge pull request #641 from AartBluestoke/upstreamMaster
cache the IRecipe
2013-02-19 04:53:45 -08:00
Andrew Hill
6d700c4adc move CraftingHelper. 2013-02-19 10:04:30 +10:00
SirSengir
8d5fd2a35b Merge pull request #640 from AartBluestoke/patch-6
math.ceil() is very slow
2013-02-18 07:46:42 -08:00
Andrew Hill
7d23bda09f add a method to get the recipe. 2013-02-18 16:11:01 +10:00
Andrew Hill
1730feed03 cache the IRecipe
act's should not re-search for their recipe, when the last recipe found
is still able to be used.

CraftingHelper.findMatchinRecipe() is identical to
vanilla.CraftingManager.findMatchingRecipe, except it returns the
IRecipe, rather than just the result.
2013-02-18 14:41:00 +10:00
Andrew Hill
2e2e1d8ce8 math.ceil() is very slow
see http://imgur.com/nT62QYQ
math.ceil is almost 100% of the cpu cost of pipePowerWood and transport.pipeTransportPower
(full nps from 
https://www.dropbox.com/s/01ywgc8lnyr2es2/1361111585024.nps?dl=1
several hundred k items extracted from ex-dim barrels, sent to a set of act's, crafted to blocks, and then sent back to barrels.

sendStack->queueRoutedItem() is to do with logistics HUD display, and is being worked on lag-wise also.)
2013-02-18 12:26:25 +10:00
SirSengir
fefd3df7e2 Merge pull request #633 from nallar/master
Improve quarry performance, updated build.xml. Correctly this time.
2013-02-16 14:14:47 -08:00
SirSengir
cf8b533e66 Merge pull request #637 from viper283/master
Override canCommandSenderUseCommand
2013-02-16 14:14:17 -08:00
Ross Allan
814b450719 Improve quarry performance.
Reduce getBlockId calls in canChangeBlock/isSoftBlock to one, add canChangeBlock/isSoftBlock with blockID parameter to allow for only a single getBlockId call per block checked for the visit list.
Use heightmaps when building visit list to increase performance when checking a mostly empty quarry

Signed-off-by: Ross Allan <rallanpcl@gmail.com>
2013-02-15 21:52:10 +00:00
viper283
8eb7af5741 Override canCommandSenderUseCommand
This allows users to use the /Buildcraft command without needing to
enable cheats in the world creation menu
2013-02-15 19:34:24 +00:00
SirSengir
4d790e9229 Typos fixed. 2013-02-14 12:45:40 +01:00
CovertJaguar
28639f46cc Merge pull request #636 from powercrystals/master
Additional transactor fix for getInventoryStackLimit
2013-02-13 23:00:20 -08:00
powercrystals
016ad7082b Update common/buildcraft/core/inventory/TransactorSimple.java
Fix getPartialSlot for inventories with a getInventoryStackLimit less than the item's max stack size
2013-02-13 19:21:59 -05:00
CovertJaguar
8b0312b12a Merge pull request #629 from nallar/patch-1
Update project version in /build.xml
2013-02-12 06:04:57 -08:00
Player
bf22970fba Add better Pipe selection checking, open the gate GUI only if it has been clicked 2013-02-11 18:39:28 +01:00
Ross Allan
8559c1a3e5 Update project version in /build.xml 2013-02-09 20:31:40 +00:00
sfPlayer1
e5c1af707f adv. assembly workbench: Match vanilla getStackInSlot behavior
The vanilla implementation checks for out of bound access and returns null in that case.
This fixes the following incompatibility: http://pastie.org/private/mn2yefhc5yddahbkxgcqw
2013-02-08 14:03:43 +01:00
Krapht
374aa6ebc1 Merge pull request #622 from immibis/master
Fix world-breaking infinite loop in TransactorSimple
2013-02-04 23:21:59 -08:00
immibis
b4d9b73a99 Removed any possibility of TransactorSimple entering an infinite loop when getPartialSlot and addToSlot disagree. 2013-02-05 19:33:04 +13:00
CovertJaguar
78745179ce Marked vines as a soft block 2013-02-01 06:15:28 -08:00
CovertJaguar
47541f7478 Better solution to the last commit
Don't even register the decorator if we aren't going to modify the
world.
2013-01-31 23:10:14 -08:00
CovertJaguar
2dab4b0a8b Added config check to prevent crashes
Fixes part of #618
2013-01-31 23:03:35 -08:00
Christian
ff05f75e12 Buff the autarchic gates - they always pulse at a single, fast rate, about
10% faster than a top speed RS engine. This means they're usefully responsive
in a gate network environment
2013-01-30 20:57:35 -05:00
Krapht
78be7c1b7d Fix potential NPE in RenderTank when liquid no longer exist. Closes #614 2013-01-29 17:28:42 +01:00
SirSengir
65dd923bb0 Merge pull request #611 from viper283/patch-1
Fix /buildcraft not working in singleplayer
2013-01-28 14:56:18 -08:00
viper283
7f4b9b3927 Fix /buildcraft not working in singleplayer 2013-01-28 22:39:16 +00:00
Krapht
06b938d007 Enabled glass facades
Closes #606
2013-01-28 22:02:09 +01:00
Krapht
9d20450f81 Remove redundant loop
Closes #608
Closes #566
2013-01-28 20:01:13 +01:00
CovertJaguar
2bd1e96e11 Fix Tanks filling and added safety check on load 2013-01-28 04:26:04 -08:00
CovertJaguar
1c6cb011c8 Update Forge req 2013-01-27 12:25:56 -08:00
CovertJaguar
91dd6785ae Merge pull request #605 from viliml/patch-10
Added a failure check
2013-01-27 03:31:20 -08:00
viliml
31372ebb53 Added a failure check by https://github.com/nallar 2013-01-27 11:15:44 +01:00
CovertJaguar
573630b601 Fixed last commit cause the PR was lazy 2013-01-26 16:10:37 -08:00