Commit graph

40198 commits

Author SHA1 Message Date
Jordan Borean
7d52c07df2 ansible-test: add Ubuntu 18.04 container (#50790)
* ansible-test: Add Ubuntu 18.04 to Shippable CI nodes

* re-add ubuntu1604/3 to matrix

* forgot to add environment for git kill gpg-agent

(cherry picked from commit 828df4b336)
2019-01-24 12:00:16 -08:00
Sam Doran
44d7c1e23e [stable-2.7] Catch sshpass authentication errors and don't retry multiple times to prevent account lockout (#50776)
* Catch SSH authentication errors and don't retry multiple times to prevent account lock out

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Subclass AnsibleAuthenticationFailure from AnsibleConnectionFailure

Use comparison rather than range() because it's much more efficient.

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Add tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Make paramiko_ssh connection plugin behave the same way

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Add changelog

Signed-off-by: Sam Doran <sdoran@redhat.com>.
(cherry picked from commit 9d4c0dc111)

Co-authored-by: Sam Doran <sdoran@redhat.com>
Signed-off-by: Sam Doran <sdoran@redhat.com>
2019-01-24 10:38:08 -08:00
Dag Wieers
f67081e97b Clarify gather_facts and highlight important lines
Clarify gather_facts and highlight important lines

+label: docsite_pr
2019-01-24 10:37:00 -08:00
Trishna Guha
bb28719541 fix ansible_connect_timeout variable in connection plugins and nxos_install_os timeout check (#51209)
* fix ansible_connect_timeout variable in connection plugins and nxos_install_os timeout check (#50965)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit a1ea7e430a)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-01-24 10:23:01 -08:00
Jordan Borean
44474bf424 file - allow touch on files not owned by user (#50964)
* file - allow touch on files not owned by user

* use Sentinal value and preserved existing args

* Do no instantiate the Sentinel object

(cherry picked from commit 419727a6da)
2019-01-24 10:22:11 -08:00
Nathaniel Case
e828d54675 Redo #50208 on a per-plugin basis 2019-01-24 10:21:43 -08:00
Matt Clay
22448ce99e [stable-2.7] Disable failing azure_rm_postgresqlserver test..
(cherry picked from commit 37767849ee)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-22 22:34:56 -08:00
John Nelson
e44468738f win_chocolatey: Fix hang on missing/required base env vars (#51154)
* win_chocolatey: Fix crash on missing/required base env vars

* Add changelog fragment

(cherry picked from commit 5540d66747)
2019-01-21 18:34:04 -08:00
aaronk1
b2fbd7fd35 [backport/2.7] Update vmware.py minor typo
"supported added" changed to "support added"

(cherry picked from commit 0d97629e4d)
2019-01-21 08:33:32 -08:00
Jacob Olsen
8f2e6abbcf check for chroot in systemd module (#43904)
* check for result['status'] in systemd module

* instead of checking for result['state'], actually check for chroot and warn

* allow systemctl status to work if in a chroot, update warn text

* simply change warning message


(cherry picked from commit 37960ccc87)
2019-01-21 08:32:51 -08:00
Matt Clay
278aa94f1f [stable-2.7] Fix subversion integration test on Fedora 29. (#51089)
* Fix subversion integration test on Fedora 29.

This upgrades the sqlite-libs and subversion packages to make sure
that the version of sqlite expected by subversion is installed.

* Fix compatibility with RHEL and CentOS.
(cherry picked from commit d4dbc7f2e0)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-18 16:24:32 -08:00
Jordan Borean
970669b70e reboot - Fix connection timeout reset (#51000)
* only reset if we could retrieve the conn timeout

(cherry picked from commit 9fa46e7f94)
2019-01-18 13:27:41 -08:00
Brian Coca
4a89749dd5 Prevent duplicate role insertion into roles: (#50552)
* Corner case in which import_role would add another instance of a role with the same signature into roles: when it already existed there.

  roles:
	- name: a
  tasks:
       - import_role: name=a

  would execute role 'a' 3 times instead of the intended 2 (x2 in roles: phase +1 in tasks:)

* added tests

(cherry picked from commit eca7c3c8c7)
2019-01-18 12:58:43 -08:00
Ryan Conway
41214d4426 Merge pull request #50160 from Rylon/backport/2.7/47213
Fix an issue retrieving some types of 1Password items. (#47213)
2019-01-18 12:49:51 -08:00
Brian Coca
016bc83b58 ensure we have required systemd env var (#50607)
* ensure we have required systemd env var
* add clarification about systemd and user scope

  fixes #50272


(cherry picked from commit a7e81ba500)
2019-01-18 12:48:18 -08:00
Yunge Zhu
9c19df3fd2 fix new inventory azure_rm.py (#50006)
* fix new inventory

* fix lint

* resolve comments

* resolve comments

* add defensive code

* fix response not match handler

* remove useless import

* fix lint

* add changelog

(cherry picked from commit 0f846f39ca)
2019-01-18 12:44:17 -08:00
Jordan Borean
8fcdb0a73c ansible-test git: kill gpg-agent to remove locks (#50917)
* ansible-test git: kill gpg-agent to remove locks

* skip gpg-agent kill for OpenSUSE

(cherry picked from commit 3db6b9b416)
2019-01-18 12:42:48 -08:00
feranwq
f2d4187761 archive: Fix check if archive is created in path to be removed (#29420) (#49444)
* archive: Fix check if archive is created in path to be removed (#29420)

(cherry picked from commit 3a45de4209)

* add changelog
2019-01-18 12:41:23 -08:00
Jordan Borean
80b5b33e2b setup_rabbitmq - fix erlang pinned dependencies (#51048)
(cherry picked from commit 18c35b69fb)
2019-01-17 16:57:47 -08:00
Toshio Kuratomi
74050cf69f Update Ansible release version to v2.7.6.post0. 2019-01-17 11:17:09 -08:00
Toshio Kuratomi
1594ccf533 New release v2.7.6 2019-01-17 09:16:01 -08:00
Jordan Borean
49f0ab85d6 ansible-test: fix cloud_init_data_facts for Ubuntu 18.04 (#50916)
(cherry picked from commit 03669cdcdd)
2019-01-14 22:28:20 -08:00
Jordan Borean
e70aa001bf ansible-test: fix dpkg_selections on Ubuntu 18.04 (#50915)
(cherry picked from commit a54eb58156)
2019-01-14 22:28:20 -08:00
Jordan Borean
bca3066a27 ansible-test: add postgresql var file for Ubuntu 18.04 (#50914)
(cherry picked from commit 8c5b2048de)
2019-01-14 22:28:20 -08:00
Jordan Borean
19597c559a ansible-test: rename setup_mysql_db Ubuntu name to work with 18.04 (#50907)
(cherry picked from commit 518699988f)
2019-01-14 22:28:20 -08:00
Jordan Borean
4ca81631b6 ansible-test: apt cleanup and futher 18.04 fixes (#50906)
(cherry picked from commit bbad033a5e)
2019-01-14 22:28:20 -08:00
Jordan Borean
18a3916a76 ansible-test setup_dep_repo trust package repo (#50795)
(cherry picked from commit 2fcc3593cc)
2019-01-14 22:28:20 -08:00
Jordan Borean
7130ffddf6 test subversion - support Ubuntu 18.04 (#50791)
(cherry picked from commit 91522bd9c4)
2019-01-14 22:28:20 -08:00
Felix Fontein
8cc23c0802 [2.7] [docker_container] Failing on non-string env values (#50899)
* [docker_container] Failing on non-string env values (#49843)

* [docker_container] Failing on non-string env values

Fixes #49802

* Clarify failure message

Co-Authored-By: DBendit <David@ibendit.com>

* Fixup from review

(cherry picked from commit d62d7176b0)

* Turn fail into warning for 2.7 backport.

* Fix test for backport

The behaviour in the backport is to warn rather than error
2019-01-14 20:02:24 -08:00
Hannes Ljungberg
2730e43e7b docker_swarm_service: Documentation fixes (#50861)
* Describe labels and container_labels correctly

* Clarify reserve_memory and limit_memory docs

* Remove default from container_labels doc

* Remove trailing whitespace

* Document min api version for configs and secrets

* Add changelog fragment

* Specify type on labels and container_labels

* Consolidate required API version descriptions

* Update reserve and limit memory docs

* Use correct power-of-two units

* Remove description about limit_memory minimum 4mb

(cherry picked from commit 644057e9ec)
2019-01-14 12:44:29 -08:00
Dhanuka
361f34b4fe redfish_utils: fix reference to local variable 'systems_service' (#50298)
* fixes issue 50296

* fixes the indentation of the return statement

* Adds a conditional test into `_find_systems_resource()` to check the existence
of the Members of System resource

* updates the error message

* harden the conditional test

* Add a changelog

(cherry picked from commit 94a1d86d70)
2019-01-14 12:43:49 -08:00
Hannes Ljungberg
40cec0e4f4 docker_swarm_service: Don’t add difference when update_order is None (#50655)
* Don’t add difference when update_order is None

* Add changelog fragment

(cherry picked from commit cde292cc43)
2019-01-14 12:38:31 -08:00
Rich Wareham
776dadc5a3 docker_swarm_service: use exact name match when finding services (#50665)
* docker_swarm_service: use exact name match when finding services

The Docker API's filtering support allows filtering for substring
matches which means that when we filter the list of running services we
may accidentally match a service called "foobar" when looking for a
service named "foo".

Fix this by filtering the list of services returned from the Docker API
so that name matches are exact. It is still worth passing the filter
parameter to the Docker API because it reduces the number of results
passed back which may be important for remote Docker connections.

Closes 50654.

* add changelog fragment for #50654

(cherry picked from commit fd32760d7a)
2019-01-14 12:38:05 -08:00
Felix Fontein
11c1580b23 [2.7] icinga2_host: fix use_proxy option (#50865)
* fix use_proxy option in icinga2_host (#47671)


(cherry picked from commit e7b91f331b)

* Move changelog fragment to changelogs/fragments/.
2019-01-14 12:37:23 -08:00
cahlchang
12ee5c9f6e [Backport #46774] fix ec2_instance check mode 2019-01-14 12:36:54 -08:00
Felix Fontein
c532169697 docker_volume: revert #47390 (#50663)
* Revert "Fix option change detection / force support for docker_volume. (#47390)"

This reverts commit 8ef994fbc5.

* Update changelog.

* Adjusting tests.

(cherry picked from commit 0e7a9a2771)
2019-01-14 12:36:00 -08:00
Abhijeet Kasurde
f201aa8948 [Backport 2.7] VMware: Fix vmware_vm_inventory
* Added documentation around using vmware dynamic inventory plugin
* Fixed bug for populating host_ip in hostvars for given inventory host
* VMware: Add properties in vmware_vm_inventory

Fixes: #50249

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit af914695e6)
2019-01-14 12:35:21 -08:00
Brian Coca
d20040296b added missing docs for option in acl module (#50775)
* added missing docs for option in acl module
* remove acl from ignore

(cherry picked from commit 91d8383898)
2019-01-14 12:34:39 -08:00
Nathaniel Case
41c98d208b Move errors from import to connect (#50034) (#50036)
* Move errors from import to connect (#50034)

(cherry picked from commit bf4ad56479)

* Add changelog fragment.
2019-01-14 12:32:16 -08:00
Matt Clay
ffd1590a63 [stable-2.7] Cleanup integration test inventory. (#50753)
* Move var_blending test inventory into test.
* Remove Amazon specific inventory entry for tests.
* Remove Azure specific inventory entry for tests.
* Move var_precedence test inventory into test.
* Move unicode test inventory into test.
* Remove unused inventory entry.
* Move gathering_facts test inventory into test.
* Move delegate_to test inventory into test.
* Clean up inventory for binary_modules test.
* Clean up integration test inventory..
(cherry picked from commit e5094e8071)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-11 19:46:38 -08:00
Sloane Hertel
63bb122e37 [stable-2.7] Add unstable alias to s3_bucket integration tests (#50508)
(cherry picked from commit d21ed42f4b)

Co-authored-by: Sloane Hertel <shertel@redhat.com>
2019-01-11 16:59:02 -08:00
Matt Clay
c4e0d4d7a5 [stable-2.7] Move unrelated connection test to separate target.
(cherry picked from commit d59bc9ae48)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-11 15:49:49 -08:00
Matt Clay
396edb96c1 [stable-2.7] Fix dpkg_selections integration test.
Download package from S3 since the previous location no longer exists.
(cherry picked from commit fd56788a14)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-11 10:27:30 -08:00
Nathaniel Case
79a281737b [2.7] Log netconf connection a la paramiko (#50169)
(adapted for 2.7 from commit 806b90f)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
2019-01-10 08:38:49 -08:00
Felix Fontein
20eaebd9b2 [2.7] openssl_pkcs12: fix ca_certificates path expansion (#50697)
* Expand user and variables in ca_certificates paths.

This is a fix specific for stable-2.7. In devel (and stable-2.8),
this problem is fixed by #48473. That PR adds argument spec
validation for list elements.

* Add changelog.
2019-01-10 08:37:17 -08:00
trogdor_the_burninator
66720f470a [stable-2.7] Add AIX support to reboot module (#50353)
* Add ability for reboot module to work for AIX

* changelog for AIX reboot support.
(cherry picked from commit 1dac10e5c3)

Co-authored-by: trogdor_the_burninator <gforster@users.noreply.github.com>
Signed-off-by: Sam Doran <sdoran@redhat.com>
2019-01-10 08:35:57 -08:00
Matt Clay
bb94698556 [stable-2.7] Disable retry files for integration tests.
(cherry picked from commit 39824f50b1)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-09 23:43:53 -08:00
Matt Clay
97d07a1504 [stable-2.7] Improve performance of no-tests-as-filters test.
(cherry picked from commit 7995f69a44)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-09 23:27:03 -08:00
Matt Clay
100e4639aa [stable-2.7] Minor cleanup of code-smell tests. (#45658)
* Minor cleanup of code-smell tests.
* Add exception handling for YAML load..
(cherry picked from commit e7426e3795)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-01-09 21:48:12 -08:00
Matt Clay
5fa8d54488 Use relative inventory paths instead of symlinks.
(cherry picked from commit 4915920d71)
2019-01-09 21:00:26 -08:00