Commit graph

2444 commits

Author SHA1 Message Date
Rémi Verschelde
eaaff9da31
Merge pull request #29941 from qarmin/redundant_code_and_others
Remove redundant code, possible NULL pointers and others
2019-06-27 01:05:18 +02:00
qarmin
4e5310cc60 Some code changed with Clang-Tidy 2019-06-26 15:08:25 +02:00
Rémi Verschelde
18b62d5019
Merge pull request #30053 from guilhermefelipecgs/fix_popup_centered
Fix Popup::popup_centered not centralizing at the first call
2019-06-25 17:46:57 +02:00
Guilherme Felipe
54653565a4 Fix Popup::popup_centered not centering at the first call 2019-06-25 12:04:29 -03:00
Rémi Verschelde
93a67dba37
Merge pull request #30002 from GlaceGwyneth/master
Give LineEdit/TextEdit a custom color for font while uneditable
2019-06-25 13:05:27 +02:00
Rémi Verschelde
b966ee49b2
Merge pull request #29979 from flomar/master
Line edit placeholders now react properly to translation changes.
2019-06-25 08:59:31 +02:00
Gwyneth Lowe
45f78d786a Give TextEdit a custom color for font when read only is set
Previously there was some transparency hard coded into TextEdit when in read only mode.
This change adds a custom color for adjusting the font in read only mode.
It also applies when syntax highlighting is on.
2019-06-24 20:00:05 -05:00
Gwyneth Lowe
f07e5ac153 Give LineEdit a custom font color when un-editable
By default the LineEdit's text when editable is unchecked had some transparency hardcoded.
This change adds a custom color to LineEdit for adjusting the font when editable is off.
Addresses issue 29814
2019-06-24 20:00:05 -05:00
Florian Marchal
0f2b25f83e Line edit placeholders now react properly to translation changes. 2019-06-24 23:22:20 +02:00
Rémi Verschelde
6fbd045845
Merge pull request #29913 from eligt/fix-editor-help
Ensure indentation works properly in rich text
2019-06-24 22:59:59 +02:00
Rémi Verschelde
efa4264633
Merge pull request #30009 from Anutrix/tree-icons-height-fix
Fixed script and visibility icons's highlight height in tree
2019-06-24 18:55:44 +02:00
Gwyneth Lowe
7142064110 Correct typo that broke custom selected font color
Change several font_selected_color to font_color_selected; the actual name of the override
2019-06-24 04:55:29 -05:00
unknown
c58b7ab094 Fixed script and visibility icons's highlight height in tree 2019-06-23 22:26:24 +05:30
Dawid Wdowiak
0f14489ecb Center script line when double clicked on error in debugger 2019-06-23 15:58:07 +02:00
qarmin
c77ff48a85 Fix some editor crashes 2019-06-21 11:34:32 +02:00
Rémi Verschelde
5c66771e3e
Merge pull request #29283 from qarmin/fix_some_always_same_values
Remove always true/false values
2019-06-20 21:10:10 +02:00
qarmin
532a7ba06a Fix TextEdit Select 2019-06-20 17:13:16 +02:00
qarmin
072e40368e Fix always true/false values 2019-06-20 16:59:48 +02:00
Elia Sarti
81065d53df Fix for #29810
Ensure indentation works properly in rich text
Fix formatting
2019-06-20 11:42:25 +01:00
Rémi Verschelde
300d4dfd54
Merge pull request #25573 from nekomatata/button-shortcut-fix
Fixed shortcut events in BaseButton (now acts the same as ui_accept action)
2019-06-20 12:06:31 +02:00
PouleyKetchoupp
1e6fa5d1a5 Fixed shortcut events in BaseButton (now acts the same as ui_accept action) 2019-06-20 09:13:23 +02:00
Rémi Verschelde
5a29be31b3
Merge pull request #27188 from samH-FIT/MacroUpdate
Made use of semicolons after GDCLASS more consistent, added semicolons where I found them missing.
2019-06-19 22:59:49 +02:00
Rémi Verschelde
02ed4b392c
Merge pull request #29902 from KoBeWi/dem_setters
Fix set_pick_color error
2019-06-19 20:43:15 +02:00
JohnJLight
38d3bfe971 Made use of semicolons more consitent, fixed formatting 2019-06-19 15:24:31 +02:00
Tomasz Chabora
9bdf110840 Fix set_pick_color error 2019-06-19 14:52:54 +02:00
Rémi Verschelde
d7af08aa95
Merge pull request #27389 from YeldhamDev/acceptdiag_label_wrap
Add option to enable autowrapping for label inside 'AcceptDialog'
2019-06-19 14:46:32 +02:00
Rémi Verschelde
bb0aeb4874
Merge pull request #28659 from KoBeWi/rainbow_mode
Add HSV mode to color picker
2019-06-19 12:41:51 +02:00
Rémi Verschelde
d61d1af64d
Merge pull request #29489 from groud/fixes_nan
Fixes NaN errors with anchors mode
2019-06-18 09:53:25 +02:00
Rémi Verschelde
3b3ba7d179
Merge pull request #29847 from yurchor/master
Fix minor typos
2019-06-17 17:28:55 +02:00
Rémi Verschelde
1d93b4abef
Merge pull request #29633 from jbuck3/optionbutton-selection
Connect OptionButton selection to menu's "index_pressed" signal
2019-06-17 16:56:16 +02:00
Yuri Chornoivan
340c2c0584 Fix minor typos 2019-06-17 15:11:49 +03:00
Rémi Verschelde
2935caa13f
Merge pull request #29838 from KoBeWi/4real
Fix selection undo... for real
2019-06-17 11:07:26 +02:00
Tomasz Chabora
e5cfb9d6b2 Fix selection undo... for real 2019-06-17 03:54:28 +02:00
Michael Alexsander Silva Dias
98d0c99652 Fix Range's "changed" signal emitting with a value even if binded to emit none 2019-06-16 12:00:49 -03:00
Rémi Verschelde
0a3c21d999
Merge pull request #29785 from eligt/fix-richtext-alignment
Fix RichTextLabel alignment tags not working properly
2019-06-15 10:34:22 +02:00
Rémi Verschelde
e999929024
Merge pull request #29787 from Paulb23/fix_negative_cursor_column
Fix TextEdit cursor.column having a negative value
2019-06-15 00:29:07 +02:00
Paulb23
1d55207fd2 Fix TextEdit cursor.column having a negative value 2019-06-14 21:48:16 +01:00
Elia Sarti
c4e5ee1fd2 Fix RichTextLabel alignment tags not working properly
Also fixes #6982
Fix error and formatting
2019-06-14 21:38:33 +01:00
Rémi Verschelde
8e04aecb19
Merge pull request #29647 from YeldhamDev/file_dialog_hidden_toggle
Add toggle for hidden file visibility in FileDialog
2019-06-14 22:29:49 +02:00
Rémi Verschelde
a745934761
Merge pull request #29731 from akien-mga/scene-is-off-limits
Cleanup some unecessary editor/ includes in scene/
2019-06-12 23:44:24 +02:00
Rémi Verschelde
84d969a42a Cleanup some unecessary editor/ includes in scene/
Part of #29730, handles false positives.
2019-06-12 22:48:43 +02:00
Rémi Verschelde
2cedf7173a BaseButton: Make shortcuts call virtual methods
When buttons are not in Toggle Mode, shortcuts used to only trigger the
`pressed` signal, without calling the `_pressed` virtual method,
contrarily to what happens when you click the button.

For Toggle Mode buttons, it did call the `_toggled` virtual method
together with emitting the `toggled` signal *twice*.

This commit harmonizes it all and makes shortcuts behave the same as
mouse clicks or `ui_accept`, for both toggle and non-toggle modes.

Fixes #29604.
2019-06-12 16:35:49 +02:00
Rémi Verschelde
df25679235
Merge pull request #29601 from NilsIrl/hiding_enabled
Treat hiding_enabled as bool throughout
2019-06-12 14:23:27 +02:00
Rémi Verschelde
434a1fddf3
Merge pull request #29648 from jbuck3/tree-tooltips
Fix Tree button tooltips
2019-06-12 13:29:36 +02:00
Rémi Verschelde
971b5160c6
Merge pull request #29306 from qarmin/small_code_fixes
Small fixes to unrechable code, possibly overflows, using NULL pointers
2019-06-12 12:49:21 +02:00
Rémi Verschelde
4043c8a8c9
Merge pull request #29678 from akien-mga/err-macros-semicolon
Fix error macro calls not ending with semicolon
2019-06-11 19:01:26 +02:00
Rémi Verschelde
15425b450f
Merge pull request #29573 from qarmin/fix_rich_text_process_line
Fix RichLabelText::_process_line crash
2019-06-11 16:00:03 +02:00
Rémi Verschelde
6d16f2f053 Fix error macro calls not ending with semicolon
It's not necessary, but the vast majority of calls of error macros
do have an ending semicolon, so it's best to be consistent.
Most WARN_DEPRECATED calls did *not* have a semicolon, but there's
no reason for them to be treated differently.
2019-06-11 14:49:34 +02:00
Rémi Verschelde
d8877d2df5
Merge pull request #29539 from qarmin/fix_crash_with_get_keywords_color
Fix crash with get_keywords_color
2019-06-11 14:19:18 +02:00
bruvzg
63d8dc0920
Fix third and fourth level (AltGr / ⌥ modifier) keys input in LineEdit. 2019-06-11 08:10:07 +03:00
James Buck
215fed1fb3 Fix Tree button tooltips
Fixes #22777
2019-06-09 22:33:47 -05:00
Michael Alexsander Silva Dias
be6d48fcad Add toggle for hidden file visibility in FileDialog 2019-06-10 00:20:24 -03:00
James Buck
17e1be6478 Connect OptionButton selection to menu's "index_pressed" signal
Simplifies code and fixes bug where only the first item with a given
ID could be selected.
2019-06-09 14:44:36 -05:00
Nils ANDRÉ-CHANG
e4f90337f2 Treat hiding_enabled as bool throughout 2019-06-08 12:37:57 +01:00
qarmin
685451967c Fix RichLabelText::_process_line crash 2019-06-07 12:36:11 +02:00
qarmin
8d993f6357 Fix crash with get_keywords_color 2019-06-06 12:59:29 +02:00
Rémi Verschelde
46c56cad0c
Merge pull request #29469 from bojidar-bg/29446-graphnode-seperation
Fix GraphNode not adding separation after the first node
2019-06-04 22:37:55 +02:00
Gilles Roudière
df0a69bbac Fixes NaN errors with anchors mode 2019-06-04 21:58:21 +02:00
Bojidar Marinov
8a1a067b91
Fix GraphNode not adding seperation after the first node
Fixes #29446
2019-06-04 16:05:23 +03:00
Tomasz Chabora
2f75471f24 Fix crash when searching Tree with no selection 2019-06-04 01:50:50 +02:00
Rémi Verschelde
774a9fde84
Merge pull request #26848 from ptrojahn/utf8navigation
Support UTF-8 in TextEdit and LineEdit navigation
2019-06-03 22:28:54 +02:00
qarmin
8245db869f Small fixes to unrechable code, possibly overflows, using NULL pointers 2019-06-03 21:52:50 +02:00
Tomasz Chabora
59f403de0b Fixed get_item_at_position being weird 2019-06-02 14:32:32 +02:00
Rémi Verschelde
64a88e8ef3
Merge pull request #28841 from KoBeWi/option_button_options
Improvements to incremental search
2019-06-01 11:47:06 +02:00
Rémi Verschelde
af2c742f53 Fix and expose String::strip_escapes(), use it in LineEdit paste
Supersedes #27736.
2019-05-31 15:49:14 +02:00
Tomasz Chabora
9de912caf5 Improvements to incremental search 2019-05-31 14:56:49 +02:00
James Buck
4f4513f99c Remove some redundant lines 2019-05-29 15:20:39 -05:00
Rémi Verschelde
e832a3269c
Merge pull request #29261 from volzhs/fix-basebutton
Fix BaseButton not emitting signal with virtual function
2019-05-29 13:16:02 +02:00
volzhs
5c01e066e1 Fix BaseButton not emitting signal with virtual function
Fix #29258
2019-05-29 06:28:34 +09:00
qarmin
66a36ba474 Fix some unincialised variables 2019-05-28 19:12:19 +02:00
Tomasz Chabora
86e4677fb4 Add HSV mode to color picker 2019-05-28 18:00:52 +02:00
Rémi Verschelde
8384582828
Merge pull request #27836 from turtletooth/right-click
Allow Right Click in Empty Space on FileSystemDock
2019-05-28 12:07:06 +02:00
Rémi Verschelde
47f00925dc
Merge pull request #28454 from homer666/popup-centered-maxsize
Add `popup_centered_clamped()` method to Popup
2019-05-28 11:36:41 +02:00
Rémi Verschelde
06da7bf6b9
Merge pull request #28726 from megalike/add_mac_os_hotkeys_le
Support Mac OS hotkeys in line_edit
2019-05-28 10:37:04 +02:00
Rémi Verschelde
556ee71277
Merge pull request #29174 from Chaosus/fix_line_wrap_output
Fix "Index out of size" TextEdit's spam to output (when using Expression nodes in the visual shaders)
2019-05-28 10:21:54 +02:00
Ibrahn Sahir
e975d9dcdb Fix uninitialised member variable 'meta_hovering' in RichTextLabel 2019-05-27 15:14:48 +01:00
Tomasz Chabora
90ea9dfede Fix TextEdit blocking scroll without scrollbar 2019-05-26 20:51:08 +02:00
Chaosus
e5f5a71d27 Fix "Index out of size" TextEdit's spam to output 2019-05-25 20:57:32 +03:00
Rémi Verschelde
71c784f796
Merge pull request #29078 from KoBeWi/scroll_stuff
Improvements to scroll handling
2019-05-24 19:56:15 +02:00
Rémi Verschelde
f173d242a2
Merge pull request #28811 from iwek7/editor_remove_spaces_to_closes_indention
Change rules of indenting for spaces
2019-05-24 16:21:04 +02:00
Rémi Verschelde
f279837f3e
Merge pull request #29067 from KoBeWi/spin_edit
Pass mouse events to SpinBox from its LineEdit
2019-05-24 15:51:03 +02:00
Rémi Verschelde
8689af6238
Merge pull request #29060 from volzhs/toggled-group
Refactor BaseButton event handling
2019-05-24 15:44:35 +02:00
Tomasz Chabora
01491aaf32 Improvements to scroll handling 2019-05-24 14:56:39 +02:00
Michael Alexsander Silva Dias
de378ef012 Fix 'TextEdit's line wrapping being highlighted incorrectly
Fixes #22867.
2019-05-22 18:45:24 -03:00
Ibrahn Sahir
d8a5fcd3d1 Initialize readonly/editable in LineEdit and TextEdit controls 2019-05-21 21:50:02 +01:00
Rémi Verschelde
1d9bb73a15
Merge pull request #29040 from swarnimarun/fix_override_bug
Clear overrides on passing null
2019-05-21 15:23:18 +02:00
Rémi Verschelde
26e0cc7aa3
Merge pull request #29041 from hbina/add_const
add const to methods that return literals
2019-05-21 15:16:41 +02:00
volzhs
5e8017721a Refactor BaseButton event handling
also _toggled() function and "toggled" signal called  when unpressed by ButtonGroup
2019-05-21 22:14:01 +09:00
Tomasz Chabora
2d84ec5468 Pass mouse events to SpinBox from its LineEdit 2019-05-21 14:49:53 +02:00
Rémi Verschelde
aa33b6a3fa
Merge pull request #29046 from volzhs/tree-page-down
PageDown key selects last one when left items count is short
2019-05-21 10:06:09 +02:00
volzhs
6f97022041 PageDown key selects last one when left items count is short 2019-05-21 15:32:17 +09:00
hbina085
f78baa5f93 added a const keyword for a methods that return constant literal... 2019-05-21 02:16:30 -04:00
Swarnim Arun
6ab7fb4976 Clear overrides on passing null 2019-05-21 10:50:43 +05:30
Rémi Verschelde
8c95e1aaf8
Merge pull request #28952 from jbuck3/update-margins
Update Control margins when size is overridden by change to minsize
2019-05-20 22:40:35 +02:00
Rémi Verschelde
63e7d2db08
Merge pull request #28218 from KoBeWi/b00km4rk5
Add bookmarks for easier code navigation
2019-05-20 22:39:19 +02:00
Rémi Verschelde
fdea3d48b0
Merge pull request #26809 from KoBeWi/undo_set_text_like_a_boss
Allow to undo TextEdit.set_text
2019-05-20 22:00:39 +02:00
Rémi Verschelde
79cc95c6a7
Merge pull request #27559 from groud/anchor_mode
Improve the anchors and margin workflow
2019-05-20 17:44:56 +02:00
Rémi Verschelde
e0574e1d98 Fix typos with codespell
Using codespell 1.15.0.

Method:
```
$ cat > ../godot-word-whitelist.txt << EOF
ang
curvelinear
doubleclick
leapyear
lod
merchantibility
nd
numer
ois
ony
que
seeked
synching
te
uint
unselect
webp
EOF

$ codespell -w -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"
$ git diff // undo unwanted changes
```
2019-05-19 13:10:35 +02:00
Max Hilbrunner
ee5ba3e097
Merge pull request #28366 from iwek7/feature/issue28355/showSpacesInEditor
Add feature to show spaces in code editor
2019-05-17 20:38:40 +02:00
James Buck
5f5507cc62 Update Control margins when size is overridden by change to minsize 2019-05-16 21:56:17 -05:00
Paulb23
a8a0392c12 Fix text_edit drawing incorrect chars when syntax highlighting enabled 2019-05-16 22:32:06 +01:00
Tomasz Chabora
3bc0445e05 Allow to undo TextEdit.set_text 2019-05-16 23:05:17 +02:00
Michael Alexsander Silva Dias
be8dc97be7 Fix leftover connection to the "Open" signal in FileSystemDock
Fixes #28903.
2019-05-15 11:25:52 -03:00
Michael Alexsander Silva Dias
15cda53d80
Merge pull request #28583 from theoniko/show-long-name-variables-correctly
Fix First Ctrl+R and Ctrl+F not showing long name variables correctly
2019-05-14 21:53:36 +00:00
Gilles Roudiere
e875f05c3b Improve the anchors and margin workflow 2019-05-13 18:55:31 +02:00
miwanczuk
cbc68a3e04 Change rules of indenting for spaces
Now indentations and deindentations of spaces attemt to align text to
closest full indent level. It works with tab/tab+shift (both with
selection and no selection) as well as backspace. Also fixes bug where
selection and cursor position were mispaced after (un)indenting selected
text.
2019-05-11 10:30:40 +02:00
Rémi Verschelde
fea0c8858e
Merge pull request #28770 from volzhs/fix-scroll-back-top
Fix scroll back top
2019-05-11 09:44:11 +02:00
Aaron Franke
702b539405
Change "ID" to lowercase "id"
Reasoning: ID is not an acronym, it is simply short for identification, so it logically should not be capitalized. But even if it was an acronym, other acronyms in Godot are not capitalized, like p_rid, p_ip, and p_json.
2019-05-09 06:25:32 -04:00
volzhs
68c3728b47 Revert "Merge pull request #26053 from qarmin/back_scroll_to_start"
This reverts commit b5deb1dc72, reversing
changes made to 2cc8848c3c.

This change causes unwanted regression.
It's too risky to have scroll back to top in ItemList.clear()
2019-05-09 03:51:08 +09:00
megalike
ed37912e66 Support Mac OS hotkeys in line_edit 2019-05-06 22:59:34 +03:00
Rémi Verschelde
7b7a664a97
Merge pull request #28709 from YeldhamDev/tabcontainer_locale_update
Fix 'TabContainer' not updating its tab titles when locale is changed
2019-05-06 10:53:22 +02:00
Michael Alexsander Silva Dias
a242bf464a Fix 'TabContainer' not updating its tab titles when locale is changed 2019-05-06 01:59:34 -03:00
Tomasz Chabora
0bfcf8bc2f Add bookmarks for easier code navigation 2019-05-05 18:57:53 +02:00
megalike
c6310e9a7e Support Mac OS default delete char hotkeys 2019-05-04 17:15:32 +03:00
Michael Alexsander Silva Dias
37f4d51a75 Make 'TabContainer' update when icon/title is changed
Fixes #28655.
2019-05-03 14:55:32 -03:00
Rémi Verschelde
7b64a24eb3
Merge pull request #28548 from YeldhamDev/check_button_disabled_icon
Add "disabled" icon for 'CheckButton'
2019-05-03 14:55:32 +02:00
megalike
39398f173e Fix Mac OS move cursor behaviour 2019-05-02 21:13:41 +03:00
Michael Alexsander Silva Dias
acadfe0a49 Add "disabled" icon for 'CheckButton' 2019-05-02 13:39:56 -03:00
Michael Alexsander Silva Dias
d6489374e7 Fix regression in 'PopupMenu' when icons have different values for width and height 2019-05-02 11:40:13 -03:00
theoniko
505ab3d225 Fix First Ctrl+R and Ctrl+F not showing long name variables correctly 2019-05-01 20:59:17 +02:00
Rémi Verschelde
2f74e6b854
Merge pull request #28559 from megalike/mac_os_move_cursor_hotkeys
Support Mac OS default move cursor hotkeys
2019-05-01 15:08:30 +02:00
megalike
17d14fe511 Support Mac OS default move cursor hotkeys
Add missing FALLTHROUGH define
2019-05-01 13:45:00 +03:00
miwanczuk
c86b03abd8 Expose TextEdit's drawSpaces feature to GDScript 2019-05-01 11:32:54 +02:00
Rémi Verschelde
f3eafcec1a
Merge pull request #25350 from Connall/master
Fix "Auto Brace Complete" inserting extra quotation character sometimes in a string.
2019-05-01 10:32:41 +02:00
Rémi Verschelde
a72552367e
Merge pull request #25453 from nekomatata/button-keep-pressed-option
Add option to keep button pressed when moving cursor outside while pressing
2019-05-01 10:30:40 +02:00
Rémi Verschelde
59b553b2af
Merge pull request #28493 from mitchcurtis/mac-line
Make Command + Left go to first non-whitespace character
2019-05-01 08:25:40 +02:00
Michael Alexsander Silva Dias
48bfa9d17a Fix regression on 'PopupMenu's minimal size 2019-05-01 02:30:56 -03:00
Rémi Verschelde
5f3dd5fdc7
Merge pull request #28481 from iwek7/issue28446/highlighingOfWhitespaces
Disable higlighting all occurences of selection in editor if it contains only whitespaces
2019-04-30 18:31:53 +02:00
Rémi Verschelde
9dc9434b1b
Merge pull request #24437 from mateusfccp/single_quotes_option
Add settings for single-quotes on completion
2019-04-30 14:58:33 +02:00
miwanczuk
fda3a568ef Issue-28355 - show spaces in editor 2019-04-30 14:57:48 +02:00
Rémi Verschelde
b5deb1dc72
Merge pull request #26053 from qarmin/back_scroll_to_start
Back scroll bar to start when changing folder
2019-04-30 13:35:45 +02:00
Rémi Verschelde
2cc8848c3c
Merge pull request #26224 from hilfazer/autocomplete
Working autocomplete for $" and $'
2019-04-30 13:32:37 +02:00
Rémi Verschelde
88c0a8d4b8
Merge pull request #26252 from ZahFox/colorpicker
ColorPicker: Properties to toggle the editability and visibility of presets
2019-04-30 13:31:51 +02:00
Rémi Verschelde
e949d6c2ae Fix build error after #27294 2019-04-30 12:33:02 +02:00
Rémi Verschelde
0da61614c0
Merge pull request #27204 from YeldhamDev/popupmenu_checkicon_offset
Offset items in PopupMenu when Icons and Checks are present
2019-04-30 11:49:16 +02:00
Rémi Verschelde
d6b20e854c
Merge pull request #27294 from lupoDharkael/rect2i
Add missing methods to Rect2i
2019-04-30 11:46:40 +02:00
Rémi Verschelde
9916319df8
Merge pull request #27693 from YeldhamDev/method_brackets_smart
Make brackets only be inserted when necessary when autocompleting methods
2019-04-30 11:11:08 +02:00
Rémi Verschelde
4f10a08d1b
Merge pull request #27796 from Leytak/patch-2
Reset button state on exit tree
2019-04-30 11:05:09 +02:00
Rémi Verschelde
ea30bcdfef
Merge pull request #28287 from YeldhamDev/text_editable_contextmenu
Make 'Line/TextEdit's context menus hide their editing options when in readonly mode
2019-04-30 10:15:47 +02:00
Rémi Verschelde
d0e628fa55
Merge pull request #28334 from YeldhamDev/popup_buttons_scale
Make buttons that trigger popups have the same scale
2019-04-30 10:15:02 +02:00
miwanczuk
1001c7fdde issue-28446 - disable higlighting all occurences of string in editor if only whitespaces are selected 2019-04-30 09:59:59 +02:00
homer666
80e9e93e27 Add Popup::popup_centered_clamped method
- Also replace redundant duplicate code in editor dialogs with calls to popup_centered_clamped()
2019-04-30 05:35:43 +10:00
Michael Alexsander Silva Dias
f7a45eb0de Make 'Line/TextEdit's context menus hide their editing options when in readonly mode
Fixes #28243.
2019-04-29 14:03:31 -03:00
Rémi Verschelde
23147ae2c3
Merge pull request #28101 from MunWolf/debugger_cursor
Added a marker in text_edit that tells which row is executing.
2019-04-29 18:38:38 +02:00
Michael Alexsander Silva Dias
b8e09f98c4 Make buttons that trigger popups have the same scale 2019-04-29 13:07:47 -03:00
Rémi Verschelde
7e87a410fa
Merge pull request #28205 from mikolasan/26937-hide-popup-menu
Hide popup menu when OptionButton is hidden
2019-04-29 17:28:49 +02:00
Rémi Verschelde
6822ee37dd
Merge pull request #28281 from zqyoung1/fix-selection-undo
Fix selection undo
2019-04-29 17:25:14 +02:00
Rémi Verschelde
17ad16e396
Merge pull request #28284 from Daw11/doc-link-fix
Fix the unclickable links inside the doc
2019-04-29 17:23:50 +02:00
Rémi Verschelde
1af18ab235
Merge pull request #28399 from YeldhamDev/textedit_expose_tab_fold
Expose 'TextEdit's tab drawing and folding to GDScript
2019-04-29 17:04:46 +02:00
Mitch Curtis
b0956915c9 macOS: make Command + Left go to first non-whitespace character
Instead of going to column 0. This matches the behaviour of other
popular IDEs.

Fixes #28462.
2019-04-28 17:51:47 +02:00
Daw11
ce6ab56e9f Fix the unclickable links inside the doc
Fixes #27384
2019-04-27 21:30:08 +02:00
Aaron Franke
b659e1eb2b
Use approximate equallity methods in many places 2019-04-25 13:20:29 -04:00
Rémi Verschelde
cce2e4b07c
Merge pull request #22301 from YeldhamDev/button_popup_highlight
Enable toggle behaviour for buttons that trigger popups
2019-04-25 17:47:23 +02:00
Michael Alexsander Silva Dias
350bcce041 Expose 'TextEdit's tab drawing and folding to GDScript 2019-04-24 12:42:12 -03:00
Michael Alexsander Silva Dias
4bca3236d1 Make small changes to the new connection info on script feature 2019-04-24 03:13:25 -03:00
Rikhardur Bjarni Einarsson
9bfa63496a Added a marker in text_edit that tells which row is executing. 2019-04-23 21:51:01 +01:00
Rémi Verschelde
b4d561013f
Revert "RichTextLabel: Adding the ability to change the default cursor" 2019-04-23 16:10:15 +02:00
Nikolay Neupokoev
ebe54833a9 Fix popup visibility for OptionButton, MenuButton and ColorPickerButton
Hide popup when its button or another parent object is hidden

Fixes #26937
2019-04-22 15:11:49 -07:00
hilfazer
17166f5640 autocomplete for $" and $' 2019-04-22 12:53:24 +02:00
Rémi Verschelde
a342131eba
Merge pull request #27673 from qarmin/small_fixes
Small fixes, mostly duplicated code
2019-04-22 12:00:34 +02:00
Rémi Verschelde
22457b907e
Merge pull request #28234 from Paulb23/connection_info_on_script
Display connection information in the script editor
2019-04-22 11:52:13 +02:00
Rémi Verschelde
86aa22b2ac
Merge pull request #28266 from coldrye-collaboration/gh-28241
Fix LineEdit not expanded to text length on undo/redo
2019-04-22 10:47:58 +02:00
Zach Young
516b80cd65 Fix completely #14835 -proper selection reset on undo 2019-04-21 17:20:58 -04:00
Carsten Klein
da2a0a3814 Call minimum_size_changed() on redo/undo if expand_to_text_length is true
Fixes #28241
2019-04-21 19:10:01 +02:00
Michael Alexsander Silva Dias
ac1c523989 Fix 'LineEdit' offset limit not accounting for the right/clear icon width
Fully fixes #28242.
2019-04-21 13:55:40 -03:00
Rémi Verschelde
2226ce0fa8
Merge pull request #28248 from YeldhamDev/lineedit_clearbutton_limit
Fix 'LineEdit' contents not ending before the clear button if no right icon was set
2019-04-21 13:25:38 +02:00
Rémi Verschelde
71bbe6eb01
Merge pull request #27979 from Paulb23/remember_script_state
Restore script editor state between sessions
2019-04-21 13:01:43 +02:00
Michael Alexsander Silva Dias
d84acb98d0 Fix 'LineEdit' contents not ending before the clear button if no right icon was set
Fixes #28242.
2019-04-20 18:22:37 -03:00
Paulb23
a6562cd004 Display connection information in the script editor 2019-04-20 13:13:54 +01:00
griant
eb5807984c fix improper uncommenting behavior in TextEditor 2019-04-19 15:39:57 +08:00
Rémi Verschelde
6697fd9a05
Merge pull request #27821 from mawenzy/pr_sliderfix
Fix slider handle being hard to select
2019-04-17 09:03:30 +02:00
Paulb23
6ea253aa77 Restore script editor state between sessions 2019-04-13 13:07:12 +01:00
groud
14a901e88f Enhance tree scrolling when dragging 2019-04-12 21:58:48 +02:00
Juan Linietsky
9f4b5a91c0 Reorganized connection dialog for much improved ease of use.
-Removed dest path field
-Added a "Source" signal
-Added an "Advanced" button to hide complexity
-Fix bug on Tree to make sure "ensure visible" works on hidden trees
-Fix bug on TextEdit to ensure signals created with script not open sill focus the right line
2019-04-11 23:23:24 -03:00
mawenzy
e2e8457ca6 Fix #24124, Slider control size 2019-04-09 21:58:19 +02:00
Jeremy Bullock
36bdf78927 Allow Right Click in Empty Space on FileSystemDock 2019-04-09 11:22:14 -06:00
Rémi Verschelde
c8994b56f9 Style: Apply new changes from clang-format 8.0
It seems to stay compatible with formatting done by clang-format 6.0 and 7.0,
so contributors can keep using those versions for now (they will not undo those
changes).
2019-04-09 17:09:48 +02:00
Juan Linietsky
a20235aeb0 Add ability to edit editor feature profiles
Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 19:18:51 -03:00
qarmin
856a8226a5 Small fixes, mostly dupicated code 2019-04-08 11:03:37 +02:00
Alexey Kashlakov
c7fbc63cc2 Reset button state on exit tree
Steps to reproduce a bug:
1) Hold / hover the button
2) Remove it (or parent node) from the tree
3) When we return the button back to the tree, it's pressed / hover
2019-04-08 15:11:07 +07:00
Rémi Verschelde
2db0613fb0
Merge pull request #25624 from nekomatata/texture-rect-flip
Add ability to flip TextureRect horizontally or vertically
2019-04-06 13:15:01 +02:00
Rémi Verschelde
963165065d
Merge pull request #26914 from xDGameStudios/popup_menu_add_item
Fixed optional idx argument in add_item (PopupMenu)
2019-04-05 16:49:19 +02:00
Rémi Verschelde
fc370b3feb Fix -Wimplicit-fallthrough warnings from GCC 8
Adds `FALLTHROUGH` macro to specify when a fallthrough is intentional.
Can be replaced by `[[fallthrough]]` if/when we switch to C++17.

The warning is now enabled by default for GCC on `extra` warnings level
(part of GCC's `-Wextra`). It's not enabled in Clang's `-Wextra` yet,
but we could enable it manually once we switch to C++11. There's no
equivalent feature in MSVC for now.

Fixes #26135.
2019-04-05 15:14:53 +02:00
Michael Alexsander Silva Dias
24137f423a Make brackets only be inserted when necessary when autocompleting methods 2019-04-04 23:06:44 -03:00
Michael Alexsander Silva Dias
61cbb1f6bb Add option to enable autowrapping for label inside 'AcceptDialog' 2019-04-04 17:51:48 -03:00
Rémi Verschelde
d9b9c9f98a
Merge pull request #27567 from Calinou/selection-boxes-use-accent-color
Use the editor theme's accent color for 2D/3D selections and rotations
2019-04-04 17:45:01 +02:00
Rémi Verschelde
3a7a1cd4c9
Merge pull request #27596 from mo7sener/master
Fix: RichTextLabel Crash - meta_hover_ended
2019-04-04 17:27:34 +02:00
PouleyKetchoupp
43bd28bc14 Option for BaseButton to keep button down when moving the pointer outside while pressed 2019-04-03 14:19:33 +02:00
PouleyKetchoupp
8b84638322 Add ability to flip TextureRect horizontally or vertically 2019-04-03 13:05:29 +02:00
marxin
f9f2413e69 Fix -Wnon-virtual-dtor warnings.
Example of the warning:
./core/script_language.h:198:7: warning: 'class ScriptCodeCompletionCache' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
2019-04-02 14:07:29 +02:00
Robear Selwans
84dfb3ff2d Fixed an issue where changing the default_cursor on the RichTextLabel's meta_hover_ended caused the entire project to crash 2019-04-02 13:59:38 +02:00
Hugo Locurcio
d59b210aec
Use the editor theme's accent color for 2D/3D selections and rotations 2019-03-31 23:54:46 +02:00
Paulb23
bfba1e36bc Fixed not deselecting when clearing lineedit. 2019-03-31 16:32:24 +01:00
Rémi Verschelde
e02c7612e5
Merge pull request #27088 from fire/scaling_texture_button_focus
Fix scaling issue for texture button focus texture.
2019-03-27 16:55:07 +01:00
Rémi Verschelde
04c6347856
Merge pull request #27017 from qarmin/fix_inspector_update
Fix inspector update after changing anchor from buttons
2019-03-27 16:53:58 +01:00
lupoDharkael
6232e7eed3 Add missing methods to Rect2i
Replace inline with _FORCE_INLINE_ in short methods.
Remove unused and redundant method no_area() as we already have has_no_area().
Add grow_individual() grow_margin() and expand() to Rect2i.
2019-03-21 17:35:01 +01:00
qarmin
8b391b9ab0 Fix inspector update after changing anchor via buttons 2019-03-19 18:37:28 +01:00
Michael Alexsander Silva Dias
de04003d3f Offset items in PopupMenu when Icons and Checks are present 2019-03-18 10:10:19 -03:00
Rémi Verschelde
67764bff64
Merge pull request #26788 from mo7sener/master
RichTextLabel: Adding the ability to change the default cursor
2019-03-16 11:08:29 -07:00
K. S. Ernest (iFire) Lee
1971c09e5e Fix scaling issue for texture button focus texture. 2019-03-15 01:55:50 -07:00
xDGameStudios
ffc5f360e8 Fixed optional idx argument in add_item (OptionMeny & PopupMenu) 2019-03-11 11:54:12 +00:00
Bojidar Marinov
964152ed71
Fix cursor going to start while editing GraphNode's title
Fixes #26816
2019-03-10 12:22:15 +02:00
Paul Trojahn
8851e16f75 Support UTF-8 in TextEdit and LineEdit navigation
This allows jumps over whole non ASCII words with Ctrl+Left/Right in
a LineEdit or TextEdit.
Fixes #25681
2019-03-09 20:08:40 +01:00
Robear Selwans
b852a7a854 Added the ability to change the default cursor property for the RichTextLabel component. 2019-03-08 13:33:34 +02:00
Rémi Verschelde
e28e849012
Merge pull request #21534 from volzhs/fix-scrollcontainer-size
Precise size calculation of ScrollContainer
2019-03-07 14:19:43 +01:00
Juan Linietsky
5f079e2ef9 -Make tileset and meshlibrary edit in a separate inspector, fixes #26671
-Made relationship lines appear based on theme settings, not previous hack
-Fix drawing of relationship lines (was broken)
-Fix double initialization of theme settings
2019-03-06 12:12:42 -03:00
Rémi Verschelde
4ab4ff67ff
Merge pull request #26642 from DrMoriarty/check_cursor_line
Check cursor line and column
2019-03-05 22:57:55 +01:00
Vasiliy Makarov
a3d9b7d916 Check cursor line and column
Added a trivial check if cursor.line and cursor.column are valid.
Fix #26245
2019-03-05 18:27:37 +03:00
Michael Alexsander Silva Dias
a292d1fefb Fix general issues with filesystem-related UI components in the editor 2019-03-05 10:12:06 -03:00
Juan Linietsky
6b8b1cabae Add a warning when using plain Container, as many users seem to misunderstand what this is. 2019-03-03 16:00:56 -03:00
Juan Linietsky
51b80f6857 Fixed some crashers, closes #26393 2019-03-01 17:24:57 -03:00
Rémi Verschelde
994bdc9adc
Merge pull request #26140 from karliss/meta-item
Use correct meta item in rich text.
2019-03-01 18:16:27 +01:00
Justin Vesper
079ed007c8 Fixed wrong method binding in control
Control.get_parent_area_size() is now bound to
Control::get_parent_area_size() instead of Control::get_size()
2019-03-01 14:16:19 +01:00
Bojidar Marinov
a7b564db6e
Fix minimum size of ProgressBar-s
Was a leftover from 0a1c1c660f.
Fixes #21633.
2019-02-27 15:56:49 +02:00
Bojidar Marinov
8dad5f1e10
Update controls when a stylebox or icon override changes; change to CONNECT_REFERENCE_COUNTED
Also, cleanup unnessesary calls to update() and NOTIFICATION_THEME_CHANGED.

Fixes #25904.
2019-02-25 17:42:38 +02:00
will
eb9c92f996 ColorPicker: New properties to toggle the editability and visibility of presets 2019-02-24 23:16:56 -06:00
Michael Alexsander Silva Dias
52abab5aa7 Make 'SplitContainer' update drawing only if actually needs to 2019-02-22 10:12:39 -03:00
Michael Alexsander Silva Dias
f2f09f00b7 Fix 'SplitContainer's showing their handles when they shouldn't
Fixes #25735.
2019-02-21 23:01:30 -03:00
Kārlis Seņko
05f5774592 Use correct meta item in rich text.
Prevent incorrect static cast and unnecesarry meta_hover_ended/started
events.
2019-02-22 00:23:05 +02:00
Rémi Verschelde
47c4ec7f1d
Merge pull request #26105 from nekomatata/texture-button-mask-fix
TextureButton with click mask only can be clicked
2019-02-21 14:48:43 +01:00
PouleyKetchoupp
f07dfe8a3f Fixed TextureButton click mask when no other texture is set 2019-02-21 01:11:56 +01:00
marxin
8d51618949 Add -Wshadow=local to warnings and fix reported issues.
Fixes #25316.
2019-02-20 19:44:12 +01:00
Rémi Verschelde
9714f701c5
Merge pull request #26089 from ianb96/word_wrap_cutoff_fix
Fix word wrap cutoff and tab wrapping issue
2019-02-20 16:28:43 +01:00
Rémi Verschelde
6709ff6a96
Merge pull request #26049 from vixelz/textureprogress-nineslice-fill-fix
Truncate first segment in TextureProgress 9slices
2019-02-20 15:23:31 +01:00
ianb96
39f537e481 Fix word wrap cutoff and tab wrapping issue 2019-02-20 08:52:33 -05:00
Kārlis Seņko
86374c0431 Allow moving LineEdit visible window left by more than one symbol. 2019-02-19 23:59:09 +02:00
qarmin
9bf1964dff Back scroll to start when changing folder 2019-02-19 13:31:39 +01:00
Vixelz
559b8fd236 Truncate first segment in TextureProgress 9slices
Much in the way that TextureProgress was truncating the last segment
of the nine slice when the value wasn't close to the end, perform
similar work on the beginning segment. This fixes the beginning segment
always being drawn, sometimes in the incorrect location.
2019-02-19 08:28:32 +00:00
Rémi Verschelde
a034cac583
Merge pull request #25953 from nekomatata/fix-radial-texture-progress
Fixed TextureProgress in Radial Mode when using center offset
2019-02-16 22:26:06 +01:00
PouleyKetchoupp
1974f6995f Fixed radial progress with center offset by taking distance to edge into account in uv calculation 2019-02-16 21:02:29 +01:00
qarmin
7a254b303b Fix copy text when TextEdit is readonly 2019-02-16 07:56:24 +01:00
Rémi Verschelde
fe7d2dc4d3
Revert "Fix MenuButton item label disappearing when setting shortcut." 2019-02-15 11:44:27 +01:00
Unknown
3236c9a0e7 Fix MenuButton item label disappearing when setting shortcut. 2019-02-14 23:17:29 +01:00
Rémi Verschelde
b340b7e804
Merge pull request #25422 from azagaya/optionbutton
Fix docs about item_selected and item_focused . Fixes #25273
2019-02-13 20:31:53 +01:00
Naoto Kondo
f48829d1a4 Fix button alignment of Package Installer on OSX
This problem occurs only in the HiDPI environment.
2019-02-13 23:52:14 +09:00
Rémi Verschelde
5fc86026ca Fix typos with codespell
Using codespell 1.14.0.

Method:
```
$ cat > ../godot-word-whitelist.txt << EOF
ang
doubleclick
lod
nd
numer
que
te
unselect
EOF
$ codespell -w -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"
$ git diff // undo unwanted changes
```
2019-02-13 09:23:29 +01:00
Rémi Verschelde
c5dcbeb160 Scene: Ensure classes match their header filename
Also drop some unused files.

Renamed:
- `scene/2d/navigation2d.h` -> `navigation_2d.h`
- `scene/2d/screen_button.h` -> `touch_screen_button.h`
- `scene/3d/scenario_fx.h` -> `world_environment.h`
- `scene/audio/audio_player.h` -> `audio_stream_player.h`
- `scene/resources/bit_mask.h` -> `bit_map.h`
- `scene/resources/color_ramp.h` -> `gradient.h`
- `scene/resources/shape_line_2d.h` -> `line_shape_2d.h`
- `scene/resources/scene_format_text.h` -> `resource_format_text.h`
- `scene/resources/sky_box.h` -> `sky.h`

Dropped:
- `scene/resources/bounds.h`
2019-02-12 17:21:48 +01:00
azagaya
7051685a77 Fixes differences between docs and item_selected and item_focused signals in optionbutton
Description in docs about item_selected and item_focused signals in optionbutton is fixed to match the real behaviour. Also, get_item_index function is added.
2019-02-11 08:52:09 -03:00
Michael Alexsander Silva Dias
4fd7115e13 General cleanup of script and doc search bars 2019-02-10 14:18:08 -02:00
Paulb23
69374cd378 Fixed selection being activated when using scroll lines 2019-02-04 10:55:45 +00:00
Michael Alexsander Silva Dias
8d3ae29e8f Small fixup on button toggle behaviour in ColorPicker 2019-01-28 15:51:57 -02:00
Michael Alexsander Silva Dias
182f26fe5e Make some small enhancements to the ColorPicker 2019-01-27 12:44:39 -02:00
Connall Lindsay
11f4b5efc5 Brace completion for quotation marks was introducing another quotation mark at the end of the
string, I think because it wasn't checking that the quotation mark didn't exist at the current
cursors position. Simple change, that fixed the issue and stood up to testing. Issue #25084
2019-01-26 17:03:11 +00:00
groud
a1f955a1d3 Updates containers minimum size when some constants are modified 2019-01-24 22:31:33 +01:00
Rémi Verschelde
a29b10cced ProgressBar: Set default step to 0.01
Fixes #22655.
2019-01-24 12:58:58 +01:00
Rémi Verschelde
51c67a386d
Merge pull request #25190 from 99alfie/master
Fix ButtonGroup.get_pressed_button bug
2019-01-23 12:30:23 +01:00
Rémi Verschelde
055456d5fc
Merge pull request #25064 from homer666/itemlist-adjust-ui_select-precedence
ItemList: ignore `ui_select` action if Select Mode is not "Multi"
2019-01-21 17:45:30 +01:00
Kraus
ea211af412 ButtonGroup.get_pressed_button bugfix, fixes issue #25057 2019-01-21 16:46:09 +01:00
Hugo Locurcio
4b78306459
Fix a rounding error in ColorPicker
This closes #25063.
2019-01-18 22:19:19 +01:00
homer666
5f47e18b0f ItemList: ignore ui_select action if Select Mode is not "Multi" 2019-01-18 01:54:24 +11:00
Michael Alexsander Silva Dias
9c69d7f339 Appease some CppCheck warns for files in the "scene" directory 2019-01-16 12:59:18 -02:00
volzhs
1e603b706e Update rect size on select 2019-01-16 20:44:34 +09:00
Juan Linietsky
6af8b7c955 Defer activated signal after tree has been traversed. 2019-01-14 17:20:54 -03:00
Juan Linietsky
ed9b230744 Hide visible popups by default if visible when entering tree, unless on editor. Fixes #24737 2019-01-14 13:16:19 -03:00
bruvzg
55bc004a73
Update IME text only for focused input controls. 2019-01-08 22:52:56 +02:00
Timo Schwarzer
3b2e03cf0b
Fix jumping when scrolling down fast with smooth scroll enabled
Fixes #24773
2019-01-06 10:22:38 +01:00
Paulb23
411df08711 Fix text edit wrapping beyond control size, issue 23896 2019-01-05 16:58:54 +00:00
Rémi Verschelde
fa5ca1bbf0
Merge pull request #24738 from timoschwarzer/24725-fit-child-in-rect-null-check
Check if p_child is not null in Container.fit_child_rect()
2019-01-04 14:54:57 +01:00
Timo Schwarzer
a8f367a4b8
Check if p_child is not null in Container.fit_child_rect()
Fixes #24725
2019-01-03 22:33:07 +01:00
Rémi Verschelde
65a86ae17c
Merge pull request #24683 from SoIAS/autocompletion_menu_position_24674
Fixed autocompletion menu vertical position
2019-01-03 21:33:12 +01:00
Dawid Wdowiak
615ca1d59e Fixed autocompletion menu vertical position 2019-01-03 07:11:40 +01:00
Hugo Locurcio
574f90605d
Make GraphEdit lines smoother and scale their width on hiDPI displays 2019-01-02 23:29:48 +01:00
Rémi Verschelde
b16c309f82 Update copyright statements to 2019
Happy new year to the wonderful Godot community!
2019-01-01 12:58:10 +01:00
Rémi Verschelde
e3e36c963f
Merge pull request #24588 from volzhs/tree-relationship-line
Draw relationship lines when its value is higher than 0
2018-12-27 11:19:20 +01:00
Rémi Verschelde
2e39e38c10 doc: Sync classref with current source
Fix various code formatting issues and argument names.
2018-12-27 11:10:18 +01:00
Rémi Verschelde
e86418f7a9
Merge pull request #24566 from thomasruiz/fix/completion-box-center-text-vertically
Center lines vertically in completion box
2018-12-27 08:55:17 +01:00
volzhs
6a43f0a901 Draw relationship lines when its value is higher than 0 2018-12-25 09:18:18 +09:00
Thomas Ruiz
d2fa0658a2
Fix caret size with font smaller than row height 2018-12-23 14:29:33 +01:00
Thomas Ruiz
7fb0853c68
Center lines vertically in completion box 2018-12-23 12:19:27 +01:00
Mateus Felipe C. C. Pinto
ca1935d6f7 Add settings for single-quotes on completion 2018-12-18 12:48:36 -02:00
Paulb23
f1c6947702 Fix Word wrap cache desync causing crash 2018-12-18 13:12:46 +00:00
Rémi Verschelde
a195b2f1a3
Merge pull request #24428 from akien-mga/label-uppercase
Label: Fix kerning when using Uppercase mode
2018-12-18 07:57:41 +01:00
Hein-Pieter van Braam
c58b1608ea Don't accidentally convert string content to char
Due to the right hand side of the :? trickery the rhs was cast to a
char losing precision. Previously this didn't matter, but with
CharProxy it does. (Previously we could just happily cast it back to
a wchar_t and get the original 16 - 32 bits. Now we'll only ever
get the first 8).
2018-12-17 22:31:02 +01:00
Rémi Verschelde
7cb5e005ee Label: Fix kerning when using Uppercase mode
Seemingly a typo, I did not check what exact impact it had, but
the x_ofs would likely have accumulated errors when using fonts
with varying char widths.
2018-12-17 20:56:36 +01:00
Michael Alexsander Silva Dias
04ea79c738 Fix item highlighting in PopupMenu for items with offset 2018-12-15 18:48:10 -02:00
Kanabenki
cfb89b672e Prevent FileDialog from stealing focus when setting current file in editor 2018-12-14 22:58:01 +01:00
Guilherme Felipe
64e52f5bdb Fix tree item editable cell not updating when windows was resized 2018-12-14 12:09:47 -02:00
Michael Alexsander Silva Dias
c2fe5c0468 Expose ButtonGroup's "get_buttons()" to GDScript 2018-12-14 04:16:23 -02:00
Rémi Verschelde
01fa0673a4
Merge pull request #22870 from semtri/godot-issue-7620
Fix richtextlabel meta links shouldn't open when swiping to scroll
2018-12-13 21:16:13 +01:00
Rémi Verschelde
2f31d31c23
Revert "Use more subtle indentation guides in the script editor" 2018-12-13 19:57:34 +01:00
merumelu
61ceb59f1d ColorPicker fixes
- Fix regression from #22402 which made presets invisible ingame
with `tools=yes` builds.
- Don't emit `color_changed` signal when deleting a preset
as no color change happens.
2018-12-12 22:30:49 +01:00
Michael Alexsander Silva Dias
8f9447310d Enable toggle behaviour for buttons that trigger popups 2018-12-11 19:23:26 -02:00
Rémi Verschelde
13d037b200
Merge pull request #21471 from RodZill4/issue_11893
Fixed issue #11893 (SpinBox capturing mouse)
2018-12-11 18:16:29 +01:00
Rémi Verschelde
4c41e29c8e
Merge pull request #23923 from bruvzg/ime_gdscript
Changes IME to make it possible to use it from gdscript/gdnative
2018-12-11 18:00:48 +01:00
Rodolphe Suescun
0838eca063 Fixed issue #11893 (SpinBox Capturing mouse)
To prevent the SpinBox from capturing mouse, added a "drag.allowed"
variable that is set to true only when clicking inside the control.
Entering the control with the left mouse button pressed will not
trigger drag anymore.

Also modified the value update code when dragging so it does not
modify the base_val.
2018-12-10 19:33:04 +01:00
Rémi Verschelde
bf59b73250
Merge pull request #20609 from YeldhamDev/menu_hover_explicit
Make opening menus with the same parent on mouse focus explicit
2018-12-09 23:15:33 +01:00
Rémi Verschelde
3a312dbd32
Merge pull request #20725 from Calinou/textedit-subtle-indent-guides
Use more subtle indentation guides in the script editor
2018-12-09 23:10:32 +01:00
Rémi Verschelde
41d1dba35f
Merge pull request #22431 from DualMatrix/pivot
Fixed pivot tool not setting position of Controls correctly
2018-12-07 23:18:27 +01:00
Rémi Verschelde
d303a7e6d7
Merge pull request #22680 from lupoDharkael/color-picker-presets
ColorPicker: extend access to presets from gds
2018-12-07 22:39:12 +01:00
Michael Alexsander Silva Dias
3ae5eec366 Add tooltips to GraphEdit node 2018-12-04 15:00:27 -02:00
Rémi Verschelde
e6b0327c2c
Merge pull request #24112 from allkhor/rich_label_update_cache
RichTextLabel: update the cache when the scroll hide.
2018-12-03 17:32:04 +01:00
Rémi Verschelde
f86013082e
Merge pull request #24106 from groud/fix_split_container
Fixes collapsed SplitContainers
2018-12-02 21:19:44 +01:00
allkhor
c80b9e9173 RichTextLabel: update the cache when the scroll hide. 2018-12-02 05:06:38 +06:00
groud
136847e5c3 Fixes collapsed SplitContainers 2018-12-01 17:31:37 +01:00
allkhor
7831cd76ab TextEdit: added redo option to the context menu 2018-11-29 23:21:43 +06:00
Rémi Verschelde
05755618c5
Merge pull request #23993 from Kanabenki/autocomplete-ignore-case
Add suggestions ignoring case at the end of the code autocomplete
2018-11-28 13:26:28 +01:00
allkhor
a04ba76d89 Ceil tabs font size 2018-11-27 00:30:12 +06:00
Kanabenki
99ffd748f1 Add suggestions ignoring case at the end of the code autocomplete 2018-11-26 16:36:46 +01:00
Rémi Verschelde
73551a1edc
Merge pull request #23964 from allkhor/text_edit_clear_selection
TextEdit: remove selection when clear happens.
2018-11-26 11:00:54 +01:00
allkhor
594e0261f3 TextEdit: remove selection when clear happens. 2018-11-25 23:24:49 +06:00
Paulb23
9e57c359b7 Fix scroll bar lock when smooth scroll enabled, issue 23314 2018-11-24 14:03:54 +00:00
allkhor
970dc91cb7 RichTextLabel: clear the scroll offset. 2018-11-23 23:54:49 +06:00
bruvzg
4554c682e6
Changes IME input to use notification instead of callback, exposes IME methods to gdscript/gdnative. 2018-11-23 14:07:48 +02:00
Rémi Verschelde
da31d63f76
Merge pull request #23680 from YeldhamDev/unified_help_search_revived
Unified Class and Reference Search 2: Resurrection
2018-11-22 16:16:52 +01:00
Rémi Verschelde
feee2b5842
Merge pull request #23731 from lupoDharkael/remove-button-tooltip
BaseButton: make input related information in the tooltip optional
2018-11-22 16:13:47 +01:00
Ray Koopa
fddffa9eb8 Unify editor class and reference search
Co-authored-by: Michael Alexsander Silva Dias <michaelalexsander@protonmail.com>
2018-11-20 20:52:27 -02:00
Michael Alexsander Silva Dias
da7d3c5a58 Make opening menus with the same parent on mouse focus explicit 2018-11-20 20:37:45 -02:00
Rémi Verschelde
33947a5722
Merge pull request #23728 from groud/keep_splitcontainer_offset
Keep the SplitContainer offset value when it is shrinked
2018-11-20 14:17:52 +01:00
lupoDharkael
d2b890ede5 BaseButton: add shortcut_in_tooltip
This flag disables the input related information in the tooltip.
It is exposed as a member variable in gdscript.
2018-11-19 23:48:05 +01:00
Juan Linietsky
0f7a86ca52 If using relationship lines (now default) hide guides. 2018-11-18 22:00:31 -03:00
pshe94
554b3f77c7
Use VScrollBar when calculating horiz. offset in ScrollContainer
Someone forgot to change `h_scroll` to `v_scroll` when copy-pasting the code ;)
2018-11-16 02:47:43 +01:00
Juan Linietsky
26d33d1c6e ViewportContainer was not passing unhandled input. Pass it, fixes #17326 2018-11-15 17:29:55 -03:00
Juan Linietsky
80a90ca824 -Send mouse motion events again to CollisionObjects (Area/Body) if they move, even if mouse does not. Fixes #16536 (likely many others should check)
-Add ability for viewports to set input events as handled locally
2018-11-15 13:56:57 -03:00
groud
a982531368 Keep the SplitContainer offset value when it is shrinked 2018-11-15 16:47:28 +01:00
Thomas ten Cate
922f2d613f Fix return value of get_total_character_count
Also document that it only counts visible characters.

Fixes #23720
2018-11-15 12:34:08 +01:00
Juan Linietsky
5f4485d4ff Always use default theme for overrides, closes #13071 2018-11-14 21:21:51 -03:00
Juan Linietsky
88bfb27abf Show theme values from default theme always, fixes #16011, fixes #13071 2018-11-14 18:02:21 +01:00
Ibrahn Sahir
ed337085cf Fixed various uninitialised member variables in editor plugins. 2018-11-11 17:32:47 +00:00
Juan Linietsky
f2e54057ae -Moved EditorDefaultValue to ClassDB, made it core
-Removed one and zero hints for properties, replaced by default value
2018-11-08 11:30:59 -03:00
groud
0ec448d21d Fixes icons in itemlist not working 2018-11-07 18:29:24 +01:00
Rémi Verschelde
de0d306558
Merge pull request #23383 from groud/better_tilemap_transform
Enhance the tilemap transform buttons
2018-11-06 22:27:29 +01:00
K. S. Ernest (iFire) Lee
562d241b13 Fix creating a visual script virtual function after minimizing crashes #23536 2018-11-05 13:48:27 -08:00
Marcelo Fernandez
ea43218bca Fix possible crash with VideoPlayer _mix_audio function 2018-11-02 13:33:20 -03:00
Juan Linietsky
65e3ef705b
Merge pull request #21962 from YeldhamDev/switch_hover_submenu
Fix MenuButton hover switching not happening with submenus open
2018-11-01 17:01:51 -03:00
Rémi Verschelde
aec8ea4f47
Merge pull request #22780 from samuelpedrajas/fix_texture_button_hovering
Fix hovering on toggled link and texture buttons
2018-11-01 11:22:34 +01:00
groud
bdb5282ea0 Enhance the tilemap transform buttons 2018-10-30 14:43:52 +01:00
zhagsenkk
67ba4dc8cd Remove no longer necessary "raise_from_completion" in TextEdit
This is no longer needed to fix #1257 because the code-autocomplete hint stops
at the script editor’s edge now.
And #6690 will not arise because it is just caused by "raise_from_completion".

Fixes #22504 and fixes #16064.
2018-10-26 19:29:51 +02:00
Sean McCarthy
0ce185629d Fix "fill" justification in RichTextLabel to only affect lines that have automatically wrapped. 2018-10-25 16:19:15 -07:00
Rémi Verschelde
1169196f04
Merge pull request #22779 from Superwaitsum/LimitSettings
Limit several project settings
2018-10-25 11:38:06 +02:00
Superwaitsum
e5041ad0f5 Add some limits on the Editor Settings 2018-10-24 19:46:33 -05:00
lupoDharkael
e19520e8fe ColorPicker: extend access to presets from gds 2018-10-24 01:07:33 +02:00
M. Huri
90efe5be08 Fixed a typo, treshhold to threshold. 2018-10-23 03:46:16 +07:00
Rémi Verschelde
81c2ed61f6
Merge pull request #23196 from Paulb23/scene_tab_errors_issue_22890
Scene tabs closing and thumbnail errors, issue 22890
2018-10-21 18:08:31 +02:00
Paulb23
5c04535e10 Update Tab hover status when adding or removing tabs, issue 22890 2018-10-21 15:55:58 +01:00
Ibrahn Sahir
7bf54d2334 Initialise LineEdit clear_button_status.
Avoiding undefined behaviour and cleaning up Valgrind output.
2018-10-20 11:27:31 +01:00
M. Huri
596ba88869 Repaired mistyped of 'just_disconnected'. 2018-10-19 18:31:35 +07:00
Rémi Verschelde
47c0aff491
Merge pull request #22894 from OsamaElHariri/prevent-comment-indent
A colon ending a comment line no longer indents the next line
2018-10-16 14:47:33 +02:00
M. Huri
967831d9a0 [Docs] Fixed 'get_button_count's link and a typo related to 'button'. 2018-10-13 17:34:57 +07:00
Rémi Verschelde
ebdb374d80
Merge pull request #22844 from samgreen/fix_gui_dragging_spam
Fix spam when dragging in the editor
2018-10-11 17:48:19 +02:00
OsamaElHariri
317f7c91a2 A colon ending a comment line no longer indents the next line 2018-10-10 00:36:12 +03:00
dennisseong
14c0b75b63 Fix richtextlabel meta links shouldn't open when swiping to scroll 2018-10-09 09:04:59 +09:00
Sam Green
24a339245f Swap condition to prevent spam in editor. 2018-10-08 11:05:20 -07:00
Fabio Alessandrelli
e355a8fc4c Fix crash in Tree when moving using Joypad 2018-10-07 16:22:04 +02:00
Rémi Verschelde
13892f2668
Merge pull request #22822 from godotengine/revert-16977-master
Revert "Created a new function named get_element in GridContainer. This funct…"
2018-10-07 11:19:55 +02:00
Rémi Verschelde
bf6dcb9105
Merge pull request #22722 from akien-mga/fix-warnings
Fix more "may be used initialized" warnings from GCC 7
2018-10-07 11:07:13 +02:00
Rémi Verschelde
cb677e57c6
Revert "Created a new function named get_element in GridContainer. This funct…" 2018-10-07 10:32:34 +02:00
Aaron Franke
4f7b33cdcf Remove redundant "== false" code
Some of this code has been re-organized.
f
2018-10-06 16:20:41 -04:00
Aaron Franke
37386f112b Remove redundant "== true" code
If it can be compared to a boolean, it can be evaluated as one in-place.
2018-10-06 16:12:36 -04:00
Rémi Verschelde
dda6d80598
Merge pull request #22742 from YeldhamDev/textedit_margin_scroll
Fix TextEdit margin start spacing with two scrollbars
2018-10-06 13:32:08 +02:00
Samuel P
cf2bdcbb3f fix hovering on toggled texture buttons
fix hovering on toggled link buttons
2018-10-06 13:06:06 +02:00
Rémi Verschelde
d2043fad67
Merge pull request #22774 from kellams/master
Fix to scrolling, rounding error on max_v_scroll
2018-10-06 12:36:17 +02:00
Kellam Spencer
f51ce0f7b1 Fix to scrolling, rounding error on max_v_scroll 2018-10-05 16:50:49 -04:00
R. K
2ef29d35bd Fix to ColorPicker behaviour when entering html. 2018-10-05 13:04:23 +02:00
Michael Alexsander Silva Dias
8a64a44e0e Fix TextEdit margin start spacing with two scrollbars 2018-10-04 19:38:08 -03:00
Rémi Verschelde
3e9740ac93 Fix more "may be used initialized" warnings from GCC 7
Fixes the following GCC 7 warnings:
```
core/cowdata.h:269:47: warning: 'alloc_size' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/error_macros.h:163:26: warning: 'nearest_point' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1579:5: warning: 'colormap_size' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1582:12: warning: 'size_height' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1590:23: warning: 'size_width' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1599:29: warning: 'pixel_size' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/math/face3.cpp:207:15: warning: 'tri_max' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/math/face3.cpp:209:15: warning: 'tri_min' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/rasterizer_scene_gles3.cpp:665:22: warning: 'best_used_frame' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/rasterizer_storage_gles3.cpp:865:27: warning: 'blit_target' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/rasterizer_storage_gles3.cpp:980:29: warning: 'blit_target' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/shader_gles3.h:122:9: warning: '<anonymous>.ShaderGLES3::Version::frag_id' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/shader_gles3.h:122:9: warning: '<anonymous>.ShaderGLES3::Version::id' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/shader_gles3.h:122:9: warning: '<anonymous>.ShaderGLES3::Version::vert_id' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/plugins/script_editor_plugin.cpp:1980:31: warning: 'se' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/scene_tree_dock.cpp:840:30: warning: 'new_node' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4259:9: warning: 'a1' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4259:9: warning: 'lll' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4259:9: warning: 'lul' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4260:9: warning: 'a2' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4261:9: warning: 'a3' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4265:3: warning: 'enable_lin' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4294:3: warning: 'enable_ang' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4311:34: warning: 'll' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4311:34: warning: 'ul' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/3d/voxel_light_baker.cpp:1655:47: warning: 'cone_dirs' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/3d/voxel_light_baker.cpp:1656:73: warning: 'cone_weights' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/gui/texture_progress.cpp:181:6: warning: 'cp' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/gui/texture_progress.cpp:181:6: warning: 'cq' may be used uninitialized in this function [-Wmaybe-uninitialized]
servers/physics/shape_sw.cpp:1056:19: warning: 'support_max' may be used uninitialized in this function [-Wmaybe-uninitialized]
```
2018-10-04 18:54:20 +02:00
karroffel
a0f206aae8 fix enum cast warnings on clang 2018-10-04 09:17:59 +02:00
Rémi Verschelde
95131e6f23 Fix warnings on release builds (not DEBUG_ENABLED)
Fixes the following Clang 5 warnings:
```
modules/bmp/image_loader_bmp.cpp:46:60: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
modules/bmp/image_loader_bmp.cpp:48:61: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
drivers/png/image_loader_png.cpp:231:20: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
scene/gui/graph_edit.cpp:1045:8: warning: comparison of constant 0 with expression of type 'bool' is always false [-Wtautological-constant-out-of-range-compare]

core/class_db.cpp:812:13: warning: unused variable 'check' [-Wunused-variable]
core/io/file_access_pack.cpp:172:11: warning: unused variable 'ver_rev' [-Wunused-variable]
core/math/bsp_tree.cpp:195:13: warning: unused variable 'plane' [-Wunused-variable]
core/math/bsp_tree.cpp:168:6: warning: unused variable 'plane_count' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:685:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:706:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:755:19: warning: unused variable 'var_type' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:1306:12: warning: unused variable 'err' [-Wunused-variable]

modules/gdscript/gdscript_function.cpp:158:15: warning: unused function '_get_var_type' [-Wunused-function]
modules/gdscript/gdscript_parser.cpp:750:20: warning: unused variable 'lv' [-Wunused-variable]
modules/gdscript/gdscript_parser.cpp:59:15: warning: unused function '_find_function_name' [-Wunused-function]
scene/main/node.cpp:2489:13: warning: unused function '_Node_debug_sn' [-Wunused-function]
```
2018-10-03 17:34:55 +02:00
Hugo Locurcio
9c1d4f9da2
Use more subtle indentation guides in the script editor 2018-10-03 00:00:25 +02:00
Rémi Verschelde
3c173ebca4
Merge pull request #21395 from mrcdk/spin_box_expose_align
Expose the align property of the SpinBox's LineEdit control
2018-10-02 10:36:20 +02:00
Rémi Verschelde
08a24698eb
Merge pull request #22062 from Leytak/patch-1
Discard button pressing flags on disable
2018-10-02 09:49:17 +02:00
Rémi Verschelde
fb5cbf2d30
Merge pull request #22402 from DualMatrix/colorpicker_presets
Made ColorPicker save it's presets while in editor.
2018-10-02 09:24:33 +02:00
Rémi Verschelde
01e1c6e8b6
Merge pull request #22560 from lupoDharkael/clipboard
TextEdit: prevent the copy of an empty string
2018-09-30 22:49:45 +02:00
lupoDharkael
f5f948210c TextEdit: prevent the copy of an empty string 2018-09-30 17:17:29 +02:00
Rémi Verschelde
0378a9ba80
Merge pull request #22520 from akien-mga/fix-warnings
Fix warning about functions defined but not used [-Wunused-function]
2018-09-29 23:51:17 +02:00
Rémi Verschelde
62ecb44035 Fix warning about functions defined but not used [-Wunused-function]
Fixes the following GCC 5 warnings:
```
core/io/zip_io.h:128:26: warning: 'zlib_filefunc_def zipio_create_io_from_file(FileAccess**)' defined but not used [-Wunused-function]
core/script_debugger_remote.cpp:110:17: warning: 'ObjectID safe_get_instance_id(const Variant&)' defined but not used [-Wunused-function]
drivers/unix/socket_helpers.h:103:12: warning: 'int _socket_create(IP::Type&, int, int)' defined but not used [-Wunused-function]
drivers/unix/socket_helpers.h:45:15: warning: 'size_t _set_sockaddr(sockaddr_storage*, const IP_Address&, int, IP::Type)' defined but not used [-Wunused-function]
drivers/unix/socket_helpers.h:76:15: warning: 'size_t _set_listen_sockaddr(sockaddr_storage*, int, IP::Type, IP_Address)' defined but not used [-Wunused-function]
editor/editor_fonts.cpp:40:24: warning: 'Ref<BitmapFont> make_font(int, int, int, int, const int*, const Ref<Texture>&)' defined but not used [-Wunused-function]
editor/editor_themes.cpp:85:26: warning: 'Ref<StyleBoxFlat> change_border_color(Ref<StyleBoxFlat>, Color)' defined but not used [-Wunused-function]
editor/import/editor_import_collada.cpp:493:13: warning: 'void _generate_normals(const PoolVector<int>&, const PoolVector<Vector3>&, PoolVector<Vector3>&)' defined but not used [-Wunused-function]
editor/import/editor_import_collada.cpp:524:13: warning: 'void _generate_tangents_and_binormals(const PoolVector<int>&, const PoolVector<Vector3>&, const PoolVector<Vector3>&, const PoolVector<Vector3>&, PoolVector<float>&)' defined but not used [-Wunused-function]
editor/pvrtc_compress.cpp:118:13: warning: 'void _compress_etc(Image*)' defined but not used [-Wunused-function]
modules/etc/image_etc.cpp:89:13: warning: 'void _decompress_etc1(Image*)' defined but not used [-Wunused-function]
modules/etc/image_etc.cpp:93:13: warning: 'void _decompress_etc2(Image*)' defined but not used [-Wunused-function]
modules/gdscript/editor/gdscript_highlighter.cpp:46:13: warning: 'bool _is_whitespace(CharType)' defined but not used [-Wunused-function]
scene/2d/cpu_particles_2d.cpp:510:14: warning: 'float rand_from_seed_m1_p1(uint32_t&)' defined but not used [-Wunused-function]
scene/3d/cpu_particles.cpp:474:14: warning: 'float rand_from_seed_m1_p1(uint32_t&)' defined but not used [-Wunused-function]
scene/resources/default_theme/default_theme.cpp:123:20: warning: 'Ref<Shader> make_shader(const char*, const char*, const char*)' defined but not used [-Wunused-function]
scene/resources/default_theme/default_theme.cpp:130:24: warning: 'Ref<BitmapFont> make_font(int, int, int, int, const int*, const Ref<Texture>&)' defined but not used [-Wunused-function]
```

Had to split `core/io/zip_io.h` into header and .cpp file without 'static' keyword.

Not fixed yet (static definition in header used in some files but not all):
```
modules/websocket/lws_helper.h:111:13: warning: 'void _lws_make_protocols(void*, int (*)(lws*, lws_callback_reasons, void*, void*, size_t), PoolVector<String>, _LWSRef**)' defined but not used [-Wunused-function]
```

Also fixed a couple other warnings missed in previous commits.
2018-09-29 22:26:12 +02:00
Paulb23
f08eead3a2 Fix code folding taking into account empty lines, issue 15689 2018-09-29 18:08:56 +01:00
Rémi Verschelde
3a2ca68af3 SCons: Build thirdparty code in own env, disable warnings
Also remove unnecessary `Export('env')` in other SCsubs,
Export should only be used when exporting *new* objects.
2018-09-28 14:07:39 +02:00
Rémi Verschelde
c45ef38004
Merge pull request #22384 from DualMatrix/hover_pressed
Added hover_pressed style to CheckBox and CheckButton
2018-09-28 10:54:02 +02:00
Rémi Verschelde
28c6837219
Merge pull request #22381 from DualMatrix/range_exp_warning
Added warning when min_value of range <= 0 while exp_edit is true.
2018-09-28 10:53:24 +02:00
Rémi Verschelde
a5017f925f
Merge pull request #22405 from DualMatrix/better_step
Fixed step value not being respected for ranges in some cases.
2018-09-28 10:38:33 +02:00
Rémi Verschelde
c7e646c30a
Merge pull request #22447 from akien-mga/fix-warnings-Wswitch
Fix warnings about unhandled enum value in switch [-Wswitch]
2018-09-28 09:47:29 +02:00
elasota
9cf689183d Fix some wchar_t truncations 2018-09-28 00:31:15 -04:00
Rémi Verschelde
7b081a7fc8 Fix warnings about unhandled enum value in switch [-Wswitch]
Fixes GCC 5 warnings of the form:

core/io/http_client.cpp:288:9: warning: enumeration value 'STATUS_SSL_HANDSHAKE_ERROR' not handled in switch [-Wswitch]
core/io/marshalls.cpp:806:9: warning: enumeration value 'AABB' not handled in switch [-Wswitch]

Those can be trivial cases where adding a default fallback is the solution,
or more complex issues/hidden bugs where missed values are actually meant
to be handled.
2018-09-27 18:34:30 +02:00
Rémi Verschelde
cdc411fd54 Fix various warnings: [-Waddress], [-Wpointer-arith], [-Wwrite-strings], [-Wreturn-local-addr] and more
Fixes the following GCC 5 warnings:
```
core/os/file_access.cpp:49:19: warning: the address of 'FileAccess::create_func' will always evaluate as 'true' [-Waddress]
servers/audio_server.cpp:192:70: warning: comparison with string literal results in unspecified behaviour [-Waddress]

drivers/gles2/rasterizer_storage_gles2.cpp:4095:90: warning: NULL used in arithmetic [-Wpointer-arith]

modules/gdnative/register_types.cpp:237:3: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]
platform/android/export/export.cpp:207:1: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]

modules/gdscript/gdscript.h:150:67: warning: returning reference to temporary [-Wreturn-local-addr]
servers/physics_2d/collision_object_2d_sw.h:119:56: warning: returning reference to temporary [-Wreturn-local-addr]
servers/physics_2d/collision_object_2d_sw.h:123:56: warning: returning reference to temporary [-Wreturn-local-addr]
servers/physics_2d/collision_object_2d_sw.h:127:50: warning: returning reference to temporary [-Wreturn-local-addr]
servers/physics_2d/collision_object_2d_sw.h:131:52: warning: returning reference to temporary [-Wreturn-local-addr]

editor/plugins/skeleton_editor_plugin.cpp:34:36: warning: extra tokens at end of #include directive
modules/bullet/bullet_types_converter.cpp:31:9: warning: #pragma once in main file

editor/import/editor_scene_importer_gltf.cpp:1996:51: warning: name lookup of 'i' changed
modules/visual_script/visual_script_property_selector.cpp:402:45: warning: name lookup of 'E' changed
scene/gui/tree.cpp:1268:25: warning: name lookup of 'i' changed
scene/resources/visual_shader.cpp:808:32: warning: name lookup of 'i' changed
```
2018-09-27 16:33:52 +02:00
Rémi Verschelde
d95bbb8922 Fix warnings about set but unused variables [-Wunused-but-set-variable]
Fixes the following GCC 5 warnings:
```
drivers/gles2/rasterizer_canvas_gles2.cpp:814:8: warning: variable 'rt_size' set but not used [-Wunused-but-set-variable]
drivers/gles2/rasterizer_scene_gles2.cpp:2270:11: warning: variable 'vp_height' set but not used [-Wunused-but-set-variable]
drivers/gles2/rasterizer_scene_gles2.cpp:2673:22: warning: variable 'e' set but not used [-Wunused-but-set-variable]
drivers/gles2/rasterizer_scene_gles2.cpp:715:7: warning: variable 'no_cull' set but not used [-Wunused-but-set-variable]
drivers/gles2/shader_gles2.cpp:693:14: warning: variable 'cc' set but not used [-Wunused-but-set-variable]
drivers/gles3/rasterizer_canvas_gles3.cpp:1226:8: warning: variable 'rt_size' set but not used [-Wunused-but-set-variable]
drivers/gles3/rasterizer_scene_gles3.cpp:3039:10: warning: variable 'contrib' set but not used [-Wunused-but-set-variable]
drivers/gles3/rasterizer_scene_gles3.cpp:4504:32: warning: variable 'vp_height' set but not used [-Wunused-but-set-variable]
editor/editor_inspector.cpp:272:9: warning: variable 'guide_color' set but not used [-Wunused-but-set-variable]
editor/editor_themes.cpp:1067:14: warning: variable 'alpha3' set but not used [-Wunused-but-set-variable]
editor/editor_themes.cpp:263:8: warning: variable 'script_bg_color' set but not used [-Wunused-but-set-variable]
editor/plugins/collision_shape_2d_editor_plugin.cpp:326:11: warning: variable 'cpoint' set but not used [-Wunused-but-set-variable]
editor/plugins/mesh_editor_plugin.cpp:72:9: warning: variable 'size' set but not used [-Wunused-but-set-variable]
editor/plugins/shader_editor_plugin.cpp:471:12: warning: variable 'mpos' set but not used [-Wunused-but-set-variable]
editor/plugins/shader_editor_plugin.cpp:89:8: warning: variable 'basetype_color' set but not used [-Wunused-but-set-variable]
editor/plugins/shader_editor_plugin.cpp:90:8: warning: variable 'type_color' set but not used [-Wunused-but-set-variable]
editor/plugins/shader_editor_plugin.cpp:92:8: warning: variable 'string_color' set but not used [-Wunused-but-set-variable]
modules/visual_script/visual_script_editor.cpp:2521:7: warning: variable 'seq_connect' set but not used [-Wunused-but-set-variable]
platform/android/export/export.cpp:580:12: warning: variable 'styles_count' set but not used [-Wunused-but-set-variable]
platform/android/export/export.cpp:584:12: warning: variable 'styles_offset' set but not used [-Wunused-but-set-variable]
platform/osx/export/export.cpp:464:9: warning: variable 'zerr' set but not used [-Wunused-but-set-variable]
scene/2d/tile_map.cpp:260:10: warning: variable 'tcenter' set but not used [-Wunused-but-set-variable]
scene/3d/light.cpp:166:7: warning: variable 'editor_ok' set but not used [-Wunused-but-set-variable]
scene/3d/navigation.cpp:566:11: warning: variable 'closest_navmesh' set but not used [-Wunused-but-set-variable]
scene/gui/rich_text_label.cpp:869:8: warning: variable 'size' set but not used [-Wunused-but-set-variable]
scene/main/viewport.cpp:705:14: warning: variable 'xform' set but not used [-Wunused-but-set-variable]
scene/main/viewport.cpp:706:8: warning: variable 'ss' set but not used [-Wunused-but-set-variable]
scene/main/viewport.cpp:726:14: warning: variable 'xform' set but not used [-Wunused-but-set-variable]
scene/main/viewport.cpp:727:8: warning: variable 'ss' set but not used [-Wunused-but-set-variable]
scene/resources/material.cpp:430:7: warning: variable 'using_world' set but not used [-Wunused-but-set-variable]
servers/visual/shader_language.cpp:2026:7: warning: variable 'all_const' set but not used [-Wunused-but-set-variable]
servers/visual/visual_server_scene.cpp:1383:28: warning: variable 'z_max_cam' set but not used [-Wunused-but-set-variable]
```

Also fixes two [-Wunused-value] warnings:
```
scene/gui/text_edit.cpp:4405:20: warning: statement has no effect [-Wunused-value]
servers/visual/visual_server_scene.cpp:905:48: warning: value computed is not used [-Wunused-value]
```

Some of those are bugs and need further work, they are identified with
`// FIXME` comments.
2018-09-27 16:25:24 +02:00
Rémi Verschelde
cda5b0bfe1 Fix warnings about unused variables [-Wunused-variable]
Fixes the following GCC 5 warnings:
```
drivers/gles2/rasterizer_scene_gles2.cpp:1139:15: warning: unused variable 'offset' [-Wunused-variable]
drivers/gles2/rasterizer_scene_gles2.cpp:1205:39: warning: unused variable 'multi_mesh' [-Wunused-variable]
drivers/gles2/rasterizer_storage_gles2.cpp:359:7: warning: unused variable 'srgb' [-Wunused-variable]
drivers/gles2/shader_gles2.cpp:1016:45: warning: unused variable 'texture_hints' [-Wunused-variable]
editor/animation_track_editor.cpp:776:9: warning: unused variable 'keys_to' [-Wunused-variable]
editor/editor_inspector.cpp:273:7: warning: unused variable 'vs_height' [-Wunused-variable]
editor/editor_themes.cpp:202:10: warning: unused variable 'begin_time' [-Wunused-variable]
editor/editor_themes.cpp:239:10: warning: unused variable 'end_time' [-Wunused-variable]
editor/plugins/animation_blend_tree_editor_plugin.cpp:726:17: warning: unused variable 'an' [-Wunused-variable]
editor/plugins/script_text_editor.cpp:1278:8: warning: unused variable 'fold_state' [-Wunused-variable]
main/main.cpp:132:13: warning: 'use_vsync' defined but not used [-Wunused-variable]
modules/cvtt/image_compress_cvtt.cpp:231:8: warning: unused variable 'y_end' [-Wunused-variable]
modules/cvtt/image_compress_cvtt.cpp:311:6: warning: unused variable 'shift' [-Wunused-variable]
modules/gdscript/gdscript_editor.cpp:58:7: warning: unused variable 'th' [-Wunused-variable]
modules/gridmap/grid_map.cpp:1084:6: warning: unused variable 'ofs' [-Wunused-variable]
modules/theora/video_stream_theora.cpp:442:9: warning: unused variable 'tr' [-Wunused-variable]
modules/visual_script/visual_script_editor.cpp:2606:6: warning: unused variable 'count' [-Wunused-variable]
modules/visual_script/visual_script_editor.cpp:2829:6: warning: unused variable 'seq_count' [-Wunused-variable]
modules/visual_script/visual_script_editor.cpp:2844:24: warning: unused variable 'vnode_function' [-Wunused-variable]
modules/websocket/lws_peer.cpp:122:12: warning: unused variable 'peer_data' [-Wunused-variable]
modules/websocket/lws_peer.cpp:135:12: warning: unused variable 'peer_data' [-Wunused-variable]
modules/websocket/lws_peer.cpp:63:12: warning: unused variable 'peer_data' [-Wunused-variable]
modules/websocket/lws_peer.cpp:91:12: warning: unused variable 'peer_data' [-Wunused-variable]
platform/android/export/export.cpp:763:16: warning: unused variable 'node_size' [-Wunused-variable]
scene/gui/rich_text_label.cpp:850:10: warning: unused variable 'x_ofs' [-Wunused-variable]
scene/gui/text_edit.cpp:653:8: warning: unused variable 'tab_w' [-Wunused-variable]
scene/resources/bit_mask.cpp:186:6: warning: unused variable 'i' [-Wunused-variable]
scene/resources/mesh.cpp:549:20: warning: '_array_name' defined but not used [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:107:10: warning: unused variable 'v2' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:108:10: warning: unused variable 'v3' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:109:10: warning: unused variable 'v4' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:110:10: warning: unused variable 'v5' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:111:10: warning: unused variable 'v0n' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:112:10: warning: unused variable 'v1n' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:113:10: warning: unused variable 'v2n' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:114:10: warning: unused variable 'v3n' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:115:10: warning: unused variable 'v4n' [-Wunused-variable]
servers/audio/audio_rb_resampler.cpp:116:10: warning: unused variable 'v5n' [-Wunused-variable]
servers/visual/default_mouse_cursor.xpm:2:21: warning: 'default_mouse_cursor_xpm' defined but not used [-Wunused-variable]
```
2018-09-27 16:25:24 +02:00
Rémi Verschelde
d8b30d42f5 Fix warnings for operator precedence disambiguation [-Wparentheses]
Fixes the following GCC 5 warnings:
```
core/io/resource_format_binary.cpp:1721:29: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
core/typedefs.h:108:24: warning: suggest parentheses around comparison in operand of '!=' [-Wparentheses]
editor/plugins/spatial_editor_plugin.cpp:2202:58: warning: suggest parentheses around comparison in operand of '!=' [-Wparentheses]
editor/plugins/spatial_editor_plugin.cpp:5002:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
main/input_default.cpp:346:59: warning: suggest parentheses around '-' inside '<<' [-Wparentheses]
main/input_default.cpp:348:60: warning: suggest parentheses around '-' inside '<<' [-Wparentheses]
main/input_default.cpp:579:57: warning: suggest parentheses around '-' inside '<<' [-Wparentheses]
modules/gridmap/grid_map_editor_plugin.cpp:613:14: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
modules/theora/video_stream_theora.cpp:335:34: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses]
modules/theora/video_stream_theora.cpp:336:35: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses]
modules/visual_script/visual_script_property_selector.cpp:215:38: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
scene/gui/rich_text_label.cpp:424:84: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
scene/gui/rich_text_label.cpp:512:80: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
scene/gui/scroll_container.cpp:173:36: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
scene/gui/scroll_container.cpp:173:86: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
scene/gui/tree.cpp:1419:98: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
```
2018-09-27 10:29:48 +02:00
Rémi Verschelde
ea63c9a870 Inspector: Enable wrap for multiline text widget
Fixes #22458.
2018-09-27 09:09:47 +02:00
Hugo Locurcio
c4770a5b5d
Tweak some editor texts' capitalization, use "Go to" instead of "Goto"
This also fixes a typo in the `debugger/debug_with_external_editor`
shortcut.
2018-09-25 22:51:13 +02:00
DualMatrix
16cac24c9d Fixed pivot tool not setting position of Controls correctly
Fixed pivot tool not setting position of Controls correctly
2018-09-25 21:20:03 +02:00
DualMatrix
4980ae5632 Made ColorPicker save it's presets while in editor.
Made ColorPicker save it's presets while in editor.
2018-09-24 19:32:36 +02:00
DualMatrix
98395f652c Fixed step value not being respected for ranges in some cases.
Fixed step value not being respected for ranges in some cases.
2018-09-24 18:09:00 +02:00
DualMatrix
99e3309296 Added hover_pressed style to CheckBox and CheckButton
Added hover_pressed style to CheckBox and CheckButton.
If no style is defined for this property it will default to the pressed property.
2018-09-24 02:31:03 +02:00
Michael Alexsander Silva Dias
d959e2ce78 Add proper strikethrough BBCode to RichTextLabel 2018-09-23 16:25:43 -03:00
DualMatrix
e78bfe19a7 Added warning when min_value of range is smaller than 0 while exp_edit is true.
Added warning when min_value of range is smaller than 0 while exp_edit is true.

The new warning is: "If exp_edit is true min_value must be > 0."
2018-09-23 20:59:35 +02:00
DualMatrix
f483460e38 Removed obsoleted core/helper/value_evaluator.h and moved math_fieldwise to core/math/
Removed obsoleted core/helper/value_evaluator.h and moved math_fieldwise to core/math/
2018-09-23 14:58:15 +02:00
Michael Alexsander Silva Dias
622bae393b Make EditorFileDialog be able to pick a folder when entering it 2018-09-21 19:42:06 -03:00
Rémi Verschelde
561a7772c6
Merge pull request #22198 from DualMatrix/input_was_eaten
Fixed ctrl+up/down shortcut no longer working in scene tree
2018-09-20 15:54:54 +02:00
DualMatrix
f8ead1a2ee Fixed ctrl+up/down shortcut no longer working in scene tree
Fixed ctrl+up/down shortcut no longer working in scene tree.
2018-09-20 15:27:37 +02:00
Guilherme Felipe
b0b88df016 Fix Label::get_minimum_size not updating cache size for autowrap 2018-09-19 14:05:44 -03:00
Rémi Verschelde
c25e23317c Rename ScrollBar's drag_slave to drag_node 2018-09-15 00:55:22 +02:00
Alexey Kashlakov
1e65916241
Discard button pressing flags on disable
Is it a bug?
1) Click the button and hold
2) Disable it (for example I bind this action on keyboard)
3) Release the mouse and move it outside the button
4) Enable the button
5) It's still pressed, but shouldn't
2018-09-14 14:21:58 +07:00
Rémi Verschelde
4ae78987b7
Merge pull request #22017 from YeldhamDev/errors_tab_changes
Add expand/collapse all buttons for the "Errors" tab
2018-09-13 11:21:31 +02:00
Rémi Verschelde
1a16dabfb5
Merge pull request #21982 from luzpaz/misc-typos
Misc. typos
2018-09-13 10:59:00 +02:00
Michael Alexsander Silva Dias
3a9df46b90 Add expand/collapse all buttons for the "Errors" tab 2018-09-12 23:53:10 -03:00
luz.paz
08bde5b2de Misc. typos
Found via `codespell -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"`
2018-09-12 21:39:17 -04:00
Guilherme Felipe
51e854846e Fix default_cursor_shape for TextEdit 2018-09-12 13:26:51 -03:00
Rémi Verschelde
06667b2fcf
Merge pull request #21219 from AlexHolly/fix-textedit-shows-nothing
TextEdit update cache.size on ENTER_TREE
2018-09-12 17:41:12 +02:00
Rémi Verschelde
82a0e752df
Merge pull request #21877 from DualMatrix/richlabel
Fixed the remove_line function in richtextlabel. It was totally broken
2018-09-12 14:59:34 +02:00
Rémi Verschelde
ead2c2eef2
Merge pull request #21705 from KellyThomas/tree-create-item
Change return value of Tree.create_item() from Object to TreeItem
2018-09-12 10:57:50 +02:00