Commit graph

25734 commits

Author SHA1 Message Date
asynts 71b4b180ba Prevent crash described in #34555.
Normally it wouldn't be possible to click on the "Connect" button if no node
is selected, because the button would be disabled.

However, double clicking on a node is also hooked up to the same signal
and double clicking is possible even if the "Connect" button is disabled.

This caused a crash described in #34555.
2020-01-14 17:02:18 +01:00
Rémi Verschelde dc0f43a1c2
Merge pull request #35117 from timothyqiu/deferred
Makes adding port in Visual Script nodes deferred
2020-01-14 14:41:53 +01:00
Haoyu Qiu ddde73cc62 Makes adding port in Visual Script nodes deferred 2020-01-14 21:03:09 +08:00
Rémi Verschelde ea4c88f38a
Merge pull request #35116 from YeldhamDev/more_scrollbar_tweaks
Fix more scrollbar anchorings
2020-01-14 13:55:34 +01:00
Rémi Verschelde 0a8879c1b8
Merge pull request #35101 from KoBeWi/randocs_the_sequel
Complete documentation of some more classes
2020-01-14 13:37:59 +01:00
Tomasz Chabora c09b9c488f Complete documentation of some more classes 2020-01-14 13:19:39 +01:00
Rémi Verschelde 4d3acbcb3a
Merge pull request #35114 from timothyqiu/macos-ime
Fixes IME input backspace on macOS
2020-01-14 13:06:03 +01:00
Haoyu Qiu bda9145aae Fixes IME input backspace on macOS 2020-01-14 19:41:42 +08:00
Michael Alexsander e69593842e Fix more scrollbar anchorings 2020-01-14 08:25:55 -03:00
Rémi Verschelde 2f1be121b7
Merge pull request #35113 from akien-mga/aint-no-peeking-for-command-lurkers
Export: Properly disable resource preview thread
2020-01-14 12:13:28 +01:00
Rémi Verschelde a565c93aeb Export: Properly disable resource preview thread
Fixes #26857.
Fixes #34433.
Fixes #34826.
2020-01-14 11:34:02 +01:00
Rémi Verschelde dbbfade584
Merge pull request #35082 from akien-mga/dont-count-yer-chicken
EditorNode: Delay addon init to NOTIFICATION_READY
2020-01-14 08:26:08 +01:00
Rémi Verschelde 870ec61417
Merge pull request #35092 from AndreaCatania/frames_exp
Exposed physics frame count and idle frame count
2020-01-14 08:25:46 +01:00
Rémi Verschelde 63112b5090
Merge pull request #35106 from YeldhamDev/scrollbar_overlap_fixes
Fix more instances of overlapping scrollbars
2020-01-14 08:12:20 +01:00
Rémi Verschelde 6a9b38741f
Merge pull request #35105 from timothyqiu/center-container-min-size
Updates min size on CenterContainer::set_use_top_left
2020-01-14 08:11:34 +01:00
Rémi Verschelde ebf28c942f
Merge pull request #35088 from akien-mga/object-disconnect-was-safe-enough
Object: Remove error on disconnect of locked signals
2020-01-14 07:53:30 +01:00
Michael Alexsander 712cd8a97e Fix more instances of overlapping scrollbars 2020-01-13 22:49:17 -03:00
Haoyu Qiu 66a54582ee Updates min size on CenterContainer::set_use_top_left 2020-01-14 08:35:21 +08:00
Rémi Verschelde 0aeb5bbf62 Object: Avoid error on emit_signal with freed target
As advised by @reduz.
2020-01-13 22:20:18 +01:00
Rémi Verschelde 34ad33d9e0
Merge pull request #35099 from neikeq/sync-visual-server-after-script-server-finish
Sync pending VisualServer commands after ScriptServer finalization
2020-01-13 22:13:29 +01:00
Rémi Verschelde f06372cb73
Merge pull request #35097 from neikeq/issue-34954
Mono/C#: Fix _update_exports() leaking temporary Object/Node instances
2020-01-13 22:01:11 +01:00
Ignacio Etcheverry d5122ab31c Sync pending VisualServer commands after ScriptServer finalization
This is needed as C# may free resources from the finalizer thread during
CSharpLanguage::finish(). Previously this would result in RIDs not being freed.
2020-01-13 21:46:44 +01:00
Ignacio Etcheverry a6a5ef0fd6 Mono/C#: Add error checks to detect possible Reference leaks 2020-01-13 21:00:07 +01:00
Ignacio Etcheverry ea737db43c Mono/C#: Fix _update_exports() leaking temporary Object/Node instances 2020-01-13 20:58:46 +01:00
George Marques 1d129f9bec
GDScript: Check function arguments on release too
Needed because otherwise the certain type operations (such as type
casting) used as a function argument might become unresolved on release,
causing a compilation failure.

Fix #28680
2020-01-13 15:58:53 -03:00
Andrea Catania 9c60502357 Exposed physics frame count and idle frame count 2020-01-13 17:53:10 +01:00
Rémi Verschelde f38bfccf42 Object: Remove error on disconnect of locked signals
According to 22637beb2e (commitcomment-36651823)
and as confirmed by @reduz, this seems not to be necessary now that we
copy-on-write.

This triggered freeze scenarios in cases where a node would be deleted
while being used as a target in a signal emission.

Fixes #34650.
Fixes #34769.

Now those two errors go back to reporting:
```
ERROR: emit_signal: Condition ' !target ' is true. Continuing..:
   At: core/object.cpp:1191.
```
2020-01-13 17:03:02 +01:00
Rémi Verschelde 031b5455ae
Merge pull request #35083 from akien-mga/squish-s3tc-compress-in-template
Image: Include S3TC compression via Squish in non-tools build
2020-01-13 16:21:30 +01:00
Rémi Verschelde 04a1ae90df
Merge pull request #35080 from malbach/scrollbars_overlap
Fix #33309 Overlapping Scrollbars in ScrollContainer
2020-01-13 16:10:12 +01:00
Rémi Verschelde c7b701dfd2 Image: Include S3TC compression via Squish in non-tools build
We already build Squish in templates build for S3TC decompression,
so we can as well expose the compression feature.

Fixes #25640.
2020-01-13 15:58:49 +01:00
Rémi Verschelde 1cf387ed9d
Merge pull request #35079 from akien-mga/managers-dont-build-solutions
Ignore command line --build-solutions when not editing project
2020-01-13 15:08:31 +01:00
Rémi Verschelde 017b7de2df EditorNode: Delay addon init to NOTIFICATION_READY
Fixes #25635.
2020-01-13 15:02:11 +01:00
malbach bc8ce836e3 Fix overlapping scrollbars in ScrollContainer (#33309) 2020-01-13 14:37:55 +01:00
Rémi Verschelde d88103172c Ignore command line --build-solutions when not editing project
This option is meant to use together with `--path` or from a project
folder. Otherwise the project manager is opened and the option triggers
a crash.

Fixes #25589.
2020-01-13 14:00:47 +01:00
Rémi Verschelde 087ffc8b5a
Merge pull request #35078 from akien-mga/animation-editor-duplicate-name
Animation editor: Set resource name when duplicating
2020-01-13 14:00:37 +01:00
Rémi Verschelde 57e43af3a2
Merge pull request #35075 from AlexHolly/fix-double_tap-regression
fixes android double tap regression
2020-01-13 13:43:43 +01:00
Rémi Verschelde c72b5dc0bc
Merge pull request #35073 from akien-mga/zero-scale-shall-not-pass
Control/Light2D: Preventing setting 0 as scale as for Node2D
2020-01-13 13:38:08 +01:00
Rémi Verschelde 4a95186b4b Animation editor: Set resource name when duplicating
Fixes #25156.
2020-01-13 13:22:06 +01:00
Rémi Verschelde e32d232053
Merge pull request #35076 from vnen/gdscript-type-match-assign
Type match on assignment only if operators have type
2020-01-13 13:14:57 +01:00
Rémi Verschelde 854a7bd9bb
Merge pull request #35074 from GodotExplorer/lsp-fix-34147
Fix infinite loop error in document link parsing of GDScript Language Server
2020-01-13 13:05:39 +01:00
George Marques e6060706ca
GDScript: Type match on assignment only if operators have type
This ensures that a value without type won't be wrongly assigned to a
typed variable when the types mismatch.
2020-01-13 08:51:24 -03:00
Alexander Holland dd2fd4e853 fixes android double tap regression 2020-01-13 12:46:33 +01:00
Rémi Verschelde 33be750634
Merge pull request #35072 from Calinou/2d-zoom-clamp-editor-scale
Clamp the editor scale to 1 for 2D zoom operations
2020-01-13 12:28:28 +01:00
Geequlim d5e1890c85 Fix infinite loop error in document link parsing 2020-01-13 19:23:29 +08:00
Rémi Verschelde 100f50b7df Control/Light2D: Preventing setting 0 as scale as for Node2D
Triggers errors in `Transform2D::affine_invert()`.

Fixes #26510.
Fixes https://github.com/godotengine/godot/issues/24997#issuecomment-457951639.
2020-01-13 12:20:15 +01:00
Hugo Locurcio 929dfe1bcc
Clamp the editor scale to 1 for 2D zoom operations
Some people set the editor scale below 1 to fit more content on
screen, even if their display doesn't have a particularly low DPI.

This closes #35059.
2020-01-13 12:16:27 +01:00
Rémi Verschelde 52f44e72b6
Merge pull request #35070 from akien-mga/revert-34968
Revert "Enable Vsync via Compositor by default"
2020-01-13 10:13:17 +01:00
Rémi Verschelde ab97f78fa5 Revert "Enable Vsync via Compositor by default"
This reverts commit 9600fd5dde.

Add comment warning about possible implications of using this option.

Fixes #35038.
2020-01-13 09:33:27 +01:00
Rémi Verschelde 7a15569c6f
Merge pull request #35050 from Calinou/enlarge-item-list-editor
Increase the size of the item list editor popup
2020-01-13 09:14:02 +01:00
Rémi Verschelde 8130decfe4
Merge pull request #35064 from clayjohn/rendering_crashes
Fix light and multimesh crashes
2020-01-13 09:13:18 +01:00