Commit graph

339 commits

Author SHA1 Message Date
Luke Elmers c6afc47f32
Remove data <--> expressions circular dependencies. (#82685) 2020-11-09 13:01:22 -07:00
Marco Liberati 97e2dc853b
[Lens] Extend Datasource props validation with VisualizationGroups (#82607)
*  First pass with visualization validation + error messages

* 🔥 Remove indexpattern error handling for now

* 🏷️ Fix type issues

*  Add getErrorMessage test for data table

*  Add tests for pie and metric error messages

* 🌐 Fix i18n checks issues

* 🐛 Fix last issue

*  Add more tests for the XY visualization validation code

* 👌 Included all feedback from first review

* ✏️ Off by one message

* 🌐 Fix i18n duplicate id

* 🌐 Fix last i18n issue

* 🐛 Fixed a hook reflow issue

* ♻️+ Reworked validation flow + tests

* 🏷️ Fix type issue

* 🐛 Improved XY corner cases validation logic

* 🐛 Fix empty datatable scenario

*  +  Improved error messages for invalid datasources + tests

* 🌐 Add missing i18n translation

* 🏷️ Fix type issues

* 🌐 Fix i18n issues

*  Filter out suggestions which fail to build

* 🚚 Migrate datatable validation logic to the building phase, handling it as building state

* 🏷️ Fix type issue

* ✏️ Add comment for future enhancements

* ✏️ Updated comment

* :world_with_meridians: Refactor axis labels

* 🌐 Reworked few validation messages

* 🐛 Fix break down validation + percentage charts

*  Align tests with new validation logic

* ♻️ Fix suggestion panel validation to match main panel

* 🌐 Fix i18n issues

* 🔧 Fix some refs for validation checks in suggestions

* 🐛 Fix missing key prop in multiple errors scenario

* 🐛 Fix swtich issue from XY to partition

* 🌐 Fix i18n messages and aligned tests

* 🐛 Fix suggestions switching bug

* :refactor: Add more validation + refactored validation logic in a single place

* ✏️ Add note about lint hooks disable rule

* 🚨 Fix linting issue

* 🏗️ Add infra API for datasource advanced validation

*  Align tests with new API

*  Fix type issues in tests

* 👌 Early exists added

*  Add layers groups to the API

*  Fix some broken test after the validation change

* 👌 Move to disctionary shape

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-09 15:22:21 +01:00
Joe Reuter 651345b18b
[Lens] Expose active data in some places (#79851) 2020-11-06 17:05:34 +01:00
Stratoula Kalafateli 5710f6763b
[Visualize] New visualization wizard (#79627)
* [Visualizations] New vis wizard

* Update functional tests

* Create oss plugins for maps and lens and unregister alias function

* Add new plugins to .i18nrc.json

* Add readme and codeowners to the new plugins

* update docs

* fix tests

* fix types

* fixes

* Update development docs

* fix oss functional tests

* Fix jest and x-pack functional tests

* Fix functional test

* changes on the layout

* Cleanup and responsiveness

* cleanup unecessary code

* add common folder to the new OSS plugins

* remove unecessary translations

* Update limits.yml file

* Fix basic label

* Add experimental badge on controls vis

* Nice improvements

* fixes

* Improving styles

* Making modal go full height on smaller screens

* Fixing sass lint warning

* fix lint error

* fix internationalization error

* PR fixes

* PR changes

* Use useCallback where possible

* Remove translations that need to be translated again

* Lazy Load wizard modal

* Remove legacyMapVisualizationWarning

* Import the OSS plugins constants from the plugins

* Export constant from lensOss

* Change the new oss plugins from OSS to Oss

* Add a new line to the kibana.json files of the new plugins

* New nit fix

* Fix spaces

* Change the texts for the first step of the modal

* Fix test

* Fixes some of the PR comments

* Add onClick funtionality to the entire aggregation based card

* Cards description changes, introduce a copyFromRoot method to solve the problem of when disabling the x-pack plugic, to also disable the oss

* Create new FTR for testing the functionality of the wizard when both maps and lens apps are disabled

* fix eslint error

* Change groupTitles and descriptions

* Change input vis description

* Remove the copyFromRoot from the signature of the ConfigDeprecationFactory and export it from the main entrypoint

* Make the disabled cards badge clickable

* Changes from code review

* Fix functional tests failures

* Rename groupTitle to titleInWizard to be more specific

* Change vega vis note

* minor design changes

* fix problem with plugins list docs

* Retrieve maps and lens landing page from docs service and add tracking url param

* Fix funtional test for the new dashboard flow

* Fix logic in alias registry for removing the discardOnRegister alias

* no need to remove the alias entry from the discardOnRegister array

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
2020-11-06 18:03:44 +02:00
Marco Liberati d3d3fa7bd2
[Lens] New value labels config option for bar charts (#81776)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-06 16:34:30 +01:00
Wylie Conlon 03ee1a6476
[Lens] Fix bug in terms formatting (#82776) 2020-11-06 09:54:37 -05:00
Joe Reuter 94d0e60706
[Lens] Implement time scaling function (#82104) 2020-11-06 13:47:55 +01:00
Joe Reuter d83167629c
fix underlying data drilldown for Lens (#82737) 2020-11-06 12:18:54 +01:00
Devon Thomson 7c66880a11
[Time to Visualize] Embeddable Error Handling Without ReplacePanel (#82201)
Fixed embeddable error handling so that fatal errors are caught and displayed with an errorEmbeddable no matter when they occur.
2020-11-05 11:11:29 -05:00
Kim S. Ly 52e8d1459c
[Lens] Remove visible title in workspace panel (#82234) 2020-11-05 14:33:56 +01:00
Marco Liberati 53ea09078f
[Lens] Visualization validation and better error messages (#81439)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-04 18:28:00 +01:00
Joe Reuter fe3b0538ff
[Lens] Categorical color palettes (#75309) 2020-11-04 11:27:52 +01:00
Marta Bondyra 6689167b64
[Lens] Drag within dimension group to reorder (#80547) 2020-11-03 21:18:44 +01:00
Joe Reuter d8c37fe890
[Lens] Reload on change via history object (#81753) 2020-11-03 14:29:56 +01:00
Pierre Gayvallet d4b2a5145a
SavedObjects tagging MVP (#79096)
* create xpack plugin skeleton, start to implement management section

* add tag creation modal

* first implementation of the tags table

* use InMemoryTable

* add edit modal and delete action

* update plugin list

* add tag list, fix types

* add capabilities check on client-side

* add tag combo box component

* add missing i18n keys

* fix privilege FTR tests

* add base structure for FTR tests

* fix feature ftr test

* use string literals for i18n

* create savedObjectsTaggingOss plugin, move API types to oss plugin, start to wire to SO management page.

* update plugin list

* fix types

* allow to use `_find` with multiple references

* add FTR test for _find API on references fields

* add _find integration tests

* update generated doc

* start to implement tag filtering on SO management section

* update generated docs

* wire tagging API to dashboard listing page

* fix i18n namespace

* fix type & tests

* update dashboard listing snapshots

* adapt FTR listingTable service to search for parsable queries

* wite tagging API to visualize listing

* update tagging plugin limits

* add server-side and client-side validation for tag create/edit

* rename title field to name

* fix types

* fix types bis

* add removeReferencesTo API to SOR/SOC

* update generated doc

* add server-side unit test for `savedObjectsTagging` plugin

* move tagging API types to its own file

* add savedObjectsTaggingOss mock

* add tags_cache tests

* add tests for client-side tag client

* extract uiApi to distinct files

* various API improvements

* add more tests

* add link between tag and so management sections + add connection counts

* add base functional test suite for tagging

* add more FTR tests

* improve feature control func test

* update codeowners

* update generated doc

* fix access to proxy modal

* adapt SO save modal to allow to add tag field

* add SO decorator registry and tag implementation

* add unit tests for SO tag decorator

* add functional tests for visualize integration

* add tag SO read permission for vis/dash feature

* add RBAC api integ tests

* add API integration tests

* add test for getTagConnectionsUrl

* add SOM test suite

* add dashboard integration suite

* remove test line

* add missing unit tests

* improve API types doc

* fix create modal save button label

* remove console.log

* improve doc

* self review

* add refresh interval for tag cache

* improve page object doc

* minor cleanup

* address review comments

* small layout fixes

* add initial focus

* use lazy accessor for tag request handler context

* adapt SOM export and export route to handle references

* remove icon from feature config due to master changes

* fix SO table tests

* update generated docs

* sort tags by name in filter dropdown and listing component

* wire SO tagging to dashboard save modal

* fix types

* - add 'create tag' action in tag selector
- add notifications on update/create/delete from management
- delete modal wording

* add description max length validation

* remove real-time validation

* fix i18n bundle id

* update expected size of savedObjectsTagging plugin

* use own useIfMounted

* update limit again, contract components cannot be lazy loaded atm.

* math is hard

* remove single usage of lodash for bundle size

* add async imports for create/edit modal

* add FTR test for 'create tag' action from tag selector

* allow 'create new' option to prepopulate name field

* extract savedObjectToTag

* add advancedSettings read user for security api_integ suite

* add audit login for security client wrapper

* use import type when possible

* wire SO tagging to lens visualization

* fix lens jest test

* Fix `create tag` option being selected when closing the selector dropdown

* add sorting to tag column from getTableColumnDef

* address some of restrry comments

* rename tag selector's setSelected option to onTagsSelected

* fix audit logging even type for saved_object_remove_references

* update plugin size limit to current size

* adapt maxlength validation wording

* remove selection column until we have batch action menu

* remove connections link when user lack read privilege to savedObjectManagement

* forbid registering multiple SO decorators with the same priority

* add so decorator test

* extract getTagFindReferences and create API mock

* update audit-logging ascidoc

* doc nit

* throw conflict error if update returns any failure

* use refresh=true as default

* wording nits

* export: rename `references` to `hasReference`

* update generated doc

* set description max length to 100

* do not initialize tag cache on anonymous pages

* split fetchObjectsToExport into two distinct functions

* change tag client `delete` call order

* tsdoc nits

* more nits

* add README for oss plugin

* add oss plugin start tests

* SavedObject.find: rename `references` to `hasReference`

* change section description label

* remove url prefix constants

* last nits and comments

* update generated doc
2020-11-03 10:33:18 +01:00
Nathan Reese 97a32fde9f
[lens] fix unhandled promise rejection when saving Lens with duplicate title (#82195)
* [lens] fix unhandled promise rejection when saving Lens with duplicate title

* more clean up

* restore getDisplayName, used by return of checkForDuplicateTitle

* fix jest test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-02 11:35:33 -07:00
Marta Bondyra ba1b20da9f
[Lens] Fix console error by passing I18nProvider to metric vis (#82282)
* [Lens] Fix console error by passing I18nProvider to metric vis

* Update expression.tsx
2020-11-02 19:15:59 +01:00
Devon Thomson 8c1b2157df
[Time to Visualize] Small Attribute Service Fixes (#82072)
* Removed some dashboard-centric wording from the Attribute Service & removed type argument from save method
2020-11-02 11:25:53 -05:00
Greg Thompson 6fdc7eb1fa
Upgrade EUI to v30.1.1 (#81499)
* eui to v30.0.0

* removed unused RecentLinks component

* update compressed -> display prop

* euiformrow compressed -> display

* euipopover remove withtitle

* euibuttongroup prop updates

* remove euibuttontoggle

* src snapshot updates

* tutorial euibuttongroup update

* x-pack snapshot updates

* euibuttongroup test updates

* TODO

* misc. js file updates

* remove euinavdrawer scss references

* translation removals

* more x-pack snapshot updates

* update data-test-subj lookup

* icons logoAMP -> logoObservability

* cypress selector updates

* update euibuttontoggle onchange, test interaction

* Fix auto-update toggle in Visualize

* some more change -> click test updates

* idtoselectedmap change

* Fix feature table button group

* Remove empty SASS file

* Fix feature table button group II

* Using `compressed` to also dictate dual range row

* Fix a few security labels

* An ML fix

* Apply suggestions from code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* remove unused translation

* update view_type_toggle snapshot

* more snapshot updates

* eui to 30.1.0

* undo temp ts-ignore

* more x-pack snapshot updates

* eui to 30.1.1

* update feature privilege text

* Update x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/sub_feature_form.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* reuse i18n token

* Adapt log entry action button to new `minWidth` prop

* clean up label

* Combine auto apply strings into one

* ternary fix

* cases status useCallback

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>
2020-10-30 16:18:27 -06:00
Joe Reuter 512c35e70b
fix Lens heading structure (#81752) 2020-10-30 11:20:54 +01:00
Michael Marcialis 2a38461817
[Lens] Adjust Lens Visualization Padding in Dashboards (#81911)
* reduce padding on lens visualizations in dashboard

* tweak padding and axes title colors to match lens

* remove faux padding (border) to match lens padding

* update snapshots

* Revert "update snapshots"

This reverts commit c63cf2bf1c.

* update functional test baseline screenshot
2020-10-29 16:52:02 -04:00
Anton Dosov 6deafd06b8
[Search] Use session service on a dashboard (#81297) 2020-10-29 16:43:22 +01:00
Joe Reuter 59662eefd2
[Lens] Add loading indicator during debounce time (#80158) 2020-10-29 16:06:12 +01:00
Wylie Conlon b5e3e18ea4
[Lens] Stop using multi-level metrics in Lens pie charts (#81523)
* [Lens] Stop using multi-level metrics in Lens

* Fix linting

* Simplify even more
2020-10-29 10:48:49 -04:00
Marco Liberati 8f92de860c
[Lens] Improved range formatter (#80132)
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2020-10-27 18:08:01 +01:00
Joe Reuter db0816f4a1
[Lens] Fix URL query loss on redirect (#81475) 2020-10-27 11:43:56 +01:00
Joe Reuter ea229891f1
fix flaky unit test (#81466) 2020-10-22 17:12:49 +02:00
Stratoula Kalafateli 4f67c3d00b
[Lens] Rename X/Y axis to horizontal/vertical (#80991)
* [Lens] Rename x/y axis to horizontal/vertical ones

* Change configuratio

* Add unit tests to cover the change

* Change texts to follow EUI guidelines

* Fix the translations ids

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-22 13:13:05 +03:00
Kim S. Ly 08a6ddf25b
[Lens] Add toast notification when visualization is saved (#80788) 2020-10-20 13:46:10 +02:00
Joe Reuter 88a9453500
[Lens] Lazy load lens telementry and attribute service (#80479) 2020-10-19 17:21:25 +02:00
Wylie Conlon f0023ed879
[Lens] Split up dimension panel code (#80423)
* [Lens] Split up dimension panel code

* Fix test failures

* Style updates

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-19 10:51:21 -04:00
Marco Liberati 7b1b36e38d
[Lens] Remove Over time suggestions for numeric intervals (#78442)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-19 14:45:48 +02:00
Peter Pisljar c90dabaeba
removing kibana_datatable in favor of datatable (#80548) 2020-10-16 18:46:51 +02:00
Joe Reuter 52b35f3504
[Lens] Add median operation (#79453) 2020-10-16 16:49:06 +02:00
Joe Reuter 5fd7ad3b34
[Lens] Custom labels for ranges (#79628) 2020-10-14 14:21:27 +02:00
Joe Reuter d508fef5dd
respect requested sub vis type for xy charts (#80297) 2020-10-14 09:56:26 +02:00
spalger 6eeab00944 Revert "removing kibana_datatable in favor of datatable` (#75184)"
This reverts commit 255b865be8.
2020-10-13 08:53:14 -07:00
Peter Pisljar 255b865be8
removing kibana_datatable in favor of datatable` (#75184) 2020-10-13 17:00:38 +02:00
Joe Reuter cd84ace53d
[Lens] Leverage original http request error (#79831) 2020-10-13 15:17:40 +02:00
Maja Grubic 13059bdd8f
[Refactor] Move AttributeService from Dashboard to Embeddable plugin (#79830)
* [Refactor] Move AttributeService from Dashboard to Embeddable plugin

* Fix wrong import

* Fixing typescript errors

* Make Dashboard a required dependency

* Fixing circular dependency

* Fix label namespace

* Updating docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-12 14:51:39 +01:00
Marco Liberati ff80d90626
[Lens] Fix for Percentage and Metric suggestions/visualizations on 0 or empty vlaues (#79309)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-07 10:36:56 +02:00
Marta Bondyra ae84bb2033
[Lens] Improve unclear UI for bucket aggregation grouping order (#77331) 2020-10-07 10:34:48 +02:00
Joe Reuter 018c2bd22f
[Lens] Make histogram brushing possible (#79435) 2020-10-07 10:20:58 +02:00
Marta Bondyra cded1ce5f1
[Lens] Don't debounce visualization settings UI (#79625)
* perf: don't debounce settings menu

* perf: fix performance for settings
2020-10-07 10:17:17 +02:00
Wylie Conlon 2de2c70f75
[Lens] Break long titles into multiple lines (#79580) 2020-10-06 11:50:44 -04:00
Joe Reuter 11886bf51c
[Lens] Add search to chart switcher (#77631) 2020-10-06 17:17:41 +02:00
Stratoula Kalafateli 08a4586b14
[Lens] Navigate from discover to lens (#77873)
* Create lens action and unregister the visualize one

* remove console

* Implement Discover to Lens, wip, missing tests

* Add unit tests

* fix embed lens to empty dashboard functional tests

* fix suggestions on save

* Fix bug on save button, query and filters should be transferred from discover

* Add functional test for the navigation from Discover to Lens

* PR update after code review

* unregister visualize action only if the action exists

* Change the test to not be flaky

* Move suggestions to editor frame and hide the emptyWorkspace for visualize field

* Update ui actions docs

* Add a retry to remove test flakiness

* Fix bug of infinite loader when removing the y axis dimension

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 11:15:41 +03:00
Maja Grubic 989e9c9702
Refactor attribute service (#78414)
* Making saveMethod mandatory in attribute service

* Making unwrap method mandatory

* Making book embeddable respect new attribute service

* Remove savedObjectsClient from attribute service

* Add checkForDuplicateTitle method to book embeddable

* Make options mandatory on attribute service

* Changing Lens attribute service

* Somw more typescript fixes

* Fixing attribute service typescript and tests

* Fixing typescript errors

* Unsetting feature flag

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 08:31:55 +01:00
Marta Bondyra f663743d78
[Lens] fix empty callout for empty/meta fields accordion (#79429) 2020-10-05 23:07:07 +02:00
Marta Bondyra ce97982522
[Lens] refactor DimensionContainer and fix flyout bug (#79277) 2020-10-05 12:41:09 +02:00
Joe Reuter b66de2ce1d
improve lens lazy loading (#79292) 2020-10-02 21:50:25 +02:00
Nick Partridge e9fd3902c5
upgrade @elastic/charts to v23.0.0 (#79226)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-02 19:48:40 +02:00
Ryan Keairns d9915fdee0
Re-style and re-order top menu buttons (#79206)
* Re-style and re-order top menu buttons

* Update snapshot due to removed fill prop

* Fix link order for Maps
2020-10-02 11:47:20 -05:00
Marco Liberati d679624532
[Lens] Fix open custom ranges saved issue (#78915)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-02 18:41:40 +02:00
Marta Bondyra fccfad24cb
[Lens] remove test warnings about improper HTML structure (#79251)
* [Lens] remove test warnings about improper HTML structure
2020-10-02 17:18:20 +02:00
PavithraCP 94ef651d7b
[Lens]Do not enable histogram mode for multiple un-stacked bar series (#78525) 2020-10-02 13:16:46 +02:00
Marco Liberati 198c5d9988
[Lens] Fix embeddable title and description for reporting and dashboard tooltip (#78767)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 18:02:37 +02:00
Caroline Horn e248f32111
[Lens] Consistent Drag and Drop styles (#78674)
* Remove wrapping div of DragDrop and pass props to child
* Using EuiHighlight
* Basic styles in for all DnD states
* Fixing dimension button styles
* Fix FieldButton to accept `…rest` props
* A few other minor fixes
* Fixed horizontal scroll of error message
* Quick fix for invalid link
2020-10-01 11:58:23 -04:00
Marco Liberati d793040082
[Lens] Histogram/range operation new copy (#78328)
* 💬 New copy revision for histogram/range operation in lens

* 👌 Updated panel copy

* 👌 Change copy based on feedback
2020-10-01 14:25:59 +02:00
Joe Reuter 8d7f2d0828
[Lens] Handle missing fields gracefully (#78173) 2020-10-01 13:39:10 +02:00
Marta Bondyra 8948811c63
fix: add EuiOutsideClickDetector (#78733)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 12:54:48 +02:00
Marta Bondyra d11da3275d
[Lens] Don't allow values outside of range for number of top values (#78734) 2020-10-01 12:54:40 +02:00
Marta Bondyra 3e7fb9352d
[Lens] fix wrong message in fields accordion (#78924) 2020-09-30 18:51:18 +02:00
Wylie Conlon 9605e291d8
[Lens] Maintain order of operations in dimension panel (#78864) 2020-09-30 11:38:43 -04:00
Joe Reuter dbef60d3f1
[Lens] Reduce initial bundle size (#78142) 2020-09-29 19:00:29 +02:00
Wylie Conlon 0ebaf92a6a
[Lens] Fieldless operations (#78080)
* [Lens] Fieldless operations

* Overhaul types

* Fix invalid state and add tests

* Fix types

* Small cleanup

* Add additional error message

* Reset field selector to empty state when invalid

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-28 11:22:03 -04:00
Caroline Horn ba635340be
[Lens] Add a better drag/drop illustration (#78245)
Fixes #76021
2020-09-24 09:46:18 -04:00
Joe Reuter 839817ca9a
[Lens] show meta field data in Lens (#77210) 2020-09-24 09:55:32 +02:00
Devon Thomson 32abbff685
[Time to Visualize] Lens By Value With AttributeService (#77561)
Used the attribute service to make lens work properly with by value embeddables.
2020-09-23 17:40:52 -04:00
Joe Reuter 6ebffef9c5
[Lens] Add search provider for global search (#77448) 2020-09-23 17:53:21 +02:00
Alejandro Fernández Haro 75a84ad56f
[Lens] Rename "telemetry" to "stats" (#78125) 2020-09-23 12:50:07 +01:00
Marco Liberati 0f8043ca8d
[Lens] Combined histogram/range aggregation for numbers (#76121)
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-09-23 10:23:55 +02:00
Marta Bondyra 8ce495b6bc
[Lens] adding some functional tests (#77863) 2020-09-18 18:41:22 +02:00
Marta Bondyra eb825db09e
[Lens] change name of custom query to filters (#77725) 2020-09-18 08:43:12 +02:00
Stratoula Kalafateli 3cf41674f5
Aligns the y axis settings on horizontal mode (#77585) 2020-09-17 18:38:43 +03:00
Marta Bondyra ab38cd5f20
[Lens] create reusable component for filters and range aggregation (#77453) 2020-09-16 12:06:00 +02:00
Stratoula Kalafateli c4eb47a46b
[Lens] Settings panel redesign and separate settings per y axis (#76373)
* wip, redsign the xy axis general settings

* pie chart settings. fix tests, initial implementation

* Fix Internationalization

* Cleanup

* remove unused translations

* Add test to check that right axis is enabled

* fix test

* remove unecessary translation

* Added icons and cleaned up some of the visuals for grouped buttons

* Fix types

* Axis Settings Popover Reusable Component

* Legend Popover Reusable Component

* Cleanup unused translations

* Fix right axis behavior

* Revert yLeftTitle to yTitle to avoid migration

* PR fixes

* identify which axis is enabled

* Change the logic on enabling the y axes popovers

* Adjust axis popover on horizontal bars

* fix failing test and change the logic of fetching the y axis titles

* Simpify the axis title logic, make the toolbar repsponsive, add TopAxisIcon

* Ui Changes on legends popover

* Cleanup and more unit tests

* use groupId instead of index to take under consideration all possible scenarios

* fix gridlines

* Remove ts-ignore from icons and move toolbar button to shared components

* Workspace toolbar wraps on smaller devices

* Tooltip on Toolbar appears only if the button is disabled

* clean up

* Add missing translations

* fix eslint

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-16 11:30:19 +03:00
Wylie Conlon e9a4555623
[Lens] Remove dynamic names in telemetry fields (#76988)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-15 18:27:39 -04:00
Joe Reuter 63f0cc0519
[Lens] Stack as percentage (#70703) 2020-09-15 11:24:02 +02:00
Caroline Horn 5a2f7ae897
[Lens] Move configuration popover to flyout (#76046)
* Moving to a Flyout implementation
* Fix up inner layout of flyout
* Fix up form rows
2020-09-14 18:23:13 -04:00
Michail Yasonik 61c4e6fd8d
Stacked headers and navigational search (#72331)
Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-09-14 14:32:30 -05:00
Devon Thomson 003fcb1332
Add Lens to Recently Accessed (#77249)
added lens to recently accessed on load and save in app.tsx
2020-09-14 13:52:14 -04:00
Marta Bondyra 42e03aa14f
[Lens] fix performance on pie settings slider (#77181) 2020-09-14 11:46:43 +02:00
Joe Reuter a49d8e8994
Separate url forwarding logic and legacy services (#76892) 2020-09-14 11:08:59 +02:00
Marta Bondyra 0c678ebada
[Lens] Filters aggregation (#75635) 2020-09-10 21:16:07 +02:00
Wylie Conlon cb5979ad51
[Lens] Show field stats for IP fields and scripted fields (#76457)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-08 17:29:26 -04:00
Marta Bondyra 728dfb4b6b
[Lens] Update grouping editor to indicate the expected result of a grouping change (#76904) 2020-09-08 17:40:06 +02:00
Wylie Conlon 9ca8551cda
[Lens] Drag dimension to replace (#75895)
* [Lens] Drag to replace

* Add jest tests for drag and drop

* Fix bug in dragging to empty

* Hide dragged dimension when drag starts

* Make table metrics required

* Update class names

* Implement styles on non-droppable items

* Replace drag and drop image in docs

* Remove extra specificity

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-04 10:11:41 -04:00
Greg Thompson ee73c59f8c
Upgrade EUI to v28.2.0 (#75700)
* eui to v28.0.0

* eui to 28.2.0

* euiselectableoptions type update

* targeted nohoist

* src snapshot updates

* x-pack snapshot updates

* strong -> mark

* upgrade @elastic/charts to v21.0.1

* strong -> mark

* fix charts version merge

* maps -> add_field_tooltip_popover type update

* snapshot update

* Fix gridline visibility

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>

Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
2020-08-31 11:01:38 -06:00
Wylie Conlon 8364d8d67a
[Lens] Decouple visualizations from specific operations (#75703)
* [Lens] Decouple visualizations from specific operations

* Remove unused mock
2020-08-26 18:27:40 -04:00
Joe Reuter ddf99b64db
[Lens] Fix rollup related bugs (#75314)
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
2020-08-26 09:09:40 +02:00
Marta Bondyra 1fee8f16ef
[Lens] fix dimension popover design on mobile (#75866) 2020-08-26 00:00:24 +02:00
Devon Thomson f495b7def5
Updated and unskipped lens breadcrumb test after #74523 (#75714)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-24 12:42:11 -04:00
Wylie Conlon 3dea4444b9
[Lens] Remove beta labels (#75574)
* [Lens] Remove beta labels

* Remove translations

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-24 12:07:28 -04:00
Marta Bondyra 5edba21e30
[Lens] Show 'No data for this field' for empty field in accordion (#73772) 2020-08-21 20:07:19 +02:00
Brian Seeders 6a334c3546
Skip failing lens test 2020-08-21 13:35:18 -04:00
Joe Reuter 86f73cb0c2
[Lens] Register saved object references (#74523) 2020-08-21 18:08:25 +02:00
Devon Thomson 6b3ce3f91e
[Dashboard First] Lens Originating App Breadcrumb (#75470)
Changed lens breadcrumbs to reflect the Originating App
2020-08-21 10:18:14 -04:00
Marta Bondyra 23f46c9d85
[Lens] Use index pattern service instead saved object client (#74654) 2020-08-21 11:33:42 +02:00
Devon Thomson eba482743a
[Dashboard First] Use App Title for Display Instead of App Id (#75457)
Created app title fetch method in embeddable_state_transfer. Used it instead of the raw app id in a number of places.
2020-08-20 13:01:25 -04:00
Andrea Del Rio 245c0a3708
[Discover] Create field_button and add popovers to sidebar (#73226)
Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
2020-08-18 13:51:47 -07:00
Marta Bondyra e04e05aa56
[Lens] Fix crash when two layers xychart switches to pie (#75267)
* [Lens] fix crash on two layers and add a functional test with two layers switching to pie chart
2020-08-18 14:27:43 +02:00
Greg Thompson bbee1f92b0
Upgrade EUI to v27.4.0 (#74004)
* eui to 27.1.0

* eui to 27.2.0

* buttoniconside type

* euiselectable type

* update onScroll callback and polyfill size references

* findTestSubject ts

* buttoncontent and collapsiblenav src snapshot updates

* update prop retrieval

* xpack snapshots

* jest updates

* type fixes

* more snapshots

* virtual list changes

* more virtualization changes

* merge

* fix functional tests

* data-test-subj for indexPatter-switcher

* storyshots

* eui to 27.3.1

* Fix unit tests

* Fix broken unit test

* Updated snapshots

* Fixed types

* search for value in euiselectable before selection

* select the correct element

* mock virtualized dep

* ts fix

* reinstate storyshot

* ts fix

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-14 10:31:15 -06:00
Wylie Conlon ec5112b9cc
[Lens] Fix table sorting bug (#74902)
* [Lens] Fix table sorting bug

* Fix types
2020-08-14 10:54:43 -04:00
Luke Elmers fe017f52dd
Make data.search.aggs available on the server. (#74472) 2020-08-13 13:38:16 -06:00
Stratoula Kalafateli 0cfc7b464c
[Lens] Add styling options for x and y axes on the settings popover (#71829)
* [Lens] Add styling options for x axis on the settings popover

* ts related changes

* Changes to the popover's design and y-axis implementatin

* fix types and add unit tests

* Add extra translations

* Fix functional test and change the logic of the yTitle

* fixes

* fix showTitle settings bug

* Fix ticklabels bug on y axes

* fix some tests

* Change the user flow on x and y titles on settings popover and enable the gridlines by default

* disable linter warning

* PR Comments

* Add a comment to callback to explain the decision to listen only to open changes

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-11 20:10:35 +03:00
Joe Reuter c1b55d5739
[Lens] Clear out all attribute properties before updating (#74483) 2020-08-10 15:06:58 +02:00
Devon Thomson dad5c72a0c
[Fix] Lose OriginatingApp Connection on Save After Create new (#74420)
Fixed typo created in #72725 which caused the originatingApp connection not to be lost properly after Create new
2020-08-06 13:24:54 -04:00
Marta Bondyra fa2251dd31
[Lens] Add functional tests on chart transitions and pie chart (#74083) 2020-08-06 18:52:21 +02:00
Anton Dosov 3064c6eceb
Improve state sync error handling (#74264)
Fixes #71461 regression since 7.7

New state syncing utils didn't properly handle errors,
Errors happening during URL parsing or writing wasn't handled, so state syncing could stop or in worth case blow out. (see #71461)

There are not much scenarios where missing proper error handling could really impact users, except the one described in #71461:

Kibana users state:storeInSessionStorage
Users often intuitively share hashed dashboard urls directly
When someone opens those urls - there is a blank screen with warning
In 7.6 - dashboard would still load with default state.
Since 7.7 these still could be achieved by removing query params for URL, but it is not obvious for regular users.

This PR makes sure that behaviour is similar to one we had before 7.7.


Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-06 15:34:32 +02:00
Marta Bondyra 626fbc2948
[Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (#70010) 2020-08-06 10:10:09 +02:00
Marta Bondyra cf6413ab2f
[Lens] fix chart switching when on VisualizationDimensionEditor (#70689) 2020-08-05 18:25:16 +02:00
Mikhail Shustov 88c0631344
Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091)
* bump @typescript-eslint deps

* update rules

* fix errors in pacakges

* fix src/

* fix x-pack

* fix test

* fix typings

* fix examples

* allow _ as prefix and suffix

* roll back prefix and suffix changes

* add eslint-plugin-eslint-comments

* report unused rules

* remove unused eslint comments from tests

* remove unused eslint comments 2nd pass

* remove unused eslint comments from src/

* remove unused comments in x-pack

* use no-script-url and no-unsanitized/property for ts files

* remove unused eslint comments

* eui/href-or-on-click removed when not complained

* no import/* rules for ts files

* cleanup

* remove the unused eslint-disable

* rollback unnecessary changes

* allow underscore prefix & sufix in type name

* update docs

* fix type error in enterprise search plugin mocks

* rename platform hack __coreProvider --> _coreProvider

* rollback space removal in src/core/public/legacy/legacy_service.test.ts

* fix naming convention in APM
2020-08-05 17:32:19 +02:00
Luke Elmers 06412ae770
Migrate timepicker:timeDefaults ui setting to the data plugin. (#73750) 2020-08-03 15:43:34 -06:00
Marta Bondyra 1c0b77c494
fix: pinned filters not applied (#73825) 2020-07-31 18:59:51 +02:00
Liza Katz 14144156f6
[Data] Query Input String manager (#72093)
* improve test stability

* query string input manager (needed for search demo)

* docs

* dashboard

* Fix jest

* mock fix

* Allow restoring a saved query

* sync url

* Luke's fix to test

* cleanup

* lens jest tests

* docs

* use queryStringManager.getDefaultQuery
Don't sync query to global state

* Update app.test.tsx

lens mock

* jest fix

* jest

* use new api in the example

* Rename state param to query to match url state

* Apply changes to discover

* Update src/plugins/data/public/query/query_string/index.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

* Improve query string state manager

* Cleanup dashboard code

* Handle refresh button

* Set initial dashboard state

* visualize state

* remove unused

* docs

* fix example

* fix jest

* fix filter app state in discover

* fix maps test

* jest

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-29 10:48:23 +03:00
Devon Thomson 0103cd3424
[Fix] Lose OriginatingApp Connection on Save As (#72725)
Reset originatingApp in lens and visualize when return to dashboard on saving is false
2020-07-23 12:21:31 -04:00
Joe Reuter 5cdd0801b2
fix bug (#72809) 2020-07-23 09:35:36 +02:00
Joe Reuter 3709de64d6
[Lens] Legend config (#70619) 2020-07-22 12:14:59 +02:00
Devon Thomson 9facf416f5
Applying tiny fix from 72532 to main branch (#72533) 2020-07-21 09:56:13 -04:00
Wylie Conlon 35ff37a434
[Lens] Fix switching with layers (#71982)
* [Lens] Fix chart switching with multiple layers

* Unskip Lens smokescreen test

* Fix types

* Revert <p> change
2020-07-17 14:02:52 -04:00
Wylie Conlon b165538486
[Lens] Unskip Lens smokescreen test (#71986) 2020-07-16 11:34:22 -04:00
Joe Reuter 7e533f26aa
[Lens] Handle failing existence check (#70718) 2020-07-16 09:54:46 +02:00
Marta Bondyra cdbe12ff57
[Lens] XY chart -long legend overflows chart in editor Feature:Lens (#70702) 2020-07-14 22:41:58 +02:00
Caroline Horn ddd8fa8947
[Lens] 7.9 design cleanup (#71444)
* Fix dimension popover layout and color picker “Auto”

* Created ToolbarButton

* Move disabled help text to tooltip for missing values

* Darker side panel backgrounds

* Adding to .asciidoc about where to put the SASS import

* Moving `SASS` guidelines to STYLEGUIDE.md

* Fix keyboard focus of XY settings popover

* Fix dark mode
2020-07-13 20:06:58 -04:00
Joe Reuter b4737e8185
fix overflow (#70723) 2020-07-13 14:59:16 +02:00
Joe Reuter 269c62adef
mitigate kql bug (#70712)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 12:47:00 +02:00
Joe Reuter bbda3f99ef
[Lens] Fitting functions (#69820) 2020-07-03 16:15:06 +02:00
Marta Bondyra a916e0a7c2
[Lens] Add ability to set colors for y-axis series (#70311) 2020-07-03 13:22:47 +02:00
Tiago Costa 6c62c686cf
chore(NA): upgrade to lodash@4 (#69868)
* chore(NA): upgrade oss to lodash4

chore(NA): migrate cli, cli_plugin, cli_keystore,  dev, test_utils and apm src script to lodash4

chore(NA): missing file for cli plugin

chore(NA): add src core

chore(NA): es archiver and fixtures

chore(NA): try to fix functional test failure

chore(NA): migrate src/legacy entirely to lodash4 except src/legacy/core_plugins

chore(NA): move legacy core plugins to lodash4

chore(NA): upgrade optimize to lodash4

chore(NA): upgrade to lodash4 on advanced_settings, charts, console and dashboard

chore(NA): migrate to lodash4 on dev_tools, discover, embeddable, es_ui)shared, expressions, home plugins

chore(NA): upgrade data plugin to lodash4

chore(NA): upgrade usage_collection, ui_actions, tile_map, telemtry, share, saved_objects, saved_objects_management, region_map and navigation to lodash4

chore(NA): missing data upgrades to lodash4

Revert "chore(NA): upgrade usage_collection, ui_actions, tile_map, telemtry, share, saved_objects, saved_objects_management, region_map and navigation to lodash4"

This reverts commit 137055c5fed2fc52bb26547e0bc1ad2e3d4fe309.

Revert "Revert "chore(NA): upgrade usage_collection, ui_actions, tile_map, telemtry, share, saved_objects, saved_objects_management, region_map and navigation to lodash4""

This reverts commit f7e73688782998513d9fb6d7e8f0765e9beb28d1.

Revert "chore(NA): missing data upgrades to lodash4"

This reverts commit 92b85bf947a89bfc70cc4052738a6b2128ffb076.

Revert "chore(NA): upgrade data plugin to lodash4"

This reverts commit 88fdb075ee1e26c4ac979b6681d8a2b002df74c6.

chore(NA): upgrade idx_pattern_mgt, input_control_vis, inspector, kbn_legacy, kbn_react, kbn_usage_collections, kbn_utils, management and maps_legacy to lodash4

chore(NA): map src plugin data to lodash3

chore(NA): missing lodash.clonedeep dep

chore(NA): change packages kbn-config-schema deps

chore(NA): update renovate config

chore(NA): upgrade vis_type plugins to lodash4

chore(NA): move vis_type_vislib to lodash3

chore(NA): update visualizations and visualize to lodash4

chore(NA): remove lodash 3 types from src and move test to lodash4

chore(NA): move home, usage_collection and management to lodash 3

Revert "chore(NA): move home, usage_collection and management to lodash 3"

This reverts commit f86e8585f02d21550746569af54215b076a79a3d.

chore(NA): move kibana_legacy, saved_objects saved_objects_management into lodash3

chore(NA): update x-pack test to mock lodash4

Revert "chore(NA): move kibana_legacy, saved_objects saved_objects_management into lodash3"

This reverts commit 2d10fe450533e1b36db21d99cfae3ce996a244e0.

* chore(NA): move x-pack and packages to lodash 4

* chore(NA): remove mention to lodash from main package.json

* chore(NA): remove helper alias for lodash4 and make it the default lodash

* chore(NA): fix last failing types in the repo

* chore(NA): fix public api

* chore(NA): fix types for agg_row.tsx

* chore(NA): fix increment of optimizer modules in the rollup plugin

* chore(NA): migrate `src/core/public/http/fetch.ts` (#5)

* omit undefined query props

* just remove merge usage

* fix types

* chore(NA): fixes for feedback from apm team

* chore(NA): recover old behaviour on apm LoadingIndeicatorContext.tsx

* chore(NA): fixes for feedback from watson

* Platform lodash4 tweaks (#6)

* chore(NA): fix types and behaviour on src/core/server/elasticsearch/errors.ts

* Canvas fixes for lodash upgrade

* [APM] Adds unit test for APM service maps transform (#7)

* Adds a snapshot unit test for getConnections and rearranges some code to make testing easier

* reverts `ArrayList` back to `String[]` in the painless script within `fetch_service_paths_from_trace_ids.ts`

* chore(NA): update yarn.lock

* chore(NA): remove any and use a real type for alerts task runner

Co-authored-by: Gidi Meir Morris <github@gidi.io>

* chore(NA): used named import for triggers_actions_ui file

* chore(NA): fix eslint

* chore(NA): fix types

* Delete most uptime lodash references.

* Simplify. Clean up types.

* [Uptime] Delete most uptime lodash references (#8)

* Delete most uptime lodash references.

* Simplify. Clean up types.

* chore(NA): add eslint rule to avoid using lodash3

* chore(NA): apply changes on feedback from es-ui team

* fix some types (#9)

* Clean up some expressions types.

* chore(NA): missing ts-expect-error statements

* Upgrade lodash 4 vislib (#11)

* replace lodash 3 with lodash 4 on vislib plugin

* Further changes

* further replacement of lodash3 to 4

* further work on upgrading to lodash 4

* final changes to update lodash

* chore(NA): upgrade data plugin to lodash4

chore(NA): upgrade data plugin public to lodash4

chore(NA): fix typecheck task

chore(NA): fix agg_config with hasIn

chore(NA): assign to assignIn and has to hasIn

chore(NA): upgrade data plugin server to lodash4

chore(NA): new signature for core api

fix(NA): match behaviour between lodash3 and lodash4 for set in search_source

* chore(NA): remove lodash3 completely from the repo

* chore(NA): fix x-pack/test/api_integration/apis/metrics_ui/snapshot.ts missing content

* chore(NA): fix lodash usage on apm

* chore(NA): fix typecheck for maps

* Patch lodash template (#12)

* Applying changes from https://github.com/elastic/kibana/pull/64985

* Using isIterateeCall, because it seems less brittle

* Also patching `lodash/template` and `lodash/fp/template`

* Reorganizing some files...

* Revising comment

* Ends up `_` is a function also... I hate JavaScript

Co-authored-by: Pierre Gayvallet <pierre.gayvallet@gmail.com>
Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
Co-authored-by: Oliver Gupte <ogupte@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Gidi Meir Morris <github@gidi.io>
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Co-authored-by: Stratoula Kalafateli <stratoula1@gmail.com>
Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Co-authored-by: kobelb <brandon.kobel@elastic.co>
2020-07-03 01:30:13 +01:00
Nick Partridge f8ba824ebc
Fix discover, tsvb and Lens chart theming issues (#69695) 2020-07-02 09:02:30 -05:00
Marta Bondyra 8fe5d154c1
[Lens] fix dimension label performance issues (#69978) 2020-07-02 08:05:08 +02:00
Joe Reuter de79985f92
[Lens] Add "no data" popover (#69147) 2020-07-01 10:08:37 +02:00
Joe Reuter a49f5cec64
[Lens] Move chart switcher over (#70182) 2020-07-01 10:07:59 +02:00
Joe Reuter e1665e8b27
[Lens] Multiple y axes (#69911) 2020-07-01 09:57:23 +02:00
Mikhail Shustov 159369b719
Use ts-expect-error in platform code (#69883)
* ts-ignore --> ts-expect-error

* fix error with mutable array

* fix errors in consumers code

* update SOM

* fix FeatureConfig & Feature compatibility

* do not re-export from code. it breaks built version

* update docs

* add eslint rule for platform team code

* remove test. this is covered by ts-expect-error in unit tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-30 07:37:42 +02:00
Wylie Conlon 40ff82d779
[Lens] Fix broken test (#70117) 2020-06-27 08:20:29 +02:00
Brian Seeders e4aaed6926 skip failing suite (#70104) (#70103) 2020-06-26 15:06:49 -04:00
Marta Bondyra 7440eea3dc
[Lens] Use accordion menus in field list for available and empty fields (#68871) 2020-06-26 18:43:35 +02:00
Marta Bondyra 2a68dc7c6b
[Lens] Last used Index pattern is saved to and retrieved from local storage (#69511) 2020-06-26 16:33:09 +02:00
Devon Thomson 52223da44f
prep state transfer for passing embeddables by value to editor and back (#69991)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-26 12:55:12 +01:00
Marta Bondyra 8448ae8b4b
[Lens] Fix delete button position in dimension panel for long labels (#69495) 2020-06-26 09:50:13 +02:00
Joe Reuter 67e48527e7
[Lens] Add toolbar api (#69263) 2020-06-26 09:38:35 +02:00
Devon Thomson 98a897736b
Remove App communication from URL (#67064)
Removed all inter-app communication via url in favour of a new service in the embeddable start contract called the state transfer service.
2020-06-23 12:21:48 -04:00
Marco Vettorello f9f1158e1f
Update dependency @elastic/charts to v19.5.2 (#69126)
Update @elastic/charts to 19.5.2

Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
2020-06-17 16:02:34 +02:00
Marta Bondyra cb2c90ca4b
[lens] perf: memoize onEvent handler to avoid unnecessary re-render (#68637)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-12 16:59:27 +02:00
Caroline Horn 1277934588
[Lens] Fix aggregation selection indicator (#68973)
* Some sass modularization and using EuiListGroup instead of EuiSideNav
* Fixes #68530
2020-06-12 10:04:54 -04:00
Mikhail Shustov f593455a62
Bump TypeScript to v3.9 (#67666)
* add babel support for export type

* bump ts version to 3.9.3

* rebuild kbn-pm

* bump typescript-eslint

* fix error in security plugin UI

* check export as works

* fix app migration type

* use correct test subj attribute

* fix errors from the old PR

* embeddable is already passed in props

* explicitly define type of fetch

* add some types for viz

* fix fetch type p.2

* add null to allow spreading without type errors due to override

* add type guard to fix type error

* cast to any, since cannot assign unknown

* add timestamp to known types

* fix type error in fetch

* fix type error. id is always defined in attibutes

* declare a type

* move ts-ignore to the lines with errors

* declare tuple type explicitly

* mute type error. cannot assign unknown

* fix errors. id is always defined

* fix error type

* fix override errors. id is always defined

* fix error. extends any doesn't work anymore

* fix type error. type is always defined

* env doesn't always contain values

* fix type error

* cast to string

* add: logs is already declared in getNodeLogsUrl

* state is already  passed in props

* fix some errors in timelion

* number of fragments is always defined

* 'absolute' is not just string, but value

* TEMP: option is always defined

* always true if cast to promise manually

* both props are always defined

* explicitly define returned SO type

* workaround type

* bump tslib to be compatible with ts v3.9

* test private property

* rebuild kbn-pm

* Fix ts errors for beats management

* Fix type inference broken by the TS 3.9 upgrade

* Fix ingest manager saved object attributes typings

* Fix TS errors in cross_cluster_replication and index_management.

* Fix TS error in Watcher.

* roll back colorRange wrong type

* fix security plugin types

* TypeScript 3.9 fixes for APM

* Fix ColorRange types.

* fix actions & alerts errors. ByGidi

* fix lists error

* More APM fixes

* Remove paramaterization from `removeEmpty in agent config SettingsPage component (it's only used there and doesn't need to be parameterized.)
* Add option chain for case in registerTransactionDurationAlertType
* Cast `overallValue` in transform_metrics_chart
* Use more specific type for custom link filters
* Add more option chaining for local UI filters buckets response
* Remove unused parameters from routes
* Fix getProjection type parameter
* Use destructuring in serviceNodesLocalFiltersRoute to hide `never` error
* Revert `UnionToIntersection` change in `AggregationResponseMap`

Fixes #67804.

* fix platform type error

* Fix visualizations types.

* Fix data plugin types.

* bump TS version to 3.9.5

* Fix telemetry TS errors

* Fix dashboard code

* Adding Canvas Fixes for TS 3.9

* Fix case and security_solution types

* roll back to the old export syntax. new one might cause problems in api-extractor

* update docs

* Fix timelion code

* Fix meta

* Fix types

* fix type errors om ingest_manager

* bump babel deps

* enable private props & methods syntax

* update kbn-pm dist

* whitelist 0BSD license

* use @babel/plugin-proposal-private-methods in default set as well

* disable new babel plugins

* Revert "disable new babel plugins"

This reverts commit 04d959431d.

* cleanup security_solution types

* Fixes type error for newer TypeScript

* update docs

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Larry Gregory <larry.gregory@elastic.co>
Co-authored-by: Nathan L Smith <smith@nlsmith.com>
Co-authored-by: Walter Rafelsberger <walter@elastic.co>
Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Co-authored-by: Tim Roes <tim.roes@elastic.co>
Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
Co-authored-by: FrankHassanabad <frank.hassanabad@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-11 10:04:09 +02:00
Joe Reuter 8d1a319472
keep custom labels (#68498) 2020-06-10 18:29:22 +02:00
Joe Reuter 497ecf8164
[Lens] Add description property and check duplicate title on save (#68219) 2020-06-10 18:28:00 +02:00
Joe Reuter a462e2c7b0
[Lens] Keep global filters, time range and refresh interval on refresh (#68075) 2020-06-10 15:44:59 +02:00
Uladzislau Lasitsa b87eefc753
[uiSettings]: Migrate items owned by app arch to new platform (#66040)
* Migrated uiSettings items to new platform

* API changes

* Fixed translations

* Fixed comment and i18n

* Fixed tests

* Fixed internalization

* Fix karma tests

* made code more explicit

* Fixed plugin

* Added consts for ui settings ids.

* Added id for another settings

* Fixed tests.

* Improved imports

* Fix imports to public which were happening from the server.

* Fixed paths

* Moved styles to plugin.ts

* Moved styles

* Fixed docs

* Fix ci

* Fix ci

* fix documentation

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Co-authored-by: Luke Elmers <luke.elmers@elastic.co>
2020-06-05 10:55:42 +03:00
Devon Thomson 97a72b33c5
[Chore] Simplify Embeddable Panel usage (#68006)
Replaced usages of the EmbeddablePanel component with a shortcut panel API
2020-06-04 16:55:11 -04:00
Joe Reuter 4a1b05c843
Lens editor auto refresh (#65868) 2020-06-03 11:35:55 +02:00
Wylie Conlon b061d85f9a
[Lens] Warn if leaving with unsaved visualization (#67689)
* [Lens] Warn if leaving with unsaved visualization

* Made confirmation logic more robust and add title

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-01 15:05:27 -04:00
Wylie Conlon be51ca6041
[Lens] Allow visualizations to provide a dimension editor (#67560)
* [Lens] Allow visualizations to provide a dimension editor

* Update to tab style

* Remove table update

* Update class name

* typecheck fix

* Add test

* Require each dimension group to enable editor

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
2020-06-01 13:33:23 -04:00
Marta Bondyra 84ed5096f3
[Lens] Fix empty values filtering (#67594) 2020-05-29 09:38:07 +02:00
Marta Bondyra 9c28661449
perf: drag and drop performance improvement for field list (#67455) 2020-05-29 09:34:55 +02:00
restrry bf04235dae apply prettier styles 2020-05-22 09:08:58 +02:00
Joe Reuter 20ba3c0fde
fix filter filtering out falsy values (#66904) 2020-05-19 14:44:59 +02:00
Marta Bondyra d9d8777613
[Lens] Fix datatable empty state (#66744) 2020-05-19 11:14:26 +02:00
Joe Reuter 52070091f4
Lens drilldowns (#65675) 2020-05-15 12:01:27 +02:00
Devon Thomson 28623ad33a
[Lens] fix redirect after reload (#66328)
Changed the way the lens app tracks originatingApp. It is now removed from the url when the app starts and is tracked as part of the state
2020-05-14 12:29:03 -04:00
Marta Bondyra 0d571ae129
[Lens] fix empty state for pie (#66206) 2020-05-13 14:49:50 +02:00
Joe Reuter b7e87c2c8b
Switch to core application service (#63443) 2020-05-13 09:19:24 +02:00
Marta Bondyra 25a3fcea52
[Lens] refactor to not filter layers three times (#66174) 2020-05-12 17:46:35 +02:00
Marta Bondyra eb97e919f3
[Lens] Fix console.error react memory leak when saving new viz (#65490) 2020-05-07 17:21:49 +02:00
Wylie Conlon 459daa7f23
[Lens] Use rules of hooks with linting (#65593) 2020-05-07 10:01:51 -04:00
Wylie Conlon 90de711c27
[Lens] Remove "inside only" option for treemap labels (#65363)
* [Lens] Remove "inside only" option for treemap labels

* Fix type error

* Update from feedback
2020-05-06 16:45:32 -04:00
Devon Thomson 5bad855e4b
Return to dashboard after editing embeddable (#62865)
Changed the process for saving visualizations and lens visualizations when the user has been redirected there from another application.
2020-05-05 16:58:36 -04:00
Wylie Conlon e5d7bb6e9a
[Lens] Pie and treemap charts (#55477)
* [Lens] Add pie and treemap visualizations

* Fix types

* Update to new platform

* Support 2-layer treemap and legends, dark mode

* Significant restructuring of code

* Upgrade to latest charts library

* Commit yarn.lock

* chore: update elastic-charts

* fix types after merge master

* Add settings panel and merge visualizations

* Fix tests

* build: upgrade @elastic/charts to 19.0.0

* refactor: onBrushEnd breaking changes

* fix: missing onBrushEnd argument changes

* More updates

* Fix XY rendering issue when all dates are empty

* Fix bugs and tests

* Use shared services location

* Fix bug in XY chart

* fix: update ech to 19.1.1

* fix: lens onBrushEnd breaking changes

* Change how pie/treemap settings work

* [Design] Fix up settings panel

* [Design] Update partition chart config styles

* fix eslint

* Fix legend issues in pie and XY, add some tests

* update to 19.1.2

* Fix text color for treemap

* Fix chart switch bug

* Fix suggestions

Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-05-05 15:59:32 -04:00
Marco Vettorello 2d4dc801c3
Update dependency @elastic/charts to v19.1.2 (#64759)
* build: upgrade @elastic/charts to 19.0.0

* refactor: onBrushEnd breaking changes

* fix: missing onBrushEnd argument changes

* fix: update ech to 19.1.1

* fix: lens onBrushEnd breaking changes

* update to 19.1.2
2020-05-04 18:42:58 -05:00
Mikhail Shustov c8ddb6b8ed
load lens app lazily (#64769) 2020-05-01 12:57:29 +02:00
Marta Bondyra c4e6789c28
[Lens] Trigger a filter action on click in datatable visualization (#63840)
* wip: datatable

* fix: empty values

* fix: empty values

* translations

* using dataPlugin to get buckets

* one more time, passing aggs data

* tests: added

* feat: new design applied

* remove icon

* feat: old design

* CR corrections

* better name

* Fix merge issue

* fix: design changes

* feat: correction

* fix: copy changes

* Update x-pack/plugins/lens/public/datatable_visualization/_visualization.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update _visualization.scss

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
2020-04-30 17:44:16 -04:00
Marta Bondyra 5887c97d75
[Lens] Allow user to drag and select a subset of the timeline in the chart (aka brush interaction) (#62636)
* feat: brushing basic example for time histogram

* test: added

* refactor: simplify the structure

* refactor: move to inline function

* refactor

* refactor

* Always use time field from index pattern

* types

* use the meta.aggConfigParams for timefieldName

* fix: test snapshot update

* Update embeddable.tsx

removing commented code

* fix: moment remov

* fix: corrections for adapting to timepicker on every timefield

* fix: fix single bar condition

* types

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
2020-04-30 20:36:50 +02:00
Wylie Conlon 988b93edca
[Lens] Hide some suggestions in preparation for pie charts (#64740)
* [Lens] Hide some suggestions in preparation for pie charts

* Suggest reordering the X and Break down by axis

* More tweaks
2020-04-30 10:52:10 -04:00
Wylie Conlon 4e58d7ae0a
[Lens] Use a size of 5 for first string field in visualization (#64726) 2020-04-29 22:03:41 -04:00
Tim Roes 9b65cbd92b
[Lens] Bind all time fields to the time picker (#63874)
* Bind non primary time fields to timepicker

* Fix typescript argument types

* Allow auto interval on all fields

* Remove lens_auto_date function

* Fix existing jest tests and add test todos

* Remove lens_auto_date from esarchives

* Add TimeBuckets jest tests

* Fix typo in esarchiver

* Address review feedback

* Make code a bit better readable

* Fix default time field retrieval

* Fix TS errors

* Add esaggs interpreter tests

* Change public API doc of data plugin

* Add toExpression tests for index pattern datasource

* Add migration stub

* Add full migration

* Fix naming inconsistency in esaggs

* Fix naming issue

* Revert archives to un-migrated version

* Ignore expressions that are already migrated

* test: remove extra spaces and  timeField=\\"products.created_on\\"} to timeField=\"products.created_on\"}

* Rename all timeField -> timeFields

* Combine duplicate functions

* Fix boolean error and add test for it

* Commit API changes

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
2020-04-29 20:10:14 -04:00
Wylie Conlon a907c9bda5
[Lens] Use suggestion system in chart switcher for subtypes (#64613)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-29 19:14:47 -04:00
Marta Bondyra da4c33b022
[Lens] Don't use auto interval to get interval for single bar (#64502)
* feat: don't use auto interval to get interval for single bar

* fix: fixing non auto intervals

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-29 14:47:45 +02:00
Nick Partridge bc6291349c
Update elastic charts v18.4.1 (#64257) 2020-04-23 11:59:19 -05:00
Wylie Conlon dd094f2333
[Lens] Split apart config panel component to more manageable chunks (#63910)
* [Lens] Split apart config panel component to more manageable chunks

* Moving around and renaming SASS appropriately

* Remove layer limit

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-04-22 17:36:36 -04:00
Chandler Prall 126d187429
Upgrade to EUI v22.3.0 (#62963)
* snapshot updates

* bump to eui 22.3.0

* snapshots

* Fix css selector in test to match EUI internal DOM change

* Updated snapshots

* Insert react-beautiful-dnd@10 into top-level kibana to force siem's node_modules to hold its correct version

* More snapshot updates, resolved a typescript issue

* Move react-beautiful-dnd dependency around to make things happy again

* Use SearchFilterConfig from the top-level eui export

* Swallow 'ResizeObserver error does not have an err object' error in canvas

* Swallow ResizeObserver error cross-browser
2020-04-22 11:01:49 -06:00
Peter Pisljar 222fdc5029
refactor action filter creation utils (#62969) 2020-04-22 10:41:58 +02:00
Wylie Conlon 561c0f9fed
[Lens] Allow table to scroll horizontally (#63805)
* [Lens] Allow table to scroll horizontally

* Fixing scrolling pt. 2

Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-04-17 17:03:33 -04:00
Wylie Conlon 13422b8c91
[Lens] Make average the default suggested metric (#63416)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 10:34:24 -04:00
Wylie Conlon c21cec7abd
[Lens] Fix escaping of field names (#63509)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-16 10:32:58 -04:00
Wylie Conlon ac549ac6f5
[Lens] Only show copy on save for previously saved docs (#63535)
* [Lens] Only show copy on save for previously saved docs

* Update app.test.tsx

import after kibana platform changes

Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
2020-04-15 14:57:44 -04:00
Tim Roes ebbc062689
Move Lens frontend to Kibana Platform (#62965)
* Move Lens frontend to Kibana platform

* Fix line breaks

* Fix jest tests

* Fix remaining test

* Remove old Lens plugin entry

* Fix i18n prefix

* Add config schema

* Address review
2020-04-15 12:22:37 +02:00